Commit Graph

823 Commits

Author SHA1 Message Date
Jason Prickett
8dc33d0067 Bug 1804589 - Refactors pdfjs feature callout instantiation for better performance r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D164174
2022-12-09 20:14:46 +00:00
Meg Viar
63afba9b12 Bug 1804490 - Update PDF.js callout messages' targeting to only show on PDF documents r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D164129
2022-12-08 12:37:03 +00:00
Jason Prickett
a880490eae Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
2022-12-06 23:22:50 +00:00
Noemi Erli
38df0ec770 Backed out changeset ab219eb65432 (bug 1803660) for causing failures in /browser_newtab_ping.js CLOSED TREE 2022-12-06 22:29:16 +02:00
Jason Prickett
fd2e0452f9 Bug 1803660 - Hide and show feature callout surface when tabs are changed r=mviar
Depends on D163639

Differential Revision: https://phabricator.services.mozilla.com/D163642
2022-12-06 19:27:40 +00:00
Meg Viar
18abc909b1 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-30 01:47:23 +00:00
Nika Layzell
c401277cf6 Bug 1538028 - Part 4: Pass TriggeringRemoteType through the frontend, r=Gijs,emilio
Propagate the ability to pass triggeringRemoteType through the desktop frontend
in various places, such that it is set when using the context menu or content
click handler.

Differential Revision: https://phabricator.services.mozilla.com/D161834
2022-11-29 20:41:46 +00:00
Sandor Molnar
61f05197c3 Backed out changeset 28484915dc1b (bug 1795894) for causing mochitest failures. CLOSED TREE 2022-11-28 04:33:07 +02:00
Meg Viar
3633b07781 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-28 00:54:14 +00:00
Neil Deakin
cbefc0ebf5 Bug 1801168, only expect the full screen exited event when the inDOMFullscreen attribute is set and select the url only in this case, r=dao
Differential Revision: https://phabricator.services.mozilla.com/D162857
2022-11-25 10:36:00 +00:00
Eemeli Aro
9a3c42464a Bug 1760029 - Migrate browser.properties strings used by tabbrowser.js to Fluent. r=dao,fluent-reviewers,flod
The autorefresh blocker strings are added to `browser.ftl` as they aren't really "tab" strings.

Differential Revision: https://phabricator.services.mozilla.com/D159017
2022-11-22 17:12:21 +00:00
Eemeli Aro
46d4e9b1a3 Bug 1760029 - Migrate tabbrowser.properties strings used by tabbrowser.js to Fluent. r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D159016
2022-11-22 17:12:21 +00:00
Neil Deakin
a402fd4d84 Bug 1801060, fix selectURL function call so that url is selected properly, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D162317
2022-11-21 21:30:46 +00:00
Neil Deakin
d3b4cd4f58 Bug 1219775 , focus the url bar when opening a new tab while in fullscreen mode, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D161517
2022-11-15 17:15:51 +00:00
Marian-Vasile Laza
cb5a3644d1 Backed out changeset de61491bc549 (bug 1795894) for causing bc failures on browser_protocol_ask_dialog.js. CLOSED TREE 2022-11-11 01:14:04 +02:00
Meg Viar
9e1c9a7613 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-10 21:01:22 +00:00
Marian-Vasile Laza
4582bdf7cb Backed out changeset 2023e8659017 (bug 1795894) for causing multiple bc failures on featureCallout.mjs. CLOSED TREE 2022-11-10 21:42:43 +02:00
Meg Viar
ed1f5ee2a9 Bug 1795894 - Enable triggering Feature Callouts in chrome by content location r=jprickett
Differential Revision: https://phabricator.services.mozilla.com/D160503
2022-11-10 18:47:04 +00:00
Bernard Igiri
511d17c548 Bug 1790971 - Prevent Firefox View Tab from being autoselected on tab closing r=dao
Prevent pinned Firefox View Tab from being autoselected on tab closing.

Differential Revision: https://phabricator.services.mozilla.com/D161218
2022-11-04 13:35:13 +00:00
Shane Hughes
b5e7da0a12 Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D160166
2022-10-26 19:27:34 +00:00
Stanca Serban
50ec21d946 Backed out changeset d076c8363b14 (bug 1743878) for causing bc failures on browser_findbar_disabled_manual.js. CLOSED TREE 2022-10-26 13:10:37 +03:00
Shane Hughes
4a0617c8ce Bug 1743878 - Avoid opening caret browsing dialogs when already open. r=dholbert
Differential Revision: https://phabricator.services.mozilla.com/D160166
2022-10-26 05:42:05 +00:00
James Teow
eb0cc6713e Bug 1788953 - Part 1: Add originalURI to browser-custom-element - r=adw
Differential Revision: https://phabricator.services.mozilla.com/D157485
2022-10-18 13:38:49 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
2022-10-18 11:21:26 +00:00
Tim Giles
9c4d623be8 Bug 1792680 - Fix Firefox View not being a reloadable tab. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D159212
2022-10-13 14:28:16 +00:00
Daisuke Akatsuka
99341cf6fa Bug 1792971: Suppress popup notification while async tab switching. r=adw,zombie
Differential Revision: https://phabricator.services.mozilla.com/D158480
2022-10-11 00:10:26 +00:00
Dão Gottwald
ffb77e2df1 Bug 1792607 - Use early return in showTab. r=aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D158229
2022-09-28 02:20:01 +00:00
Shane Hughes
1577034f2f Bug 1791770 - Prevent add-ons from showing Fx View tab. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D158009
2022-09-26 19:33:52 +00:00
Evan
7be0d917de Bug 1788783 -Converted Picture in Picture JSM modules to ESMs. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D157039
2022-09-23 18:11:48 +00:00
Dão Gottwald
308590ef34 Bug 1789022 - Insert tabs opened from Firefox View at the beginning of the tab strip. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157724
2022-09-20 13:50:34 +00:00
Dão Gottwald
1737bdc3e8 Bug 1790593 - Exclude hidden tabs from tab multiselection. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157466
2022-09-15 14:59:12 +00:00
Dão Gottwald
af3ddd2293 Bug 1783811 - "Move Tab" and "Open in New Container Tab" options should be disabled for the Firefox View tab (and hidden tabs in general) in the "List all tabs" menu. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D154099
2022-09-13 08:45:47 +00:00
Emilio Cobos Álvarez
e4bcc13cb9 Bug 1789877 - Hide inactive statuspanel. r=dao
Differential Revision: https://phabricator.services.mozilla.com/D156921
2022-09-12 09:55:30 +00:00
Emilio Cobos Álvarez
a1107cbac0 Bug 1789892 - Simplify statuspanel a bit. r=dao
I'm a bit baffled about bug 1789877. My best theory so far is that we're
inserting the element a bit deeper in the DOM and that causes us to
reflow slightly more stuff when tab-switching, but...

In any case while going through the code the status panel can be
simplified a bit now, so do that.

Differential Revision: https://phabricator.services.mozilla.com/D156876
2022-09-09 19:36:21 +00:00
Emilio Cobos Álvarez
98196eb0a8 Bug 1789125 - Explicitly position statuspanel vertically. r=dao
Right now, the vertical position of the status panel is the "auto"
position, which ends up working out, but mostly by chance, and relies on
behavior that's different from the standard flexbox, see bug 1789165.

Instead of using `position: fixed` and relying on not having any
sidebars or other content to the inline-end (otherwise the [mirror] rule
would be incorrect), explicitly position it against the
.browserContainer.

Differential Revision: https://phabricator.services.mozilla.com/D156384
2022-09-06 19:05:54 +00:00
Daisuke Akatsuka
05818fe5ec Bug 1565751: Wait for processing needed before selecting text. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D155042
2022-08-24 00:43:03 +00:00
Emilio Cobos Álvarez
0f16115b60 Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 23:13:41 +00:00
Marian-Vasile Laza
b160c98958 Backed out 3 changesets (bug 1784265) for causing reftest failures on flex-emulation-1.xhtml. CLOSED TREE
Backed out changeset 415da4b53bdd (bug 1784265)
Backed out changeset e27b21c54b1f (bug 1784265)
Backed out changeset fcb1a053fbe2 (bug 1784265)
2022-08-13 01:14:13 +03:00
Emilio Cobos Álvarez
5c4a2beefd Bug 1784265 - Drop support for flex attribute values other than 0 and 1. r=dholbert,mconley,preferences-reviewers
This makes it easier to get parity between legacy and regular flex
without having to either have tons of arbitrary attribute selectors in
the xul sheet, nor adding attribute lookup hacks to the html flexbox
layout.

Also, reimplement the remaining supported flex attribute-values (0 and 1)
purely in terms of CSS rules in xul.css (regardless of whether
emulate-moz-box-with-flex is enabled).

In practice these are pretty uncommon and the style attribute does the
trick in every case I've tried.

Add a debug-only assertion to ensure we preserve behavior for now.

Add a new test with another behavior difference between flexbox
emulation and old xul layout because the old reftest now passes. Use
replaced elements, which in modern flex are treated differently.

Differential Revision: https://phabricator.services.mozilla.com/D154394
2022-08-12 19:34:34 +00:00
Shane Hughes
509e6cf163 Bug 1783207 - Add ellipsis to some menu label strings. r=flod
The copy guidance recommends adding an ellipsis to the end of labels for
controls that require an additional step to complete the action
specified by the label. We have some menuitems and panel buttons that
open a bookmark dialog or the edit bookmark panel that don't have an
ellipsis, so add that. Also, the form "Bookmark this x" has been changed
to "Bookmark x" in menuitems. Also, there's a "Print Selection" menuitem
that needed an ellipsis. Thanks for the review!

Differential Revision: https://phabricator.services.mozilla.com/D154320
2022-08-11 17:48:11 +00:00
Niklas Baumgardner
9954b5b283 Bug 1783289 - Define lazy PictureInPicture before reference. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D153866
2022-08-08 12:59:07 +00:00
Daisuke Akatsuka
7e4536e9fd Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-08-01 00:27:50 +00:00
Butkovits Atila
fe05967e94 Backed out 2 changesets (bug 1776609) for causing failures at browser_topsites_annotation.js. CLOSED TREE
Backed out changeset cac795fd16d2 (bug 1776609)
Backed out changeset 88ec1cca8540 (bug 1776609)
2022-08-01 00:52:35 +03:00
Daisuke Akatsuka
63fc1e0ed5 Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-07-31 20:26:30 +00:00
Butkovits Atila
efbdfe270f Backed out 2 changesets (bug 1776609) for causing gtest failures. CLOSED TREE
Backed out changeset 7630fea97777 (bug 1776609)
Backed out changeset 426cbe0fac73 (bug 1776609)
2022-07-29 13:42:33 +03:00
Daisuke Akatsuka
e6ed592635 Bug 1776609: Record source and triggeringPlaceId for sponsored tile on newtab. r=mak,geckoview-reviewers,m_kato
Differential Revision: https://phabricator.services.mozilla.com/D150729
2022-07-29 09:24:28 +00:00
Mark Banner
cd9bed2e7a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-26 15:11:30 +00:00
smolnar
4cb3dcaaa2 Backed out 5 changesets (bug 1780017, bug 1780347) for causing bc failures in browser/base/content/test/performance/browser_preferences_usage.js CLOSED TREE
Backed out changeset 86c3a9142535 (bug 1780347)
Backed out changeset 35abe35417a0 (bug 1780017)
Backed out changeset f448f044f028 (bug 1780017)
Backed out changeset a400cbe83084 (bug 1780017)
Backed out changeset 0a23c9e27f01 (bug 1780017)
2022-07-25 21:00:07 +03:00
Mark Banner
bf597b1f3a Bug 1780017 - Migrate urlbar consumers to use ESM imports directly. r=adw,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D152057
2022-07-25 12:46:48 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
2022-07-20 22:43:53 +03:00