Commit Graph

9 Commits

Author SHA1 Message Date
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Matt Brubeck
17f443b41c Bug 949333 - Make Metro prompt service work for Master Password [r=TimAbraldes] 2013-12-16 10:15:09 -08:00
Tim Abraldes
3741fc3619 bug 866304. In metro, use the tab-modal prompt implementation that is available in toolkit. r=mbrubeck
This patch replaces metro's 'PromptService' (which implements nsIPromptService and nsIPrompt, among others) with an implementation that simply forwards all calls to toolkit's nsPrompter.js. Before forwarding each call, it writes the "allowTabModal" property on the object obtained from nsPrompter.js, causing the created prompt to be tab-modal.

It also adds functionality to browser.js for creating tab modal prompts. One of the changes made as part of adding this functionality is replacing the <browser> with a <stack> of <browser> objects.
2013-08-05 23:29:54 -07:00
Carsten "Tomcat" Book
03ba1633b7 Backed out changeset 516063917157 (bug 866304) mochitest metro orange 2013-08-06 12:19:29 +02:00
Tim Abraldes
6dea7287d3 bug 866304. In metro, use the tab-modal prompt implementation that is available in toolkit. r=mbrubeck
This patch replaces metro's 'PromptService' (which implements nsIPromptService and nsIPrompt, among others) with an implementation that simply forwards all calls to toolkit's nsPrompter.js. Before forwarding each call, it writes the "allowTabModal" property on the object obtained from nsPrompter.js, causing the created prompt to be tab-modal.

It also adds functionality to browser.js for creating tab modal prompts. One of the changes made as part of adding this functionality is replacing the <browser> with a <stack> of <browser> objects.
2013-08-05 23:29:54 -07:00
Jim Mathies
1f351e4455 Bug 868007 - Remove unused 'prompt-button' css class. r=fryn 2013-05-07 15:55:51 -05:00
Rodrigo Silveira
496d4ab870 bug 856241 - Remove closing multiple tabs dialog r=mbrubeck 2013-04-03 13:19:34 -07:00
Matt Brubeck
5d1a7619a6 Bug 851156 (part 3) - Clean up Metro password manager strings [r=jimm] 2013-03-14 11:08:59 -07:00
Jim Mathies
8bc324049b Bug 750903 - Land browser/metro/* r=mbrubeck 2013-02-12 14:51:25 -06:00