Commit Graph

141 Commits

Author SHA1 Message Date
mcarare
1070e28db0 Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 13:00:48 +00:00
acseh
3f4b08c594 Backed out changeset 9976b7730dbd (bug 1893120) for causing lint failures CLOSED TREE 2024-05-14 12:57:36 +03:00
mcarare
4a11afeae1 Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 08:02:38 +00:00
Roger Yang
07de485666 Bug 1883741 - Add display toolbar padding when navigation bar is enabled. r=android-reviewers,avirvara,gl
Differential Revision: https://phabricator.services.mozilla.com/D205623
2024-04-01 14:09:55 +00:00
sarah541
d57d64ae55 Bug 1870938 - Add display/edit toolbar separator and update url bar background 2024-03-11 19:37:37 +00:00
mike a
2cbd968ba9 Bug 1873260 - Move Behavior classes to ui-widget component 2024-01-31 21:46:09 +00:00
Harrison Oglesby
dcc827eaf2 Bug 1864760 - Added actions to Toolbar and MenuButton to hide and show the menu button 2024-01-29 23:44:43 +00:00
t-p-white
01f1578630 Bug 1874861 - Removed redundant LongParameterList suppression's 2024-01-18 18:37:49 +00:00
mcarare
063c553913 Bug 1849833 - Replace deprecated compileSdkVersion.
This is replaced by defaultConfig compileSdk.
2023-09-11 06:36:20 +00:00
mcarare
235c47209f Bug 1849833 - Replace deprecated kotlinOptions method. 2023-09-11 06:36:20 +00:00
mcarare
5a7b24763d Bug 1849833 - Replace qualified name with import. 2023-09-11 06:36:20 +00:00
MatthewTighe
c87183c8b5 Bug 1843168 - Expose Mockito through test support component 2023-07-24 18:02:09 +00:00
Gabriel Luong
e60ba5018e Bug 1840210 - Rename mozac_ic_fingerprint to mozac_ic_fingerprinter_24 2023-07-10 22:15:49 +00:00
rahulsainani
8de6355e70 Bug 1837961 - Part 2:Replace usages of ifChanged to distinctUntilChanged 2023-06-21 09:27:58 +00:00
Geoff Brown
6561b2de2b Bug 1825116 - Resolve many black, isort, and file-whitespace lint issues 2023-04-12 14:04:29 +00:00
mcarare
278fa80cc2 Bug 1824717 - Remove unnecessary AndroidJUnit4 runner. 2023-04-05 12:44:13 +00:00
Ryan VanderMeulen
0e5e70291c Bug 1820233 - Remove unneeded kotlin_stdlib inclusions and re-enable Werror in detekt build.gradle 2023-03-07 00:12:18 +00:00
mcarare
1f589a2e0b Bug 1802817 - Set namespace via DSL in gradle build files.
See https://developer.android.com/studio/build/configure-app-module#set-namespace
and https://issuetracker.google.com/issues/172361895
2023-03-02 17:13:09 +00:00
mcarare
922b5f6643 Bug 1802817 - Rename AC Dependencies to ComponentsDependencies.
This change is needed in order to avoid clashes with Dependencies class introduced
in Gradle from 7.6 version.
2023-03-02 17:13:09 +00:00
Mugurell
2d2404905d Bug 1800268 - Add support for refreshing autocomplete when providers change 2023-01-31 11:15:37 +00:00
Mugurell
29325133df Bug 1800268 - Refactor ToolbarAutocompleteFeature to allow easily changing providers
This class drives the autocomplete feature and previously only allowed for
adding a history or domains autocomplete provider.
With the new changes it will support adding and removing any autocomplete
provider individually or in bulk.
2023-01-31 11:15:37 +00:00
Alexandru2909
2149fea558 Bug 1805164 - Allow clients to specify whether or not the search terms should be displayed in the toolbar in display mode 2022-12-16 09:17:46 +00:00
Alexandru2909
7fe7868531 Bug 1804260 - Add method to specify the cursor placement when switching to URL editing mode 2022-12-16 08:35:35 +00:00
Christian Sadilek
4091b14a33 Fix android lint in composite builds 2022-11-21 13:40:53 -05:00
Alexander Gramiak
bcc43f0530 Bug 1799230 - Use Non-Transitive R Classes
According to Android documentation: "This leads to faster builds and
the corresponding benefits of compilation avoidance."
2022-11-17 18:23:01 +00:00
Mihai Adrian Carare
e087b524a6 Bug 1796353 - Build with compileSdkVersion for Android 13 / API 33. (https://github.com/mozilla-mobile/firefox-android/pull/62)
* Bug 1796353 - Build with compileSdkVersion for Android 13 / API 33.

* Bug 1796353 - Update method signature for View.AccessibilityDelegate.

* Bug 1796353 - Handle AccessibilityNodeInfo.CollectionInfo.obtain deprecation.

* Bug 1796353 - Update method signature for View.OnAttachStateChangeListener.

* Bug 1796353 - Handle getParcelableExtra(String) deprecation.

* Bug 1796353 - Handle getParcelable(String) deprecation.

* Bug 1796353 - Handle getParcelableArrayListExtra(String) deprecation.

* Bug 1796353 - Move URLStringUtils to ktx package.

This is needed to avoid circular dependencies for some needed changes.

* Bug 1796353 - Suppress deprecation for get(String).

* Bug 1796353 - Replace removed method setAppCacheEnabled.

* Bug 1796353 - Handle PackageManager methods deprecations.

* Bug 1796353 - Handle getSerializable(String) deprecation.

* Bug 1796353 - Handle stopForeground deprecation.

* Bug 1796353 - Update method signature for GestureDetector.SimpleOnGestureListener.

* Bug 1796353 - Handle AccessibilityEvent.obtain deprecation.

* Bug 1796353 - Handle getParcelableArrayList(String) deprecation.

* Bug 1796353 - Handle getParcelableArray(String) deprecation.

* Bug 1796353 - Handle getSerializableExtra(String) deprecation.

* Bug 1796353 - Handle readParcelable(classLoader) deprecation.

* Bug 1796353 - Handle FillResponse.Builder setAuthentication deprecation.

* Bug 1796353 - Handle Dataset.Builder setValue deprecation.

* Bug 1796353 - Suppress get(String) deprecation.

We still need to use this method because we do not know the type beforehand.

* Bug 1796353 - Handle onBackPressed() deprecation.

* Bug 1796353 - Suppress queryBroadcastReceivers deprecation.

* Bug 1796353 - Suppress package manager methods deprecation.

* Bug 1796353 - Catch and report exceptions when handling touch event detection.

* Bug 1796353 - Suppress deprecation for getPackageInfo used in tests with SDK 28.

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2022-11-16 00:35:40 -05:00
mcarare
ef3c3593c1 [components] No issue: Update AndroidX Annotation to the latest version.
Update imports for annotations moved to Companion Object.
2022-10-25 19:19:29 +00:00
mcarare
4ad330adbc [components] For https://github.com/mozilla-mobile/android-components/issues/12489: Upgrade kotlin, coroutines, compose compiler to latest versions.
Upgrade kotlin to 1.7.20, coroutines to 1.6.4 and compose compiler to 1.3.2.
Replace deprecated Xopt-in with op-in.
Replace deprecated Xjvm-default=enable with Xjvm-default=all.
Remove useIR property that is now default true.
2022-10-18 08:20:59 +00:00
Gabriel Luong
d9d783b698 [components] Issue https://github.com/mozilla-mobile/android-components/issues/12939: Address all ktlint issues 2022-10-17 17:07:40 -04:00
indu
227757b1a2 [components] For https://github.com/mozilla-mobile/android-components/issues/12215: Expand toolbar when the page is loading.
This fix allows the toolbar to be visible after the user clicks on a link and scrolls.
2022-05-31 13:18:39 +00:00
Roger Yang
d41614c2cd [components] Issue https://github.com/mozilla-mobile/android-components/issues/12191: Add support for toolbar not showing autocomplete results 2022-05-18 21:41:52 +00:00
Mugurell
d78b06b6bf [components] For https://github.com/mozilla-mobile/android-components/pull/11175 - Migrate runBlocking and runBlockingTest to runTest in unit tests
Used `runTestOnMain` where `MainCoroutineRule` was used or needed to be used,
`runTest` elsewhere.

Extra effort for removing all `runBlocking` occurrences in unit tests.
`kotlinx.coroutines.test.runTest` is a test specific API that seems like a more
appropriate way for running tests in a coroutine than the general
`kotlinx.coroutines.runBlocking` api.
2022-05-10 13:45:03 +00:00
Mugurell
2963708053 [components] For https://github.com/mozilla-mobile/android-components/issues/11755 - Replace TestCoroutineDispatcher with UnconfinedTestDispatcher
- Refactor out all usages of TestCoroutineDispatcher and TestCoroutineScope
- Refactor MainCoroutineRule to now use UnconfinedTestDispatcher by default.
This dispatcher will eagerly enter all launch or async blocks being more suited
to our codebase.
2022-05-10 13:45:03 +00:00
Roger Yang
bd452c3d99 [components] Close https://github.com/mozilla-mobile/android-components/issues/12109: Support removing edit action end in edit toolbar 2022-05-05 18:17:09 +00:00
Gabriel Luong
7c3dc51b44 [components] Issue https://github.com/mozilla-mobile/android-components/issues/11890: Add a new action container in the EditToolbar 2022-03-24 20:27:23 +00:00
mcarare
33d5df7988 [components] For https://github.com/mozilla-mobile/android-components/issues/11670: Use shadowOf(getMainLooper()).idle() to execute all posted tasks.
This is needed due to the new default Looper Mode - PAUSED in Robolectric.
2022-03-18 12:43:16 +00:00
Ionut Cristian Bedregeanu
a3340a5764 [components] For https://github.com/mozilla-mobile/android-components/issues/11279 - Add a method to remove navigation actions from toolbar
Add a new method(removeNavigationAction) in Toolbar interface to be able to remove a navigation action
as we have at this moment for browser/page actions(removeBrowserAction, removePageAction)
2021-11-17 13:22:48 +00:00
Ashutosh Singh
642b034e4d [components] Removal of browser-storage-memory (https://github.com/mozilla-mobile/android-components/pull/11211)
* deleted module and related files along with occurrences

* lint fixes

* used PlacesHistoryStorage for storage and readmeFix

* test fixes 1

* Update feature-awesomebar tests to use mocked HistoryStorage

* Linter fixes for feature-awesomebar

* toolbar fix 1

* toolbar fix

* final code cleanup

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
2021-11-05 09:27:22 +00:00
Sebastian Kaspari
90ec41fc3a [components] Update Kotlin and Jetpack Compose versions. 2021-10-25 10:58:07 +00:00
Arturo Mejia
c675876a0d [components] Close https://github.com/mozilla-mobile/android-components/issues/10827 show the toolbar Highlight (blue dot) when tracking protection is off for a site. 2021-08-18 10:11:48 +00:00
Mugurell
e277dd03f0 [components] For https://github.com/mozilla-mobile/android-components/issues/10803 - Force expanding the toolbar if requested by GeckoView 2021-08-16 07:46:15 +00:00
Sebastian Kaspari
ce323400dd [components] Run ktlintFormat to fix new ktlint errors. 2021-07-28 12:03:23 +00:00
Michael Comella
06e80c6e10 [components] For https://github.com/mozilla-mobile/android-components/issues/10604: remove remaining unused imports automatically.
This commit was automatically generated with:
```sh
./gradlew ktlint --args="-F"
```
2021-07-27 19:39:04 +00:00
Michael Comella
9f3e6f1a1b [components] For https://github.com/mozilla-mobile/android-components/issues/10604: reuse new TestCoroutineDispatcher in additional tests.
These follow a few more simple patterns I was able to find:
- the testDispatcher is not used anywhere else: remove it
- the testDispatcher is used to set a main dispatcher: this is redundant
to the test rule so remove it both the dispatcher & the main dispatcher
- the testDispatcher is actually used elsewhere: for simplicity, change
the reference to point at the MainCoroutineRule.
2021-07-27 19:39:04 +00:00
Arturo Mejia
e4d539f111 [components] Closes https://github.com/mozilla-mobile/android-components/issues/10448 show toolbar permissions indicator when permissions change from their default. 2021-07-27 17:25:23 +00:00
Sebastian Kaspari
28a76101be [components] Update Kotlin to 1.5.10 (and Coroutines to 1.5.0 and Room to 2.3.0). 2021-07-19 09:32:44 +00:00
Christian Sadilek
c9d791c53b [components] Adjust detekt TooManyFunctions threshold 2021-03-18 15:25:40 +00:00
Mugurell
ec35e97135 [components] For https://github.com/mozilla-mobile/android-components/issues/9770 - Don't animate the dynamic toolbar while tab is loading
Toolbar will not be animated while the tab is loading irrespective of the
intrinsic checks made in the BrowserToolbarBehavior - whether the touch is a
vertical scroll and it was handled by GeckoView.
2021-03-01 17:00:22 +00:00
Roger Yang
dcd57ecc3c [components] Closes https://github.com/mozilla-mobile/android-components/issues/9528: Exposes BrowserMenu dismiss through BrowserToolbarMenu 2021-01-28 10:14:24 +00:00
Arturo Mejia
53add50756 [components] Closes https://github.com/mozilla-mobile/android-components/issues/9378: Add dot notification to the toolbar 2021-01-18 16:19:32 +00:00