Commit Graph

33 Commits

Author SHA1 Message Date
Lina Butler
c4350f91fe Bug 1858542 - Introduce AwesomeBarState and Suggestion.metadata.
This commit adds:

* An `AwesomeBarState` class to hold the currently visible suggestions
  and last clicked suggestion.
* `VisibilityStateUpdated` and `SuggestionClicked` `AwesomeBarAction`s
  to update the state, and an `EngagementFinished` action to reset the
  state. Consumers will dispatch these actions on the `BrowserStore`
  in response to user interactions with the awesomebar and toolbar.
* A `metadata` map to `AwesomeBar.Suggestion`, allowing providers to
  attach opaque data to each suggestion.
2023-10-24 07:43:07 +00:00
Lina Butler
2baad7c50e Bug 1859408 - Instrument the awesomebar to report visible suggestions.
This commit adds an `onVisibilityStateUpdated` callback to the
`AwesomeBar` composable. The new callback is invoked with the current
`AwesomeBar.VisibilityState` whenever the list of visible suggestions
changes.
2023-10-17 17:08:29 +00:00
DreVla
1c25bd863f Bug 1849274 - Record history telemetry when Unified Search result tap
Searching through history using unified search, when a suggestion
is tapped, the History.searchResultTapped event is
sent.
2023-10-12 10:18:35 +00:00
mcarare
063c553913 Bug 1849833 - Replace deprecated compileSdkVersion.
This is replaced by defaultConfig compileSdk.
2023-09-11 06:36:20 +00:00
Ryan VanderMeulen
0e5e70291c Bug 1820233 - Remove unneeded kotlin_stdlib inclusions and re-enable Werror in detekt build.gradle 2023-03-07 00:12:18 +00:00
mcarare
1f589a2e0b Bug 1802817 - Set namespace via DSL in gradle build files.
See https://developer.android.com/studio/build/configure-app-module#set-namespace
and https://issuetracker.google.com/issues/172361895
2023-03-02 17:13:09 +00:00
mcarare
922b5f6643 Bug 1802817 - Rename AC Dependencies to ComponentsDependencies.
This change is needed in order to avoid clashes with Dependencies class introduced
in Gradle from 7.6 version.
2023-03-02 17:13:09 +00:00
sarah541
179a7ca332 Bug 1800700 - Add default search suggest header 2022-12-15 20:36:00 +00:00
Christian Sadilek
4091b14a33 Fix android lint in composite builds 2022-11-21 13:40:53 -05:00
Gabriel Luong
d9d783b698 [components] Issue https://github.com/mozilla-mobile/android-components/issues/12939: Address all ktlint issues 2022-10-17 17:07:40 -04:00
sarah541
805e57c7c0 [components] For https://github.com/mozilla-mobile/android-components/issues/12443 - Add firefox suggest header for lib suggestions 2022-07-14 21:16:10 +00:00
Sebastian Kaspari
46a8218028 [components] Issue https://github.com/mozilla-mobile/android-components/issues/11084: AwesomeBar(): Allow setting limit for suggestions in a provider group 2021-10-05 12:39:51 +00:00
Sebastian Kaspari
cfb9bd6e0a [components] Issue https://github.com/mozilla-mobile/android-components/issues/11072: AwesomeBar(): Allow grouping suggestion providers in groups with optional titles 2021-10-04 08:59:21 +00:00
Sebastian Kaspari
4c548dc501 [components] Remove AwesomeBar.shouldClearSuggestions 2021-08-06 11:13:56 +00:00
Hakkı Kaan Çalışkan
bff840d2bf [components] Closes https://github.com/mozilla-mobile/android-components/issues/8156: Add indicator to synced tabs suggestion in awesomebar
make lint and detekt happy

add changelog

forgotten space from another pr's in changelog

make requested changes

add flag to synced tabs suggestions too and add test

make detekt happy

add test for indicatorIcons too

make requested changes
2020-09-14 23:09:37 +03:00
Michael Debertol
cf7af4cc8e [components] For https://github.com/mozilla-mobile/android-components/issues/8175: Allow SuggestionProviders to specify a edit suggestion 2020-08-20 20:04:09 +02:00
Kirill Rakhman
5e13b69faf [components] Closes https://github.com/mozilla-mobile/android-components/issues/6813 Awesomebar: Add ability to accept suggestion from search completion without submitting 2020-07-31 18:29:40 +02:00
Hakkı Kaan Çalışkan
f855c377df [components] For https://github.com/mozilla-mobile/android-components/issues/7803: Visually indicate different types of suggestions in the search screen 2020-07-21 18:43:03 +03:00
levimatheri
181eaea947 [components] Closes https://github.com/mozilla-mobile/android-components/issues/4632. Add contains function for suggestion providers 2020-03-24 16:29:22 -04:00
Sawyer Blatz
c3abe2f6c9 [components] For https://github.com/mozilla-mobile/android-components/issues/4653: Do not display suggestion until icon is ready 2019-10-07 17:20:06 -07:00
Sebastian Kaspari
8d595984e7 [components] BrowserAwesomeBar: Only call onInputChanged() after onInputStarted() and allow provider to return suggestions from onInputStarted().
For: https://github.com/mozilla-mobile/fenix/issues/2406
2019-05-23 11:05:02 -04:00
Denys M
440c6ce145 [components] For https://github.com/mozilla-mobile/android-components/issues/2346. Enable kotlin warningsAsErrors for concept-toolbar module. 2019-05-22 08:10:12 -04:00
Christian Sadilek
985c3dc80f [components] Closes https://github.com/mozilla-mobile/android-components/issues/2364: Prevent duplicate ViewHolder IDs in AwesomeBar
- This also fixes the HistoryStorageSuggestionProvider to dedupe
history suggestions based on the ID, picking the one with the
highest score.

- Should other providers still return suggestions with duplicate
IDs we now throw an exception containing the provider class name.

Co-authored-by: Grisha Kruglov <gkruglov@mozilla.com>
2019-04-11 14:34:44 -07:00
Sawyer Blatz
96befb3993 [components] Closes https://github.com/mozilla-mobile/android-components/issues/2272: Adds removeProvider and removeAllProviders to AwesomeBar 2019-03-07 11:50:43 -08:00
Sebastian Kaspari
3af4505e8e [components] Use browser-icons component in providers implemented by feature-awesomebar. 2019-03-05 18:12:47 +01:00
Grisha Kruglov
1db5d27efa [components] Use stableIDs in SuggestionAdapter; retain suggestions on the screen
Co-authored-by: Sebastian Kaspari <s.kaspari@gmail.com>
2019-02-28 17:20:34 +01:00
Sebastian Kaspari
1a971da296 [components] Closes https://github.com/mozilla-mobile/android-components/issues/1681 - Add ClipboardSuggestionProvider for providing URL suggestions from clipboard. 2019-01-15 18:52:17 +01:00
Mitchell Hentges
8fd19cdf3a [components] Moves description to be part of project.ext 2019-01-11 10:08:32 +01:00
Mitchell Hentges
3ee4d96a84 [components] Reads componentsVersion from .buildconfig.yml 2019-01-11 10:08:32 +01:00
Grisha Kruglov
ed472d66ae [components] Clean up gradle build files for some of the components
- Remove a few unnecessary dependencies
- Add some comments around usage of 'api'
- Mark some of the dependencies as 'api' if they're necessary for use of the module
2018-12-21 13:11:27 -08:00
ali-abdullah
89f3263d12 [components] included buildSrc in ktlint and detekt checks 2018-11-16 12:40:04 +01:00
Sebastian Kaspari
43da6840b7 [components] Issue https://github.com/mozilla-mobile/android-components/issues/1109: concept-awesomebar: Introduce weights, suspend onInputChanged() and add shouldClearSuggestions.
* This change introduces the concept of "weights". Weights are used to rank suggestions against each other.
  This allows the awesomebar to mix suggestions from different providers.
* AwesomeBar.SuggestionProvider.onInputChanged() is now a suspending function.
* A provider can define `shouldClearSuggestions` to avoid suggestions getting cleared immediatelly once
  the entered text changes.
2018-11-02 17:14:47 +01:00
Sebastian Kaspari
aabc22c364 [components] Issue https://github.com/mozilla-mobile/android-components/issues/1109: Add concept component for implementing awesome bar components. 2018-10-26 14:53:59 +02:00