Commit Graph

200 Commits

Author SHA1 Message Date
Tamas Szentpeteri
9c75f7906a Backed out changeset df5c0de8443f (bug 1891972) requested by twhite for causing robotest failures. CLOSED TREE 2024-05-21 18:45:20 +03:00
t-p-white
9c4b1c8014 Bug 1891972 - Allow CFRs to be dismissed by outside touches. Interim fix to improve the current CFR implementation r=android-reviewers,vdreghici
Differential Revision: https://phabricator.services.mozilla.com/D208131
2024-05-21 08:29:41 +00:00
mcarare
1070e28db0 Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 13:00:48 +00:00
acseh
3f4b08c594 Backed out changeset 9976b7730dbd (bug 1893120) for causing lint failures CLOSED TREE 2024-05-14 12:57:36 +03:00
mcarare
4a11afeae1 Bug 1893120 - Run AC Robolectric tests on SDK 34 and adapt tests. r=android-reviewers,webcompat-reviewers,twisniewski,avirvara
Differential Revision: https://phabricator.services.mozilla.com/D209640
2024-05-14 08:02:38 +00:00
Noah Bond
2ff8aee786 Bug 1895707 - Fix crash caused by dismissing the CFR r=android-reviewers,boek
When dismissing the CFR, if the caller fragment of the anchor was also dismissed immediately, a crash would occur.

The crash was due to the combination of the manual dismiss in this Composable as well as the dismiss that happens as part of the normal logic flow when the user triggers a dismiss. The second `onDismiss` call before the first one finished caused a fatal crash (stack trace in bug).

There was also a bug where clicking on the CFR would take the user to Settings but NOT dismiss the tabs tray. This was solved by providing a callback to dismiss the CFR when the `action` is invoked.

Differential Revision: https://phabricator.services.mozilla.com/D209842
2024-05-08 22:12:11 +00:00
Noah Bond
36e9d1f91d Bug 1894120 - Fix bug causing duplicate CFRs to display r=android-reviewers,matt-tighe
Differential Revision: https://phabricator.services.mozilla.com/D208949
2024-05-01 17:24:54 +00:00
Noah Bond
a1519fab0f Bug 1816746 - Add the Inactive Tabs CFR to the Tabs Tray rewrite r=android-reviewers,matt-tighe
Differential Revision: https://phabricator.services.mozilla.com/D207641
2024-04-24 20:06:45 +00:00
Stanca Serban
1debac43ee Backed out changeset 5519716422b3 (bug 1891972) for causing Bug 1893003. 2024-04-23 22:03:03 +03:00
t-p-white
918810b173 Bug 1891972 - Allow CFRs to be dismissed by outside touches. Interim fix to improve the current CFR implementation r=android-reviewers,vdreghici
Differential Revision: https://phabricator.services.mozilla.com/D208131
2024-04-23 07:58:25 +00:00
Gabriel Luong
ad8f04aea6 Bug 1845134 - Part 3: Rename mozac_ic_append_up_24 tp mozac_ic_append_up_left_24 r=android-reviewers,007
Refactors mozac_ic_append_up_24 tp mozac_ic_append_up_left_24 and updates the source from acorn-icons

Differential Revision: https://phabricator.services.mozilla.com/D206453
2024-04-04 04:57:25 +00:00
mcarare
7562dc8765 Bug 1880077 - Switch to using Compose BOM instead of individual versioning 2024-02-22 08:51:53 +00:00
github-actions
ab1867a36c Import translations from android-l10n 2024-02-09 03:57:17 +00:00
github-actions
71356474b3 Import translations from android-l10n 2024-02-03 00:26:38 +00:00
github-actions
c11d231a4c Import translations from android-l10n 2024-01-18 20:02:46 -05:00
t-p-white
01f1578630 Bug 1874861 - Removed redundant LongParameterList suppression's 2024-01-18 18:37:49 +00:00
github-actions
579c5c9774 Import translations from android-l10n 2023-12-09 00:35:44 +00:00
DreVla
a921cc2fa0 Bug 1857558 - [a11y] Dictate Correct CFR Popup Title
Previously when using talkback and a CFR was displayed, the
dictated caption was wrong. This patch makes the Popup focusable
so talkback will dictate Pop-Up window once it appears.
2023-11-20 16:50:59 +00:00
github-actions
f8593e994f Import translations from android-l10n 2023-11-11 00:30:35 +00:00
github-actions
55addd420e Import translations from android-l10n 2023-10-30 00:26:47 +00:00
Lina Butler
2baad7c50e Bug 1859408 - Instrument the awesomebar to report visible suggestions.
This commit adds an `onVisibilityStateUpdated` callback to the
`AwesomeBar` composable. The new callback is invoked with the current
`AwesomeBar.VisibilityState` whenever the list of visible suggestions
changes.
2023-10-17 17:08:29 +00:00
github-actions
4341b9c1f5 Import translations from android-l10n 2023-10-02 01:31:08 +00:00
DreVla
4ee8243427 Bug 1812461 - Add compose test tags & ignore failing tests
Added needed test tags to compose elements. Ignored
`ContextualHintsTest` which seem to fail due to not finding
the compose elements.
2023-09-14 15:13:08 +00:00
DreVla
9ab08a358c Bug 1812461 - Add option to hide CFRPopup dismissal button
Since we migrated the `privateBrowsingRecommend` to CFRPopup,
this popup has a `No thanks` dismiss button, therefore not
requiring the classic X dismiss button. This change adds
a parameter with which we are able to control if we
want to show the X button or not in a CFRPopup.
2023-09-14 15:13:08 +00:00
DreVla
e36f3c5d83 Bug 1812461 - Migrate private browsing recommend PopupWindow to CFRPopup
Because previously the `privateBrowsingRecommend` Popup was using
PopupWindow from android widget, it could not be modified to
respect to PopupWindow behaviors. Therefore, we decided to migrate
it to the CFRPopup.
2023-09-14 15:13:08 +00:00
DreVla
c0f25a635d Bug 1812461 - Update CFR Popups to be sticky
CFRPopup default properties have been changed so a popup does not
dismiss anymore on a click outside or a back press.
Additionally, popups will reappear if the screen is rotated and
the popup was not dismissed.
2023-09-14 15:13:08 +00:00
mike a
dd3cf83610 Bug 1852328 – removed suggestion map upcasting from Awesomebar 2023-09-11 14:41:43 +00:00
mcarare
063c553913 Bug 1849833 - Replace deprecated compileSdkVersion.
This is replaced by defaultConfig compileSdk.
2023-09-11 06:36:20 +00:00
mcarare
235c47209f Bug 1849833 - Replace deprecated kotlinOptions method. 2023-09-11 06:36:20 +00:00
mcarare
5a7b24763d Bug 1849833 - Replace qualified name with import. 2023-09-11 06:36:20 +00:00
iorgamgabriel
47af2f06e2 Bug 1844960 - Bookmark suggestions should appear unconcerned with the search suggestions setting. 2023-09-08 07:57:42 +00:00
Alexandru2909
278794410b Bug 1849564 - Add support for CFR popup centered alignment 2023-08-30 08:14:25 +00:00
MatthewTighe
c87183c8b5 Bug 1843168 - Expose Mockito through test support component 2023-07-24 18:02:09 +00:00
github-actions
5ad818a6ce Import translations from android-l10n 2023-07-14 01:00:05 +00:00
Gabriel Luong
f8e7dcd258 Bug 1840210 - Rename mozac_ic_close_20 to mozac_ic_cross_20 2023-07-10 22:15:49 +00:00
Gabriel Luong
c21d65d68c Bug 1840210 - Rename mozac_ic_edit_suggestion to mozac_ic_append_up_24 2023-07-10 22:15:49 +00:00
Gabriel Luong
31806c234b Bug 1840210 - Rename mozac_ic_clear to mozac_ic_cross_circle_fill_24 2023-07-10 22:15:49 +00:00
Gabriel Luong
edc8c27961 Bug 1840210 - Rename mozac_ic_close to mozac_ic_cross_24 2023-07-10 22:15:49 +00:00
github-actions
671c33c1b3 Import translations from android-l10n 2023-07-04 00:29:41 +00:00
github-actions
570991db5c Import translations from android-l10n 2023-05-09 00:34:46 +00:00
github-actions
7ca3929415 Import translations from android-l10n 2023-05-07 00:36:22 +00:00
github-actions
59cf7ecc2e Import translations from android-l10n 2023-05-05 00:32:51 +00:00
github-actions
6fdbe40318 Import translations from android-l10n 2023-04-29 00:38:27 +00:00
Noah Bond
830d0e0cc1 Bug 1826457 - Update Compose version to 1.4.2 and Lifecycle version to 2.6.1 2023-04-27 03:17:17 +00:00
github-actions
cbcc2058d5 Import translations from android-l10n 2023-04-26 01:24:45 +00:00
github-actions
4f4b08518d Import translations from android-l10n 2023-04-22 01:15:02 +00:00
rahulsainani
42a1bace75 Bug 1827631 - Use debugImplementation for compose tooling 2023-04-20 07:11:42 +00:00
Geoff Brown
4b36c91e06 Bug 1825116 - Add license notice where missing (https://github.com/mozilla-mobile/firefox-android/pull/1637)
* Bug 1825116 - Add license notice where missing

* Bug 1825116 - Revert changes to strings.xml

* Bug 1825116 - Restore ic_cc*.xml
2023-04-19 21:08:15 +00:00
Geoff Brown
6561b2de2b Bug 1825116 - Resolve many black, isort, and file-whitespace lint issues 2023-04-12 14:04:29 +00:00
github-actions
8f0ac2dd65 Import translations from android-l10n 2023-04-03 00:36:25 +00:00