When a login choice was made, the Hint associated with it was lost, so recalculate it and pass it to the LoginSelectOption constructor.
Differential Revision: https://phabricator.services.mozilla.com/D209898
This eliminates some eslint errors on firefox-android code by running 'mach lint --linter=eslint --fix'.
The eslint --fix only addresses a few simple issues, but this allows us to remove some lint exclusions.
Differential Revision: https://phabricator.services.mozilla.com/D210107
This patch updates Android Components to use the new `hasVisibleChange `
information from the translations engine to better manage translations visible state.
Differential Revision: https://phabricator.services.mozilla.com/D209577
- remove the firefox-android exclusions from .prettierignore
- add a few specific exclusions to .prettierignore for files with existing errors
- add a few specific entries to Generated.txt and ThirdPartyPaths.txt
- add `initial_experiments.json` to the list of generated files: these are updated from Nimbus
- run `mach lint --fix --linter=eslint -- mobile/android` to generate all the formatting changes
Differential Revision: https://phabricator.services.mozilla.com/D206915
- This refactors `getProperUrl` that was introduced in https://github.com/mozilla-mobile/fenix/pull/16181 into an extension function that lives in AC.
- This function will fetch the correct URL to be used when handling features such as bookmarks or share regardless of what mode the browser might be in (e.g. Reader mode).
Differential Revision: https://phabricator.services.mozilla.com/D208215
This patch adds the option to update the user's language settings from a global perspective.
* Adds `TranslationsAction.UpdateLanguageSettingsAction` to update the language setting.
* `TranslationsStateReducer` proactively accepts updates and is set on the translations engine or else the state is rolled back in `TranslationsMiddleware`.
* Refactors `updateLanguageSetting` in `TranslationsMiddleware` to handle both the page setting and global setting perspective.
Differential Revision: https://phabricator.services.mozilla.com/D208755
Right now, it is only possible to access the “offer to translate” setting off of page settings. Unlike most of the other page settings, this setting is also a global setting.
This patch adds an option to view this setting independently of page settings and helps keep it in sync, when page settings change this setting as well.
We need this because it will soon be possible to access the global settings layer of settings directly via the main menu settings.
This patch:
* Adds `SetGlobalOfferTranslateSettingAction` - Sets the `offerTranslation` value on the global `TranslationsBrowserState`. Intended for global usage.
* Adds `UpdateGlobalOfferTranslateSettingAction` - A global way to update the offer to translate value outside of a page.
* Adds `TranslationOperation.FETCH_OFFER_SETTING` - The same as `SetGlobalOfferTranslateSettingAction`, but for a tab. Intended for tab usage.
* Adds a call to set `offerTranslation` on `Init`
Differential Revision: https://phabricator.services.mozilla.com/D208233
This is effectively a no-op because we're already picking it up implicitly
from other AC modules, but it's better to be explicit to avoid unexpected
problems down the road if that situation happens to change.
Differential Revision: https://phabricator.services.mozilla.com/D208009
The minimum API level was bumped in the Core 1.13.0 release, leading to
a number of new warnings about deprecated Java API usage which turn
fatal with warnings-as-errors enabled.
Differential Revision: https://phabricator.services.mozilla.com/D207971
