corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
861,779 Commits 1 Branch 0 Tags
c4167a3cc664ca4001b8fab535de63a901bef5a0
Commit Graph

648 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
6320be3e20 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt 
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
 2024-05-19 21:24:16 +00:00
Cristian Tuns
fbb56a1610 Backed out changeset dffe004546c6 (bug 1897361) for causing reftest failures in /list-1.html CLOSED TREE 2024-05-19 17:09:47 -04:00
Emilio Cobos Álvarez
ebdae8c849 Bug 1897361 - Share counter-style / list-style-type representation between Servo and Gecko. r=jwatt 
It's not clear to me what is going on there or what caused it. I suspect
it might be:

  https://searchfox.org/mozilla-central/rev/1f46481d6c16f27c989e72b898fd1fddce9f445f/servo/components/style/gecko/values.rs#69

Which is the only potential from_raw_parts caller there. But hard to say
without a regression range.

However I've been wanting to get rid of that code for a while, and
this is a good opportunity for that.

The WithCounterStyleNameOrSymbols stuff isn't super pretty, but it has
only two callers, and something more complicated might require further
refactoring.

Differential Revision: https://phabricator.services.mozilla.com/D210814
 2024-05-19 19:42:38 +00:00
Emilio Cobos Álvarez
28bdfc0fba Bug 1281158 - Parse alternative text for the content property. r=dshin 
This doesn't yet expose it to a11y but that will be done by the a11y
folks, since this blocks some of the a11y interop test-cases.

Modify the tests to not hit the network, and make -moz-alt-content not
exposed to content (we only need it for UA stylesheets).

Differential Revision: https://phabricator.services.mozilla.com/D209690
 2024-05-08 16:06:47 +00:00
Emily McDonough
3ca301e949 Bug 1833466 - Implement CSSMarginRule and the corresponding DOM API. r=webidl,firefox-style-system-reviewers,smaug,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D206804
 2024-04-16 19:52:39 +00:00
Sandor Molnar
a29925a21c Backed out changeset ce926ee22c80 (bug 1833466) for causing build bustages @ layout/style/ServoStyleSet.cpp CLOSED TREE 2024-04-16 04:04:55 +03:00
Emily McDonough
986c112d1b Bug 1833466 - Implement CSSMarginRule and the corresponding DOM API. r=webidl,firefox-style-system-reviewers,smaug,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D206804
 2024-04-15 23:55:12 +00:00
Sandor Molnar
ce68385462 Backed out changeset f2ae18495e1e (bug 1833466) for causing build bustages @ CSSMarginRule.cpp 2024-04-16 00:09:00 +03:00
Emily McDonough
f4b1a18436 Bug 1833466 - Implement CSSMarginRule and the corresponding DOM API. r=webidl,firefox-style-system-reviewers,smaug,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D206804
 2024-04-15 18:14:42 +00:00
Boris Chiou
0a0aa568db Bug 1889496 - Part 2: Implement CSSStartingStyleRule interface. r=webidl,firefox-style-system-reviewers,layout-reviewers,emilio 
Introduce CSSStartingStyleRule and add one extra parsing test for
@starting-style rule.

Differential Revision: https://phabricator.services.mozilla.com/D206564
 2024-04-05 21:03:07 +00:00
Boris Chiou
36f2970bd8 Bug 1889496 - Part 1: Parse @starting-style rule. r=layout-reviewers,firefox-style-system-reviewers,emilio 
We introduce this rule and parse it in this patch. Also, fix some wpt
expectations for ERROR.

We will introduce CSSStartingStyleRule in the following patch, and test
it there.

Differential Revision: https://phabricator.services.mozilla.com/D206428
 2024-04-05 21:03:06 +00:00
Cristian Tuns
e28581a958 Backed out 2 changesets (bug 1889496) for causing build bustages in RefPtr.h CLOSED TREE 
Backed out changeset 7689f9c266fc (bug 1889496)
Backed out changeset abbbf327c4f1 (bug 1889496)
 2024-04-04 19:15:49 -04:00
Boris Chiou
90f93535fd Bug 1889496 - Part 2: Implement CSSStartingStyleRule interface. r=webidl,firefox-style-system-reviewers,layout-reviewers,emilio 
Introduce CSSStartingStyleRule and add one extra parsing test for
@starting-style rule.

Differential Revision: https://phabricator.services.mozilla.com/D206564
 2024-04-04 19:39:29 +00:00
Boris Chiou
d098db3d45 Bug 1889496 - Part 1: Parse @starting-style rule. r=layout-reviewers,firefox-style-system-reviewers,emilio 
We introduce this rule and parse it in this patch. Also, fix some wpt
expectations for ERROR.

We will introduce CSSStartingStyleRule in the following patch, and test
it there.

Differential Revision: https://phabricator.services.mozilla.com/D206428
 2024-04-04 19:39:28 +00:00
keithamus
9d776293f2 Bug 1888098 - optimize nth-of dependency tracking for custom state r=dshin 
Differential Revision: https://phabricator.services.mozilla.com/D205804
 2024-03-27 21:43:01 +00:00
keithamus
390ef8eb0d Bug 1865589 - Notify PresShell of CustomState changes, so Restyle can invalidate. r=emilio,dshin 
Differential Revision: https://phabricator.services.mozilla.com/D202460
 2024-03-22 22:18:05 +00:00
David Shin
d8686f3e77 Bug 1882581: Implement @scope parsing. r=firefox-style-system-reviewers,saschanaz,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D203153
 2024-03-19 13:36:48 +00:00
Natalia Csoregi
97b561d39d Backed out 2 changesets (bug 1882581) for causing bustage on InspectorUtils.cpp. CLOSED TREE 
Backed out changeset 9f390afd0df5 (bug 1882581)
Backed out changeset 4781bbc7324f (bug 1882581)
 2024-03-19 05:38:08 +02:00
David Shin
d3c86f27a6 Bug 1882581: Implement @scope parsing. r=firefox-style-system-reviewers,saschanaz,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D203153
 2024-03-18 18:31:18 +00:00
Nicolas Chevobbe
8385ae28f0 Bug 1857523 - Pass PropertyDefinition in csscustompropertyregistered event. r=emilio. 
Differential Revision: https://phabricator.services.mozilla.com/D196828
 2024-01-16 19:31:05 +00:00
Nicolas Chevobbe
aa46055693 Bug 1857523 - Add ChromeOnly csscustompropertyregistered event. r=emilio. 
The event is emitted when a property is registered via `CSS.registerProperty`.
This will be used by DevTools so we can update the Rules view when a property
is registered.

Differential Revision: https://phabricator.services.mozilla.com/D196204
 2024-01-16 19:31:04 +00:00
David Shin
a06ce3f70f Bug 1874705: Run invalidation on appended elements even if the first node is not an element. r=firefox-style-system-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D198604
 2024-01-16 18:08:55 +00:00
David Shin
abfe574d9b Bug 1873649: Do not eagerly seek prev and next siblings DOM mutation invalidation. r=firefox-style-system-reviewers,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D198052
 2024-01-11 18:21:46 +00:00
Jonathan Watt
6c2a48d8de Bug 1869217. Don't use the @page rules that match the first page as the page defaults. r=emilio 
page-rule-specificity-001-print.html is the only test that actually fails prior
to this patch (it already passes in Chrome).

Differential Revision: https://phabricator.services.mozilla.com/D196000
 2023-12-11 17:53:41 +00:00
Norisz Fay
c52560681f Backed out changeset 8bb12620232e (bug 1869217) for causing bc failures on browser_modal_print.js 2023-12-11 16:55:28 +02:00
Jonathan Watt
cff30cfc3e Bug 1869217. Don't use the @page rules that match the first page as the page defaults. r=emilio 
page-rule-specificity-001-print.html is the only test that actually fails prior
to this patch (it already passes in Chrome).

Differential Revision: https://phabricator.services.mozilla.com/D196000
 2023-12-11 14:16:41 +00:00
Norisz Fay
7949fba057 Backed out changeset a4d1a60eed3e (bug 1869217) for causing build bustages on nsPrintJob.cpp CLOSED TREE 2023-12-11 13:54:23 +02:00
Jonathan Watt
ccc205b240 Bug 1869217. Don't use the @page rules that match the first page as the page defaults. r=emilio 
page-rule-specificity-001-print.html is the only test that actually fails prior
to this patch (it already passes in Chrome).

Differential Revision: https://phabricator.services.mozilla.com/D196000
 2023-12-11 10:59:18 +00:00
Emily McDonough
bce77aa24f Bug 1852149 Part 3 - Add margin rules to servo r=firefox-style-system-reviewers,emilio 
Parsing is disabled by the layout.css.margin-rules.enabled pref.
This isn't currently testable beyond a crashtest because the DOM interface for
margin rules isn't implemented yet.

Differential Revision: https://phabricator.services.mozilla.com/D187736
 2023-12-08 20:25:55 +00:00
Emilio Cobos Álvarez
dfebdd881a Bug 1863620 - Make animation traversal work for style roots other than the document element. r=boris 
This fixes some flickering when transitioning doc-level anonymous
content.

Differential Revision: https://phabricator.services.mozilla.com/D193046
 2023-11-08 20:48:56 +00:00
Norisz Fay
ee54f954f9 Backed out changeset 2c84b8379060 (bug 1863620) for causing failures on test_group_mouseevents.html | helper_drag_root_scrollbar_mouse_not_over_thumb.html CLOSED TREE 2023-11-09 03:44:13 +02:00
Emilio Cobos Álvarez
2c3e083257 Bug 1863620 - Make animation traversal work for style roots other than the document element. r=boris 
This fixes some flickering when transitioning doc-level anonymous
content.

Differential Revision: https://phabricator.services.mozilla.com/D193046
 2023-11-08 20:48:56 +00:00
Adam Brouwers-Harries
4a2ba69cbc Bug 1421651 - Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau 
This patch removes the old docshell timeline and timeline markers codebase and replaces them with equivalent Gecko profiler marker. This patch also fixes Bug 1834143, which is a subset of 1421651.

Differential Revision: https://phabricator.services.mozilla.com/D184217
 2023-10-24 15:18:12 +00:00
Narcis Beleuzu
67b61b8b2c Backed out changeset 714aaf6484fb (bug 1421651) for causing Bug 1860719. CLOSED TREE 2023-10-24 17:31:02 +03:00
Adam Brouwers-Harries
720e582a3a Bug 1421651 - Remove obseleted timeline and TimelineMarker code r=canaltinova,webidl,devtools-reviewers,saschanaz,smaug,ochameau 
This patch removes the old docshell timeline and timeline markers codebase and replaces them with equivalent Gecko profiler marker. This patch also fixes Bug 1834143, which is a subset of 1421651.

Differential Revision: https://phabricator.services.mozilla.com/D184217
 2023-10-23 13:55:50 +00:00
Frederic Wang
4a751329c5 Bug 1858362 - Style invalidation after call to CSS.registerProperty. r=emilio 
Call to CSS.registerProperty may result in rendering changes compared
to when variables were interpreted as unregistered custom properties.
Ensure we recascade style for the whole document tree.

This was already covered by WPTs but add a more direct check for
paint and reflow.

Differential Revision: https://phabricator.services.mozilla.com/D190656
 2023-10-12 06:10:56 +00:00
Sandor Molnar
66d2190971 Backed out changeset 8dbb04b2762b (bug 1858362) for causing wpt failures on /css/css-properties-values-api/register-property.html CLOSED TREE 2023-10-11 19:04:03 +03:00
Frederic Wang
372c799924 Bug 1858362 - Style invalidation after call to CSS.registerProperty. r=emilio 
Call to CSS.registerProperty may result in rendering changes compared
to when variables were interpreted as unregistered custom properties.
Ensure we recascade style for the whole document tree.

This was already covered by WPTs but add a more direct check for
paint and reflow.

Differential Revision: https://phabricator.services.mozilla.com/D190656
 2023-10-11 12:14:38 +00:00
David Shin
e431c263e5 Bug 1852965: :has invalidation for inner selectors. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D188339
 2023-09-28 19:48:19 +00:00
Natalia Csoregi
6a9f13d186 Backed out changeset 7e07f570bd03 (bug 1852965) for causing geckoview failures. CLOSED TREE 2023-09-28 18:43:07 +03:00
David Shin
2a4c2d86e7 Bug 1852965: :has invalidation for inner selectors. r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D188339
 2023-09-28 13:43:35 +00:00
Emilio Cobos Álvarez
bc2572c2ca Bug 1854744 - Document::RecordShadowStyleChange doesn't need to invalidate global stylesheet state. r=jrmuizel 
Things like @font-face / @font-pallete-values etc don't look into those
stylesheets.

This prevents bugs in invalidation like bug 1854742 from triggering on
shadow root style changes like when changing AdoptedStyleSheets and so
on.

Differential Revision: https://phabricator.services.mozilla.com/D189034
 2023-09-24 09:52:04 +00:00
David Shin
9f6bffd7f3 Bug 1792501: Part 7 - :has invalidation inside :nth-child(of). r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D185680
 2023-09-14 22:21:26 +00:00
David Shin
96602a739a Bug 1792501: Part 6 - :has invalidation for :empty and :nth (Without of). r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D185679
 2023-09-14 22:21:26 +00:00
David Shin
9f1cc6d0c9 Bug 1792501: Part 5 - :has DOM mutation invalidation. r=emilio,layout-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185678
 2023-09-14 22:21:25 +00:00
David Shin
14291fa2ca Bug 1792501: Part 4 - Basic :has invalidation. r=emilio,layout-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185677
 2023-09-14 22:21:25 +00:00
Sandor Molnar
f1783ba5d9 Backed out 8 changesets (bug 1792501) for causing wpt failures on /css/selectors/... 
Backed out changeset 993b0e6567e6 (bug 1792501)
Backed out changeset 7686c9df9ad4 (bug 1792501)
Backed out changeset cf9f855ad80c (bug 1792501)
Backed out changeset 27abe13a5a48 (bug 1792501)
Backed out changeset f708f940e907 (bug 1792501)
Backed out changeset 2a7c57a69803 (bug 1792501)
Backed out changeset 69f1155100f5 (bug 1792501)
Backed out changeset 3f5f59b76a56 (bug 1792501)
 2023-09-14 20:08:41 +03:00
David Shin
e5e447d0f0 Bug 1792501: Part 7 - :has invalidation inside :nth-child(of). r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D185680
 2023-09-14 12:30:57 +00:00
David Shin
5b6faed1ca Bug 1792501: Part 6 - :has invalidation for :empty and :nth (Without of). r=emilio 
Differential Revision: https://phabricator.services.mozilla.com/D185679
 2023-09-14 12:30:56 +00:00
David Shin
8dab1a142d Bug 1792501: Part 5 - :has DOM mutation invalidation. r=emilio,layout-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D185678
 2023-09-14 12:30:56 +00:00