Commit Graph

97 Commits

Author SHA1 Message Date
Kagami Sascha Rosylight
f356d7984d Bug 1863765 - Part 2: Close the stream when the type error happens r=jari,janv
Differential Revision: https://phabricator.services.mozilla.com/D195777
2024-04-04 17:50:10 +00:00
Kagami Sascha Rosylight
e1789bcded Bug 1863765 - Part 1: Wrap WriteCallback in UnderlyingSinkAlgorithmsWrapper r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D193092
2024-04-04 17:50:10 +00:00
Jan Varga
d00a567f12 Bug 1874334 - Abort open writable file streams during xpcom-will-shutdown shutdown phase; r=dom-storage-reviewers,jstutte
Differential Revision: https://phabricator.services.mozilla.com/D205687
2024-03-27 12:47:16 +00:00
Jan Varga
0c151e57a0 Bug 1858820 - Handle other FileSystemWritableFileStream states in FileSystemWritableFileStream::Write; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D190912
2023-10-19 11:25:30 +00:00
Sylvestre Ledru
b0fe72dee5 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-15 15:29:02 +00:00
Cristina Horotan
7388749830 Backed out 2 changesets (bug 1856795) for causing build bustage at BasicEvents.h CLOSED TREE
Backed out changeset 1d98b028923a (bug 1856795)
Backed out changeset eae2ac93e17c (bug 1856795)
2023-10-14 21:42:14 +03:00
Sylvestre Ledru
4a97019e39 Bug 1856795 - Remove redundant member init r=emilio
Done with:
./mach static-analysis check --checks="-*, readability-redundant-member-init" --fix .

https://clang.llvm.org/extra/clang-tidy/checks/readability/redundant-member-init.html

Differential Revision: https://phabricator.services.mozilla.com/D190002
2023-10-14 17:34:26 +00:00
Jan Varga
a221df285c Bug 1857155 - Remove custom ResolveCallback for FileSystemGetWritableFileStreamResponse; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D190181
2023-10-09 21:42:27 +00:00
Jan Varga
fff795de17 Bug 1857155 - Remove redundant build worker ref; r=dom-storage-reviewers,asuth
Differential Revision: https://phabricator.services.mozilla.com/D190175
2023-10-09 21:42:27 +00:00
Jan Varga
6d66cbc74c Bug 1857155 - Change FileSystemWritableFileStream::Create to return constructed streams synchronously; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D190173
2023-10-09 21:42:26 +00:00
Jan Varga
ac16524bf4 Bug 1857155 - Deserialize stream for FileSystemWritableFileStream lazily; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D190172
2023-10-09 21:42:26 +00:00
Jan Varga
65a87df96d Bug 1857155 - Make sure FileSystemWritableFileStream can't go away during Seek, Truncate and Close/Abort; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D190168
2023-10-09 21:42:25 +00:00
Jan Varga
32693b823d Bug 1857155 - Move WriteImpl to FileSystemWritableFileStream; r=dom-storage-reviewers,aiunusov,jari
Differential Revision: https://phabricator.services.mozilla.com/D190163
2023-10-09 21:42:25 +00:00
Jan Varga
0031a503da Bug 1841702 - Add proper handling for failed worker refs; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D188431
2023-09-21 17:37:14 +00:00
Peter Van der Beken
53143196f3 Bug 1690111 - Use new TypedArray APIs for creating a container with a copy of the data. r=necko-reviewers,farre,kershaw
Depends on D152496

Differential Revision: https://phabricator.services.mozilla.com/D152497
2023-09-20 09:42:02 +00:00
Cosmin Sabou
c3effd7450 Backed out 13 changesets (bug 1690111) for causing fetch related crashes.
Backed out changeset 5f2c25d194ad (bug 1690111)
Backed out changeset 76c408bcd053 (bug 1690111)
Backed out changeset 6d0649fdafff (bug 1690111)
Backed out changeset c1330b5e8c43 (bug 1690111)
Backed out changeset 5fa36d8fd2a5 (bug 1690111)
Backed out changeset daf7d747853a (bug 1690111)
Backed out changeset f70e09a7f5c6 (bug 1690111)
Backed out changeset 40c6d6eed7f8 (bug 1690111)
Backed out changeset 692f2a759573 (bug 1690111)
Backed out changeset 7140866dd9f6 (bug 1690111)
Backed out changeset 2865fe682139 (bug 1690111)
Backed out changeset 9dcd2416f8a5 (bug 1690111)
Backed out changeset 9c411bf84079 (bug 1690111)
2023-09-11 17:55:24 +03:00
Peter Van der Beken
42b81cb95f Bug 1690111 - Use new TypedArray APIs for creating a container with a copy of the data. r=necko-reviewers,farre,kershaw
Depends on D152496

Differential Revision: https://phabricator.services.mozilla.com/D152497
2023-09-11 12:52:20 +00:00
Jari Jalkanen
dcc9777628 Bug 1824305 - Reorganize WritableFileStream closing and aborting methods. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D182073
2023-06-28 16:23:57 +00:00
Jari Jalkanen
cc48852a6a Bug 1824305 - Pass abort flag on WritableFileStream close. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D177475
2023-06-28 16:23:54 +00:00
Jari Jalkanen
60d8a835d5 Bug 1825018 - Handle abort before WritableStream becomes errored. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D177474
2023-06-26 14:19:35 +00:00
Jari Jalkanen
a5c560ba6d Bug 1825018 - Use MozPromise internally for WritableFileStream writes. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D177473
2023-06-26 14:19:35 +00:00
Jari Jalkanen
92b6cc7e8e Bug 1825018 - Reject WritableFileStream promises with an error handler. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D177472
2023-06-26 14:19:35 +00:00
Jan Varga
f82fd2084b Bug 1825552 - Avoid the new/delete pattern; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D179559
2023-06-07 04:54:30 +00:00
Jan Varga
8a14ce174b Bug 1825552 - Let existing operation to finish before closing the stream; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D178017
2023-06-07 04:54:29 +00:00
Cristian Tuns
36fc9685b5 Backed out 2 changesets (bug 1825552) for causing build bustages in FileSystemThreadSafeStreamOwner.h CLOSED TREE
Backed out changeset 17def1f78e36 (bug 1825552)
Backed out changeset a2519447d580 (bug 1825552)
2023-06-02 09:42:34 -04:00
Jan Varga
60befeb49f Bug 1825552 - Avoid the new/delete pattern; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D179559
2023-06-02 09:52:26 +00:00
Jan Varga
93bb0d79cf Bug 1825552 - Let existing operation to finish before closing the stream; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D178017
2023-06-02 09:52:26 +00:00
Jari Jalkanen
03b5abed04 Bug 1816710 - Block shutdown until OPFS writable file streams are closed. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D170937
2023-03-23 17:25:03 +00:00
Jan Varga
3b682567d6 Bug 1816388 - Use NS_AsyncCopy directly in FileSystemWritableFileStream::Write. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D169609
2023-02-13 16:11:36 +00:00
Jan Varga
0133f11600 Bug 1816093 - Verify WritableFileStream quota management; r=dom-storage-reviewers,jari
Differential Revision: https://phabricator.services.mozilla.com/D169445
2023-02-10 13:24:05 +00:00
Jari Jalkanen
998949c63c Bug 1815837 - Deserialize RandomAccessStream on WritableFileStream TaskQueue. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D169226
2023-02-09 08:47:16 +00:00
Jari Jalkanen
bc2b706cfb Bug 1798513 - Perform stateful WritableFileStream shutdown. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D168796
2023-02-09 06:20:28 +00:00
Jari Jalkanen
36846f2d70 Bug 1798513 - Start using XPCOM streams in WritableFileStream implementation. r=dom-storage-reviewers,janv,ipc-reviewers,nika
Differential Revision: https://phabricator.services.mozilla.com/D161892
2023-02-09 06:20:28 +00:00
Kagami Sascha Rosylight
977208bb61 Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 19:21:35 +00:00
Kagami Sascha Rosylight
daebb4cf81 Bug 1812315 - Part 1: Implement WritableStream::SetUpNative for File System r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D167824
2023-01-31 17:31:08 +00:00
Iulian Moraru
023e2b3441 Backed out 3 changesets (bug 1811538) for causing build bustages on Promise.cpp. CLOSED TREE
Backed out changeset 0a665be7896a (bug 1811538)
Backed out changeset b949053bae31 (bug 1811538)
Backed out changeset 57d4dbe88611 (bug 1811538)
2023-01-31 19:00:59 +02:00
Kagami Sascha Rosylight
c06dc6c3dd Bug 1811538 - Part 3: Remove ErrorResult that became redundant r=smaug
Some spec comments now matches the implementations (as `Perform ! Foo()` means Foo can't fail).

This only covers a small part of actual redundant ErrorResult parameters because:

1. This patch stack only covers Promise::CreateFallible and does not cover helper functions e.g. Promise::CreateResolvedWithUndefined.
2. All callback calls still require ErrorResult as the IDL layer uses the existing Promise::Create

Differential Revision: https://phabricator.services.mozilla.com/D167701
2023-01-31 15:49:08 +00:00
Jari Jalkanen
18eed26cda Bug 1798513 - Replace USVString with UTF8String in union types with Blob getter. r=nika
Depends on D165730

Differential Revision: https://phabricator.services.mozilla.com/D165731
2023-01-11 08:33:47 +00:00
Noemi Erli
6023fa2a43 Backed out 2 changesets (bug 1798513, bug 1808009) for causing failures in FileSystemDirectoryHandle-removeEntry.https.any.worker.html CLOSED TREE
Backed out changeset 428ea11e738d (bug 1798513)
Backed out changeset 3e69320f3e5c (bug 1808009)
2023-01-10 22:11:45 +02:00
Jari Jalkanen
15dcf60a4c Bug 1798513 - Replace USVString with UTF8String in union types with Blob getter. r=nika
Depends on D165730

Differential Revision: https://phabricator.services.mozilla.com/D165731
2023-01-10 19:08:22 +00:00
Jan Varga
c5ee11ae76 Bug 1803062 - Add a fallible way to create FileSystemSyncAccessHandle objects; r=dom-storage-reviewers,jari
This is a preparation for creating a task queue and a strong worker ref during
FileSystemSyncAccessHandle construction.

Differential Revision: https://phabricator.services.mozilla.com/D163562
2022-12-16 06:38:05 +00:00
Jan Varga
ed542249f8 Bug 1805135 - Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari
Differential Revision: https://phabricator.services.mozilla.com/D164444
2022-12-14 13:20:45 +00:00
Narcis Beleuzu
b7f6b324df Backed out changeset 0e5d5b851391 (bug 1805135) for Hazard bustages on FileSystemWritableFileStream.cpp . CLOSED TREE 2022-12-13 15:25:18 +02:00
Jan Varga
be9c5c1b7c Bug 1805135 - Fix FileSystemWritableFileStream to use the default writer for all IO operations; r=dom-storage-reviewers,webidl,smaug,jari
Differential Revision: https://phabricator.services.mozilla.com/D164444
2022-12-13 06:43:55 +00:00
Olli Pettay
274d50847b Bug 1800470, make it possible to extend WritableStream with another cycle collectable class, r=saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D162287
2022-11-24 13:58:39 +00:00
Cosmin Sabou
53febc09c3 Backed out changeset 779cf97ae5de (bug 1800470) for crashtest failures on 1800470.html. CLOSED TREE 2022-11-18 01:09:55 +02:00
Olli Pettay
d652d9fa29 Bug 1800470, make it possible to extend WritableStream with another cycle collectable class, r=saschanaz
Differential Revision: https://phabricator.services.mozilla.com/D162287
2022-11-17 21:32:57 +00:00
Jari Jalkanen
b3fc06c246 Bug 1772617: Unify OPFS Logging r=dom-storage-reviewers,jari,janv
Differential Revision: https://phabricator.services.mozilla.com/D148318
2022-11-10 17:13:40 +00:00
Jan Varga
6328518386 Bug 1798459 - Disable WritableFileStream on the main thread; r=dom-storage-reviewers,jesup
WritableFileStream can be enabled on the main thread only when bug 1798513 gets fixed.

Differential Revision: https://phabricator.services.mozilla.com/D161354
2022-11-09 17:15:38 +00:00
Jari Jalkanen
822dc92bb6 Bug 1798459 - Restore seek position after truncate on Windows. r=dom-storage-reviewers,janv
Differential Revision: https://phabricator.services.mozilla.com/D161681
2022-11-09 17:15:37 +00:00