Commit Graph

1334 Commits

Author SHA1 Message Date
Dão Gottwald
c4167a3cc6 Bug 1898197 - Move tabs tests into browser/components/tabbrowser/. r=tabbrowser-reviewers,frontend-codestyle-reviewers,mak
Differential Revision: https://phabricator.services.mozilla.com/D211190
2024-05-23 12:54:24 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-03 15:20:15 +00:00
Chris H-C
8db3818024 Bug 1889111 - Instrument Firefox Desktop UI Interactions with events r=TravisLong,kcochrane,Gijs
Assumption: Browser Usage Telemetry (ideally) records only and all interesting
interactions with Firefox Desktop's UI, and preserving syntax and semantics
when instrumenting using events is valuable.

Value this provides over existing keyed scalars:
* Order of operations (did three tabs open and then three tabs close, or did
  a single tab open-close three times?)
* Flow control (several atomic interactions combine to a user task. flow_id
  grouping allows us to see that easily in analysis. e.g. Open a tab, open
  prefs, privacy prefs, change a setting.)
* Glean

This is aiming for prototype quality and a prototype lifetime, to see if it's
worth investing more than just a week or two into.

Differential Revision: https://phabricator.services.mozilla.com/D207908
2024-05-03 15:19:15 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
5209eded5e Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-01 12:19:41 +00:00
gravyant
e950fb5069 Bug 1869065 - Re-visit some of the element property names used in moz-message-bar. r=hjones,reusable-components-reviewers,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207897
2024-04-23 21:27:46 +00:00
Nipun Shukla
a61a9bfdac Bug 1876342 - Added tests for Windows native messaging registry key creation r=robwu,mhughes
Differential Revision: https://phabricator.services.mozilla.com/D205486
2024-04-22 22:21:12 +00:00
Cosmin Sabou
8a74e7fbc9 Bug 1781868 - Disable browser_TabUnloader.js on asan/tsan for frequent failures. r=intermittent-reviewers,jmaher DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D208200
2024-04-22 19:27:47 +00:00
Nipun Shukla
9685265c6b Bug 1889232 - Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206419
2024-04-18 15:18:04 +00:00
Iulian Moraru
ccfe6fc0fd Backed out changeset 977027e73ec0 (bug 1889232) for causing windows mass failures. 2024-04-18 01:13:29 +03:00
Nipun Shukla
fea56e6d13 Bug 1889232 - Removed firefox-bridge and firefox-private-bridge protocol creation r=mhughes,Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206419
2024-04-17 19:13:22 +00:00
PupAtlas
a327645287 Bug 1273551 - Enabled 'Debug Script' button in nightly builds as well as the dev edition r=jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D188656
2024-04-01 12:41:42 +00:00
Yi Xiong Wong
af7f0d403b Bug 1880914 - Move all reload functions. r=Gijs,devtools-reviewers,nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D205527
2024-03-28 17:05:01 +00:00
Dave Townsend
f528bb5e79 Bug 1864896: Fix more unused arguments in browser and toolkit. r=mconley,webcompat-reviewers,places-reviewers,Standard8,denschub,twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D205193
2024-03-21 08:35:36 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Nipun Shukla
b67eacdd99 Bug 1876342 - Added Windows native messaging host registration for Chromium r=mhughes,robwu,nalexander
Differential Revision: https://phabricator.services.mozilla.com/D199587
2024-03-13 19:01:05 +00:00
Nipun Shukla
5c02edf906 Bug 1876344 - Added idle startup task to register native messaging host JSON files on macOS r=mhughes,robwu,mossop
Differential Revision: https://phabricator.services.mozilla.com/D201773
2024-03-13 19:01:04 +00:00
Michael Hughes
a9151787eb Bug 1880368 - change firefox and firefox-private protocols to firefox-bridge and firefox-private-bridge protocols r=nshukla,mossop
Differential Revision: https://phabricator.services.mozilla.com/D201879
2024-02-29 19:03:17 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements
Differential Revision: https://phabricator.services.mozilla.com/D198974
2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao
Differential Revision: https://phabricator.services.mozilla.com/D198082
2024-01-24 16:35:54 +00:00
Mark Banner
1a5c3cb34a Bug 1875267 - Move browser_ContentSearch.js into browser/components/search. r=search-reviewers,mcheang
Differential Revision: https://phabricator.services.mozilla.com/D198947
2024-01-22 19:12:39 +00:00
Mark Banner
b6190d5a6d Bug 1875071 - Simplify OpenSearchEngine loading and install process in the search service. r=search-reviewers,mcheang
The current process creates the OpenSearchEngine and gets it to load its data. Once the data is loaded,
it notifies the SearchService that is ready to be added.

This changes the structure so that the SearchService loads the data, creates the engine and then adds it
straight away.

This also means that the contextual search provider can be simplified and doesn't need to tell the engine
not to add itself to the SearchService.

Differential Revision: https://phabricator.services.mozilla.com/D198814
2024-01-22 19:12:39 +00:00
Mark Banner
971668551c Bug 1874921 - Replace usages of SearchService.addOpenSearchEngine in test code with SearchTestUtils.promiseNewSearchEngine. r=search-reviewers,mcheang
This replaces all the test instances, apart from some of the OpenSearch tests where we need to test
the API directly.

Differential Revision: https://phabricator.services.mozilla.com/D198723
2024-01-22 19:12:38 +00:00
Harshit Sohaney
0a69f6eff8 Bug 1855068 - (Part 2) Tests for data size display in new dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193845
2024-01-15 13:10:05 +00:00
Noemi Erli
5ee98305d6 Backed out 4 changesets (bug 1855068, bug 1856412) for causing failures in test_SiteDataManager.js CLOSED TREE
Backed out changeset dbaf2b0da226 (bug 1856412)
Backed out changeset 8d040fd73abf (bug 1856412)
Backed out changeset 645f7ed438fb (bug 1855068)
Backed out changeset be41f5296dec (bug 1855068)
2024-01-11 03:20:27 +02:00
Hanna Jones
35ecc0e4a7 Bug 1845150 - Update notificationbox usage for process hang notification r=reusable-components-reviewers,tgiles
Can be tested locally using this snippet (which I think I took from a test...):

```js
let addonId = "test";
let policy = new WebExtensionPolicy({
    name: "Scapegoat",
    id: addonId,
    mozExtensionHostname: Services.uuid.generateUUID().number.slice(1, -1),
    baseURL: "file:///",
    allowedOrigins: new MatchPatternSet([]),
    localizeCallback() {},
});
policy.active = true;
ProcessHangMonitor.showNotification(window, { addonId, scriptBrowser: { browsingContext: { watchedByDevTools: false }} });
```

Depends on D194315

Differential Revision: https://phabricator.services.mozilla.com/D194316
2024-01-10 18:55:31 +00:00
Hanna Jones
f45d164d24 Bug 1845150 - Update notificationbox usage for crash notifications r=reusable-components-reviewers,tgiles
I've been testing locally with these snippets in the browser toolbox:

```js
const { TabCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
TabCrashHandler.showSubFrameNotification(gBrowser.selectedBrowser, "foo", "bar");
```

```js
const { UnsubmittedCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
UnsubmittedCrashHandler.show({ notificationId: "foo", reportIDs: [], onAction: () => {}});
```

Depends on D194314

Differential Revision: https://phabricator.services.mozilla.com/D194315
2024-01-10 18:55:31 +00:00
Harshit Sohaney
5daf4964a7 Bug 1855068 - (Part 2) Tests for data size display in new dialog. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D193845
2024-01-10 11:47:27 +00:00
Norisz Fay
0847da64fd Backed out 7 changesets (bug 1845150) for causing failures on browser_datachoices_notification.js CLOSED TREE
Backed out changeset a07c835a4bf7 (bug 1845150)
Backed out changeset 0016d7f4e556 (bug 1845150)
Backed out changeset 46cfe5fe6e6a (bug 1845150)
Backed out changeset 83190b8a08d0 (bug 1845150)
Backed out changeset ada948351267 (bug 1845150)
Backed out changeset 7aa4340bfd96 (bug 1845150)
Backed out changeset 683745289588 (bug 1845150)
2024-01-05 18:52:01 +02:00
Hanna Jones
394e52dd9f Bug 1845150 - Update notificationbox usage for process hang notification r=reusable-components-reviewers,tgiles
Can be tested locally using this snippet (which I think I took from a test...):

```js
let addonId = "test";
let policy = new WebExtensionPolicy({
    name: "Scapegoat",
    id: addonId,
    mozExtensionHostname: Services.uuid.generateUUID().number.slice(1, -1),
    baseURL: "file:///",
    allowedOrigins: new MatchPatternSet([]),
    localizeCallback() {},
});
policy.active = true;
ProcessHangMonitor.showNotification(window, { addonId, scriptBrowser: { browsingContext: { watchedByDevTools: false }} });
```

Differential Revision: https://phabricator.services.mozilla.com/D194316
2024-01-05 15:04:20 +00:00
Hanna Jones
bf05146b67 Bug 1845150 - Update notificationbox usage for crash notifications r=reusable-components-reviewers,tgiles
I've been testing locally with these snippets in the browser toolbox:

```js
const { TabCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
TabCrashHandler.showSubFrameNotification(gBrowser.selectedBrowser, "foo", "bar");
```

```js
const { UnsubmittedCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
UnsubmittedCrashHandler.show({ notificationId: "foo", reportIDs: [], onAction: () => {}});
```

Differential Revision: https://phabricator.services.mozilla.com/D194315
2024-01-05 15:04:20 +00:00
Cosmin Sabou
5d4c4c0f9b Backed out 7 changesets (bug 1845150) for causing dt failures on browser_screenshot_button_warning. CLOSED TREE
Backed out changeset fdc3f1b5e5ae (bug 1845150)
Backed out changeset ba7789c89bdd (bug 1845150)
Backed out changeset 6c405863be54 (bug 1845150)
Backed out changeset f66e8bb15e18 (bug 1845150)
Backed out changeset a75fe63bd39f (bug 1845150)
Backed out changeset 91365291f80f (bug 1845150)
Backed out changeset 7477fd1c48fa (bug 1845150)
2024-01-04 18:53:25 +02:00
Hanna Jones
0ff4bd7169 Bug 1845150 - Update notificationbox usage for process hang notification r=reusable-components-reviewers,tgiles
Can be tested locally using this snippet (which I think I took from a test...):

```js
let addonId = "test";
let policy = new WebExtensionPolicy({
    name: "Scapegoat",
    id: addonId,
    mozExtensionHostname: Services.uuid.generateUUID().number.slice(1, -1),
    baseURL: "file:///",
    allowedOrigins: new MatchPatternSet([]),
    localizeCallback() {},
});
policy.active = true;
ProcessHangMonitor.showNotification(window, { addonId, scriptBrowser: { browsingContext: { watchedByDevTools: false }} });
```

Differential Revision: https://phabricator.services.mozilla.com/D194316
2024-01-04 15:31:14 +00:00
Hanna Jones
1a3010070f Bug 1845150 - Update notificationbox usage for crash notifications r=reusable-components-reviewers,tgiles
I've been testing locally with these snippets in the browser toolbox:

```js
const { TabCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
TabCrashHandler.showSubFrameNotification(gBrowser.selectedBrowser, "foo", "bar");
```

```js
const { UnsubmittedCrashHandler } = ChromeUtils.importESModule("resource:///modules/ContentCrashHandlers.sys.mjs");
UnsubmittedCrashHandler.show({ notificationId: "foo", reportIDs: [], onAction: () => {}});
```

Differential Revision: https://phabricator.services.mozilla.com/D194315
2024-01-04 15:31:13 +00:00
Karandeep
f11961815d Bug 1852048 - Move address bar to search preferences. r=dao,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D194895
2024-01-04 09:11:22 +00:00
Mark Banner
742520b2f6 Bug 1870644 - Pass a preferred width rather than width and height when getting search engine icon urls. r=search-reviewers,mcheang
This also renames the function, in preparation for iconURI being merged into it.

Differential Revision: https://phabricator.services.mozilla.com/D196733
2023-12-20 13:28:24 +00:00
Chris H-C
747c89c5bc Bug 1868988 - Remove PingCentre. Its watch has ended. r=nanj,thecount,perry.mcmanis
Differential Revision: https://phabricator.services.mozilla.com/D196227
2023-12-18 16:56:22 +00:00
Mark Banner
86b8e0fb97 Bug 1868749 - Remove search engine send attribution request. r=search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D195758
2023-12-18 12:01:34 +00:00
Chris H-C
460ebb882a Bug 1868580 - Remove PingCentre from Contextual Services r=nanj,perry.mcmanis
As of 11amPT December 7, Contextual Services is now looking exclusively at
Glean-sent data for Firefox versions 116+. (See DSRE-1489)

Differential Revision: https://phabricator.services.mozilla.com/D195910
2023-12-11 19:21:37 +00:00
Perry McManis
f0ca169216 Bug 1867048 - Remove temporary GVSV data collections r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D194882
2023-12-11 15:10:40 +00:00
Anna Yeddi
4937e1e81c Bug 1864576 - Add exceptions from a11y_checks for 3 clicks on disabled controls in browser_UsageTelemetry_interaction.js r=mossop
We intentionally turn off a11y_checks for these click events, because the test is checking the telemetry functionality and the following 3 clicks are targeting disabled controls to test the changes in scalars (for more refer to the bug 1864576 comment 2 and bug 1854999 comment 4).

Also, we are adding the test `label` to the custom widget `12foo` to satisfy the a11y_check expecting to click on a control with an accessible name.

Since the test file is now passing, we are removing the `fail-if` notation that was added by the bug 1854506 before the investigation in the meta bug 1854507.

Differential Revision: https://phabricator.services.mozilla.com/D195595
2023-12-06 13:52:32 +00:00
Joel Maher
33fa84a382 Bug 1859869 - batch 12 - browser/* xpcshell .ini manifests to .toml. r=aryx,extension-reviewers,credential-management-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,issammani,Standard8,robwu,sclements
Differential Revision: https://phabricator.services.mozilla.com/D193996
2023-11-21 17:35:23 +00:00
Karandeep
ce4416a490 Bug 1852044 - Remove the Search Bar section. r=dao,fluent-reviewers,desktop-theme-reviewers,bolsson,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D192722
2023-11-21 05:09:08 +00:00
Perry McManis
649e34307c Bug 1858954 - Add some metrics for validating geckoview streaming collection against direct glean collection r=chutten,gfx-reviewers,media-playback-reviewers,jrmuizel,padenot
In an effort to understand if data collected via the Geckoview Streaming
API differs materially from that collected in Glean, we will implement
some temporary data collections that cover the existing use cases of the
former.

Differential Revision: https://phabricator.services.mozilla.com/D191119
2023-10-26 12:35:55 +00:00
Anna Yeddi
06870c70ca Bug 1854506 - Temporarily fail-if some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to fail-if the failing tests altogether and then handle each one of them individually.

This task is to add `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Tabbed Browser-specific meta bug 1854507
- Explore capturing click events for a11y_checks: bug 1692110

Depends on D188914

Differential Revision: https://phabricator.services.mozilla.com/D188915
2023-10-09 18:20:15 +00:00
Cristian Tuns
896197e59e Backed out 30 changesets (bug 1854447, bug 1855491, bug 1854646, bug 1854520, bug 1854528, bug 1854506, bug 1854502, bug 1854443, bug 1854538, bug 1854525, bug 1854660, bug 1854514, bug 1854460, bug 1854625, bug 1854228, bug 1854517, bug 1854533, bug 1692110, bug 1854636, bug 1849021, bug 1854512, bug 1854522, bug 1854509, bug 1854452, bug 1854536, bug 1854531) for causing multiple tier 2 failures on a11y-checks. CLOSED TREE
Backed out changeset 5714b7239b70 (bug 1849021)
Backed out changeset 91e5d7de3484 (bug 1849021)
Backed out changeset cc3142b909f6 (bug 1854660)
Backed out changeset 76d2a8ae9c19 (bug 1854646)
Backed out changeset 36460a147684 (bug 1854636)
Backed out changeset c7529a962a8c (bug 1854625)
Backed out changeset 791f9b03ea96 (bug 1854538)
Backed out changeset bd3f3cb434a5 (bug 1854536)
Backed out changeset 16f4f5bdcaa7 (bug 1855491)
Backed out changeset 6258bab20196 (bug 1854533)
Backed out changeset 29dca16eee2e (bug 1854531)
Backed out changeset 3a69d2c3f562 (bug 1854528)
Backed out changeset 0c63a9ea8b34 (bug 1854525)
Backed out changeset 5795bb6187a5 (bug 1854522)
Backed out changeset 7d4a123a432f (bug 1854520)
Backed out changeset ec95287bd702 (bug 1854517)
Backed out changeset 9914c1481f0d (bug 1854514)
Backed out changeset 25d85e656905 (bug 1854512)
Backed out changeset 828657f2ab73 (bug 1854509)
Backed out changeset 9d8b2e14c375 (bug 1854506)
Backed out changeset 1b3ee1e46e12 (bug 1854502)
Backed out changeset 37c2ec0851dc (bug 1854460)
Backed out changeset c2a60a8fc2d3 (bug 1854452)
Backed out changeset 744a163f2bd1 (bug 1854447)
Backed out changeset 1a9629dae7d5 (bug 1854443)
Backed out changeset c3d5c1ba2a84 (bug 1854228)
Backed out changeset dcd05518b004 (bug 1692110)
Backed out changeset 1c65a4cb618c (bug 1692110)
Backed out changeset 603b891147bd (bug 1692110)
Backed out changeset 53e2fac79d84 (bug 1692110)
2023-10-07 14:43:05 -04:00
Anna Yeddi
c573e198af Bug 1854506 - Temporarily disable some Tier 2 a11y_checks for Tabbed Browser. r=tabbrowser-reviewers,dao
We are working on [enabling Tier 2 a11y-checks to ensure our products have basic accessibility built-in (bug 1692110)](https://bugzilla.mozilla.org/show_bug.cgi?id=1692110) and before that, we need to prepare the existing code base. While we triage and investigate existent tests that would fail once the a11y-checks are enabled in the CI, we are going to skip the failing tests altogether and then handle each one of them individually.

This task is to skip with `fail-if` condition of the failing tests while we continue investigation into the reasons these tests failed and to be able to backtrack these tests once they're resolved.

Related bugs:
- Disabling tests: meta bug 1848402
- Investigation and remediation for components with disabled tests: meta bugs 1848394 and 1854227, Tabbed Browser-specific meta bug 1854507
- Explore capturing click events for a11y_checks: bug 1692110

Differential Revision: https://phabricator.services.mozilla.com/D188915
2023-10-06 18:11:33 +00:00