corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
861,215 Commits 1 Branch 0 Tags
c38ebcec1ef519f5f54dccffe1cea83bb1bb4409
Commit Graph

3393 Commits

Author SHA1 Message Date
Sam Foster
3bb578be0b Bug 1896791 - Fix logging typo for the createTabsForSessionRestore return value. r=sessionstore-reviewers,nsharpley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D210391
 2024-05-16 17:58:14 +00:00
Sam Foster
6faea180fa Bug 1854373 Use the loggers to capture errors and debug details during session restore.r=sessionstore-reviewers,markh,sclements 
* Timestamped log files are written to a `sessionstore-logs` directory in the profile directory
* Errors will always get written to disk, the logOnSuccess pref ensures all logs are saved even if no error has been captured
* The prefs configure how much logging we do. We have more verbose logging by default in  nightly/early-beta, and less (errors, warnings) in release.
* Logging statements have been added to the early phases of session restore. We'll add more I'm sure as we troubleshoot specific bugs.

Differential Revision: https://phabricator.services.mozilla.com/D208816
 2024-05-09 20:30:15 +00:00
Peter Van der Beken
811ff6e04e Bug 1865387 - Don't recreate session-store's history listener for browsing-context-did-set-embedder notification if browserId didn't change. r=geckoview-reviewers,nika,sessionstore-reviewers,owlish,kaya,farre 
Differential Revision: https://phabricator.services.mozilla.com/D193929
 2024-05-07 06:24:13 +00:00
Sam Foster
11a0641a64 Bug 1889941 - Fix the restore all windows command. r=sessionstore-reviewers,farre 
Differential Revision: https://phabricator.services.mozilla.com/D209473
 2024-05-06 17:56:43 +00:00
Nikki Sharpley
b43107b445 Bug 1885894 - Remove sidebar persistence from XULStore r=sessionstore-reviewers,backup-reviewers,sidebar-reviewers,Gijs,mconley,sfoster,sclements 
Since we are moving away from XUL for the revamped sidebar, remove persistence off of XULstore.
For now, this involves moving persistence of "sidebar-command" and "positionend" to SessionStore.

A follow up bug 1892033 for moving the style attribute to SessionStore has been filed. This is slightly more involved,
hence the separate patch.

Differential Revision: https://phabricator.services.mozilla.com/D207048
 2024-05-06 15:11:20 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D208901
 2024-05-03 15:20:15 +00:00
kycn
15151ae200 Bug 1677190 - Move buildRestoreData to toolkit to use it on both Android and Desktop. r=geckoview-reviewers,sessionstore-reviewers,owlish,farre 
Differential Revision: https://phabricator.services.mozilla.com/D208642
 2024-05-02 17:41:06 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
5209eded5e Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D208901
 2024-05-01 12:19:41 +00:00
kycn
03568c5097 Bug 1677190 - Introduce SessionStoreFunctions for GeckoView package and move the existing SessionStoreFunctions from toolkit to the browser package. r=geckoview-reviewers,farre,nika,owlish 
This change utilizes components.conf to distinguish between the contract implementations of nsISessionStoreFunctions per platform.

Differential Revision: https://phabricator.services.mozilla.com/D206904
 2024-04-30 11:17:55 +00:00
Kelly Cochrane
29334c86f7 Bug 1894061 - Resolving 'can_load' extra key error for session restore telemetry causing error console spam r=Gijs,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D208937
 2024-04-30 08:59:50 +00:00
endington543
fdf371e937 Bug 1891816 - Refactor gOnceInitializedDeferred to use Promise.withResolvers r=sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D208686
 2024-04-25 23:37:30 +00:00
Joel Maher
bedfa83025 Bug 1859204 - adjust linux asan browser-chrome tests to be more balanced, skip extremely long tests, run on xlarge instances. r=aryx,sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D206822
 2024-04-09 19:43:23 +00:00
Yi Xiong Wong
bef11a2dc2 Bug 1880914 - Move browser/tab closing functions. r=Gijs,perftest-reviewers,devtools-reviewers,fxview-reviewers,sessionstore-reviewers,sfoster,kshampur 
Differential Revision: https://phabricator.services.mozilla.com/D206197
 2024-04-08 17:21:01 +00:00
Sam Foster
e3765221a6 Bug 1886659 - Remove the FX_SESSION_RESTORE_CLOSED_TABS_NOT_SAVED probe. r=sessionstore-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D206717
 2024-04-05 22:13:48 +00:00
Nika Layzell
690b246be7 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao 
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
 2024-04-05 16:42:51 +00:00
Nika Layzell
c3d35082ee Bug 1886892 - Part 2: Remove non-SHIP cases from SessionStore tests, r=sessionstore-reviewers,sfoster 
These cases will no longer be run, as SHIP is always on for desktop firefox, so
can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D205480
 2024-04-05 16:42:51 +00:00
Nika Layzell
4d05fa6adb Bug 1886892 - Part 1: Remove non-SHIP code from desktop SessionStore, r=sessionstore-reviewers,tabbrowser-reviewers,mconley,farre,geckoview-reviewers,owlish 
In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.

This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.

Differential Revision: https://phabricator.services.mozilla.com/D205479
 2024-04-05 16:42:51 +00:00
Yi Xiong Wong
3df27d805a Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D205529
 2024-04-03 10:32:27 +00:00
Kelly Cochrane
f1c1c659d9 Bug 1874742 - Improve telemetry and logging coverage for session restore r=sessionstore-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D203138
 2024-04-02 21:27:28 +00:00
Butkovits Atila
8311343a9f Backed out 3 changesets (bug 1887029, bug 1886892) for causing failures at browser_all_files_referenced.js. CLOSED TREE 
Backed out changeset 07f554ea4869 (bug 1887029)
Backed out changeset daa5f2355675 (bug 1886892)
Backed out changeset 389163cbd649 (bug 1886892)
 2024-04-01 21:50:42 +03:00
Nika Layzell
c261303179 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao 
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
 2024-04-01 17:11:23 +00:00
Nika Layzell
96ca20b192 Bug 1886892 - Part 2: Remove non-SHIP cases from SessionStore tests, r=sessionstore-reviewers,sfoster 
These cases will no longer be run, as SHIP is always on for desktop firefox, so
can be removed.

Differential Revision: https://phabricator.services.mozilla.com/D205480
 2024-04-01 17:11:22 +00:00
Nika Layzell
4774bf7dd0 Bug 1886892 - Part 1: Remove non-SHIP code from desktop SessionStore, r=sessionstore-reviewers,tabbrowser-reviewers,mconley 
In bug 1804140, we shipped SHIP everywhere on desktop. Unfortunately, we
never removed the now-dead code from SessionStore.

This patch removes the easy to identify SessionStore code for non-SHIP,
now that it is a fully unsupported configuration.

Differential Revision: https://phabricator.services.mozilla.com/D205479
 2024-04-01 17:11:22 +00:00
Yi Xiong Wong
9457049851 Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D205528
 2024-03-28 17:05:02 +00:00
Nika Layzell
0b92bb684d Bug 1886852 - Avoid registering unnecessary MessageManager listeners when SHIP is enabled, r=smaug! 
Differential Revision: https://phabricator.services.mozilla.com/D205377
 2024-03-21 19:35:40 +00:00
Dave Townsend
d6abef5db6 Bug 1864896: Autofix unused function arguments (browser/components/sessionstore). r=sessionstore-reviewers,dao 
Differential Revision: https://phabricator.services.mozilla.com/D202953
 2024-03-19 09:36:34 +00:00
Sarah Clements
d53556f858 Bug 1861555 - Change browser.sessionstore.max_windows_undo limit to 5 r=sessionstore-reviewers,sfoster,dao 
Differential Revision: https://phabricator.services.mozilla.com/D201230
 2024-03-18 15:52:31 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao 
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
 2024-03-18 09:15:07 +00:00
Gijs Kruitbosch
3abadca53d Bug 1878636 - remove filterPrivateTabs as it creates needless performance churn, r=sfoster,sessionstore-reviewers,kaya,farre 
Differential Revision: https://phabricator.services.mozilla.com/D200687
 2024-02-13 10:34:29 +00:00
Marco Bonardo
f0bd48ca5b Bug 1876743 - Enable cross-container Tab Search in Nightly. r=mseibert 
Fixes code to properly run tests with the feature enabled.
Fixes code not considering payload.userContextId is set to -1 for private
windows.
Fixes a bug in the _openTabs Map where multiple open tabs to the same url are
not properly counted.

Differential Revision: https://phabricator.services.mozilla.com/D200036
 2024-02-07 09:29:32 +00:00
Tom Marble
a42a175006 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-29 17:30:48 +00:00
Sandor Molnar
778333649c Backed out changeset 2be67d91cf16 (bug 1868866) for causing Mn failures at toolkit/xre/test/marionette/test_exitcode.py CLOSED TREE 2024-01-27 00:15:22 +02:00
Tom Marble
920ed4a927 Bug 1868866 - adds ManifestParser TOML linter r=jmaher,linter-reviewers,ahal,webdriver-reviewers,settings-reviewers,search-reviewers,devtools-reviewers,fxview-reviewers,cookie-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,translations-reviewers,valentin,whimboo,Standard8,sclements,jesup 
Differential Revision: https://phabricator.services.mozilla.com/D199054
 2024-01-26 20:06:56 +00:00
Joel Maher
3662d84cd4 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-25 00:27:05 +00:00
Stanca Serban
71d0d5cf96 Backed out changeset 54462970f797 (bug 1873732) for causing web platform tests failures. 2024-01-24 21:08:19 +02:00
Gijs Kruitbosch
532c3bc439 Bug 1780071 - autofix browser/ violations of no-comparison-or-assignment-inside-ok, r=Standard8,webcompat-reviewers,extension-reviewers,settings-reviewers,credential-management-reviewers,fxview-reviewers,sessionstore-reviewers,places-reviewers,sgalich,dao,twisniewski,mconley,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D198974
 2024-01-24 17:03:13 +00:00
Joel Maher
04ec786571 Bug 1873732 - remove outdated manifest conditions and use consistent conditions. r=aryx,necko-reviewers,jgilbert,settings-reviewers,credential-management-reviewers,devtools-reviewers,sessionstore-reviewers,dom-storage-reviewers,sgalich,kershaw,nchevobbe,janv,dao 
Differential Revision: https://phabricator.services.mozilla.com/D198082
 2024-01-24 16:35:54 +00:00
Henrik Skupin
144fe1476d Bug 1836727 - [marionette] Fix MARIONETTE_MANIFESTS usage in moz.build files. r=webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,Standard8,jesup,jdescottes,nalexander,sclements,janv 
Differential Revision: https://phabricator.services.mozilla.com/D197515
 2024-01-11 10:34:29 +00:00
Emilio Cobos Álvarez
0c459bc49a Bug 1869796 - Remove some unused chrome flags. r=smaug,sessionstore-reviewers,dao 
And rename CHROME_WINDOW_MIN to CHROME_WINDOW_MINIMIZE, for parallel
with the resize flag.

Differential Revision: https://phabricator.services.mozilla.com/D197869
 2024-01-09 00:36:09 +00:00
Mark Banner
e2e80f646d Bug 1864821 - Replace PromiseUtils.defer() with Promise.withResolvers() in system modules. r=Gijs,perftest-reviewers,necko-reviewers,extension-reviewers,application-update-reviewers,fxview-reviewers,sync-reviewers,sessionstore-reviewers,reusable-components-reviewers,rpl,jesup,hjones,kshampur,skhamis,nalexander,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D197489
 2024-01-05 09:22:34 +00:00
Tom Marble
4b00b49e47 Bug 1859908 - convert .ini manifests to .toml: batch 20 marionette.ini r=jmaher,webdriver-reviewers,necko-reviewers,application-update-reviewers,search-reviewers,sessionstore-reviewers,places-reviewers,dom-storage-reviewers,bytesized,kershaw,whimboo,dao,jesup,Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D197206
 2024-01-02 15:31:51 +00:00
Emilio Cobos Álvarez
33f75d6854 Bug 1870512 - Remove top-level windows with WindowType::Popup. r=tnikkel,sessionstore-reviewers,dao 
These are only used right now for XUL notifications. They are extremely
weird (I bet there's tons of code that assume that WindowType::Popup
corresponds to nsMenuPopupFrame), and afaict there's no good reason why
these have to be this way.

They no longer are on Linux (because Wayland doesn't support such
thing for example).

XUL alerts work fine with this patch on all platforms after some basic
testing.

The other usage of this for the gfx sanity test can use type=dialog.
Actually it can just be a toplevel, but that breaks the XUL skeleton UI.

Differential Revision: https://phabricator.services.mozilla.com/D196665
 2023-12-20 18:38:57 +00:00
Sarah Clements
090c1c7036 Bug 1868526 - Add event listener and promise for window resize r=sfoster,sessionstore-reviewers 
* Update test_restore_manually marionette test to account for intermittent failure on linux

Differential Revision: https://phabricator.services.mozilla.com/D196426
 2023-12-19 12:17:31 +00:00
Norisz Fay
8c6bfd266a Backed out 3 changesets (bug 1870512) as part of previous backout since issues are still present CLOSED TREE 
Backed out changeset c909d207f316 (bug 1870512)
Backed out changeset cf0bda3b4253 (bug 1870512)
Backed out changeset 39cc9d155c12 (bug 1870512)
 2023-12-18 23:37:42 +02:00
Emilio Cobos Álvarez
16eab158d1 Bug 1870512 - Remove top-level windows with WindowType::Popup. r=tnikkel,sessionstore-reviewers,dao 
These are only used right now for XUL notifications. They are extremely
weird (I bet there's tons of code that assume that WindowType::Popup
corresponds to nsMenuPopupFrame), and afaict there's no good reason why
these have to be this way.

They no longer are on Linux (because Wayland doesn't support such
thing for example).

XUL alerts work fine with this patch on all platforms after some basic
testing.

Depends on D196664

Differential Revision: https://phabricator.services.mozilla.com/D196665
 2023-12-18 17:56:41 +00:00
Sarah Clements
7bc0261e9d Bug 1865154 - Add check for activeIndex in tabState.entries r=sessionstore-reviewers,sfoster 
* Only add previously open tabs to the newWindowState in _prepDataForDeferredRestore
if they have entries

Differential Revision: https://phabricator.services.mozilla.com/D196157
 2023-12-18 16:55:11 +00:00
Sarah Clements
e761c059e2 Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao 
* add new marionette test

Differential Revision: https://phabricator.services.mozilla.com/D195006
 2023-12-05 10:54:20 +00:00
Noemi Erli
8b8bc7d73b Backed out changeset e1a0d895f3a9 (bug 1863692) for causing failures in test_restore_manually.py 2023-12-04 14:52:24 +02:00
Sarah Clements
f32c50299f Bug 1863692 - Only transfer window attributes for pinned tabs with deferred sessions r=sessionstore-reviewers,dao 
* add new marionette test

Differential Revision: https://phabricator.services.mozilla.com/D195006
 2023-12-04 11:28:16 +00:00