Commit Graph

21 Commits

Author SHA1 Message Date
Mihai Alexandru Michis
c358baf0c3 Backed out changeset 0f9626b48a66 (bug 1553451) for linting failures. CLOSED TREE 2019-05-23 10:58:22 +03:00
Patrick Brosset
18bd75fb8c Bug 1553451 - Lower the eslint complexity level to 20 for devtools and exlude more complex functions; r=jdescottes
We want to go back to ESLint's default complexity level so that newly introduced code is checked for complexity.
At the same time, to make that work, we're excluding all of the more complex functions for now.
We should fix them: make them less complex, and remove the eslint-disable comment.
See bug 1553449 for more information about this.

Differential Revision: https://phabricator.services.mozilla.com/D32139
2019-05-23 07:07:49 +00:00
Michael Ratcliffe
89a6aa6015 Bug 1531845 - Silence various React warnings to help clear up debug mode test logs r=rcaliman
Differential Revision: https://phabricator.services.mozilla.com/D23115
2019-03-19 15:29:37 +00:00
Yura Zenevich
4413c6d1a1 Bug 1535070 - add aria-hidden to ArrowExpander in VirtualizedTree component. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23359
2019-03-15 17:08:22 +00:00
Yura Zenevich
d65fd81594 Bug 1535063 - add shown property to VirtualizedTree component that defines a tree item to be rendered and shown within the tree. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23358
2019-03-18 07:48:30 +00:00
Yura Zenevich
6c0a07222d Bug 1535063 - fix scrolling into view for VirtualizedTree items that are part of the traversal but not rendered. r=nchevobbe
Differential Revision: https://phabricator.services.mozilla.com/D23357
2019-03-16 04:34:59 +00:00
Julian Descottes
cc811db468 Bug 1524982 - Use browser loader in performance panel to avoid blocking toolbox destroy;r=gregtatum,ochameau
The main goal is to use the browser loader instead of script tags to avoid using promises tied to the document during the panel's destroy.
I tried to cleanup a bit the modules, to rely less on globals and more on explicit require calls, but there is room for improvement left.
I will write an additional test to check that toolboxes in WINDOW hosts can be closed and reopened for any of our panels in a second changeset.

Differential Revision: https://phabricator.services.mozilla.com/D19865
2019-02-18 16:37:18 +00:00
Yura Zenevich
489af50f29 Bug 1424159 - make virtualized tree nodes tabbable similar to how the inspector markup tree works. r=nchevobbe
MozReview-Commit-ID: LfSppQgpI0O

Differential Revision: https://phabricator.services.mozilla.com/D18591
2019-02-13 13:08:14 +00:00
Yura Zenevich
0be3f10c3a Bug 1518487 - make sure VirtualizedTree keyboard focus scrolling works for trees that are themselves inside scrollable containers. Use the same approach as the tree component in debugger.html. r=nchevobbe
MozReview-Commit-ID: 4HO7WDbyPKA

Differential Revision: https://phabricator.services.mozilla.com/D19051
2019-02-12 19:39:46 +00:00
Csoregi Natalia
845ccf6e5f Backed out 7 changesets (bug 1518487) for failures on devtools/client/accessibility/test/browser/browser_accessibility_sidebar_checks.js. CLOSED TREE
Backed out changeset 7a4f96a4d71c (bug 1518487)
Backed out changeset 8031278b4a17 (bug 1518487)
Backed out changeset d55e9ed92676 (bug 1518487)
Backed out changeset fc1687cc488d (bug 1518487)
Backed out changeset 0d2800976a32 (bug 1518487)
Backed out changeset 62f78c63d9f1 (bug 1518487)
Backed out changeset bc6cc126a9b4 (bug 1518487)
2019-02-12 00:33:42 +02:00
Yura Zenevich
16b297a57b Bug 1518487 - make sure VirtualizedTree keyboard focus scrolling works for trees that are themselves inside scrollable containers. Use the same approach as the tree component in debugger.html. r=nchevobbe
MozReview-Commit-ID: 4HO7WDbyPKA

Differential Revision: https://phabricator.services.mozilla.com/D19051
2019-02-11 20:45:54 +00:00
Mark Banner
3d6aaad3f5 Bug 1486741 - Enable ESLint rule comma-dangle for all of mozilla-central (automatic fixes). r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D8389
2018-10-19 12:55:39 +00:00
Julian Descottes
82711b9a8f Bug 1454696 - Run eslint --fix for prefer-const;r=yulia
MozReview-Commit-ID: F6xUXCgdRE4
2018-06-01 12:36:09 +02:00
Yura Zenevich
3b91ad9038 Bug 1461977 - sync tree's scrollTop with scroll state when tree scrollTop value changes outside of user scroll. r=nchevobbe
MozReview-Commit-ID: 4aIX9mSkg1T
2018-05-28 11:27:00 +03:00
Yura Zenevich
046bfe48e5 Bug 1438912 - by default, do not navigate to next node on ArrowRight key. r=nchevobbe
MozReview-Commit-ID: KQlHIA7pYAn
2018-03-13 09:39:46 -04:00
J. Ryan Stinnett
8d1c817851 Bug 1443081 - Apply spacing via eslint --fix for DevTools. r=jdescottes
MozReview-Commit-ID: 2RVNt140Zte
2018-03-12 13:44:41 -05:00
Yura Zenevich
a568a3d975 Bug 1438835 - [VirtualizedTree] keep inner state for when the tree is moused down, to help with deciding when to keyboard focus on tree container. r=nchevobbe
MozReview-Commit-ID: 6W9N242QmmU
2018-03-07 15:38:14 -05:00
Yura Zenevich
afa52a72f9 Bug 1438837 - fix VirtualizedTree node aria-level attribute to start with 1 not 0. r=nchevobbe
MozReview-Commit-ID: KLb964Irdkd
2018-03-01 10:41:47 -05:00
Yura Zenevich
f64428a194 Bug 1428432 - further improve keyboard accessibility for VirtualizedTree. r=nchevobbe
MozReview-Commit-ID: 8Es17Q5J87a
2018-02-12 22:33:20 -05:00
Yura Zenevich
ee506cb68e Bug 1428432 - prevent unnecessary VirtualizedTree render when the client height does not change. r=nchevobbe
MozReview-Commit-ID: FErkeNwUuGF
2018-02-12 22:33:07 -05:00
Leo Huang
db9e3f19d5 Bug 1426634 - Rename devtools/client/shared/components/Tree.js to VirtualizedTree.js; r=nchevobbe
MozReview-Commit-ID: 80ebj9CJODR
2017-12-22 12:10:00 +08:00