Commit Graph

149 Commits

Author SHA1 Message Date
Nika Layzell
c320f56d5b Bug 1738103 - Part 4: Add XPCOM support for shutdown tasks, r=necko-reviewers,KrisWright
Tasks registered with shutdown tasks are called when the target
nsISerialEventTarget is about to be destroyed.

Differential Revision: https://phabricator.services.mozilla.com/D129840
2022-03-23 22:22:04 +00:00
Randell Jesup
333725b02a Bug 1207753 - WebSocket thread-safety annotations r=necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D130593
2022-03-23 14:59:58 +00:00
Randell Jesup
855202c183 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 18:47:08 +00:00
Noemi Erli
16f5f5f2b9 Backed out changeset 12a59e5a50bf (bug 1207753) for causing build bustage CLOSED TREE 2022-03-16 18:32:51 +02:00
Randell Jesup
a98b1f8218 Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 16:16:14 +00:00
Butkovits Atila
01197944a0 Backed out changeset a68ee4b09f92 (bug 1207753) for causing Hazard bustages. CLOSED TREE 2022-03-16 14:38:14 +02:00
Randell Jesup
fe15f2115d Bug 1207753 - Add MOZ_UNANNOTATED to all Mutexes/Monitors r=nika,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D140849
2022-03-16 12:01:14 +00:00
Sylvestre Ledru
35a175aa33 Bug 1754767 - Remove duplicate includes r=media-playback-reviewers,padenot
Differential Revision: https://phabricator.services.mozilla.com/D138441
2022-02-11 10:01:15 +00:00
Tom Schuster
a5221505d4 Bug 1728981 - Don't upgrade HTTP WebSocket requests of exempt principals. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D131094
2021-11-24 14:50:35 +00:00
Valentin Gosu
e8cee3e505 Bug 1729897 - CSP Upgrade-insecure-requests is upgrading localhost websocket r=necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D125533
2021-09-15 11:28:13 +00:00
Paul Zuehlcke
af3672bd19 Bug 1713748 - Partition WebSocket nsWSAdmissionManager queue. r=timhuang,nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D119534
2021-07-21 12:44:40 +00:00
Olli Pettay
f047066776 Bug 1705147 - Make it possible to use WebSocket outside Window/Worker scopes, r=asuth
Differential Revision: https://phabricator.services.mozilla.com/D112061
2021-04-19 17:16:14 +00:00
Kershaw Chang
0bb95a6d85 Bug 1660307 - Get rid off nsSupportsWeakReference for WebSocketImpl, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D111059
2021-04-13 12:00:26 +00:00
Butkovits Atila
0071f31a0c Backed out changeset e3a7a6111dfe (bug 1660307) for a possible regression. CLOSED TREE 2021-04-13 01:29:29 +03:00
Kershaw Chang
edb03233be Bug 1660307 - Get rid off nsSupportsWeakReference for WebSocketImpl, r=baku
Differential Revision: https://phabricator.services.mozilla.com/D111059
2021-04-12 11:50:35 +00:00
Hubert Boma Manilla
4159d8a90a Bug 1695185 - Use the WindowId of the owner document instead r=valentin,necko-reviewers,baku
The websocket uses the innerWindowId of the window where the script lives when
triggering events for devtools. This is may not be the same as the websocket
owner window as mentioned here https://searchfox.org/mozilla-central/rev/f1159268add2fd0959e9f91b474f5da74c90f305/dom/websocket/WebSocket.cpp#206-207,212
This seems to be the case when we have iframes within a page. The devtools
do not get the events for the websockets channels opened within iframes as
the innerWindowId is that of the top-level window.

`...->TopWindowContext()->InnerWindowId()` also always point to the top-level window.

This patch fixes these issues by switching to use the websocket owner window which
the iframe.

Note: The parent revsion contains the changes for the devtools fission work that
depends on this fix. i did this to make it easy to test and review.

Differential Revision: https://phabricator.services.mozilla.com/D106607
2021-03-04 21:46:07 +00:00
smolnar
689d8209ae Backed out changeset dc7664f78fbd (bug 1660307) for causing mochitest failures. CLOSED TREE DONTBUILD 2021-02-18 14:49:38 +02:00
Yaron Tausky
93b543ff96 Bug 1660307 - Use thread-safe weak pointers in WebSocketImpl r=dragana
Differential Revision: https://phabricator.services.mozilla.com/D104518
2021-02-18 12:16:11 +00:00
Kershaw Chang
fb3eb15b6e Bug 1675207 - Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D99145
2020-12-15 04:18:17 +02:00
Butkovits Atila
5111b84aaa Backed out changeset 084279c12a76 (bug 1675207) for build bustage complaining about rules.mk. CLOSED TREE 2020-12-14 15:42:52 +02:00
Kershaw Chang
46479b5a76 Bug 1675207 - Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D99145
2020-12-14 12:14:38 +00:00
Razvan Maries
fc0e3d7f67 Backed out changeset 259ad0fe9f08 (bug 1675207) for build bustages on WebSocketChannelChild.h. CLOSED TREE 2020-12-11 12:05:34 +02:00
Kershaw Chang
2cffa76813 Bug 1675207 - Fail the websocket connection when there is no enough memory r=necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D99145
2020-12-11 09:35:05 +00:00
Simon Giesecke
498d9ed9dc Bug 1673931 - Avoid including DebuggerNotificationBinding.h from header files. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D97611
2020-12-10 11:09:32 +00:00
Karl Tomlinson
7afb800388 Bug 1119956 derive from DiscardableRunnable instead of CancelableRunnable when Cancel() is not supported r=asuth,sg
Differential Revision: https://phabricator.services.mozilla.com/D98118
2020-12-03 09:04:44 +00:00
Valentin Gosu
4acef6d14f Bug 1349969 - WebSocket: don't throw for bad ports r=annevk
Differential Revision: https://phabricator.services.mozilla.com/D96164
2020-11-06 12:57:05 +00:00
Valentin Gosu
f5629334d6 Bug 1660968 - Remove uses of GetInProcessScriptableTop in WebSocketImpl::GetLoadingPrincipal r=baku
This change also simplifies the code a bit.
Also, as BrowsingContext::GetOpener returns null when there's no opener,
we don't have to check whether the opener and innerWindow are the same.

Differential Revision: https://phabricator.services.mozilla.com/D93219
2020-10-19 12:07:00 +00:00
Paul Adenot
e76d54fa12 Bug 1668248 - Use fallible string operations in WebSocket::Send. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D91929
2020-10-02 12:42:06 +00:00
Dorel Luca
a1946dd01c Backed out 3 changesets (bug 1668248) for Devtools failures in devtools/shared/resources/tests/browser_resources_websocket.js. CLOSED TREE
Backed out changeset 3097e934187b (bug 1668248)
Backed out changeset 9f6b8aa11110 (bug 1668248)
Backed out changeset eaa857f4564d (bug 1668248)
2020-10-01 21:24:48 +03:00
Paul Adenot
3daef0f5c8 Bug 1668248 - Use fallible string operations in WebSocket::Send. r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D91929
2020-09-30 17:40:16 +00:00
Simon Giesecke
ab6f0a7137 Bug 1650145 - Replace all value uses of Empty[C]String by 0-length _ns literals. r=froydnj,geckoview-reviewers,agi
Differential Revision: https://phabricator.services.mozilla.com/D82325
2020-09-23 15:17:15 +00:00
Valentin Gosu
a1c7deab85 Bug 1646545 - Replace GetInProcessScriptableTop usage with TopWindowContext() in WebSocket.cpp r=baku
Differential Revision: https://phabricator.services.mozilla.com/D87843
2020-08-25 08:25:00 +00:00
Christoph Kerschbaumer
0499397126 Bug 1658283: HTTPS-Only: Simplify ShouldUpgradeWebSocket. r=JulianWels
Differential Revision: https://phabricator.services.mozilla.com/D86539
2020-08-11 11:19:28 +00:00
Michal Novotny
3153f226b6 Bug 1621345 - Support for nsIWebSocketEventListener.send() API r=baku,necko-reviewers,dragana
Differential Revision: https://phabricator.services.mozilla.com/D68068
2020-07-29 17:41:56 +00:00
Frederik Braun
617d3006d9 Bug 1366973: Rename security flags to not contain DATA anymore r=geckoview-reviewers,ckerschb,snorp
Differential Revision: https://phabricator.services.mozilla.com/D83490
2020-07-15 11:20:45 +00:00
Simon Giesecke
a69d79b6db Bug 1648010 - Replace uses of NS_LITERAL_STRING/NS_LITERAL_CSTRING macros by _ns literals. r=geckoview-reviewers,jgilbert,agi,hsivonen,froydnj
Differential Revision: https://phabricator.services.mozilla.com/D80860
2020-07-01 08:29:29 +00:00
Karl Tomlinson
b658dcff85 Bug 1637159 remove now-unused public DOMEventTargetHelper::BindToOwner() rebind methods r=smaug
The virtual is no longer required since
https://hg.mozilla.org/mozilla-central/rev/a01586b62cf5#l1.92

Differential Revision: https://phabricator.services.mozilla.com/D75042
2020-05-14 05:29:49 +00:00
Alexandre Poirot
ee3920790d Bug 1620966 - Move DocShell.watchedByDevtools to BrowsingContext and rename it to watchedByDevTools. r=nika,jdescottes
Differential Revision: https://phabricator.services.mozilla.com/D66037
2020-05-12 09:18:26 +00:00
Andrea Marchesini
011eb81945 Bug 1636847 - Update WebSocket CTOR definition, r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D74589
2020-05-11 09:06:20 +00:00
Andrea Marchesini
82200df343 Bug 1633197 - WebSocket bufferedAmount must be unsigned long long (uint64_t), r=valentin
Differential Revision: https://phabricator.services.mozilla.com/D74558
2020-05-11 07:44:10 +00:00
julianwels
13c63c505a Bug 1631384 - Added upgrade exceptions for HTTPS Only Mode. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D72002
2020-04-29 15:52:19 +00:00
Bogdan Tara
40e87c6b02 Backed out changeset 8e7b6ae8e18d (bug 1631384) for browser_upgrade_exceptions.js failure CLOSED TREE 2020-04-29 13:32:29 +03:00
julianwels
3675c2a638 Bug 1631384 - Added upgrade exceptions for HTTPS Only Mode. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D72002
2020-04-29 09:25:54 +00:00
Andreea Pavel
1c6560187a Backed out changeset 7b5f7ee72a6c (bug 1631384) for failing bc at browser_upgrade_exceptions.js on a CLOSED TREE 2020-04-28 01:43:57 +03:00
julianwels
2cbbce518a Bug 1631384 - Added upgrade exceptions for HTTPS Only Mode. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D72002
2020-04-27 17:23:43 +00:00
Mihai Alexandru Michis
cbba5f28b1 Backed out changeset a37a427fac07 (bug 1631384) for causing wpt crashes in websocket.https.html
CLOSED TREE
2020-04-27 18:33:36 +03:00
julianwels
0b655ee575 Bug 1631384 - Added upgrade exceptions for HTTPS Only Mode. r=ckerschb,necko-reviewers,valentin
Differential Revision: https://phabricator.services.mozilla.com/D72002
2020-04-27 13:29:24 +00:00
Bogdan Tara
7c29627ec6 Backed out changeset 537608d1e4cc (bug 1621345) for many ns related crashes CLOSED TREE 2020-04-27 02:27:36 +03:00
sonakshi
171d04c477 Bug 1621345 - Support for nsIWebSocketEventListener.send() API r=michal,baku
Differential Revision: https://phabricator.services.mozilla.com/D68068
2020-04-08 19:44:43 +00:00
julianwels
1e439e4731 Bug 1631380 - Fixed blank upgrade message on HTTPS Only Mode websocket upgrade. r=ckerschb
Differential Revision: https://phabricator.services.mozilla.com/D71546
2020-04-20 16:41:16 +00:00