Commit Graph

63 Commits

Author SHA1 Message Date
Chris H-C
a0c6f025d7 Bug 1767016 - Be a little more clear about when and how to edit metrics.rs r=Dexter DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D147430
2022-05-26 14:43:40 +00:00
Jan-Erik Rediger
5442d156db Bug 1768611 - Document how to use local glean_parser. r=chutten DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D145948
2022-05-11 09:26:21 +00:00
Chris H-C
1c0d9092cc Bug 1764549 - Don't forget to update glean-ffi's version r=TravisLong
Depends on D143749

Differential Revision: https://phabricator.services.mozilla.com/D143750
2022-04-14 20:35:08 +00:00
Chris H-C
0b70e659ac Bug 1763593 - GIFFT mirroring is now fallible r=janerik
We need to clear state at shutdown that we hold for GIFFT mirroring purposes.
However, more data can come in even later (there's nothing stopping it. Plus,
Glean can meaningfully record later given its shutdown happens in a later
phase), so the naive approach of lazy-instantiate and RunOnShutdown-clear
doesn't work.

Since Telemetry is only good to AppShutdownTelemetry, we now fail to mirror to
it after AppShutdownTelemetry and clear state in the immediately-next phase.

Also, data can come in earlier than we have a main thread to dispatch to,
requiring some careful finagling of threads to ensure our cleanup routine
is appropriately registered.

Differential Revision: https://phabricator.services.mozilla.com/D143522
2022-04-14 15:17:29 +00:00
Mitchell Hentges
eb3080a220 Bug 1724274: Move virtualenv dependency manifests to python/virtualenvs r=ahal
This is needed for a few reasons:
* All mach commands can use virtualenvs, not just `build`-related
  commands, so the files don't make sense to be in `build/`.
* When locking is added, more files associated with virtualenvs will be
  added, and this will change will ease the related directory structure
  setup.
* This removes the need for a redundant "_virtualenv_packages" keyword
  as part of the manifest filenames.

Differential Revision: https://phabricator.services.mozilla.com/D140382
2022-03-24 14:04:34 +00:00
Chris H-C
76b4164140 Bug 1754518 - Add Getting Started docs for FOG r=janerik DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D139150
2022-02-22 16:53:22 +00:00
Chris H-C
ccac134682 Bug 1752357 - Document Instrumentation Test Best Practices r=janerik DONTBUILD
...and file and link to bugs where we intend to improve it.

Differential Revision: https://phabricator.services.mozilla.com/D139128
2022-02-22 16:53:22 +00:00
Chris H-C
b4f0748057 Bug 1752201 - Remove 'early adopter' language from FOG docs r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D137064
2022-02-02 14:48:27 +00:00
Florian Quèze
02b789706d Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-19 13:31:17 +00:00
Cristian Tuns
09099c11ef Backed out 2 changesets (bug 1745511) for causing mochitest failures on GeckoChildProcessHost.cpp CLOSED TREE
Backed out changeset 620e4b9d8b61 (bug 1745511)
Backed out changeset 0fadea77038a (bug 1745511)
2022-01-19 07:24:42 -05:00
Florian Quèze
c1505dc115 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten,media-playback-reviewers,alwu.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-18 22:24:10 +00:00
Chris H-C
9ac159a1e8 Bug 1678331 - Add developer docs for what to log and how in FOG r=janerik DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D135633
2022-01-17 15:50:36 +00:00
Alexandru Michis
6b0888bb3b Backed out changeset 19b1136a92ec (bug 1745511) for causing mochitest failures in GMPServiceParent.cpp
CLOSED TREE
2022-01-13 18:49:34 +02:00
Florian Quèze
8fb191e021 Bug 1745511 - Expand FOG IPC to GMP process, r=bryce,chutten.
Differential Revision: https://phabricator.services.mozilla.com/D133550
2022-01-13 13:44:22 +00:00
James Graham
033c128ce6 Bug 1748845 - Update source-relative links in glean docs, r=firefox-source-docs-reviewers,chutten,sylvestre
These were broken since the update to MyST.

Differential Revision: https://phabricator.services.mozilla.com/D135387
2022-01-11 10:48:22 +00:00
Chris H-C
069a63f68f Bug 1748904 - Fix use of now-obsolete eval_rst directives in docs r=firefox-source-docs-reviewers,ahal DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D135252
2022-01-06 20:21:24 +00:00
Florian Quèze
52ec666a9b Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 22:18:32 +00:00
Narcis Beleuzu
a8e91af26f Backed out 4 changesets (bug 1745444) for GTest failures on IHistory.Test . CLOSED TREE
Backed out changeset b3a2dc754e16 (bug 1745444)
Backed out changeset 7b9d52dff930 (bug 1745444)
Backed out changeset 15d9a79cc305 (bug 1745444)
Backed out changeset 497572ee54af (bug 1745444)
2021-12-15 20:50:24 +02:00
Florian Quèze
6471c9335c Bug 1745444 - Expand FOG IPC to Socket process, to collect CPU time used there, r=chutten,necko-reviewers,valentin.
Differential Revision: https://phabricator.services.mozilla.com/D133491
2021-12-15 16:27:56 +00:00
Chris H-C
7a5557d320 Bug 1745660 - Flush FOG IPC every 100k samples r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D133664
2021-12-13 20:18:57 +00:00
Jan-Erik Rediger
2d1dbd7fb9 Bug 1744674 - Update to Glean v42.3.0 & glean_parser v4.3.1 r=chutten
Also updates the docs on how to update the glean_parser in-tree.
Also adds a `no_lint` exception to test pings to avoid breaking the
build.

Differential Revision: https://phabricator.services.mozilla.com/D133077
2021-12-13 11:24:50 +00:00
Narcis Beleuzu
d5f770f02c Backed out changeset 7ca282be411f (bug 1744674) for python failures on test_site_compatibility.py. CLOSED TREE 2021-12-11 01:08:45 +02:00
Florian Queze
3d358fc2aa Bug 1744162 - Expand FOG IPC to RDD process, to collect CPU and GPU time used there, r=chutten,jrmuizel.
Differential Revision: https://phabricator.services.mozilla.com/D132749
2021-12-10 12:20:10 +00:00
Jan-Erik Rediger
f7e7766bdb Bug 1744674 - Update to Glean v42.3.0 & glean_parser v4.3.1 r=chutten
Also updates the docs on how to update the glean_parser in-tree.
Also adds a `no_lint` exception to test pings to avoid breaking the
build.

Differential Revision: https://phabricator.services.mozilla.com/D133077
2021-12-09 09:30:20 +00:00
Chris H-C
cf606bb7e9 Bug 1729026 - Test that GPU-process FOG metrics work r=Dexter,nical
Differential Revision: https://phabricator.services.mozilla.com/D132406
2021-12-01 14:35:08 +00:00
Chris H-C
1f48010242 Bug 1729026 - Add support for GPU-process Glean metrics via FOG r=Dexter,nical
Differential Revision: https://phabricator.services.mozilla.com/D124840
2021-12-01 14:35:08 +00:00
Chris H-C
c3bbf0819e Bug 1737157 - Allow recording but not uploading in FOG tests r=janerik
See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences
for details.

Differential Revision: https://phabricator.services.mozilla.com/D129553
2021-11-18 19:03:24 +00:00
Sandor Molnar
bcfa357df6 Backed out changeset c859ac601495 (bug 1737157) for causing xpc failures in glean/tests/xpcshell/test_FOGPrefs. CLOSED TREE 2021-11-17 20:21:26 +02:00
Chris H-C
6514eae905 Bug 1737157 - Allow recording but not uploading in FOG tests r=janerik
See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences
for details.

Differential Revision: https://phabricator.services.mozilla.com/D129553
2021-11-17 15:55:35 +00:00
Marian-Vasile Laza
2b23f11620 Backed out changeset edefcf1ad9a5 (bug 1737157) for causing xpcshell failures on test_FOGPrefs.js. CLOSED TREE 2021-11-11 05:47:27 +02:00
Chris H-C
33aeebbf76 Bug 1737157 - Allow recording but not uploading in FOG tests r=janerik
See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences
for details.

Differential Revision: https://phabricator.services.mozilla.com/D129553
2021-11-10 21:51:27 +00:00
Cristian Tuns
8f163de49f Backed out changeset 26b8a60c88f4 (bug 1737157) for causing xpcshell failures. CLOSED TREE 2021-11-10 10:07:34 -05:00
Chris H-C
99a7f51410 Bug 1737157 - Allow recording but not uploading in FOG tests r=janerik
See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences
for details.

Differential Revision: https://phabricator.services.mozilla.com/D129553
2021-11-10 14:19:56 +00:00
criss
a6dbc6349e Backed out changeset 3ded83469acf (bug 1737157) for causing failures on test_FOGPrefs.js. CLOSED TREE 2021-11-09 00:19:14 +02:00
Chris H-C
8841e5debb Bug 1737157 - Allow recording but not uploading in FOG tests r=janerik
See https://firefox-source-docs.mozilla.org/toolkit/components/glean/dev/preferences.html#test-only-preferences
for details.

Differential Revision: https://phabricator.services.mozilla.com/D129553
2021-11-08 21:12:59 +00:00
Chris H-C
c386e9b00a Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 21:09:07 +00:00
Iulian Moraru
caf4295618 Backed out changeset 1890b6a3b3d2 (bug 1731667) for causing frequent address sanitizer failures. 2021-09-28 19:13:19 +03:00
Chris H-C
7b138891b3 Bug 1731667 - Flush FOG IPC from content children on process shutdown r=janerik
Unfortunately not testable in an automated fashion.
Tested manually by adding to a test counter metric in ContentChild, shutting
down Firefox immediately (but normally),
removing the instrumentation, rebuilding, and rerunning. Then checking that
the test counter indeed has a value.

While we're here, ensure we persist ping lifetime data _after_ flushing IPC
on idle to ensure we don't miss anything.

Differential Revision: https://phabricator.services.mozilla.com/D126295
2021-09-28 13:01:16 +00:00
Jan-Erik Rediger
a7b0e0166d Bug 1670261 - Ensure the Glean versions in the project match. r=agi,chutten
In GeckoView we need to depend on the same Glean version as the included
Glean Rust crate has.
We _could_ let Gradle read that from Cargo.lock directly,
but that complicates the build.

Instead we manually update both versions to the same
and have Gradle ensure we don't forget that.

Differential Revision: https://phabricator.services.mozilla.com/D116602
2021-08-10 07:49:08 +00:00
Butkovits Atila
fd5e3b00a1 Backed out 6 changesets (bug 1670261) for causing perma android bustage. CLOSED TREE
Backed out changeset 58ab9d5d45b7 (bug 1670261)
Backed out changeset e68f58dd9c24 (bug 1670261)
Backed out changeset af093190c4f7 (bug 1670261)
Backed out changeset 150c73837e22 (bug 1670261)
Backed out changeset c42784eeccee (bug 1670261)
Backed out changeset 45ab05c0c371 (bug 1670261)
2021-08-03 15:11:22 +03:00
Jan-Erik Rediger
dcf75bc3d0 Bug 1670261 - Ensure the Glean versions in the project match. r=agi,chutten
In GeckoView we need to depend on the same Glean version as the included
Glean Rust crate has.
We _could_ let Gradle read that from Cargo.lock directly,
but that complicates the build.

Instead we manually update both versions to the same
and have Gradle ensure we don't forget that.

Differential Revision: https://phabricator.services.mozilla.com/D116602
2021-08-02 16:22:46 +00:00
Chris H-C
8982f10441 Bug 1675288 - Move FOG's tests into a 'tests' folder r=TravisLong
Differential Revision: https://phabricator.services.mozilla.com/D120015
2021-07-20 14:33:49 +00:00
Chris H-C
68295b1edb Bug 1694496 - Update 'add a new metric type' docs r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119784
2021-07-15 16:05:50 +00:00
Butkovits Atila
6f88f89160 Backed out 5 changesets (bug 1694496) for causing build bustages on GleanJSMetricsLookup.h. CLOSED TREE
Backed out changeset 86dc6a0fd554 (bug 1694496)
Backed out changeset 9ccad5fe13e7 (bug 1694496)
Backed out changeset 887eaee3ab5c (bug 1694496)
Backed out changeset 36421c124795 (bug 1694496)
Backed out changeset 9591dcd4369d (bug 1694496)
2021-07-14 19:46:38 +03:00
Chris H-C
893befd707 Bug 1694496 - Update 'add a new metric type' docs r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D119784
2021-07-14 16:13:47 +00:00
Silke Hofmann
62e72cfe2b Bug 1481470 - Stop using xlink:href in SVG in toolkit/. r=nhnt11,desktop-theme-reviewers,harry
Differential Revision: https://phabricator.services.mozilla.com/D117207
2021-06-13 19:01:20 +00:00
surajeet310
9031d15c6b Bug 1714788 - Fixed more Sphinx warnings in 'mach doc' r=sylvestre DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D117225
2021-06-09 20:27:09 +00:00
Jan-Erik Rediger
2974364925 Bug 1714036 - Add a way to automatically update the expected file contents for Glean tests. r=chutten
One can now run the tests with `UPDATE_EXPECT=1` and the code will
update the files, so one can then commit them (after verifying that they
do what they should)

Differential Revision: https://phabricator.services.mozilla.com/D116563
2021-06-02 15:27:05 +00:00
Chris H-C
4227ae8f74 Bug 1709147 - Move test-only pref description to proper doc section r=janerik
Differential Revision: https://phabricator.services.mozilla.com/D115375
2021-05-18 16:53:58 +00:00
Chris H-C
81033018d3 Bug 1672951 - Update 'how to update the glean sdk' docs r=janerik
Depends on D114971

Differential Revision: https://phabricator.services.mozilla.com/D114972
2021-05-12 19:04:27 +00:00