corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
478,033 Commits 1 Branch 0 Tags
c2cf02e97d61a688639d56ca5646e5372df588ce
Commit Graph

61 Commits

Author SHA1 Message Date
Avikalpa Kundu
c2cf02e97d Bug 1344834 - Enable flake8 rule E501: 'line too long (113 > 99 characters)'. r=Dexter 2017-05-03 06:38:00 +02:00
Georg Fritzsche
1fc17df501 Bug 1357001 - Part 5 - Fix linting errors. r=chutten 2017-04-21 15:48:44 +02:00
Georg Fritzsche
88054b0fc7 Bug 1357001 - Part 2 - Make histogram error message style more consistent. r=chutten 2017-04-18 18:22:43 +02:00
Georg Fritzsche
15fb79d095 Bug 1357001 - Part 1 - Unify validation errors in probe parsing scripts. r=chutten, f=gps 2017-04-18 18:21:36 +02:00
pgadige
533b316bd2 Bug 1344858 - Enable flake8 rule W601: ".has_key() is deprecated, use 'in'". r=Dexter 
MozReview-Commit-ID: Far2S2TIZyl
 2017-04-12 23:06:29 +05:30
djmdev
088b0050d1 Bug 1353678 - Made duplicate Histograms.json keys build errors. r=gfritzsche 
If duplicate keys are present in Histograms.json then histogram_tools.py
will raise error.
 2017-04-12 00:14:39 +05:30
Alessio Placitelli
8d4b02c01e Bug 1278531 - Disallow adding new "scalar" histograms to Histograms.json. r=gfritzsche 
MozReview-Commit-ID: 1cYpF6N99Zi
 2017-04-07 14:56:35 +02:00
Paavini Nanda
8b72dcd8ba Bug 1344852: Enable flake8 rule W602: "deprecated form of raising exception". r=dexter 2017-03-15 17:18:52 +05:30
Federico Padua
7036c21f0b Bug 1344833 - Enable flake8 rule E128: "continuation line under-indented for visual indent". r=Dexter 
This patch enables flake8 rule E128:
"continuation line under-indented for visual indent" in toolkit/components/telemetry
by removing the relative E128 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E128 error was reported.
Precisely 10 errors violating E128 rule were found and solved.

MozReview-Commit-ID: 4sNXIxGFJQN
 2017-03-18 21:18:27 +01:00
Federico Padua
0e70316680 Bug 1344836 - Enable flake8 rule E713: "test for membership should be 'not in'". r=Dexter 
This patch enables flake8 rule E713:
"test for membership should be 'not in'" in toolkit/components/telemetry
by removing the relative E713 entry from toolkit/components/telemetry/.flake8
and fixing the files for which the E713 error was reported.
Precisely 6 errors violating E713 rule were found and solved.

MozReview-Commit-ID: 2AaYGgVkxbU
 2017-03-14 02:03:13 +01:00
djmdev
89fefef3a5 Bug 1344849 - Enabled flake8 rule E201: "whitespace after '{'". r=Dexter 
Removed whitespace after '{'
 2017-03-15 18:33:48 +05:30
Federico Padua
3ad82d5643 Bug 1344841 - Enable flake8 rule E111: "indentation is not a multiple of four". r=Dexter 
This patch enables flake8 rule E111: "indentation is not a multiple of four"
in toolkit/components/telemetry by removing the relative E111 entry from
toolkit/components/telemetry/.flake8 and fixing the files for which the E111
error was reported.

MozReview-Commit-ID: EOVcsllJNJK
 2017-03-13 19:38:01 +01:00
djmdev
d657ec5e92 Bug 1344831 - Enable flake8 rule E703: "statement ends with a semicolon". r=dexter 
Removed ending semicolons.
 2017-03-09 22:37:32 +05:30
djmdev
2410c58bae Bug 1344718 - Enable flake8 rule E302: "expected 2 blank lines, found 1" for Telemetry code. r=Dexter 2017-03-08 22:41:00 +05:30
Georg Fritzsche
fced0d6848 Bug 1312806 - Categorical histograms should default to 50 buckets. r=dexter 2016-12-23 14:46:17 +01:00
AdamG2
c5d766c5cf Bug 1300715 - prevent newer registered histograms from using default r=chutten 
"expires_in_version", and add old ones to the whitelist. r?chutten

MozReview-Commit-ID: Hp9rXdkQgBN
 2016-10-04 23:50:08 -04:00
Georg Fritzsche
a3264dcae0 Bug 1294018 - Part 1 - Enforce whitelist updates on Histograms.json changes. r=chutten 2016-08-10 18:23:43 +02:00
Georg Fritzsche
b204aad44b Bug 1188888 - Part 7 - Bonus - Explicitly restrict histogram names to current patterns. r=chutten 2016-07-20 17:10:24 +02:00
Georg Fritzsche
e54db4e599 Bug 1188888 - Part 6 - Implement C++ API for categorical histograms. r=chutten,r=froyndj 2016-07-20 17:10:24 +02:00
Georg Fritzsche
cb5ae2c904 Bug 1188888 - Part 5 - Restrict label values. r=chutten 2016-07-20 17:10:24 +02:00
Georg Fritzsche
75a2db27c3 Bug 1188888 - Part 4 - Implement categorical histograms with JS API. r=chutten 2016-07-20 17:10:24 +02:00
Georg Fritzsche
9c36a5146a Bug 1188888 - Part 3 - Refactor the histogram script type & presence checking. r=chutten 2016-07-20 17:10:24 +02:00
Georg Fritzsche
2ae4a0e2df Bug 1271986 - Allow for Histogram.json entries with "keyed":"true" when running histogram_tools.py in the pipeline. r=dexter 2016-05-12 14:07:48 +01:00
Georg Fritzsche
55b7646bab Bug 1269318 - Skip alert_emails and bug_numbers checks for use counters. r=chutten 2016-05-03 18:07:44 +02:00
Georg Fritzsche
58d32f8773 Bug 1263189 - Skip the new type checks in histogram-tools.py on the server-side. r=chutten 2016-04-12 17:25:27 +02:00
Chris H-C
b875671a64 Bug 1219768 - make alert_emails field mandatory for new histograms. r=gfritzsche 
alert_emails tell us who is interested in a particular histogram. If there's
no one interested, then the histogram shouldn't exist.

MozReview-Commit-ID: 90Yqof3dbsd
 2016-02-23 10:48:13 -05:00
Chris H-C
dd6659b161 Bug 1219768 - make Histograms.json's bug_numbers field mandatory. r=gfritzsche 
bug_numbers is now mandatory, because we really want to have some explanation
about where the probe came from.

We have a lot of non-bug-numbered probes (including non-Histograms.json-
resident probes like the use counters) that are being "grandfathered in" via
a whitelist in whitelists.json.

MozReview-Commit-ID: 62dN96sEOUf
 2016-02-23 10:20:28 -05:00
Chris H-C
d4620c6a9e Bug 1219768 - make histogram_tools' whitelist file generic. r=gfritzsche 
Future-proofing.

MozReview-Commit-ID: Jz41SWRK0bK
 2016-02-22 16:13:02 -05:00
Eric Hu
ddb3c00078 Bug 1245910 - Enforce correct types in Histograms.json. r=gfritzsche 
- Convert string values to integer and boolean values for Histograms
- Add compile time type checks on Histograms.json
- Remove string to int/bool coercion for the Histogram keys:
  - n_buckets
  - n_values
  - low
  - high
  - keyed
- Remove check_numeric (redundant with check_expression_types)
 2016-02-17 21:14:31 +07:00
Georg Fritzsche
f775dcfeca Bug 1247264 - Update the Histogram bucket limit error message to point to the Telemetry team. r=chutten 2016-02-10 15:19:37 +01:00
Anup Kumar
af825059ba Bug 1201492 - Remove extended_statistics_ok from Telemetry histograms. r=dexter 2015-12-21 08:31:00 +01:00
Chris H-C
29f944b4f1 Bug 1222044 - Only allow lists of alert_emails r=vladan 2015-11-06 04:35:00 -08:00
Georg Fritzsche
c875ecd0de Bug 1219733 - Allow a 'bug_numbers' field in Histograms.json entries. r=vladan 2015-11-02 11:32:53 +01:00
Chris H-C
6004a06aa6 Bug 1211599 - Only allow whitelisted histograms to have > 100 buckets. r=nfroyd 2015-10-28 07:09:00 +01:00
Nathan Froyd
1713be633d Bug 1204994 - part 2 - rename all USE_COUNTER_* histograms to USE_COUNTER2_* histograms; r=bz,vladan 
We're changing the definition of each of the use counter histograms.
Therefore, they need new names, so as to not throw wrenches into the
server-side machinery.  This renaming is the most straightforward way to
do things and similar to how we have renamed other histograms before.
 2015-09-15 20:44:37 -04:00
Nathan Froyd
7c48b60607 Backout c5b25c30befc:b217dfd70e22 (bug 1204994) for browser-chrome oranges; r=me 2015-09-17 05:09:13 -04:00
Nathan Froyd
de18995209 Bug 1204994 - part 2 - rename all USE_COUNTER_* histograms to USE_COUNTER2_* histograms; r=bz,vladan 
We're changing the definition of each of the use counter histograms.
Therefore, they need new names, so as to not throw wrenches into the
server-side machinery.  This renaming is the most straightforward way to
do things and similar to how we have renamed other histograms before.
 2015-09-15 20:44:37 -04:00
Nathan Froyd
598d0413cc Bug 968923 - part 6 - add use counters for deprecated operations; r=bz 2015-06-17 12:28:26 -04:00
Ryan VanderMeulen
be49d72a6f Backed out changeset 50702da2194a (bug 1172113) for assertions. 
CLOSED TREE
 2015-07-02 20:59:36 -04:00
Anthony Zhang
acf3b9ccd3 Bug 1172113 - Add bucket count and ranges to histogram_tools. r=vladan 2015-06-15 11:13:13 -04:00
Nathan Froyd
4f35cbf40d Bug 1168409 - part 2 - avoiding importing usecounters in histogram_tools.py; r=gfritzsche 2015-06-02 11:33:43 -04:00
Nathan Froyd
1b884fe55c Bug 1168409 - part 1 - avoid importing buildconfig in histogram_tools.py; r=gfritzsche 
histogram_tools.py is used by in-tree and out-of-tree consumers, so we
need to be aware of that when using build-time-only modules like
buildconfig.
 2015-05-27 12:25:04 -04:00
Nathan Froyd
a088ae0bef Bug 968923 - part 1 - add infrastructure for defining use counters from UseCounters.conf; original-author=heycam; r=heycam,gfritzsche,mshal 
This patch adds UseCounter.conf for defining use counters along with
infrastructure to generate enums and telemetry identifiers from
UseCounter.conf.
 2015-02-04 17:00:00 -05:00
Georg Fritzsche
18530f552d Bug 1120369 - Allow specifying the desired dataset in Histograms.json. r=vladan 2015-01-29 15:17:24 +01:00
Georg Fritzsche
0fd9b006e5 Bug 1069874 - Add keyed histogram types. r=froydnj 2014-10-30 20:51:01 +01:00
Georg Fritzsche
e75bffb6b2 Bug 1069873 - Add counter histogram type. r=froydnj 2014-09-26 17:45:33 +02:00
Roberto A. Vitillo
30caaa00e0 Bug 1037494 - Add author field to Histograms.json; r=vladan 2014-07-28 09:53:00 +02:00
Roberto A. Vitillo
5b37e47663 Bug 957156 - Expire telemetry histograms by default also in development channels. r=vladan 2014-01-09 13:20:41 -05:00
Roberto A. Vitillo
28d9c36835 Bug 956715 - Allow missing "expires_in_version" in histogram definition. r=froydnj 2014-01-09 13:20:12 -05:00
Roberto A. Vitillo
e6520ed502 Bug 742500 - Disable expired telemetry probes. r=vladan 2014-01-03 12:02:48 -05:00