Commit Graph

56 Commits

Author SHA1 Message Date
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Rob Wu
5ea50ab2dd Bug 1544834 - Replace deprecated generics in test code r=evilpie
- `Array.map` becomes `Array.from`
- Array copying via `Array.slice` becomes `Array.from`.
- `Array.forEach` that did not rely on closures becomes `for`-`of` loops.
- Anything else: `Array.X` becomes `Array.prototype.X`.

Complex cases:

dom/bindings/test/TestInterfaceJS.js and
dom/bindings/test/test_exception_options_from_jsimplemented.html
use `Array.indexOf` to generate an error with a specific error message.
Switched to `Array.prototype.forEach` to generate the same error.

js/src/jit-test/tests/basic/exception-column-number.js
In this test `Array.indexOf()` is used to generate an error. Since the
exact message doesn't matter, I switched to `Array.from()`.

Intentionally not changed:

editor/libeditor/tests/browserscope/lib/richtext/richtext/js/range.js
Did not modify because this is 3rd-party code and the code uses
feature detection as a fall back when Array generics are not used.

testing/talos/talos/tests/dromaeo/lib/mootools.js
Did not modify because mootools adds the `Array.slice` method to the
`Array` object.

Not changed because they check the implementation of Array generics:
js/src/jit-test/tests/basic/arrayNatives.js
js/src/jit-test/tests/basic/bug563243.js
js/src/jit-test/tests/basic/bug618853.js
js/src/jit-test/tests/basic/bug830967.js
js/src/jit-test/tests/jaeger/recompile/bug656753.js
js/src/jit-test/tests/self-hosting/alternate-static-and-instance-array-extras.js
js/src/tests/non262/Array/generics.js
js/src/tests/non262/Array/regress-415540.js
js/src/tests/non262/extensions/regress-355497.js
js/src/tests/non262/extensions/typedarray-set-neutering.js

Depends on D27802

Differential Revision: https://phabricator.services.mozilla.com/D27803
2019-04-17 19:03:19 +00:00
Kris Maglione
f498964d86 Bug 1519596: Part 1 - Remove several unnecessary/unused ChromeUtils.import() calls. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D16377
2019-01-11 16:59:23 -08:00
Johann Hofmann
65314d413a Bug 1483440 - Part 2 - Don't use purge-domain-data to clear session history for a domain. r=mikedeboer,baku
Differential Revision: https://phabricator.services.mozilla.com/D16461
2019-01-17 17:41:23 +00:00
Jan Henning
d561bbf114 Bug 1498812 - Part 9: Switch session store/session history to use visual viewport for scroll position tracking. r=mikedeboer,snorp
For simplicity's sake, for now we keep storing only one scroll position per
history entry (bug 1499210), so if we have to choose between the layout and the
visual viewport, the latter is a vastly better choice, as it more accurately
represents the scroll position as perceived by the user, especially when the
page has been pinch-zoomed.

This also means that instead of the normal scroll events, the session store now
has to listen for the corresponding events specific to the visual viewport.

We also extend the scroll position test to check that the scroll position isn't
just properly saved, but also actually properly restored in practice as well.
We only add this test now instead of already adding it beforehand like we did
with the rest of the test
- to avoid having to temporarily extend the checkScroll() helper function to
  deal with todo()/todo_is etc.
- because getting that part of the test to complete without timing out (which
  would be one of its natural failure modes, because the expected events would
  be missing) would require faking even more scroll events
- because we already have the todo() tests that are telling us the we didn't
  *store* any scroll position in the first place, so there's no point in trying
  to actually restore anything

For the GeckoView saveAndRestoreState test, we now spin the event loop once
before setting the scroll position in order to give APZ opportunity to settle
down after the initial page load.

Differential Revision: https://phabricator.services.mozilla.com/D15690
2019-01-11 19:50:09 +00:00
Nicholas Nethercote
7019398c81 Bug 1490158 - Minimize cancelability in nsISHistoryListener. r=nika
nsISHistoryListener can cancel several operations, but the functionality is
only ever used for OnHistoryReload(). So this patch removes it for the other
operations.
2018-09-06 16:51:58 +10:00
Nicholas Nethercote
548a48d45f Bug 1487328 - Remove nsISHistoryListener.OnHistoryGo{Back,Forward}. r=nika
As per the previous commit, they are now subsumed by OnHistoryGotoIndex.
2018-09-03 09:27:37 +10:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Nika Layzell
3d4a532d9d Bug 1434768 - Part 3: Rewrite JS consumers of .sessionHistory, r=bz 2018-04-10 17:49:45 -04:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Tim Taubert
5c1a30b131 Bug 1373672 - Part 1: Filter events from dynamic docShells in Gecko before they reach SessionStore event handlers r=smaug,mystor 2017-08-02 19:08:04 +02:00
Sebastian Hengst
3073215161 Backed out changeset e62c93a8c93b (bug 1373672) for bustage at nsSessionStoreUtils.cpp:21: bad implicit conversion constructor for 'DynamicFrameEventFilter, and e.g. eslint failures. r=backout on a CLOSED TREE 2017-08-01 12:39:21 +02:00
Tim Taubert
12284f3ab0 Bug 1373672 - Part 1: Filter events from dynamic docShells in Gecko before they reach SessionStore event handlers r=smaug,mystor 2017-07-21 14:57:30 +02:00
Florian Queze
ddf0cda8da Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
4cd95d4a02 Backed out changeset 18d45aa984d6 (bug 1355161) 2017-04-14 23:39:23 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Florian Queze
35cd8ba883 Bug 1355161 - script-generated patch to replace .{currentThread,mainThread}.dispatch(..., Ci.nsIThread.DISPATCH_NORMAL) with .dispatchToMainThread(...), r=froydnj. 2017-04-14 18:29:12 +02:00
Mark Banner
e20b9ee0f3 Bug 1311347 - Enable eslint of browser/components/sessionstore/. Manual fixes. r=jaws
MozReview-Commit-ID: AupJNLZJ2Ye
2017-03-13 10:32:03 +00:00
Mark Banner
03b4896b94 Bug 1311347 - Enable eslint of browser/components/sessionstore/. Autofix changes. r=jaws
MozReview-Commit-ID: 5LKHbcmjSy
2017-03-10 19:51:20 +00:00
AJ Kerrigan
9981c05a18 Bug 1132556 - Replace runInContent() with ContentTask.spawn(). r=smacleod 2016-01-07 03:26:31 -05:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Tim Taubert
1b7a4dd39b Bug 1163745 - Remove erroneous subtest from browser_sessionHistory.js r=Yoric 2015-06-10 14:45:37 +02:00
Tim Taubert
eda69fead2 Bug 1167579 - Fix intermittent browser_broadcast.js failures by rewriting modifySessionStorage() r=billm 2015-05-22 21:01:11 -04:00
Tim Taubert
982c542752 Bug 1109875 - Fix sessionstore tests to properly wait for data from closed tabs r=billm 2015-04-28 16:30:47 +02:00
Tim Taubert
eae431522a Bug 1022403 - Fix intermittent browser_sessionHistory.js timeouts by making sure the weak shistory listener isn't GC'ed before we saw the notification r=smacleod 2015-03-04 16:45:27 +01:00
Steven MacLeod
baec6f8b21 Bug 1107609 - Simplify test_pushstate_replacestate with ContentTask. r=ttaubert r=mconley 2015-02-11 17:15:01 -05:00
Dave Townsend
e0c3f34526 Bug 1114040 - Test for bug 1114040 (r=ttaubert) 2015-01-28 11:53:45 -08:00
Tim Taubert
fe2214ebc9 Bug 1099490 - Follow-up to fix spike of intermittent browser_sessionStorage.js failures r=me 2014-11-18 13:18:55 +01:00
Bill McCloskey
7e5519b6e8 Bug 1059007 - Fix async bugs in session store tests (r=ttaubert) 2014-09-23 15:48:53 -07:00
Bill McCloskey
d21cb88d02 Bug 1059007 - Make session restore tests work in e10s (r=ttaubert) 2014-09-23 15:48:53 -07:00
Bill McCloskey
c563be6db1 Bug 1059007 - Use useCapture for MozStorageChanged events (r=ttaubert) 2014-08-28 13:37:16 -07:00
Steven MacLeod
746465ac05 Bug 1036036 - Stop leaking docshells in Session Store tests. r=ttaubert
When adding a SHistoryListener in the Session Store test frame script
we were creating an intermediate global variable that was rooting the
docshell. This prevented things from being GC'd properly.

I've removed this intermediate variable and we should no longer keep
the docshell alive. This will probably also fix Bug 1036031.
2014-07-24 18:13:28 -04:00
Trevor Saunders
7fdd19b194 bug 1036694 - merge nsIMarkupDocumentViewer into nsIContentViewer r=smaug 2014-07-09 17:27:49 -04:00
Tim Taubert
da89684598 Bug 965697 - Fix intermittent browser_sessionHistory.js failures by waiting until the history entry has been replaced. r=smacleod 2014-07-07 14:11:17 -04:00
Steven MacLeod
26a9e3fd2b Bug 967028 - Use a SHistoryListener to collect entries from history.pushState(). r=Yoric 2014-03-20 22:52:31 -04:00
Tim Taubert
3e2ad5ff69 Bug 960903 - Tests for broadcasting shistory r=yoric 2014-01-20 17:36:59 +01:00
Tim Taubert
94fa0d39d5 Bug 947212 - Tests for broadcasting form data r=yoric
From 53d47a84c35781e73545eab3e665d63c742a9d20 Mon Sep 17 00:00:00 2001
2013-12-04 10:15:43 +01:00
David Rajchenbach-Teller
a78eff7834 Bug 942340 - Extracting many Telemetry statistics from sessionstore.js;r=ttaubert,froydnj 2014-01-11 09:51:24 +01:00
Tim Taubert
3307102e15 Bug 952998 - Use FrameTree to collect DOMSessionStorage data r=yoric
From 594cc2bdabe535ef356276bce49c4b36c73ab3a2 Mon Sep 17 00:00:00 2001
2013-12-20 14:23:32 +01:00
Tim Taubert
cded9bcb7b Bug 921942 - Add FrameTree and scroll position broadcast tests r=yoric
From 5645706beeae13673e87ba665f225e01a32949e2 Mon Sep 17 00:00:00 2001
2013-11-30 13:49:46 +01:00
David Rajchenbach-Teller
ffd23f7bb2 Bug 899276 - Don't collect/save private tabs. r=ttaubert 2013-12-18 12:39:53 -05:00