Commit Graph

921 Commits

Author SHA1 Message Date
Matthew Noorenberghe
8052744b84 Bug 1582738 - ChromeProfileMigrator: Don't initialize crypto if there are no rows. r=Gijs
Initializing OSCrypto can lead to a useless macOS Keychain prompt when there are no logins to import.

Differential Revision: https://phabricator.services.mozilla.com/D46616
2020-01-28 10:50:10 +00:00
Matthew Noorenberghe
4c950765ff Bug 1216186 - Use the actual browser name for imported bookmark folders from Chromium. r=Gijs
Using _getLocalePropertyForBrowser isn't ideal but ideally this patch would get uplifted so I didn't want to do a larger refactoring to fix this.

Differential Revision: https://phabricator.services.mozilla.com/D61104
2020-01-28 12:27:25 +00:00
Matthew Noorenberghe
1c4e674073 Bug 1608513 - Chromium Edge migrator support on Windows and macOS. r=Gijs
Microsoft supports using both old and new Edge in side-by-side (SxS) mode so both migrators should be supported if they have data.

Also rename the existing EdgeHTML Edge migrator to "Microsoft Edge Legacy" to allow disambiguation. This is the name Microsoft uses in side-by-side (SxS) mode.

Differential Revision: https://phabricator.services.mozilla.com/D60621
2020-01-22 18:35:11 +00:00
Matthew Noorenberghe
5d4b5120a2 Bug 1605491 - Add Chromium Edge Beta migrator support on Windows. r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D59542
2020-01-11 00:05:09 +00:00
Matthew Noorenberghe
b94148f2ca Bug 1605491 - Add Chromium Edge Beta migrator support on macOS. r=Gijs
Re-using all of the import logic from our Chrome/Chromium migrator.

Differential Revision: https://phabricator.services.mozilla.com/D58203
2020-01-10 21:40:30 +00:00
premk
ad0520c6ab Bug 1523179 - Support Chrome Beta import on Windows. r=MattN
Differential Revision: https://phabricator.services.mozilla.com/D59541
2020-01-10 20:00:10 +00:00
Matthew Noorenberghe
452fd0c08f Bug 1523179 - Fix Linux Chrome Beta and Chrome Dev migrator support and telemetry. r=Gijs
Symbols exported from a JSM cannot be nested inside an `if` otherwise `undefined` will be exported. I don't think it's worth filing a bug for that considering bug 1608269 is coming.

Differential Revision: https://phabricator.services.mozilla.com/D58202
2020-01-10 21:13:50 +00:00
Matthew Noorenberghe
a580b96586 Bug 1605871 - Delete unused importBookmarks/importFromBookmarks code/string for the migration window. r=zombie
Differential Revision: https://phabricator.services.mozilla.com/D58198
2019-12-24 17:03:47 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
Gabriele Svelto
eeb9bfc398 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443
2019-12-06 09:16:44 +00:00
Andreea Pavel
004229e0c9 Bug 1558330 - disable test_MigrationUtils_timedRetry.js on mac shippable r=egao
Differential Revision: https://phabricator.services.mozilla.com/D54888
2019-11-27 07:11:51 +00:00
Brian Grinstead
92c7336a05 Bug 1592369 - Rewrite [align="left"] to [align="start"] and [align="right"] to [align="end"] in XUL elements r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D51164
2019-11-19 20:30:34 +00:00
Kirk Steuber
a64a470673 Bug 1589134 - Move <script> tags out of <wizard>s r=bgrins
Moving these script tags has caused some code to be called in a different order. This patch enforces the necessary ordering by explicitly initializing MozWizardButtons from MozWizard's connectedCallback.

Differential Revision: https://phabricator.services.mozilla.com/D49490
2019-11-05 21:08:50 +00:00
Ehsan Akhgari
e195d030f5 Bug 1591813 - Make nsICookieManager.getCookiesFromHost() return an Array<nsICookie>; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D50750
2019-10-28 12:08:09 +00:00
Kirk Steuber
b1fee823ec Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov. On a CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D48922
2019-10-17 21:25:53 +00:00
Dorel Luca
acf9057708 Backed out changeset 01007f3333ea (bug 1584283) for Browser-chrome failures in widget/tests/browser/browser_test_procinfo.js 2019-10-23 03:23:24 +03:00
Kirk Steuber
73382954df Bug 1584283 - Stop using xul:wizard as a root element and migrate consumers to xul:window[role=dialog] with the wizard as the only child r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D48922
2019-10-17 21:25:53 +00:00
Mark Hammond
0f63f855d4 Bug 1577662 (part 2) - Profile reset now correctly handles that signed in to FxA doesn't always mean sync. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D47572
2019-10-01 01:12:42 +00:00
Mark Hammond
30236b5212 Bug 1577662 (part 1) - Allow profile refresh test to test multiple refresh scenarios. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D47571
2019-10-01 01:12:23 +00:00
Christoph Kerschbaumer
6dec8a1a75 Bug 1499354: Add object-src 'none' to the CSP of all about: pages. r=freddyb
Differential Revision: https://phabricator.services.mozilla.com/D46950
2019-09-26 16:22:41 +00:00
Paul Zuehlcke
7aaa589abf Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848
2019-09-24 17:13:43 +00:00
Oana Pop Rus
0b45091dcf Backed out changeset cb1b6afa9f33 (bug 1574469) for multiple failures in nsICookieManager.remove on a CLOSED TREE 2019-09-24 13:10:07 +03:00
Paul Zuehlcke
380cac0210 Bug 1574469 - Removed block param from nsICookieManager::Remove. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D45848
2019-09-19 17:10:58 +00:00
Matthew Noorenberghe
4ae7f7853a Bug 1423714 - Import logins from Chrome/Chromium on macOS. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45155
2019-09-18 04:47:34 +00:00
Matthew Noorenberghe
de9e2d0ae8 Bug 1423714 - Add a module to decrypt Chrome/Chromium Login Data from macOS. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D45969
2019-09-18 04:47:22 +00:00
Matthew Noorenberghe
ebef8321e3 Bug 1423714 - Add an API to retrieve a password from Keychain by account and service. r=mstange
Differential Revision: https://phabricator.services.mozilla.com/D45968
2019-09-18 04:47:10 +00:00
monikamaheshwari
edb30ffaec Bug 1578683 Turn on ESLint rule prefer-boolean-length-check for toolkit and browser r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D45629
2019-09-14 09:39:26 +00:00
Ciure Andrei
c0802578d1 Backed out changeset 81156ff3f4fa (bug 1571656) for causing browser_PageActions.js and test_insertTree_fixupOrSkipInvalidEntries.js to perma fail CLOSED TREE 2019-08-19 13:00:44 +03:00
Moritz Birghan
ecdc572dbd Bug 1571656 - Use Assert.jsm numeric comparison functions in tests r=mixedpuppy,MattN
Differential Revision: https://phabricator.services.mozilla.com/D40614
2019-08-19 07:17:12 +00:00
Matthew Noorenberghe
16e6094f43 Bug 1569414 - Don't hardcode a too old history visit date in test_Chrome_history.js.
Differential Revision: https://phabricator.services.mozilla.com/D39606
2019-07-27 15:57:53 +00:00
Christoph Kerschbaumer
e8a716d084 Bug 1497209: Apply Meta CSP to about:sessionrestore and about:welcomeback. r=Gijs,vporof
Differential Revision: https://phabricator.services.mozilla.com/D38081
2019-07-17 11:22:35 +00:00
Gijs Kruitbosch
20abdebabd Bug 1557960 - cope with 0 values in Chrome's date/time columns when importing, r=mak
Differential Revision: https://phabricator.services.mozilla.com/D37810
2019-07-15 21:52:56 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Victor Porof
84b7635dee Bug 1558517 - Pre 3.0: Remove conflicting eslint rules, and turn on "curly: all" everywhere, r=standard8
Differential Revision: https://phabricator.services.mozilla.com/D34535
2019-06-28 17:14:01 +02:00
Maliha Islam
29ba83b477 Bug 1559975 - Make directories python3 compatible r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D35257
2019-07-02 15:47:34 +00:00
Boris Zbarsky
95de682140 Bug 1557793 part 2. Stop using [array] in nsIStringBundle. r=Pike
Differential Revision: https://phabricator.services.mozilla.com/D34196
2019-06-11 15:51:51 +00:00
Matthew Noorenberghe
b45e2f12a4 Bug 1148205 - Replace misnamed formSubmitURL and hostname properties on nsILoginInfo in browser/. r=jaws,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D33346
2019-06-05 05:33:24 +00:00
Andrea Marchesini
5cde15b155 Bug 1554464 - Merge nsICookie2 and nsICookie in 1 single interface, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D33031
2019-05-31 09:36:44 +00:00
Andrea Marchesini
da871a46a1 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214
2019-05-29 15:55:03 +00:00
arthur.iakab
f6d085aa58 Backed out 5 changesets (bug 1551798) for multiple build bustages on StaticPrefList.h CLOSED TREE
Backed out changeset c89daff34d97 (bug 1551798)
Backed out changeset bbc3f88b8c03 (bug 1551798)
Backed out changeset b87996b8a411 (bug 1551798)
Backed out changeset d88b0002d736 (bug 1551798)
Backed out changeset 0fe740c90e2b (bug 1551798)
2019-05-29 18:07:26 +03:00
Andrea Marchesini
f2a2bcb708 Bug 1551798 - Rename nsICookie2.SAMESITE_UNSET to nsICookie2.SAMESITE_NONE, r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31214
2019-05-24 15:18:49 +00:00
Sylvestre Ledru
c4c57387c3 Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31769
2019-05-22 22:37:14 +00:00
Trishul
e74443601a Bug 1442271 - Cookie imports fail on newer versions of Chrome r=Gijs
DB field name is changed in chrome, so matching that.

Cookie imports fail on newer versions of Chrome

Differential Revision: https://phabricator.services.mozilla.com/D31976
2019-05-21 12:40:22 +00:00
Brendan Dahl
a0aed74712 Bug 1551320 - Replace all CreateElement calls in XUL documents with CreateXULElement. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D31295
2019-05-20 16:50:28 +00:00
Boris Zbarsky
6babe3ddd4 Bug 1551657 part 3. Stop using [array] in findLogins. r=MattN
I audited the results from
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BFf%5DindLogins%5B%5EA-Za-z_%5D&case=true&regexp=true&path=

Differential Revision: https://phabricator.services.mozilla.com/D31119
2019-05-14 19:28:52 +00:00
Boris Zbarsky
bc9de78e60 Bug 1551657 part 1. Stop using [array] in getAllLogins. r=MattN
I audited all the callsites
https://searchfox.org/mozilla-central/search?q=%5B%5EA-Za-z_%5D%5BGg%5DetAllLogins%5B%5EA-Za-z_%5D&case=true&regexp=true&path=
brings up.

Differential Revision: https://phabricator.services.mozilla.com/D31117
2019-05-14 19:28:51 +00:00
Matthew Noorenberghe
b0aa646e82 Bug 1543258 - Handle NULL 'action_url' for Chrome login import. r=sfoster
Save it with the wildcard "" value so it works with any form action.

Differential Revision: https://phabricator.services.mozilla.com/D30332
2019-05-09 22:59:18 +00:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Dave Townsend
9bbde3d698 Bug 1541804: Make profile refresh for non-ascii named profiles work correctly. r=Gijs
This fixes two bugs. The first is that when the firefox profile migrator doesn't
know which profile to migrate it attempts to fall back to another profile. I
think this was intended to be the default but in bug 1322797 I ended up making
it the current profile, which is the profile we're restoring into now. I think
at this stage the profile directory doesn't even exist so things go wrong.
Changing to use the actual default works but....

When the profile migrator UI doesn't know what profile to migrate from it uses
the default profile. So if the profile you're actually trying to restore is not
the default we'll effectively throw its data into the archive and replace it
with data from the default profile. I'm inclined to say that if the migrator
does not know what profile to migrate from it should error at that point for
safety.

Why would the profile migrator not know what profile to migrate from? Because of
a long-standing text encoding problem. In C++ profile names are encoded in UTF8.
But we try to pass them to JS through an IDL parameter of type ACString. This
does no UTF8 decoding and so JS recieves an incorrect name if the name includes
non-ascii characters and so can't find the profile.

This patch fixes the IDL parameter to AUTF8String which does the decoding
correctly and so JS gets the name correctly.

We should probably think about whether just passing the nsIToolkitProfile object
to the migrator is a better choice here.

Differential Revision: https://phabricator.services.mozilla.com/D26250
2019-04-04 21:53:01 +00:00
Jonas Allmann
30b70ed3f9 Bug 1498569, Replace wizard.xml attributes with event listeners, r=Gijs
* Removed all occurences of custom onwizard* attributes.
* Removed custom handler code from wizard.xml.
* Updated eval()-usage whitelist.

Differential Revision: https://phabricator.services.mozilla.com/D24033
2019-04-02 08:56:25 +00:00