Commit Graph

82 Commits

Author SHA1 Message Date
Tom Schuster
953b906337 Bug 1904798 - Remove onclick inline event handlers from protections popup. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D215345
2024-07-10 09:27:36 +00:00
Tom Schuster
32f03d71b3 Bug 1904798 - Remove protections-popup popup inline event handlers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D215344
2024-07-10 09:27:36 +00:00
Tom Schuster
0b3f4747c1 Bug 1904798 - Remove not-blocking-why inline event handlers. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D215343
2024-07-10 09:27:36 +00:00
Tom Schuster
c1ebd01f90 Bug 1904798 - Remove oncommand inline event handlers from protections popup. r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D215342
2024-07-10 09:27:35 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Thomas Wisniewski
37957b7306 Bug 1881798 - remove the legacy ETP webcompat reporter; r=pbz,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D203022
2024-03-03 01:39:42 +00:00
Itiel
cd3ef922f3 Bug 1869574 - Refactor the headerText setter to cater for more panelview needs r=twisniewski,Gijs,translations-reviewers
This introduces `mainview-with-header` attribute for panels that their
mainview should have a header (no matter where they appear); and
`has-custom-header` for panels that their panelview (not necessarily a
mainview) has a custom design for a header, one that headerText setter
can't anticipate in advance (due to UX needs that may arise).
If one of these attributes are set on the panel, this signals headerText
that the panelview's header should NOT be removed and that the markup
should be respected.

Differential Revision: https://phabricator.services.mozilla.com/D196671
2024-01-09 17:01:25 +00:00
Anna Yeddi
50eaec3786 Bug 1872954 - [Protections Panel] Ensure blocker tracker milestones subviewbutton is labeled. r=anti-tracking-reviewers,pbz
The Protections doorhanger UI includes [a subview button with id `protections-popup-milestones-content`](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/components/controlcenter/content/protectionsPanel.inc.xhtml#160-167) that does not provide an accessible name,

It appears to happen because this `<toolbarbutton>` XUL control is marked up with [`<description>` as its child containing the on-screen text](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/components/controlcenter/content/protectionsPanel.inc.xhtml#164-165), while `<label>` does provide an expected output for the Accessibility API preserving its visual appearance at the same time.

Since this control would become labeled and would start passing a11y_checks, we are also removing [the `fail-if` notation](https://searchfox.org/mozilla-central/rev/762f24e00a9548d80ebba1b985c871ba6d9b829d/browser/base/content/test/protectionsUI/browser.toml#57) from the `browser/base/content/test/protectionsUI/browser_protectionsUI_milestones.js` test manifest.

Note: the following prefs are needed:
```
      // Hide protections cards so as not to trigger more async messaging
      // when landing on the page.
      ["browser.contentblocking.report.monitor.enabled", false],
      ["browser.contentblocking.report.lockwise.enabled", false],
      ["browser.contentblocking.report.proxy.enabled", false],
      ["browser.contentblocking.cfr-milestone.update-interval", 0],
```

Differential Revision: https://phabricator.services.mozilla.com/D197634
2024-01-04 17:18:28 +00:00
Thomas Wisniewski
76bddf1405 Bug 1870887 - hide the Report Broken Site menu options until the component initializes; r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D197009
2023-12-22 13:31:12 +00:00
Itiel
34e523a635 Bug 1865827 - Make the Report Broken Site panel more similar to other panels, and simplify some CSS r=Gijs,twisniewski,desktop-theme-reviewers,emilio
Differential Revision: https://phabricator.services.mozilla.com/D194416
2023-11-27 17:13:56 +00:00
Thomas Wisniewski
d4de90a56b Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-20 01:50:36 +00:00
Cristian Tuns
8e6281d821 Backed out 3 changesets (bug 1852340) for causing frequent mochitest failures in docshell/test/chrome/ CLOSED TREE
Backed out changeset 61875987e62c (bug 1852340)
Backed out changeset 05320d6c0441 (bug 1852340)
Backed out changeset 411374d444d1 (bug 1852340)
2023-11-19 11:46:26 -05:00
Thomas Wisniewski
86011b4643 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 15:34:40 +00:00
Natalia Csoregi
f0be2f0119 Backed out 3 changesets (bug 1852340) for causing failures due to reportBrokenSite.ftl. CLOSED TREE
Backed out changeset 86f9e01f70d6 (bug 1852340)
Backed out changeset 0049d0494b17 (bug 1852340)
Backed out changeset 7851355d5c95 (bug 1852340)
2023-11-19 10:50:25 +02:00
Thomas Wisniewski
ba87a9d6fc Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-19 07:31:31 +00:00
Natalia Csoregi
6e68090bc2 Backed out changeset 59a1d385ed2a (bug 1852340) for causing multiple failures e.g. browser_startup_images.js. CLOSED TREE 2023-11-17 15:59:18 +02:00
Thomas Wisniewski
cf421bd6f6 Bug 1852340 - part 1: Add a new Gecko component for reporting broken websites; r=ayeddi,fluent-reviewers,mossop,flod,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D190647
2023-11-17 12:34:52 +00:00
DJ
9ad2936c0d Bug 1862982 - fix fluent schema for cookie banner blocker cancel button. r=fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D193235
2023-11-10 15:16:41 +00:00
DJ
99b6ebc81d Bug 1862427 - move cookie banner blocker info to bottom of privacy panel. r=cmkm
Differential Revision: https://phabricator.services.mozilla.com/D192477
2023-11-01 16:27:35 +00:00
DJ
5e121de832 Bug 1856014 - Fix fluent schema for strings in protections panel. r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D191997
2023-10-30 15:34:55 +00:00
Emilio Cobos Álvarez
d45fa4cc60 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-23 15:51:37 +00:00
Cieara Meador
73f9d6b44b Bug 1857972 - Update cookie banner blocker strings on privacy panel r=pbz,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D190813
2023-10-13 13:59:17 +00:00
Cristina Horotan
c1f4823686 Backed out changeset 6d11e2f54668 (bug 1855875) for causing bug 1856697 2023-10-04 18:46:25 +03:00
Emilio Cobos Álvarez
253a8284f6 Bug 1855875 - Rename panel-footer-button to footer-button, and use them for customize mode footer too. r=dao,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D189630
2023-10-02 16:51:52 +00:00
ganna
ce241d6c1d Bug 1832348 - Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183417
2023-08-30 17:35:39 +00:00
Hanna Jones
20cbf2f575 Bug 1801936 - use moz-toggle in the ETP panel r=mstriemer,tgiles,desktop-theme-reviewers,flod,dao
This patch replaces both toggles in the different sub views of the ETP panel with `moz-toggle`. Previously there was a small discrepancy where we were setting an `aria-label` on one toggle but not the other. I added a method to handle updating both toggles at once to ensure they stay in sync/always receive the same updates.

Differential Revision: https://phabricator.services.mozilla.com/D176700
2023-08-09 18:18:44 +00:00
Butkovits Atila
cea2025687 Backed out 6 changesets (bug 1832348) for causing mochitest failures with leaks. CLOSED TREE
Backed out changeset 50f0546e5e0e (bug 1832348)
Backed out changeset 294d38c19889 (bug 1832348)
Backed out changeset 9cc22e70d293 (bug 1832348)
Backed out changeset fdcd11e66071 (bug 1832348)
Backed out changeset a357b1c75148 (bug 1832348)
Backed out changeset fcc56c5fd7e4 (bug 1832348)
2023-07-26 20:41:26 +03:00
ganna
60a8295095 Bug 1832348 - Part 5: Add panel-footer-button class for buttons in protectionsPanel. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D183417
2023-07-26 15:47:40 +00:00
ganna
c8753bc02d Bug 1814411 - Use moz-support-link for the protections-popup-shim-allow-learn-more labels in protectionsPanel.inc.xhtml. r=tgiles
Depends on D179594

Differential Revision: https://phabricator.services.mozilla.com/D179719
2023-06-05 14:25:52 +00:00
ganna
1e17d58bb7 Bug 1814412 - Use moz-support-link for the protections-popup-sendReportView-learn-more label. r=tgiles,fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D179594
2023-06-05 14:25:51 +00:00
Mark Striemer
e136593fca Bug 1819372 - Part 3: Use moz-button-group in ETP report site panel r=pbz
Depends on D173892

Differential Revision: https://phabricator.services.mozilla.com/D175190
2023-04-13 16:20:50 +00:00
Mark Striemer
ae16cd84c7 Bug 1819372 - Part 2: Use moz-button-group in Cookie Banner Reduction panel r=pbz
Differential Revision: https://phabricator.services.mozilla.com/D173892
2023-04-13 16:20:50 +00:00
Itiel
25055b9ddb Bug 1827730 - Don't specify the cookie banner reduction panel header in the markup and let it be created by PanelMultiView.jsm r=emilio
Specifically, here:
https://searchfox.org/mozilla-central/rev/ad732108b073742d7324f998c085f459674a6846/browser/components/customizableui/PanelMultiView.jsm#1403-1457

Differential Revision: https://phabricator.services.mozilla.com/D175286
2023-04-13 15:30:57 +00:00
Tom Ritter
5c328a34af Bug 1824160: Add 'Fonts' to the reasons a Site Might Not Be Working r=fluent-reviewers,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D173565
2023-03-29 16:02:37 +00:00
ganna
851a344aca Bug 1802364 - Convert ETP breakage report links to toolbarbuttons in ETP panel. r=hjones,desktop-theme-reviewers,anti-tracking-reviewers,Itiel,pbz
Differential Revision: https://phabricator.services.mozilla.com/D172957
2023-03-28 19:44:11 +00:00
Jared Hirsch
a15a5ae9a6 Bug 1812796 - Refactor and simplify cookie banner handling UI state r=pbz,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D172075
2023-03-28 16:31:48 +00:00
Itiel
c391349369 Bug 1822134 - Fix panel header footer buttons appearance in the protections panel r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D172461
2023-03-13 18:40:45 +00:00
Emilio Cobos Álvarez
4191621d17 Bug 1821387 - Don't use vbox on panel headers. r=Gijs
While at it remove useless display declaration too.

vbox was setting -moz-box-orient: vertical, but that had no effect
because it had display: flex explicitly.

Differential Revision: https://phabricator.services.mozilla.com/D172145
2023-03-09 20:18:47 +00:00
DJ
0a24edca4c Bug 1810052 - update strings for protections panel and expose to localization. r=fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D168011
2023-02-06 19:09:01 +00:00
Jared Hirsch
cc107e3f5d Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-02 19:12:57 +00:00
Butkovits Atila
b95413c1ad Backed out changeset f878cff45427 (bug 1800670) for causing failures at browser_protectionsUI_cookie_banner.js. CLOSED TREE 2023-02-01 20:40:46 +02:00
Jared Hirsch
42e2eda79e Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-02-01 14:51:39 +00:00
Noemi Erli
879d74bdb0 Backed out changeset 68de023d3c5c (bug 1800670) for causing failures in browser_protectionsUI_cookie_banner.js CLOSED TREE 2023-01-30 21:16:42 +02:00
Jared Hirsch
992086fbed Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 16:30:28 +00:00
Butkovits Atila
8a37a83f45 Backed out changeset 0072aa5cd31d (bug 1800670) for causing multiple mochitest failures. CLOSED TREE 2023-01-30 15:26:29 +02:00
Jared Hirsch
64cb4ee8e6 Bug 1800670 - Update cookie banner handling UI in protections popup r=pbz
This patch also implements bug 1800671 and bug 1800673.

Differential Revision: https://phabricator.services.mozilla.com/D164241
2023-01-30 12:24:28 +00:00
Paul Zuehlcke
6bdcae659e Bug 1812296 - Add missing class to protections popup panel header. r=hpeuckmann
Bug 1795041 moved the font-weight rule to a separate class. I forgot to add
this class to the switch in the site-not-working sub-panel too.

Differential Revision: https://phabricator.services.mozilla.com/D167801
2023-01-25 16:45:48 +00:00
Itiel
c5c7610894 Bug 1577257 - Share logic behind panel headers across the UI r=willdurand,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D160972
2022-11-17 21:34:34 +00:00
Paul Zuehlcke
0668c2ff68 Bug 1795041 - Add a cookie banner handling per-site toggle to the protection panel. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D160254
2022-11-01 13:34:56 +00:00
Itiel
93140a5b5c Bug 1790232 - Use subviewbutton for the Protections popup buttons and cleanup some CSS r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D157045
2022-10-25 19:02:45 +00:00