Commit Graph

19 Commits

Author SHA1 Message Date
Marco Castelluccio
91823bf6b0 Bug 1357517 - Remove or delay Preferences.jsm usage from some browser/components/* files. r=Gijs 2017-07-31 13:25:41 +02:00
Mark Banner
ca95cdd557 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx
2017-04-19 12:06:16 +01:00
Wes Kocher
c94cafc922 Backed out changeset e1c9c6e89f50 (bug 1348097) for asan failures in test_SubsessionChaining.js a=backout
MozReview-Commit-ID: AiAjjlBmODC
2017-04-20 13:34:16 -07:00
Mark Banner
a436ee25b7 Bug 1348097 - Fix intermittent failures caused by Experiments.jsm by ensuring the preference monitoring is in sync. r=gfritzsche
Change the ExperimentsService to get the current value of the preferences (since it only uses them once or twice), so that they match the values in Experiments, and avoid differences causing promises to be rejected in the updateManifest call.
Also fix Experiments to correctly re-enable itself when toolkit.telemetry.enabled is changed from false to true (also fixes bug 1232648).
Finally, add a catch for a promise when calling updateManifest so that we don't get an uncaught promise exception.

MozReview-Commit-ID: GD6gfcRSgbx
2017-04-19 12:06:16 +01:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Dave Townsend
4e295aa48d Bug 1316882: Turn on space-before-function-paren eslint rule (browser). r=jaws
MozReview-Commit-ID: 2ZvTiZDHchz
2016-11-11 08:10:51 -08:00
Alessio Placitelli
ea8833fe9c Bug 1234526 - Remove unused healthreporter prefs. r=gfritzsche 2016-01-05 06:41:00 +01:00
Alessio Placitelli
8a596d564d Bug 1178456 - Experiments service shouldn't use FHR prefs. r=gfritzsche 2015-07-01 05:46:00 +02:00
David Rajchenbach-Teller
d5874d42c9 Bug 1087110 - Don't update experiments manifests if no experiment is running. r=gfritzsche 2015-03-10 13:36:17 +01:00
Georg Fritzsche
a43214f2af Bug 1005270 - Trigger experiments initialization on opening the addon manager UI. r=bsmedberg 2014-05-16 12:56:25 +02:00
Georg Fritzsche
8b6af78c44 Bug 993084 - Delay initialization of telemetry experiments if there is no active experiment. r=bsmedberg
To sync experiment state with the addon manager, we need to start it early when there is a
active experiment.
However, initializing the telemetry experiments system too early can lead to performance
regressions, so we delay the initialization if we don't have an active experiment.
2014-04-15 18:12:26 +02:00
Georg Fritzsche
1c320894e7 Bug 993084 - Don't load experiments module if the feature is preffed off. r=bsmedberg 2014-04-10 16:56:25 +02:00
Benjamin Smedberg
feb25d7dc1 Bug 984879 - Experiment manager shutdown, r=felipe 2014-03-18 22:52:30 +01:00
Georg Fritzsche
0042d40cb7 Bug 974009 - Telemetry experiments: test experiment conditions and enable experiments. r=felipe,unfocused 2014-03-18 22:52:28 +01:00