corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
494,824 Commits 1 Branch 0 Tags
c0c3cc7f32330eaec4e5fb380092c165d7813367
Commit Graph

454 Commits

Author SHA1 Message Date
Sebastian Hengst
31742f9ca2 Backed out changeset 1538b0445eda (bug 1366555) for timing browser_locationBarCommand.js and browser_locationBarExternalLoad.js. r=backout 2017-08-05 23:15:16 +02:00
Michael Kohler
a220eeb86a Bug 1366555 - Remove MOZ_PHOTON_THEME ifdefs and non-MOZ_PHOTON_THEME code r=dao 
MozReview-Commit-ID: CoHv9mKpAe
 2017-08-05 20:37:40 +02:00
Erica Wright
ad80e133d2 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs 
MozReview-Commit-ID: KrFYUijzawU
 2017-08-02 16:20:52 -04:00
Gijs Kruitbosch
4639ca807b Bug 1354117 - stop relying on gPhotonStructure in bookmarks/history code, r=adw 
MozReview-Commit-ID: FqUFNrSufvQ
 2017-08-01 19:55:41 +01:00
Gijs Kruitbosch
d485cb5fac Bug 1354117 - remove wrap handling for the bookmarks toolbar button and tests verifying it, r=johannh 
MozReview-Commit-ID: CeSGIQrDPpw
 2017-07-31 21:52:06 +01:00
Wes Kocher
6184b5919e Backed out changeset 4c8cc6044599 (bug 1382570) because it might have caused the spike in browser_page_action_menu.js failures a=backout CLOSED TREE 
MozReview-Commit-ID: HCTskH7e4RF
 2017-08-03 18:42:02 -07:00
Erica Wright
d4c8da7872 Bug 1382570 - Ignore non-left clicks on the bookmark icon. r=Gijs 
MozReview-Commit-ID: KrFYUijzawU
 2017-08-02 16:20:52 -04:00
Marco Bonardo
2703fb553f Bug 1382991 - Cleanup Places controller InsertionPoint. r=standard8 
MozReview-Commit-ID: 2pSbYtPGtYx
 2017-08-03 12:16:36 +02:00
Mark Banner
48ddb251f8 Bug 1094812 - Use Bookmarks.jsm in browser-places.js. r=mak 
MozReview-Commit-ID: HJ1NbFMm0l8
 2017-07-19 13:50:47 +01:00
Marco Bonardo
a90abdc771 Bug 1094818 - Use Bookmarks.jsm in controller.js. r=standard8 
MozReview-Commit-ID: 7vli02K19bt
 2017-07-18 19:18:02 +02:00
Mark Banner
1286bb379e Bug 1386197 - Show/Hide recently bookmarked menuitems don't exist in the Library window on Mac, handle the case so to avoid exceptions stopping listeners being removed. r=mak 
MozReview-Commit-ID: 6zcw2Q7vRYI
 2017-08-01 11:59:41 +01:00
Jared Wein
6954ff71c6 Bug 1384145 - Guard the removal of the 'animate' attribute so it only happens in builds with MOZ_PHOTON_ANIMATIONS since the attribute only makes sense when MOZ_PHOTON_ANIMATIONS=True. r=mconley 
MozReview-Commit-ID: DuUCYGt5uV2
 2017-07-26 08:53:04 -04:00
Jared Wein
818712371f Bug 1352063 - Implement new animation for bookmarking. r=Gijs 
MozReview-Commit-ID: GDfxtaCNtZo
 2017-07-24 17:52:44 -04:00
Wes Kocher
55f16cab91 Backed out changeset 9202b42e8dcb (bug 1352063) for failures in browser_startup_images.js a=backout 
MozReview-Commit-ID: 4sfnaQwjv76
 2017-07-24 14:38:10 -07:00
Jared Wein
ba7cd5c9a8 Bug 1352063 - Implement new animation for bookmarking. r=Gijs 
MozReview-Commit-ID: GDfxtaCNtZo
 2017-07-23 02:45:51 -04:00
Florian Quèze
3fa089754c Bug 1381853 - lazy load browserPlacesViews.js into the browser window, r=mconley. 2017-07-23 00:17:56 +02:00
Johann Hofmann
0bc53a79e8 Bug 1371219 - Increase margin of main menu items when accessed through touch. r=mikedeboer 
MozReview-Commit-ID: 9gjxxc6O5YS
 2017-07-20 16:45:02 +02:00
Mark Banner
8c8fb5a55f Bug 1381049 - Fix cases of async function definitions without await in Places code. r=mak 
MozReview-Commit-ID: 3G3BD5SrJ8b
 2017-07-14 17:32:22 +01:00
Mark Banner
a96f023139 Bug 1380570 - Fix setting the title when bookmarking a url from an error page when the url is not found in the history. r=mak 
MozReview-Commit-ID: EMuCpR1Sg9G
 2017-07-12 22:56:06 +01:00
Marco Bonardo
337b1dae96 Bug 1379611 - Avoid GetItemTitle() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: 9Ig63XHcEIE
 2017-07-10 16:13:55 +02:00
Marco Bonardo
652f85e780 Bug 1379611 - Avoid GetFolderIdForItem() synchronous API in editBookmarkOverlay.js. r=standard8 
MozReview-Commit-ID: LLikbxfAN4u
 2017-07-10 15:37:55 +02:00
Mark Banner
385eeb7b23 Bug 1377599 - Fix typos to make the Star UI remove bookmarks correctly, and add an extra hook to ensure the tests passes in async mode. r=mak 
MozReview-Commit-ID: FGBq9GTP2sB
 2017-07-12 17:35:59 +01:00
Johann Hofmann
c39fd8969c Bug 1377802 - Check if bookmarking UI is visible before anchoring bookmarking popup. r=mak 
This also avoids flushing when bounds checking the identity popup for visibility.

MozReview-Commit-ID: EBUR7RIB0w6
 2017-07-11 23:17:07 +02:00
Marco Bonardo
2e63b9b6bb Bug 1371677 - Delay the database connection in the history service as far as possible. r=adw 
Makes initing Places services cheaper, by delaying the connection creation to the first time
it's actually needed.
Same way, delays reading the bookmark roots at the first time they are requested.
Deprecates the concept of lazy observers, since they are no more needed, we can just use addObserver.
Simplifies the startup path: always sends "places-init-complete" (both as a category and a topic) when
the connection starts and adds a "locked" database state when we can't get a working connection.
Makes PlacesCategoriesStarter register for the new category, since it's cheaper than being a bookmarks
observer.
Fixes a couple race conditions in keywords and expiration due to new startup timings.
Removes a test in test_keywords.js that is no more easily feasible, since it'd requires a pre-build
places.sqlite that should be kept up-to-date at every version.

MozReview-Commit-ID: 6ccPUZ651m0
 2017-06-09 18:51:09 +02:00
Mike de Boer
1c56ce043f Bug 1354159 - Part 3 - Add a Bookmarks button to the Library panel that shows a subview with a list of most recent bookmarks. r=Gijs,mak 
This patch changes the Recent Bookmarks flow in browser-places.js to use the new
PlacesPanelview to provide a rich view that support drag and drop and context
actions.
A new button 'Search Bookmarks' was added, which prefills the urlbar with '* ',
which is a shortcut for searching bookmarks using the Awesomebar.

MozReview-Commit-ID: 1XlO8HMKEJs
 2017-06-29 17:57:25 -07:00
Mike de Boer
96f0faf27f Bug 1354159 - Part 1 - Remove the unneeded third 'view' argument from PlacesUIUtils.openNodeWithEvent(). r=mak 
MozReview-Commit-ID: Jema2qMYEdX
 2017-06-29 17:57:22 -07:00
Gijs Kruitbosch
1b926a256d Bug 1352120 - move the bookmarks star into the url bar, r=mak 
MozReview-Commit-ID: Ka5Wn2hrb1P
 2017-06-23 17:35:59 +01:00
Rajesh Kathiriya
993895141d Bug 1370225 - Enabled the ESLint comma-style rule across mozilla-central. r=standard8 
MozReview-Commit-ID: 9OhLgBpYS4L
 2017-06-15 18:24:17 +01:00
Marco Bonardo
70c4a90e76 Bug 625778 - Contextual commands on the main menubar bookmarks menu don't work after a customization. r=adw 
MozReview-Commit-ID: 8Atiql9Zplv
 2017-06-09 16:15:28 +02:00
Drew Willcoxon
d28a56eefb Bug 1363183 - Add a "bookmark" item to the page action menu. r=mikedeboer 
MozReview-Commit-ID: 9RR4U3X3gIT
 2017-05-25 16:19:02 -07:00
milindl
d307ef0df3 Bug 1350377 - Remove getPlacesInfo and change associated files and tests, r=mak 
Files which make use of `getPlacesInfo` have been replaced with `History.fetch`.
The code for `GetPlacesInfo` has been deleted from the cpp and idl files.
The test for `getPlacesInfo` has been suitably rewritten and moved alongside the
other History.jsm tests.

There were 2 places where the fact that `getPlacesInfo` takes an array as opposed
to a single uri mattered, in `test_getPlacesInfo.js` and `test_refresh_firefox.py`.

MozReview-Commit-ID: KQSMHCvvlrQ
 2017-05-17 16:02:21 +05:30
Marco Bonardo
9cd385fe81 Bug 1364488 - Allow fetch to use a concurrent connection. r=standard8 
MozReview-Commit-ID: 4L4PFtXsjsy
 2017-05-17 15:51:02 +02:00
Marco Bonardo
8488ea9641 Bug 1364488 - Recover from a Talos regression due to recent changes to the Star button. r=standard8 
The main reason for these changes is to avoid initializing the bookmarks service too early,
plus a lot of micro-optimizations to reduce the code-bloat compared to the previous bogus
(but slick) async getter.

MozReview-Commit-ID: Fy4fshsDaIw
 2017-05-15 19:32:47 +02:00
Florian Quèze
50b8c6608d Bug 1353542 - script-generated patch to remove .bind(this) calls we no longer need now that generator functions have been replaced with async functions, r=Mossop. 2017-05-12 14:47:41 +02:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Pauline
903b853642 Bug 1157709 - Removed all uses of PlacesUtils.asyncGetBookmarkIds. r=mak77 
MozReview-Commit-ID: FPhhbbIxOwz
 2017-05-11 14:23:03 +01:00
Nihanth Subramanya
e8ef9ee48c Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: EWgOI8x4Qdj
 2017-04-28 21:47:07 +05:30
Carsten "Tomcat" Book
efd5419472 Backed out changeset 4d6cbe2ebbd1 (bug 1347543) for causing bc6 issues 2017-05-03 15:50:55 +02:00
Nihanth Subramanya
82b97772b5 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: 27zDcyScFnj
 2017-04-28 21:47:07 +05:30
Wes Kocher
2e2823a7c7 Backed out changeset 0e3f9e184e6b (bug 1347543) for landing on the wrong tree a=backout 
MozReview-Commit-ID: 33rhqi8g77s
 2017-04-28 12:32:38 -07:00
Nihanth Subramanya
53ce1a1e14 Bug 1347543 - Use SVGs instead of PNGs for toolbar button icons. r=dao 
MozReview-Commit-ID: AdW6POOBeeh
 2017-04-28 21:47:07 +05:30
Florian Queze
6cc0b6e992 Bug 1355056 - replace (function(args) { /* do stuff using this */ }).bind(this) with arrow functions, r=jaws. 2017-04-27 00:25:45 +02:00
Florian Queze
d3c36892fa Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Sebastian Hengst
42670ceca0 Backed out changeset 322fde2d53bf (bug 1356569) so bug 1355161 can be backed out. r=backout 2017-04-14 23:39:22 +02:00
Florian Queze
9b4f73599f Bug 1356569 - Remove addObserver's last parameter when it is false, r=jaws. 2017-04-14 21:51:38 +02:00
Kirk Steuber
a5f3668356 Bug 1349823 - Populate bookmark panel before showing it r=enndeakin+6102,mak 
When panel behavior became asynchronous, |StarUI._doShowEditBookmarkPanel| needed to be changed to wait for the panel to finish opening before initializing it. Although the content of the panel can be changed successfully before the panel opens, the element focus at the end of initialization fails. This prevents the capturing of certain events, such as an Esc keypress (which should close the panel).

However, this introduced the problem where there is a short delay between when the bookmark panel opens and when the correct content is displayed in it. To fix this, the initialization function |gEditItemOverlay.initPanel| will now be called before the panel opens, but the element focus code will wait for the panel's popupshown event.

MozReview-Commit-ID: 6SrcCz963qW
 2017-04-05 15:38:37 -07:00
Florian Quèze
b15de4893d Bug 1345253 - Use element.firstChild.remove() instead of element.removeChild(element.firstChild), r=jaws. 2017-03-08 10:17:52 +01:00
Jared Wein
bcfb85b065 Bug 1294799 - Disable the autoclosing of the bookmark popup if there is any interaction with it such as mousedown or keypress. r=mak 
MozReview-Commit-ID: JRo5ZVu0uFD
 2017-02-10 11:11:57 -05:00
Jared Wein
65cc3fc0d6 Bug 1335043 - Prevent the bookmark panel from closing automatically if the mouse is hovering over it. r=mak 
MozReview-Commit-ID: 2jor6H2cQck
 2017-01-30 10:34:53 -05:00
Thom Chiovoloni
43289b1e98 Bug 1295237 - Add 'Mobile Bookmarks' root to the bookmark menus if we have it. r=markh 
MozReview-Commit-ID: 3ybnskOID1O
 2017-01-17 13:15:49 -05:00