Commit Graph

59 Commits

Author SHA1 Message Date
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Ganesh Chaitanya Kale
67bb868656 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1
2018-03-20 12:36:31 +00:00
Doug Thayer
2a70781cd0 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
shindli
f1661b02af Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE
Backed out changeset c1b0ea577728 (bug 1433593)
Backed out changeset 96327b595b91 (bug 1433593)
2018-02-20 23:01:54 +02:00
Doug Thayer
afbdc3b32b Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Margareta Eliza Balazs
7ec62aee45 Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE 2018-02-16 04:50:42 +02:00
Doug Thayer
38979fb27e Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Gijs Kruitbosch
4cd34f4756 Bug 1434167 - remove getSourceHomePageURL implementations and callsites, r=dthayer
MozReview-Commit-ID: 98p2Iy70EPv
2018-02-07 10:18:46 +00:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Doug Thayer
015377398b Bug 862127 - Make migration interfaces more async r=Gijs
In order to clean up sync IO within our profile migrators, we
need to have async interfaces for those parts which are currently
doing sync IO. This converts the sync interfaces and adjusts most
of the call sites (migration.js call site changes are addressed
in a separate patch to break it out a bit).


MozReview-Commit-ID: 2Kcrxco4iYr
2018-01-12 09:06:21 -08:00
Sam R-T, Joseph F, Robin H
0be01d2d28 Bug 1432062 - Require dangling commas via eslint for the migration component. r=MattN 2018-01-22 15:22:35 -08:00
Doug Thayer
c88b6d5bf1 Bug 1430318 - Fix getLastUsedDate bugs from using typedURLs r=mak
getLastUsedDate should be converting the microseconds of typedURLs
into milliseconds.

MozReview-Commit-ID: DjJKm5aPcGD
2018-01-17 11:15:27 -08:00
Mark Banner
9fc03b12e9 Bug 1365412 - Clean up various ESLint global definitions in browser/. r=mossop
MozReview-Commit-ID: JqAm9x1XGCM
2017-05-16 22:22:42 +01:00
Florian Quèze
ff53eb9a63 Bug 1353542 - massive script-generated patch converting Task.async and Task.spawn calls, and generators clearly identifiable as tasks, rs=Mossop. 2017-05-12 14:42:39 +02:00
Gijs Kruitbosch
e1717a1338 Bug 1341097 - part 2: allow turning off notifications for individual inserted results when calling updatePlaces, r=mak
This sets a property on the callback object rather than passing an argument
to handleCompletion, to avoid accidentally breaking consumers who don't
expect arguments. The downside is that this required more changes to C++
consumers, but we control all of those so that seemed an acceptable
trade-off.

We should probably actually report errors for all the migrators, but I didn't
want to add risk (what if in some edge-case there are lots?) so I didn't. I'll
file a followup to update them to Cu.reportError() any errors.

MozReview-Commit-ID: Hue9Ci3hyVz
2017-02-21 14:20:21 +00:00
Jared Wein
242ab87626 Bug 1326511 - Enable brace-style and no-multi-spaces eslint rules for toolkit. r=MattN
MozReview-Commit-ID: FuVu8skcqOe
2016-12-30 21:47:25 -05:00
Jared Wein
e3149c378f Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 7E7LPorrEje
2016-12-29 18:34:54 -05:00
Wes Kocher
2d7553dcfd Backed out 3 changesets (bug 1325464) for xpcshell failures a=backout
Backed out changeset 562ddc32cc21 (bug 1325464)
Backed out changeset cd10db6087dd (bug 1325464)
Backed out changeset 4079437c4648 (bug 1325464)
2016-12-29 14:05:44 -08:00
Jared Wein
34e228f767 Bug 1325464 - Enable object-shorthand rule and run 'mach eslint --fix' with the rule enabled. r=MattN
MozReview-Commit-ID: 8WoGr8i6oCR
2016-12-29 15:20:47 -05:00
Wes Kocher
390c1f407f Merge inbound to m-c a=merge CLOSED TREE 2016-11-16 17:07:26 -08:00
Gijs Kruitbosch
be4f40c56e Bug 1276705 - rm IE/safari settings importers, r=Dolske
MozReview-Commit-ID: 2YcaxJkbTwj
2016-11-14 13:04:06 +00:00
Dave Townsend
bbe7bf32d1 Bug 1316882: Turn on rest-spread-spacing eslint rule. r=felipe
MozReview-Commit-ID: EbRmrGz1G0a
2016-11-10 15:12:47 -08:00
Jared Wein
5edec1c0d9 Bug 1315013 - part 1, remove unnecessary double-slash comments that don't add value and look out of place with the spaced-comment eslint rule. r=mossop
MozReview-Commit-ID: HIUTSdkXxbY
2016-11-03 14:42:06 -04:00
Gijs Kruitbosch
1eb867efaf Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Wes Kocher
5d8f248c21 Backed out changeset 77012ce07e57 (bug 1279501) a=gijs 2016-11-01 10:47:59 -07:00
Gijs Kruitbosch
f0e91ab90a Bug 1279501 - add telemetry for the number of bookmarks, history visits and logins are imported from another browser, r=bsmedberg,mak
MozReview-Commit-ID: EiZfkj6AsVL
2016-10-22 14:40:48 +01:00
Jared Wein
0c024fa9ca Bug 1312486 - Enable no-extra-boolean-cast, no-new-object, no-shadow-restricted-names, and spaced-comment rules for eslint. r=standard8
MozReview-Commit-ID: 7Gx90a5y8t6
2016-10-24 13:14:19 -04:00
Gijs Kruitbosch
bbf79f28ea Bug 1311043 - make eslint much more strict in browser/components/migration/, and fix issues, r=mikedeboer
MozReview-Commit-ID: RXO68w3Kv3
2016-10-18 16:03:06 +01:00
Jared Wein
8860cdf2c1 Bug 1294547 - Enable the comma-spacing rule for eslint. r=felipe
MozReview-Commit-ID: RCSDEvvk2I
2016-08-16 15:44:15 -04:00
Gijs Kruitbosch
63852c5b10 Bug 1276694 - store recency of browser data in telemetry when importing to see how good a predictor default browser is, r=dolske,bsmedberg
MozReview-Commit-ID: 16uPNGGDE68
2016-05-30 17:10:54 +01:00
Gijs Kruitbosch
aaeb13df55 Bug 1246591 - followup: fix rules enabled in the last 24 hours in migration, rs=bustage 2016-02-09 10:57:55 +00:00
Gijs Kruitbosch
b582ea005a Bug 1246591 - fix whitespace issues, r=MattN 2016-02-08 12:03:10 +00:00
Tooru Fujisawa
14a6e39246 Bug 1216775 - Remove for-each from browser/. r=Gijs 2015-10-19 01:27:39 +09:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Tooru Fujisawa
aa4cdf03d4 Bug 1207491 - Part 7: Remove use of expression closure from browser/components/migration/. r=Gijs 2015-09-23 18:36:21 +09:00
Gijs Kruitbosch
a688b4fb63 Bug 1205053 - use registry typedURLs to import rudimentary history from MS Edge, r=dolske 2015-09-15 22:18:41 +01:00
Riadh Chtara
a783a87550 Bug 1192035 - Import passwords from Microsoft Edge / Windows 8+ r=Gijs,MattN 2015-09-16 17:34:26 -07:00
Ehsan Akhgari
d6254db4c6 Bug 1202039 - Do not pretend to support IE7FormPasswords on Windows 8 and above; r=mattn 2015-09-14 08:04:31 -04:00
Riadh Chtara
591805ea25 Bug 682069 - Password Import from IE not available. r=dolske r=mattn 2015-09-01 17:27:04 -07:00
Gijs Kruitbosch
95d597e462 Bug 1193387 - Import reading list from MS Edge. r=jaws 2015-08-26 15:34:02 +01:00
Ryan VanderMeulen
fc5047b7d6 Backed out changeset ef82210d0bf3 (bug 1193387) for various WinXP test failures.
CLOSED TREE
2015-08-28 21:01:27 -04:00
Gijs Kruitbosch
ef01e16420 Bug 1193387 - import reading list from MS Edge, r=jaws 2015-08-26 15:34:02 +01:00