Commit Graph

437 Commits

Author SHA1 Message Date
Marco Bonardo
c03dbb59bd Bug 1439315 - 6 - Move some utils into PlacesController or PlacesUIUtils. r=standard8
MozReview-Commit-ID: D7J6hY7Akro
2018-02-28 13:51:28 +01:00
Marco Bonardo
3e6ba6ed6d Bug 1439315 - 5 - defineLazyScriptGetter controller.js. r=standard8
MozReview-Commit-ID: 4Kq3XvJNNGB
2018-02-28 12:31:37 +01:00
Marco Bonardo
9755291ead Bug 1439315 - 3 - Don't use NetUtil.newURI. r=standard8
MozReview-Commit-ID: 58jYURt7EWF
2018-02-28 12:28:54 +01:00
Marco Bonardo
e0791e9a76 Bug 1439315 - 2 - Move command utils to PlacesUIUtils. r=standard8
MozReview-Commit-ID: 6hN9LxVQunX
2018-02-28 12:27:21 +01:00
Marco Bonardo
47da5f79b5 Bug 1439315 - 1 - rename InsertionPoint to PlacesInsertionPoint. r=standard8
MozReview-Commit-ID: 1NfkueEUPXC
2018-02-28 12:10:12 +01:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
8b297fe619 Bug 1434261 - Disable user actions on the places trees not in the library window to avoid accidential/unintentional actions. r=mak
MozReview-Commit-ID: ILo09hwWRsZ
2018-02-21 17:51:23 +00:00
Mark Banner
1135f98089 Bug 1437310 - Fix moving bookmarks across special folders. r=mak
MozReview-Commit-ID: dj6dOwDxOT
2018-02-12 21:51:08 +00:00
Francesco Lodolo (:flod)
a26d7198c4 Bug 1437583 - Split plural forms for Delete/Add bookmarks in separate strings r=standard8
Since the number of tabs is not actually displayed, having two separate strings from 1 vs many is preferable.

MozReview-Commit-ID: y1dgvsCxmC
2018-02-12 19:04:59 +01:00
Jared Wein
db0a992247 Bug 1436575 - Autofix errors from no-compare-against-boolean-literal. r=standard8
MozReview-Commit-ID: 66sXxnOWDgw
2018-02-08 12:57:31 -05:00
Mark Banner
5e632ca5e3 Bug 1437651 - Remove unused simulated-places-node references. r=mak
MozReview-Commit-ID: 6JzFXRykF2W
2018-02-12 20:33:07 +00:00
Mark Banner
00472aedd4 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Coroiu Cristina
8fb5593ad1 Backed out 5 changesets (bug 1423896) for bustage at /src/toolkit/components/places/nsNavHistoryResult.cpp on a CLOSED TREE
Backed out changeset 4012bc74e900 (bug 1423896)
Backed out changeset 12239646395f (bug 1423896)
Backed out changeset abf61cd5fb77 (bug 1423896)
Backed out changeset 569173c95238 (bug 1423896)
Backed out changeset 6401e950298d (bug 1423896)
2018-02-07 14:07:31 +02:00
Mark Banner
2339900150 Bug 1423896 - Make the All Bookmarks folder for the left pane of the Library a virtual query. r=mak
MozReview-Commit-ID: HzJ9y1fiEz1
2017-12-07 14:15:39 +00:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Mark Banner
b62dfadc2c Bug 1432407 - Merge loops in PlacesController.onDrop now that sync transactions have been removed. r=mak
MozReview-Commit-ID: JXaxRv10HQs
2018-01-25 21:00:34 +00:00
Mark Banner
dbe8b88641 Bug 1131491 - Remove browser.places.useAsyncTransactions preference - async transactions are now the only version. r=mak
MozReview-Commit-ID: 9EKNvA8Q9jo
2018-01-22 13:36:41 +00:00
Mark Banner
23fcf17af7 Bug 1432112 - Remove the Move Bookmarks dialog as it doesn't work properly and has alternatives. r=mak
MozReview-Commit-ID: LRqyjJeuoVt
2018-01-22 13:48:14 +00:00
Mark Banner
8d1d3df1ae Bug 1425339 - Allow Places tree's selectItems() function to handle guids as well as ids. r=mak
MozReview-Commit-ID: LmZ7AYXBsJ4
2017-12-14 13:56:26 -06:00
Mark Banner
4416ebb91e Bug 1425437 - Improve view batching when dropping/pasting to tags, use the actual bookmarks count, not the count of transactions. r=mak
MozReview-Commit-ID: B6Bt8bHhh3e
2017-11-08 15:32:51 +00:00
Mark Banner
4fc8cc8128 Bug 1422724 - Remove unused constants in Places' controller.js. r=mak
MozReview-Commit-ID: AWTTksnPUp8
2017-12-04 12:09:03 +00:00
Mark Banner
aebd86c238 Bug 1415877 - Merge transaction handling into one function for onDrop/paste. r=mak
MozReview-Commit-ID: AMhuLyc98WO
2017-11-08 14:48:45 +00:00
Mark Banner
60b83c5096 Bug 1415877 - Rework PlacesControllerDragHelper#onDrop and PlacesController#paste to make the transaction handling parts similar. r=mak
MozReview-Commit-ID: BInw5oT0Ja5
2017-11-08 12:02:30 +00:00
Mark Banner
6f15fd42c1 Bug 1415877 - Remove unused type parameter to PlacesUIUtils#getTransactionForData. r=mak
MozReview-Commit-ID: 3kZQ4vnCk3b
2017-11-08 11:25:26 +00:00
Mark Banner
ad0aef3c26 Bug 1413843 - Improve speed of operations when pasting to the left-hand library pane by getting the right-hand pane to use for batching. r=mak
MozReview-Commit-ID: 2Q1rIpIhmmM
2017-11-02 10:37:14 +00:00
Mark Banner
64f3f531c3 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm
2017-10-23 18:18:00 +01:00
Mark Banner
3003416b05 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
MozReview-Commit-ID: EEFizNPmKpr
2017-10-23 15:50:52 +01:00
Sebastian Hengst
bba67d8083 Backed out 2 changesets (bug 1410940) for failing browser-chrome's browser/components/places/tests/browser/browser_controller_onDrop_tagFolder.js. r=backout
Backed out changeset 1c78029ded02 (bug 1410940)
Backed out changeset 37ceb314b2b3 (bug 1410940)
2017-11-03 11:52:54 +01:00
Mark Banner
db255523a1 Bug 1410940 - Unify the parts of onDrop and paste that get the transaction information. r=mak
This also fixes inserting bookmarks on paste at the right insertion points.

MozReview-Commit-ID: Km93oZt1UHm
2017-10-23 18:18:00 +01:00
Mark Banner
53150e1c61 Bug 1410940 - Make PlacesController#paste and PlacesControllerDragHelper#onDrop more similar to each other. r=mak
MozReview-Commit-ID: EEFizNPmKpr
2017-10-23 15:50:52 +01:00
Mark Banner
c7f732b366 Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1
2017-10-26 10:14:14 +01:00
Margareta Eliza Balazs
a5635befe3 Backed out changeset e17a2bca5391 (bug 1411891) for failing xpcshell in toolkit/modules/tests/xpcshell/test_NewTabUtils.js r=backout on CLOSED TREE 2017-10-31 14:19:52 +02:00
Mark Banner
3bcdba86cd Bug 1411891 - Improve the performance of deleting bookmarks with async transactions. r=mak
MozReview-Commit-ID: GL9nKfypie1
2017-10-26 10:14:14 +01:00
Marco Bonardo
dcbda9bca0 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Sebastian Hengst
7a15678a21 Backed out changeset af8fdfac66fa (bug 1405722) for failing xpcshell's browser/components/places/tests/unit/test_PUIU_livemarksCache.js, at least on OS X 10.10 opt. r=backout on a CLOSED TREE 2017-10-17 00:55:53 +02:00
Marco Bonardo
6652796654 Bug 1405722 - Remove the IsLivemark() bookmarks observer from PlacesUIUtils. r=standard8
MozReview-Commit-ID: 586IR54ggbm
2017-10-10 12:05:19 +02:00
Dan Banner
5af4450327 Bug 1408777 - Automatically fix instances of missing semicolons in the tree. r=Standard8
MozReview-Commit-ID: Jm8BRgt6mIv
2017-10-15 20:50:39 +01:00
Peter Van der Beken
a8401db6ec Bug 1383059 - Remove instanceof for supplemental interfaces. Part 1: add Window.isChromeWindow and switch |instanceof [nsIDOM]ChromeWindow| to use it instead. r=bz. 2017-10-06 13:47:27 +02:00
Marco Bonardo
7af44bf697 Bug 1405687 - Remove some deprecated code from Places related code. r=standard8
MozReview-Commit-ID: 411z07otlfN
2017-10-04 16:33:46 +02:00
Mark Banner
a37a0a7508 Bug 1392533 - Make the places tree view directly communicate batch notifications to the results. r=mak
MozReview-Commit-ID: HpN0v0jSwdK
2017-09-27 15:26:35 +01:00
Mark Banner
b4848d29a8 Bug 1400846 - Fix ordering of bookmarks with Async Transactions when dropping into different folders. r=mak
MozReview-Commit-ID: GjnehR5PumZ
2017-09-19 06:54:16 +01:00
Mark Banner
69f202466e Bug 1401242 - Fix removing bookmarks from tag groups - when getting the tagGuid from the node, we must get it async, rather than using the concrete guid. r=mak
MozReview-Commit-ID: 7fGS6jFNVPl
2017-09-19 20:47:26 +01:00
Michael Layzell
151bdf2f69 Bug 1398471 - Read data from DataTransfer before yielding, r=gijs
Previously the code looped and yielded between each loop. This caused the
DataTransfer to be cleared before the read completed.

This splits the loop into 2 sections such that we read all important data from
the DataTransfer before it is cleared.
2017-09-13 11:45:48 -04:00
Mark Banner
5401fe8673 Bug 1396888 - Handle async moving of bookmarks in the caller for the move dialog, to avoid going out of scope whilst async actions are happening. r=mak
MozReview-Commit-ID: JhETMnmxNOD
2017-09-05 17:15:58 +01:00
Mark Banner
4cd4cb5dc8 Bug 1391166 - Fix the order of bookmarks via drag and drop when moving a bookmark down in the list. r=mak
MozReview-Commit-ID: 7Adz2Et0NQn
2017-08-23 12:24:53 +01:00
Mark Banner
eedb2f4c4e Bug 1392189 - Fix deleting bookmark tags from the Library view with Places Transactions enabled. r=mak
MozReview-Commit-ID: unNGjPpTX6
2017-08-23 13:40:44 +01:00