Commit Graph

174 Commits

Author SHA1 Message Date
Gijs Kruitbosch
58be8a530b Bug 1652614 - update the initial 'Tracking Content' state correctly when the protection panel shows, r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D83675
2020-07-16 14:32:05 +00:00
Sebastian Streich
9a30e9e484 Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-13 18:35:01 +00:00
Gijs Kruitbosch
480e677a3b Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-10 21:32:09 +00:00
Bogdan Tara
7689a981c8 Backed out changeset add40bc29da9 (bug 1634032) for browser_controlCenter.js failures CLOSED TREE 2020-07-10 21:10:42 +03:00
Gijs Kruitbosch
ec4fcaf060 Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-10 15:28:58 +00:00
Butkovits Atila
73a0d4bed1 Backed out changeset 71ca1673171d (bug 1634032) for assertion failure on DOMJSProxyHandler.cpp. CLOSED TREE 2020-07-10 01:36:16 +03:00
Gijs Kruitbosch
06c3b72ba5 Bug 1634032 - use a template to wrap the protections popup while it's not needed, r=nhnt11
This also only updates per-category block information in the protections panel
while it's open or when it's about to be shown. To do this, the patch:

1. changes the `categoryItem` getter on all blockers to avoid memo'izing null when the popup is unavailable;
2. changes the `updateCategoryItem` method on all blockers to deal with `categoryItem` being null;
3. stops calling `updateCategoryItem` from the blockers' `init` method, instead delegating this responsibility
   to gProtectionsHandler doing so when the popup first becomes available. Note that we still need (2) because
   pref changes can trip us calling into `updateCategoryItem` anyway. We cannot avoid instantiating the pref
   getters because they are relied on by some of the `isDetected` and `isBlocking` implementations.
4. reorganizes `onContentBlockingEvent` so it updates the icon, reports telemetry, and updates internal state -
   but only updates the panel if it's visible, and otherwise simply memorizes the last event (which is just
   a number!);
5. ensures showing the panel updates the panel's category data based on the memorized state from (4).

Differential Revision: https://phabricator.services.mozilla.com/D81926
2020-07-09 20:23:14 +00:00
Dorel Luca
a924a67d2b Backed out changeset 255d9078dd17 (bug 1633710) for Browser-chrome failures in extensions/test/xpinstall/browser_datauri.js. CLOSED TREE 2020-07-06 18:38:13 +03:00
Sebastian Streich
e62e8bee75 Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-06 14:00:09 +00:00
Dorel Luca
40dd06e506 Backed out changeset 2c46bcd325bb (bug 1633710) for Browser-chrome failures in extensions/test/xpinstall/browser_datauri.js. CLOSED TREE 2020-07-01 18:12:19 +03:00
Sebastian Streich
76d294400f Bug 1633710 - Move js uri.host to principal r=ckerschb,preferences-reviewers,ntim
Differential Revision: https://phabricator.services.mozilla.com/D73242
2020-07-01 12:21:22 +00:00
Gijs Kruitbosch
a25d1a59b7 Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D78894
2020-06-23 14:04:49 +00:00
Dorel Luca
10867ecce0 Backed out changeset 3671a57712e4 (bug 1646780) for Browser-chrome failures in webrtc/browser_devices_get_user_media_tear_off_tab.js 2020-06-19 04:22:23 +03:00
Gijs Kruitbosch
e7ae448a2d Bug 1646780 - use a template to wrap the identity popup while it's not needed, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D78894
2020-06-19 00:02:11 +00:00
luma
8c09de11a9 Bug 1572377 - Updating the protection panel only when the panel is opened or already opened. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D68534
2020-06-09 12:04:10 +00:00
Bogdan Tara
122f6a7668 Backed out changeset a38011a0bed3 (bug 1572377) for protectionsUI mochitest failures CLOSED TREE 2020-04-29 19:41:44 +03:00
luma
8f1f6f2711 Bug 1572377 - Updating the protection panel only when the panel is opened or already opened. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D68534
2020-04-29 15:11:23 +00:00
Dão Gottwald
57bf726432 Bug 1630918 - Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D71308
2020-04-29 06:26:49 +00:00
Noemi Erli
b1465a587f Backed out changeset 49365332dd15 (bug 1630918) for causing failures on browser_protectionsUI_animation_2.js CLOSED TREE 2020-04-28 18:59:49 +03:00
Dão Gottwald
20409eba3b Bug 1630918 - Use prefers-reduced-motion media query for the tracking protection shield icon animation. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D71308
2020-04-28 13:35:32 +00:00
Artem
e206d05827 Bug 1609559 - Migrate protectionsPanel.inc.xhtml to Fluent r=Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D71234
2020-04-28 06:23:10 +00:00
aarushivij
fb9545cf6e Bug 1587870 - [Protections Panel] Add level of protection next to 'Protection Settings' r=johannh,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D70521
2020-04-19 09:27:39 +00:00
meenohara
490fc29ec5 Bug 1586934 Fixed cookie subview for all cookieBehaviors when thers's a site exception. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D68015
2020-03-26 14:39:42 +00:00
jbone
41a892ed20 Bug 1574316 - Show all of the data in the subpanels of the protection panel as origins not domains r=prathiksha
Differential Revision: https://phabricator.services.mozilla.com/D66915
2020-03-23 11:39:59 +00:00
aarushivij
e7bf6dfffb Bug 1571522 - [Protections Panel] Move _trackingProtectionIconContainer from gIdentityHandler to gProtectionsHandler r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D66615
2020-03-15 07:36:02 +00:00
Mark Banner
1cc76add79 Bug 1620218 - Automatic code fixes for Prettier 1.18.2 upgrade. r=mossop,webcompat-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D65509
2020-03-08 21:45:16 +00:00
Liang-Heng Chen
82d6586233 Bug 1602715 - support cookieBehavior=5 in protection UI; r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D61543
2020-02-07 09:42:45 +00:00
Dimi Lee
113588eb24 Bug 1600896 - P2. Use getContentBlockingLog in WindoowGlobalParent instead of getContentBlockingEvent in nsIRemoteTab. r=timhuang,Ehsan
Depends on D55779

Differential Revision: https://phabricator.services.mozilla.com/D55780
2019-12-17 11:34:41 +00:00
Dimi Lee
e83925623c Bug 1600878 - P2. Use contentBlockingEvents in WindowGlobalParent instead of contentBlockingEvent in RemoteSecurityUI r=timhuang,Ehsan
ContentBlockingEvent in RemoteSecurityUI is updated after receiving a notification from a child process.
Since contentBlockingEvent will be removed from the child, this patch removes the use of
contentBlockingEvent in RemoteSecurityUI and uses the API defined in WindowGlobalActor.

Depends on D55621

Differential Revision: https://phabricator.services.mozilla.com/D55622
2019-12-17 11:25:23 +00:00
Erica Wright
831516af01 Bug 1603545 - Add telemetry for app menu protections button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D58044
2020-01-09 17:50:11 +00:00
Noemi Erli
883f769112 Backed out changeset bc55dd49ef82 (bug 1603545) for causing build bustages CLOSED TREE 2020-01-09 18:25:18 +02:00
Erica Wright
e12d63e48f Bug 1603545 - Add telemetry for app menu protections button r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D58044
2020-01-09 15:57:02 +00:00
Ehsan Akhgari
a9bd53c507 Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493
2019-12-19 02:56:52 +00:00
Gurzau Raul
9646f974e0 Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset c4d79087eef1 (bug 1603969)
Backed out changeset 2c0198f3506c (bug 1603969)
Backed out changeset c5ad252c525b (bug 1603969)
Backed out changeset a334451b95eb (bug 1603969)
2019-12-19 02:08:09 +02:00
Ehsan Akhgari
4f7f73843f Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493
2019-12-18 19:14:53 +00:00
Gurzau Raul
10ec17678c Backed out 4 changesets (bug 1603969) for failing at /browser_startup_mainthreadio.js on a CLOSED TREE.
Backed out changeset 959f12e42db9 (bug 1603969)
Backed out changeset 18bf461b9630 (bug 1603969)
Backed out changeset 8c3bb23a048b (bug 1603969)
Backed out changeset 450eec13d73e (bug 1603969)
2019-12-18 20:53:13 +02:00
Ehsan Akhgari
29fa5c0a8a Bug 1603969 - Part 1: Remove the concept of granted origins from the anti-tracking backend; r=baku
Granted origins cause a third-party tracker browsing context to not get
full first-party storage access after successfully calling the storage
access API or a heuristic granting ephemeral access.

For example, after https://tracker.example calls the storage access API
successfully in the third-party context, they embed
https://other-tracker.example, and that load fails because of ETP
restrictions.  Here what happens is that https://other-tracker.example
is mistakenly considered the granted origin, and because such a
permission doesn't exist, access is denied.

Differential Revision: https://phabricator.services.mozilla.com/D57493
2019-12-18 15:48:29 +00:00
Johann Hofmann
cdeb6cc6af Bug 1603511 - Optimize sending SiteProtection:ContentBlockingEvent events. r=nhnt11
These events were sent excessively on onStateChange. This patch makes it so that:

- we only listen to top-level document changes (we used to send all events from iframes)
- we don't send events unless there's tracking content on the page
- we only send a single event on tab switch instead of multiple

Differential Revision: https://phabricator.services.mozilla.com/D57006
2019-12-12 23:48:13 +00:00
Ehsan Akhgari
4f80b43251 Bug 1589476 - Emit a separate notification when a tracker from the Level 2 Disconnect blocklist is observed on a page and use this code to avoid using the URL classifer service in the front-end; r=nhnt11,droeh
Differential Revision: https://phabricator.services.mozilla.com/D49660
2019-11-18 20:56:36 +00:00
Nihanth Subramanya
0d817f0d56 Bug 1578831 - Link directly to breakage report subview when ETP is off. r=timhuang,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D47574
2019-11-07 20:13:31 +00:00
Johann Hofmann
eec1c8d979 Bug 1575785 - Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D51383
2019-11-06 21:14:19 +00:00
Johann Hofmann
19a257105e Bug 1582751 - Show an error message when content blocking breakage reporting fails. r=nhnt11,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D51382
2019-11-06 21:14:21 +00:00
Johann Hofmann
10b5f06c6c Bug 1592616 - Don't show breakage report link when we're not blocking anything. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D51381
2019-11-06 21:16:53 +00:00
Coroiu Cristina
23ead68999 Backed out 5 changesets (bug 1582751, bug 1575785, bug 1592616) for browser-chrome failures at browser/base/content/test/siteProtections/browser_protections_UI.js on a CLOSED TREE
Backed out changeset 7bc4ba491fc6 (bug 1592616)
Backed out changeset 7f420cfdf282 (bug 1592616)
Backed out changeset 9c00153e7458 (bug 1575785)
Backed out changeset e8ba7d342c46 (bug 1582751)
Backed out changeset 6ded6886d2ed (bug 1592616)
2019-11-06 22:58:29 +02:00
Johann Hofmann
861ea7b671 Bug 1575785 - Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D51383
2019-11-06 13:53:54 +00:00
Johann Hofmann
75310ef7bd Bug 1582751 - Show an error message when content blocking breakage reporting fails. r=nhnt11,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D51382
2019-11-06 15:35:17 +00:00
Johann Hofmann
d2d2097209 Bug 1592616 - Don't show breakage report link when we're not blocking anything. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D51381
2019-11-06 16:48:08 +00:00
Gurzau Raul
0ba66b9123 Backed out 5 changesets (bug 1582751, bug 1575785, bug 1592616) for failing at browser_protections_UI.js on a CLOSED TREE.
Backed out changeset ee2ba98f5a17 (bug 1592616)
Backed out changeset 1f665fb32bff (bug 1592616)
Backed out changeset dde543f12c83 (bug 1575785)
Backed out changeset fadcc9e29ffd (bug 1582751)
Backed out changeset e86703d8db17 (bug 1592616)
2019-11-06 15:48:17 +02:00
Johann Hofmann
29874f0efd Bug 1575785 - Show a confirmation hint when a user successfully submitted a breakage report. r=nhnt11
Differential Revision: https://phabricator.services.mozilla.com/D51383
2019-11-06 00:47:31 +00:00
Johann Hofmann
4e30d01f3f Bug 1582751 - Show an error message when content blocking breakage reporting fails. r=nhnt11,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D51382
2019-11-06 00:47:33 +00:00