Commit Graph

52 Commits

Author SHA1 Message Date
Nihanth Subramanya
c003434ef1 Bug 1551542 - Implement Protections Panel header. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D31070
2019-05-15 13:15:32 +00:00
Syeda Asra Arshia Qadri
b032199b17 Bug 1546088: Improve the look of the page URL in the Site Identity Button's drag-image/tooltip.r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D28985
2019-05-15 12:54:57 +00:00
Nihanth Subramanya
e51e424827 Bug 1551206 - Introduce new Protections Panel behind a pref. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D30921
2019-05-14 16:17:07 +00:00
Liang-Heng Chen
f8f39e7811 Bug 1330467 - part 10. Use principal for permissions in browser site-identity; r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D19931
2019-05-07 22:19:06 +00:00
Bogdan Tara
6a7a024dea Backed out changeset 791dcf072a98 (bug 1496844) for browser_identity_UI.js failures CLOSED TREE 2019-05-08 04:21:19 +03:00
jawad
301850a3f8 Bug 1496844 - treatment of https view-source URIs is inconsistent. r=johannh
***

Differential Revision: https://phabricator.services.mozilla.com/D23214
2019-05-07 23:34:31 +00:00
Johann Hofmann
37db3eb300 Bug 1540416 - Move toggling the report breakage button out of onContentBlockingEvent. r=ewright
Differential Revision: https://phabricator.services.mozilla.com/D27254
2019-04-15 20:34:12 +00:00
Trushita
19b14883c7 Bug 1494948: Removed FX_PREFERENCES_OPENED_VIA probe and origin parameter for openPreferences r=jaws,chutten
Removed FX_PREFERENCES_OPENED_VIA probe as it expired in 63.Origin parameter for openPreferences has also been removed.

Differential Revision: https://phabricator.services.mozilla.com/D26795
2019-04-09 20:40:26 +00:00
Syeda Asra Arshia Qadri
8fb9946f6e Bug 1208858: Show the page URL in the Site Identity Button's drag-image/tooltip. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D26527
2019-04-09 08:20:50 +00:00
neha
fbc9087bc9 Bug 1511834 - Improving site Information header in reader mode r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D21869
2019-03-07 12:36:51 +00:00
Alexander Surkov
62ec0b0d61 Bug 1527495 - migrate text-link binding to CE, r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D19595
2019-02-12 19:14:40 -05:00
Johann Hofmann
a5bb82422f Bug 1522565 - Add sub-panels for cryptominers and fingerprinters in the identity popup. r=nhnt11
This is mostly a lot of boilerplate based off the trackers category/subpanels.

I would like to do some code-de-duplication, especially in browser-contentblocking,
but I figured it would be a good idea to leave that to a different bug to not obstruct
the feature from landing :)

Differential Revision: https://phabricator.services.mozilla.com/D18826
2019-02-06 14:11:39 +01:00
ui.manish
3f2f4b0c21 Bug 1497827 - Do not display EV labels instead of domains in site identity header r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D18013
2019-02-05 09:29:50 +00:00
Myk Melez
5ecc2c1225 Bug 1518283 - prohibit blank lines at the beginning and end of blocks (eslint padded-blocks) r=mossop,Standard8
Differential Revision: https://phabricator.services.mozilla.com/D17526
2019-01-30 17:26:25 +00:00
Dorel Luca
435d0c8542 Backed out 2 changesets (bug 1520436) for browser-chrome failures in browser/base/content/test/permissions/browser_permissions.js
Backed out changeset 031aee32565c (bug 1520436)
Backed out changeset 1428560105ca (bug 1520436)
2019-01-23 19:35:50 +02:00
alwu
476272db30 Bug 1520436 - part1 : add another tooltip text for non-promptable permission. r=flod,johannh
As non-promptable permission won't prompt user to ask for their approval, we should use different texts for the cancel button of promptable permissions.

Differential Revision: https://phabricator.services.mozilla.com/D16770
2019-01-23 16:21:48 +00:00
Ehsan Akhgari
d4307ed0f6 Bug 1521598 - Part 2: Only update the identity panel for permissions that are visible inside it; r=johannh
Profiles show that we do a lot of needless work in response to notifications for
other permissions such as "storageAccessAPI".

Depends on D17362

Differential Revision: https://phabricator.services.mozilla.com/D17155
2019-01-23 15:57:10 +00:00
shindli
40e668f6e9 Backed out 2 changesets (bug 1520436) for TV failures in browser/base/content/test/permissions/browser_permissions.js CLOSED TREE
Backed out changeset 4752a33b4c3a (bug 1520436)
Backed out changeset 10716b2122dc (bug 1520436)
2019-01-23 03:20:13 +02:00
alwu
8fe5fe8ea7 Bug 1520436 - part1 : add another tooltip text for non-promptable permission. r=flod,johannh
As non-promptable permission won't prompt user to ask for their approval, we should use different texts for the cancel button of promptable permissions.

Differential Revision: https://phabricator.services.mozilla.com/D16770
2019-01-18 18:54:54 +00:00
Dale Harvey
4d11e4dbfa Bug 1517526 - Let user allow blocked autoplay. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D17130
2019-01-22 21:48:24 +00:00
Razvan Maries
fd761a009d Backed out changeset 1e7c60e83b86 (bug 1497827) for perma failing at testing/firefox-ui/tests/functional/security/test_ev_certificate.py. CLOSED TREE 2019-01-16 11:56:11 +02:00
ui.manish
82a1634dc6 Bug 1497827 Do not display EV labels instead of domains in site identity header r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D16508
2019-01-15 10:12:50 +00:00
Dale Harvey
d7c1fb6c48 Bug 1488946 - Remove about:searchreset. r=mkaply, r=flod
Tags: #secure-revision

Differential Revision: https://phabricator.services.mozilla.com/D14416
2018-12-14 10:01:51 +00:00
Ehsan Akhgari
f14967e85c Bug 1490811 - Part 1: Add a permission doorhanger for the storage access API r=baku,johannh
Differential Revision: https://phabricator.services.mozilla.com/D12467
2018-11-26 21:23:16 +00:00
Dão Gottwald
c080ee4c28 Bug 1508963 - Load browser-siteIdentity.js lazily. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D12521
2018-11-21 17:09:23 +00:00
Ehsan Akhgari
0189ad92c7 Bug 1507353 - Convert the accesses to security.insecure_connection_*.* prefs into lazy getters r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D11968
2018-11-20 20:04:14 +00:00
James Teh
7ac659d370 Bug 1506503: PanelMultiView: Automatically focus the first item if a panel is opened via the keyboard. r=johannh,paolo
Previously, we had specific code to do this for the "View site information" button (#identity-box) when activated via the keyboard.
To work well for keyboard and screen reader users, all such popups (e.g. Firefox menu, Page Actions, etc.) should do this.
These are all based on panelMultiView.
The arguments passed to PanelMultiView.openPopup can include the event which triggered the popup.
We now use this to detect keypress events and focus the first item in the panel in that case.

Differential Revision: https://phabricator.services.mozilla.com/D11605
2018-11-16 22:51:59 +00:00
Johann Hofmann
aac16516bb Bug 1484251 - Part 3 - Use Telemetry events to record interactions in the identity popup. r=Gijs
This removes the old TRACKING_PROTECTION_EVENTS probe and replaces it with new
Telemetry events that record basic user interaction in the identity popup.

We are now measuring interaction with more elements than before, not just block/unblock.

We're also dropping the old way of measuring updates to onSecurityChange,
since with the recent changes to content blocking it would just record most page loads.

Differential Revision: https://phabricator.services.mozilla.com/D6895
2018-10-11 13:13:58 +00:00
Johann Hofmann
8b3b7bd837 Bug 1476220 - Show a "site information" header in the identity popup. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D7090
2018-10-09 13:47:13 +00:00
Narcis Beleuzu
daeaf1aece Backed out changeset 015250ccee42 (bug 1476220) for causing en-US failures on identity-popup-host 2018-10-09 13:07:09 +03:00
Johann Hofmann
ffea729963 Bug 1476220 - Show a "site information" header in the identity popup. r=paolo
Differential Revision: https://phabricator.services.mozilla.com/D7090
2018-10-09 09:11:01 +00:00
Dipen Patel
fbf2d8d5d9 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=Gijs,snorp,jcj,mcmanus,sfraser,keeler,baku,ato
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704
2018-09-11 00:07:30 +00:00
Csoregi Natalia
4c04e1f45b Backed out changeset bd8baf88f373 (bug 1468222) for test_security-info-parser.js failures. CLOSED TREE 2018-09-08 03:16:25 +03:00
Dipen Patel
8e9fd08fb5 Bug 1468222 Consolidate nsISSLStatus info nsITransportSecurityInfo r=snorp,ato,sfraser,keeler,baku,mcmanus,Gijs
Move all fields of nsISSLStatus to nsITransportSecurityProvider
Remove nsISSLStatus interface and definition
Update all code and test references to nsISSLStatus
Maintain ability to read in older version of serialized nsISSLStatus.  This
is verified with psm_DeserializeCert gtest.

Differential Revision: https://phabricator.services.mozilla.com/D3704
2018-09-07 22:50:17 +00:00
Mark Banner
462116b7f9 Bug 1486739 - Add missing dangling commas in browser/, services/, taskcluster/ and toolkit/. r=mossop
Automatic changes by ESLint, except for manual corrections for .xml files.

Differential Revision: https://phabricator.services.mozilla.com/D4439
2018-08-31 05:59:17 +00:00
Dale Harvey
d9d889d663 Bug 1476555 - Show notification when autoplay blocked globally. r=cpearce,johannh
MozReview-Commit-ID: EI0GiaoBNqX
2018-07-23 16:43:08 +01:00
Paolo Amadini
e3ef4b43ed Bug 1480082 - Remove broadcasters from the identity panel. r=johannh
MozReview-Commit-ID: DOBK86SAs3q
2018-08-01 13:51:39 +01:00
Dave Townsend
7c2cace29b Bug 1479050: Migrate a number of call-sites to use document.createXULElement. r=bgrins
Differential Revision: https://phabricator.services.mozilla.com/D2489
2018-07-31 19:13:38 +00:00
Paolo Amadini
5bfedd8bf1 Bug 1473748 - Part 1 - Use the type of element instead of the "subviewbutton" and "subviewkeynav" classes to initialize the list of navigable elements. r=johannh
MozReview-Commit-ID: IgxwGRNLsct
2018-07-26 14:58:43 +01:00
Dipen Patel
54148735a5 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL
2018-07-13 11:48:55 -07:00
Andreea Pavel
f6396a98eb Backed out changeset c235d6f86c22 (bug 1475647) for breaking firefox ui at testing/firefox-ui/tests/puppeteer/test_tabbar.py on a CLOSED TREE 2018-07-25 19:34:58 +03:00
Dipen Patel
b987e41d2e Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL
2018-07-13 11:48:55 -07:00
shindli
376051d773 Backed out changeset d126a6593e8f (bug 1475647) for mozmake.exe bustage on a CLOSED TREE 2018-07-24 02:55:53 +03:00
Dipen Patel
3a1015c4e6 Bug 1475647 - Remove nsISSLStatusProvider interface. r=baku,Gijs,jchen,jryans,keeler,mcmanus
- Access nsISSLStatus directly as a member of nsITransportSecurityInfo
and nsISecureBrowserUI.  This is part of a larger effort to consolidate
nsISSLStatus and nsITransportSecurityInfo.
- The TabParent implementation of GetSecInfo will always return null.
- Removed unnecessary QueryInterface calls
- Style adherence updates

MozReview-Commit-ID: Dzy6t2zYljL
2018-07-13 11:48:55 -07:00
Johann Hofmann
bfdb0dd5e0 Bug 1467385 - Use PanelMultiView APIs for keyboard navigation in the identity popup. r=Paolo
PanelMultiView has its own concept of "selected", so we should use this rather than move focus
using advanceFocusIntoSubTree.

MozReview-Commit-ID: DW2JqqggLl1
2018-07-02 14:34:25 +02:00
James Teh
587bc7aedf Bug 1473200: Provide accessibility context for permission controls in the identity popup. r=johannh
The containers are given an ARIA role of group and labels are associated using aria-labelledby.
For example, this allows screen reader users to know which permission each control is associated with.
Otherwise, they might hear only "Clear this permission and ask again  button", with no knowledge of what the permission is.

MozReview-Commit-ID: LeiOmz6go9l
2018-07-04 12:13:51 +10:00
James Teh
e058a35408 Bug 1473199: Make permission controls tabbable again in the identity popup. r=johannh
Now that the PanelMultiView keyboard navigation code is being used for the identity popup, these need a class of subviewkeynav in order to be tabbable.

MozReview-Commit-ID: 47drdy78s4F
2018-07-04 12:24:40 +10:00
Dale Harvey
f28e841657 Bug 1461656 - Ask permission when site wants to autoplay media. r=flod,johannh
MozReview-Commit-ID: Fc2IUZK90eu
2018-05-18 12:54:33 +01:00
Johann Hofmann
afbf74cb67 Bug 1462471 - Link to permission preferences from the identity popup permissions section. r=prathiksha
MozReview-Commit-ID: 4XNBfztgWOG
2018-06-01 23:17:52 +02:00
Johann Hofmann
f36133f213 Bug 1462469 - Add a "Clear Cookies and Site Data" footer button to the identity popup. r=nhnt11
This implements a new button in the identity popup that allows users to quickly
remove cookies and site data from the sites they're visiting.

This uses the SiteDataManager behind the scenes and is similar to the changes
we made for PageInfo already.

There's a major drawback to this approach in that SiteDataManager needs to
refresh its entire data set everytime we want information about a single site
or want to remove anything (it's not trivial to get rid of that limitation while
dealing with all the quirks of our storage APIs). I will work around this by
implementing a way for SiteDataManager to incrementally update itself in bug 1460768.

MozReview-Commit-ID: Iy7ia0KllFq
2018-05-18 11:36:15 +02:00