Commit Graph

382 Commits

Author SHA1 Message Date
Florian Quèze
bf9d1afd1e Bug 1921012 - Remove unreferenced telemetry event security.ui.app_menu, r=chutten,firefox-desktop-core-reviewers .
Differential Revision: https://phabricator.services.mozilla.com/D223598
2024-09-26 20:40:44 +00:00
Gregory Pappas
49494b7cae Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D219834
2024-09-24 23:45:09 +00:00
Butkovits Atila
e9a321c37b Backed out changeset 76c285a906b6 (bug 71895) as requested by dev. CLOSED TREE 2024-09-24 12:28:38 +03:00
Jared Hirsch
d8e226be55 Bug 1886001, bug 1918175 - Create the profile deletion page and populate with data. r=niklas,mossop,fluent-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D222033
2024-09-23 19:05:06 +00:00
Florian Quèze
7b21b6a22d Bug 1920228 - Only call BrowserUsageTelemetry.reportInstallationTelemetry on Windows, r=firefox-desktop-core-reviewers ,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D222999
2024-09-21 06:38:18 +00:00
Florian Quèze
9e3dbc3fba Bug 1918702 - Migrate telemetry events to use Glean APIs in browser/components/BrowserGlue.sys.mjs, r=chutten,firefox-desktop-core-reviewers ,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D222166
2024-09-20 13:58:14 +00:00
Florian Quèze
8aee9b101f Bug 1918702 - Migrate telemetry events to use Glean APIs for pictureinpicture.settings, r=chutten,settings-reviewers,pip-reviewers,firefox-desktop-core-reviewers ,mconley.
Differential Revision: https://phabricator.services.mozilla.com/D222128
2024-09-20 13:58:13 +00:00
Gregory Pappas
7bb2622a0a Bug 71895 - Create the hidden window on macOS only r=firefox-desktop-core-reviewers ,mossop
Differential Revision: https://phabricator.services.mozilla.com/D219834
2024-09-20 00:54:07 +00:00
Gijs Kruitbosch
d4b4962785 Bug 1913704 - remove pioneer/ion now that it's been retired, r=rhelmer,chutten,firefox-desktop-core-reviewers ,extension-reviewers,desktop-theme-reviewers,emilio,mossop,robwu
Differential Revision: https://phabricator.services.mozilla.com/D220751
2024-09-19 13:32:22 +00:00
Niklas Baumgardner
f5fc2f4c0f Bug 1885999 - Create about:editprofile page. r=jhirsch,mossop,fluent-reviewers,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221714
2024-09-18 00:04:14 +00:00
Dana Keeler
cd6d7aa50b Bug 1918455 - collect telemetry for how often TLS key logging has been enabled via SSLKEYLOGFILE r=Gijs,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D222003
2024-09-17 21:39:11 +00:00
Florian Quèze
7346c45e51 Bug 1917838 - Remove expired telemetry event close_tab_warning.shown, r=chutten,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao.
Differential Revision: https://phabricator.services.mozilla.com/D221650
2024-09-12 13:42:22 +00:00
Micah Tigley
a22f833a97 Bug 1917709 - Rename megalist pref to contextual-password-manager. r=issammani,rsafaeian,firefox-desktop-core-reviewers ,sidebar-reviewers,dao,jsudiaman
Differential Revision: https://phabricator.services.mozilla.com/D221554
2024-09-11 16:02:02 +00:00
Gregory Pappas
68146534c6 Bug 1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers
This was added in bug 1275942, which added the --wait-for-jsdebugger option.
I think it's not necessary because BrowserGlue.sys.mjs is loaded before
"command-line-handler" category runs[1], so the early blank window will
have already opened before DevToolsStartup.handleDebuggerFlag spins the
event loop[2].

Currently, the early blank window is not enabled on all platforms and
can be disabled by pref. To make it reliable for DevTools use, we will
forcefully create the early blank window regardless of OS or pref when
--wait-for-jsdebugger is passed to the application. I tested this patch
on macOS (where the early blank window is not enabled) and it works well.


[1] https://searchfox.org/mozilla-central/rev/3f193a8bb0759058c2f9a9d7761ad73bc6ffd4b1/toolkit/xre/nsAppRunner.cpp#5571-5573,5734-5737
[2] https://searchfox.org/mozilla-central/rev/1d4c27f9f166ce6e967fb0e8c8d6e0795dbbd12e/devtools/startup/DevToolsStartup.sys.mjs#1011,1037-1043

Differential Revision: https://phabricator.services.mozilla.com/D220171
2024-08-29 08:18:48 +00:00
Stanca Serban
70d11b2cc5 Backed out changeset e04c427060e1 (bug 1915014) for causing OS X mochitests failures in browser_startup.js. 2024-08-29 09:54:16 +03:00
Gregory Pappas
d9ef635fd7 Bug 1915014 - Remove fallback to hidden window in ParentProcessTargetActor._getInitialDocShell r=ochameau,firefox-desktop-core-reviewers
This was added in bug 1275942, which added the --wait-for-jsdebugger option.
I think it's not necessary because BrowserGlue.sys.mjs is loaded before
"command-line-handler" category runs[1], so the early blank window will
have already opened before DevToolsStartup.handleDebuggerFlag spins the
event loop[2].

Currently, the early blank window is not enabled on all platforms and
can be disabled by pref. To make it reliable for DevTools use, we will
forcefully create the early blank window regardless of OS or pref when
--wait-for-jsdebugger is passed to the application. I tested this patch
on macOS (where the early blank window is not enabled) and it works well.


[1] https://searchfox.org/mozilla-central/rev/3f193a8bb0759058c2f9a9d7761ad73bc6ffd4b1/toolkit/xre/nsAppRunner.cpp#5571-5573,5734-5737
[2] https://searchfox.org/mozilla-central/rev/1d4c27f9f166ce6e967fb0e8c8d6e0795dbbd12e/devtools/startup/DevToolsStartup.sys.mjs#1011,1037-1043

Differential Revision: https://phabricator.services.mozilla.com/D220171
2024-08-28 17:42:15 +00:00
Chris
11abd33f53 Bug 1583811 - Middle clicking email address now opens account page in new tab. r=credential-management-reviewers,firefox-desktop-core-reviewers ,mossop,issammani
Differential Revision: https://phabricator.services.mozilla.com/D218499
2024-08-28 04:00:50 +00:00
Iulian Moraru
88732149c4 Backed out changeset 2ee7eb9d554a (bug 1583811) for causing bc failures on browser_fxAccounts.js. CLOSED TREE 2024-08-25 15:16:24 +03:00
Chris
a47b799741 Bug 1583811 - Middle clicking email address now opens account page in new tab. r=credential-management-reviewers,firefox-desktop-core-reviewers ,mossop,issammani
Differential Revision: https://phabricator.services.mozilla.com/D218499
2024-08-25 10:46:43 +00:00
Gijs Kruitbosch
0862e0ea1e Bug 1879550 - allow using image-set for prompt icons to cater for dpi differences, r=dao,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D219738
2024-08-21 13:20:51 +00:00
Florian Quèze
2cd7e2596a Bug 1913624 - Remove expired telemetry histogram AUTOPLAY_DEFAULT_SETTING_CHANGE, r=chutten,firefox-desktop-core-reviewers .
Depends on D219441

Differential Revision: https://phabricator.services.mozilla.com/D219442
2024-08-20 10:26:51 +00:00
Florian Quèze
887590c978 Bug 1913624 - Remove expired telemetry histograms PERMISSION_REQUEST_ORIGIN_SCHEME and PERMISSION_REQUEST_HANDLING_USER_INPUT, r=chutten,firefox-desktop-core-reviewers .
Depends on D219437

Differential Revision: https://phabricator.services.mozilla.com/D219438
2024-08-20 10:26:50 +00:00
Nipun Shukla
9044371423 Bug 1794159 - Part 3: Enable MSIX pinning in nsWindowsShellService r=nrishel,nalexander,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D217763
2024-08-12 17:05:48 +00:00
Stephen Thompson
ac28601c38 Bug 1901308 - Show profile backup errors and keep modals open r=backup-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,mconley,bolsson
Currently, clicking "confirm" buttons on modals in the profile backup settings menu will always close the modals regardless of whether the operation succeeded or failed. In the case of errors, users don't know that something went wrong. It's better to keep the modals open and display an error so that the user knows what to do next and can try to fix the issue, if applicable.

Differential Revision: https://phabricator.services.mozilla.com/D218358
2024-08-06 18:21:16 +00:00
Narcis Beleuzu
e69542173f Backed out changeset bd72ed21a114 (bug 1901308) for Doc failure on BackupUIChild.sys . CLOSED TREE 2024-08-06 20:46:23 +03:00
Stephen Thompson
1b8f32ff12 Bug 1901308 - Show profile backup errors and keep modals open r=backup-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,mconley,bolsson
Currently, clicking "confirm" buttons on modals in the profile backup settings menu will always close the modals regardless of whether the operation succeeded or failed. In the case of errors, users don't know that something went wrong. It's better to keep the modals open and display an error so that the user knows what to do next and can try to fix the issue, if applicable.

Differential Revision: https://phabricator.services.mozilla.com/D218358
2024-08-06 14:56:53 +00:00
Sammy Khamis
994493e803 Bug 1909783: Synced tabs list should de-dupe r=markh,fxview-reviewers,sync-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Differential Revision: https://phabricator.services.mozilla.com/D217700
2024-07-26 20:31:03 +00:00
Ed Lee
1dd2819331 Bug 1905750 - Stub actors and panel to display content-area shortcuts on text selection r=tarek,desktop-theme-reviewers,tabbrowser-reviewers,firefox-desktop-core-reviewers ,dao
Add default false shortcuts pref to control GenAI actors initially detecting text selection. Prepare content-area elements that stack on top of tab's browser.

Differential Revision: https://phabricator.services.mozilla.com/D217544
2024-07-26 07:22:59 +00:00
Kagami Sascha Rosylight
95045a3f87 Bug 1908108 - Replace TelemetryUtils.isTelemetryEnabled with inline pref reading r=chutten,firefox-desktop-core-reviewers ,mak
Differential Revision: https://phabricator.services.mozilla.com/D217612
2024-07-25 09:40:34 +00:00
Nipun Shukla
415fe6c69b Bug 1905090 - Update strings to reflect MSIX pin to start functionality r=fluent-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,mak,mviar
Differential Revision: https://phabricator.services.mozilla.com/D216709
2024-07-24 21:13:36 +00:00
Nipun Shukla
8d8dd02d0f Bug 1901621 - Use start menu pinning as targeting for messages r=aminomancer,omc-reviewers,firefox-desktop-core-reviewers ,pdahiya,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D213158
2024-07-24 21:13:35 +00:00
Nipun Shukla
93c6531ceb Bug 1900035 - Added Windows start menu pinning to MSIX set-to-default and taskbar pinning scenarios r=omc-reviewers,firefox-desktop-core-reviewers ,Gijs,mpohle,aminomancer,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D212461
2024-07-24 21:13:35 +00:00
Karandeep
b207f35b42 Bug 1903633 - Integrate the UrlbarSearchTermsPersistence component with remote setting. r=jteow,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D215777
2024-07-23 12:14:44 +00:00
Gijs Kruitbosch
a295abd9b9 Bug 1908312 - Make it clear in about:preferences that PPA is disabled when telemetry is disabled, r=bgrins,settings-reviewers,firefox-desktop-core-reviewers ,mossop
Right now the UI state for PPA remains checked and active even when the main telemetry
setting is disabled. This is confusing UX, since DAP submission is disabled when
telemetry is disabled.

Also migrate off the deprecated toolkit-private isTelemetryEnabled() accessor to the normal pref check.

Differential Revision: https://phabricator.services.mozilla.com/D216801
2024-07-17 16:00:47 +00:00
Alexandre Lissy
5d8765d4fa Bug 1899516 - Warn user when missing unprivileged user namespace r=firefox-desktop-core-reviewers ,fluent-reviewers,Gijs,flod
Differential Revision: https://phabricator.services.mozilla.com/D212024
2024-07-15 12:11:54 +00:00
Mike Conley
a44f7c8ceb Bug 1904925 - Fill out more of the backup-settings reusable component. r=backup-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,flod,kpatenio
This exposes some UI to show the most recent backup timestamp
and location (if a recent backup exists), and buttons to show
that location, and to edit the location.

Differential Revision: https://phabricator.services.mozilla.com/D215543
2024-07-10 15:38:46 +00:00
Ray Kraesig
7a0df6b4c8 Bug 1884426 - [3/6] Implement file-picker-crashed UI message r=Gijs,win-reviewers,fluent-reviewers,firefox-desktop-core-reviewers ,flod,gstoll
Fire a signal (via the observer service) when the file-dialog crashes or
otherwise fails.

Set up a listener for that signal which reports the failure to the
end-user via the NotificationBox.

Differential Revision: https://phabricator.services.mozilla.com/D214192
2024-07-09 22:16:55 +00:00
kpatenio
c9515e2262 Bug 1893295 - (part 2) make enable-backup-encryption re-run encryption using BackupUI actors and BackupService. r=backup-reviewers,firefox-desktop-core-reviewers ,mconley
Differential Revision: https://phabricator.services.mozilla.com/D214893
2024-06-28 16:55:02 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
2024-06-19 19:45:01 +00:00
kpatenio
d52799a404 Bug 1893301 - Build confirmation dialog element for removing encryption password from backup. r=backup-reviewers,firefox-desktop-core-reviewers ,fluent-reviewers,mconley
This patch adds a new dialog for disabling a backup's password protection.

Steps to test this feature:
1. First ensure that the following prefs are enabled: browser.backup.enabled and browser.backup.preferences.ui.enabled
2. Then ensure that the existing backup for the current profile has encryption enabled (should have enc-state.json)
3. Else, access the debug page (chrome://browser/content/backup/debug.html) to enable encryption
4. Once encryption is enabled, the sensitive data checkbox should be checked in about:settings / about:preferences
5. Clicking the checked checkbox should now show the new dialog for removing password protection
6. If the dialog is confirmed, the checkbox should be unchecked in both the settings/preferences page and the debug page

Other notes:
- If the checkbox is *not* checked, nothing will happen. This is because the dialog for enabling password protection is not yet implemented
- Added tests and Storybook entries as well

Figma: https://www.figma.com/design/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=147-4568&t=9NNUojWMeOLwe3rD-0

Differential Revision: https://phabricator.services.mozilla.com/D213171
2024-06-19 17:36:01 +00:00
Ed Lee
e16e2c3f1c Bug 1903444 - Detect provider change to auto-open sidebar r=tarek,firefox-desktop-core-reviewers
Add startup init to detect pref changes.

Differential Revision: https://phabricator.services.mozilla.com/D214207
2024-06-19 17:01:12 +00:00
Mike Conley
b8652840e3 Bug 1889123 - Add a ping / metrics to help measure accounts usage. data-review=mreid, r=markh,firefox-desktop-core-reviewers ,data-stewards,chutten
Differential Revision: https://phabricator.services.mozilla.com/D206820
2024-06-18 14:15:28 +00:00
Sammy Khamis
d62c97561b Bug 1900513: Notifications for closing remote tabs r=lina,markh,fluent-reviewers,firefox-desktop-core-reviewers ,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D212500
2024-06-17 23:14:38 +00:00
Gijs Kruitbosch
b690d00da5 Bug 1054947 - Also check prefs.js last modified time before showing profile reset notification after a long absence, r=mossop,firefox-desktop-core-reviewers ,mconley,glandium
Differential Revision: https://phabricator.services.mozilla.com/D212960
2024-06-14 22:35:40 +00:00
Sandor Molnar
0c56720629 Backed out changeset 21855963319c (bug 1900513) for causing bc failures @ browser_device_connected.js CLOSED TREE 2024-06-14 23:52:19 +03:00
Sammy Khamis
ab89b65a7d Bug 1900513: Notifications for closing remote tabs r=lina,markh,fluent-reviewers,firefox-desktop-core-reviewers ,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D212500
2024-06-14 19:17:44 +00:00
Fred Chasen
112102e74a Bug 1894020 - Build dialog for restoring from a backup file. r=backup-reviewers,fluent-reviewers,bolsson,mconley
- Adds button in the preferences backup settings to restore from a backup file.
- Adds a dialog component `restore-from-backup` which will open a filepicker to select a HTML backup file to restore from, show the backup's date and prompt to input a password if needed.
- Adds a stub `getBackupInfo` event to eventually return metadata and config JSON from `sampleArchive` in Bug 1901132.

Does not yet implement:
- Expanding the input to fit multiline files names.
- Restoring the selected backup file.

Figma: https://www.figma.com/design/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=147-8701&t=zvoykS3OusX9YVCv-4

Differential Revision: https://phabricator.services.mozilla.com/D211248
2024-06-14 15:39:05 +00:00
Eric Chen
35224d47a5 Bug 1901840 - restore browser.privateWindowSeparation.enabled pref r=nshukla,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D213651
2024-06-14 14:47:04 +00:00
Gijs Kruitbosch
99908892c1 Bug 1901899 - exempt primary password users from startup OS reauth migration r=firefox-desktop-core-reviewers ,credential-management-reviewers,ssachdev
Differential Revision: https://phabricator.services.mozilla.com/D213574
2024-06-13 15:27:30 +00:00
kpatenio
56fdf83248 Bug 1895943 - Implement file picker and save location for backups. r=backup-reviewers,fluent-reviewers,flod,firefox-desktop-core-reviewers
Patch by kpatenio <kpatenio@mozilla.com>.

1. Allows for selecting a custom path or the default (Documents) path for saving backups. The selection is passed from the "turn-on-scheduled-backups" dialog to "BackupService".
2. After pressing the "Choose" button in the dialog, a filepicker will appear so that a folder can be selected.
3. Once the dialog is confirmed, the absolute path is saved to a pref called "browser.backup.location" and saved in the service state.

Other changes:
- Added the Documents folder as the default save location
- Added an onUpdate function for "browser.backup.location" that passes the updated BackupService state to registered widgets (backup settings section, dialogs)
- Added Storybook entries and tests for the newly updated input and filepicker

Figma: https://www.figma.com/design/vNbX4c0ws0L1qr0mxpKvsW/Fx-Backup?node-id=147-4568&t=tILUMKfg8c6Ed1Ul-0 (turn on backup dialog)

Differential Revision: https://phabricator.services.mozilla.com/D210850
2024-06-12 17:36:52 +00:00