corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
760,537 Commits 1 Branch 0 Tags
bc09027cd87fedcb4bdce91a282a9045bc4522e8
Commit Graph

1091 Commits

Author SHA1 Message Date
Mike Conley
810d9bf588 Bug 1795780 - Add the ability to disable a browser migrator at runtime via a pref. r=NeilDeakin,Gijs 
It seems that at build time, we already make decisions about what migrators we register
with XPCOM in browser/components/migration/components.conf. This doesn't, however, give
us the ability to turn off a migrator that happens to be misbehaving, nor make it easy
for us to do development of a new migrator without exposing it to the migration dialog
(without doing binary recompiles).

This adds another layer to the enable-ment of our migrators so that they must both
be registered AND enabled in order to appear in the import dialog.

Differential Revision: https://phabricator.services.mozilla.com/D159544
 2022-10-19 14:48:46 +00:00
Mark Banner
5407bdffa8 Bug 1792341 - Migrate more toolkit/modules consumers to use direct ES module import. r=Gijs,webdriver-reviewers,perftest-reviewers,necko-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,sgalich,owlish,bytesized,AlexandruIonescu,whimboo,mconley,mixedpuppy 
Mainly automated changes. Some manual ESLint fixes and whitespace cleanup.

Differential Revision: https://phabricator.services.mozilla.com/D158452
 2022-10-18 11:21:26 +00:00
Emilio Cobos Álvarez
7fb28de591 Bug 1793355 - Fix dialog sizing when dialog is bigger than specified min-width. r=aminomancer 
Before bug 1792730, we didn't look at style.minWidth, even though this
dialog used it (but contents can be larger).

Using scrollWidth is the right thing to do here. Also fix some other
hard-coded widths I found while at it.

Differential Revision: https://phabricator.services.mozilla.com/D158462
 2022-10-07 08:40:23 +00:00
Henrik Skupin
9320c5804e Bug 1141335 - [marionette] Use in_app by default for quit() and restart(). r=webdriver-reviewers,jdescottes,perftest-reviewers,AlexandruIonescu 
Hereby the "in_app" argument is required to be specified in case some
other argument eg. "clean" requires a termination of the application.

Differential Revision: https://phabricator.services.mozilla.com/D157219
 2022-10-04 09:04:25 +00:00
Butkovits Atila
cc79c082db Backed out changeset 3e220bf19d7b (bug 1141335) for causing failures at awsy/test_memory_usage.py. CLOSED TREE 2022-09-30 02:12:58 +03:00
Henrik Skupin
8ffaf35609 Bug 1141335 - [marionette] Use in_app by default for quit() and restart(). r=webdriver-reviewers,jdescottes 
Hereby the "in_app" argument is required to be specified in case some
other argument eg. "clean" requires a termination of the application.

Differential Revision: https://phabricator.services.mozilla.com/D157219
 2022-09-29 18:34:25 +00:00
Mark Banner
a49b8ef78f Bug 1792365 - Convert toolkit/modules consumers to use ES module imports directly. r=webdriver-reviewers,perftest-reviewers,geckoview-reviewers,extension-reviewers,preferences-reviewers,desktop-theme-reviewers,application-update-reviewers,pip-reviewers,credential-management-reviewers,robwu,Gijs,sgalich,bytesized,AlexandruIonescu,dao,m_kato 
Differential Revision: https://phabricator.services.mozilla.com/D158094
 2022-09-29 06:52:34 +00:00
Tooru Fujisawa
769ca13218 Bug 1779988 - Part 1: Merge multiple ChromeUtils.defineESModuleGetters calls into one. r=Standard8 
Differential Revision: https://phabricator.services.mozilla.com/D152879
 2022-07-28 00:54:20 +00:00
Mark Banner
d026f430f6 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 22:34:21 +00:00
smolnar
ee079d37e2 Backed out 8 changesets (bug 1779982, bug 1780017, bug 1780347) for causing doc generate failures. CLOSED TREE 
Backed out changeset 3f22c0f99cf1 (bug 1780347)
Backed out changeset 6f20b7e4b21b (bug 1780017)
Backed out changeset ae6062c69aeb (bug 1780017)
Backed out changeset e668d7778d97 (bug 1780017)
Backed out changeset e158fc41594b (bug 1780017)
Backed out changeset d4c69c956271 (bug 1779982)
Backed out changeset 145212fd826d (bug 1779982)
Backed out changeset 54079aaa1857 (bug 1779982)
 2022-07-20 22:43:53 +03:00
Mark Banner
8715b062f5 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 15:50:40 +00:00
Iulian Moraru
bc13570de5 Backed out 7 changesets (bug 1779982, bug 1780017) for causing multiple failures. CLOSED TREE 
Backed out changeset f33a58aa2f3f (bug 1780017)
Backed out changeset e21c85d61b91 (bug 1780017)
Backed out changeset 213ee5578e7c (bug 1780017)
Backed out changeset ea9b3bf42ea1 (bug 1780017)
Backed out changeset d2d8530f3c4d (bug 1779982)
Backed out changeset 088e5148c307 (bug 1779982)
Backed out changeset 267e08f3868a (bug 1779982)
 2022-07-20 15:44:53 +03:00
Mark Banner
2bd76952c1 Bug 1779982 - Migrate places consumers to use ESM imports directly. r=mak,preferences-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D152005
 2022-07-20 10:36:49 +00:00
Tooru Fujisawa
328d63ce7f Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-12 04:21:34 +00:00
Andreea Pavel
f009ba2983 Backed out 11 changesets (Bug 1777486) for failing bc at browser_startup.js on a CLOSED TREE 
Backed out changeset b6c4c386f1a6 (Bug 1777486)
Backed out changeset 195cc2de8433 (Bug 1777486)
Backed out changeset 20c746fb1648 (Bug 1777486)
Backed out changeset d5fd8173d62d (Bug 1777486)
Backed out changeset 6d758fab5a3e (Bug 1777486)
Backed out changeset e938b601ba15 (Bug 1777486)
Backed out changeset 0c4ea0b9416b (Bug 1777486)
Backed out changeset 0559c53cc668 (Bug 1777486)
Backed out changeset eea573d3a9f9 (Bug 1777486)
Backed out changeset 9ce3a6496a49 (bug 1777486)
Backed out changeset b0867652fc48 (bug 1777486)
 2022-07-11 22:24:40 +03:00
Tooru Fujisawa
bf0a8b781b Bug 1777486 - Part 2: Migrate XPCOMUtils.jsm consumers with automatic migration. r=webdriver-reviewers,geckoview-reviewers,preferences-reviewers,application-update-reviewers,pip-reviewers,kmag,owlish,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D151214
 2022-07-11 15:09:13 +00:00
Tooru Fujisawa
48c568867c Bug 1667455 - Part 5: Stop importing Services.jsm from chrome-priv JS code, top-level single-line cases. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,application-update-reviewers,pip-reviewers,twisniewski,m_kato,jdescottes,mconley,AlexandruIonescu,mossop 
Differential Revision: https://phabricator.services.mozilla.com/D150894
 2022-07-11 12:41:50 +00:00
Tooru Fujisawa
b10d0289af Bug 1667455 - Part 4: Stop importing Services.jsm from JSM. r=kmag,webdriver-reviewers,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,application-update-reviewers,pip-reviewers,twisniewski,devtools-reviewers,m_kato,jdescottes,ochameau,mconley,sfoster,AlexandruIonescu 
Differential Revision: https://phabricator.services.mozilla.com/D150893
 2022-07-11 12:41:50 +00:00
Tooru Fujisawa
1862091f08 Bug 1776837 - Part 1: Do not use lazy getter for eagerly loaded modules. r=mossop,webdriver-reviewers,application-update-reviewers,jdescottes 
Differential Revision: https://phabricator.services.mozilla.com/D150935
 2022-07-05 01:01:34 +00:00
Mark Banner
f733d566c8 Bug 1646183 - Extend ESLint rule reject-importGlobalProperties to also handle defineLazyGlobalGetters. r=arai,webdriver-reviewers,webcompat-reviewers,extension-reviewers,whimboo,twisniewski,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D150353
 2022-06-29 22:37:57 +00:00
Tooru Fujisawa
005cb01ee5 Bug 1773747 - Part 1: Do not use lazy getter for immediately-used symbol in browser/components/. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D149986
 2022-06-24 11:03:52 +00:00
Joel Maher
5d7fe68032 Bug 1769154 - Run some xpcshell tests with a conditioned profile. r=aryx,extension-reviewers,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D149937
 2022-06-22 16:47:06 +00:00
Bogdan Szekely
72726c29d0 Backed out changeset 7b707ff8a7d1 (bug 1769154) for causing xpcshell failures on test_system_upgrades.js 2022-06-22 17:17:10 +03:00
Joel Maher
c0af767fd4 Bug 1769154 - Run some xpcshell tests with a conditioned profile. r=aryx,extension-reviewers,kmag 
Differential Revision: https://phabricator.services.mozilla.com/D149937
 2022-06-22 13:03:46 +00:00
Tooru Fujisawa
8f9bf2f553 Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag 
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
 2022-06-16 00:19:54 +00:00
Butkovits Atila
0642580e74 Backed out 4 changesets (bug 1608282) for causing hazard failures. CLOSED TREE 
Backed out changeset 32aebc8be201 (bug 1608282)
Backed out changeset 37c970364269 (bug 1608282)
Backed out changeset ced8d82cc2d2 (bug 1608282)
Backed out changeset e26e480c7dd6 (bug 1608282)
 2022-06-16 03:10:02 +03:00
Tooru Fujisawa
f094b522e1 Bug 1773829 - Part 3: Stop using lazy getter unnecessarily in browser/components/. r=MattN 
Depends on D149011

Differential Revision: https://phabricator.services.mozilla.com/D149012
 2022-06-15 20:56:23 +00:00
Tooru Fujisawa
a4b321722f Bug 1608282 - Part 3: Remove Cu.importGlobalProperties from JSM. r=extension-reviewers,kmag 
Depends on D149195

Differential Revision: https://phabricator.services.mozilla.com/D149196
 2022-06-15 20:34:35 +00:00
Tooru Fujisawa
754211aed1 Bug 1772100 - Part 9: Use plain object for lazy getter in browser/components/migration/. r=MattN 
Differential Revision: https://phabricator.services.mozilla.com/D148019
 2022-06-06 22:46:22 +00:00
Tooru Fujisawa
ebcb6dfd9c Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148168
 2022-06-06 04:42:10 +00:00
Tooru Fujisawa
f947410342 Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 04:42:09 +00:00
Tooru Fujisawa
3e483c26e8 Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148160
 2022-06-06 04:42:06 +00:00
Molnar Sandor
4c2b06df41 Backed out 15 changesets (bug 1772313, bug 1772351, bug 1772360) for causing xpc failures in telemetry/tests/unit/test_SocketScalars.js CLOSED TREE 
Backed out changeset c8b0a2ed239e (bug 1772360)
Backed out changeset 1922adad6abe (bug 1772351)
Backed out changeset 6d3634cce489 (bug 1772351)
Backed out changeset f03968a9d053 (bug 1772351)
Backed out changeset e7a38ef90fe4 (bug 1772351)
Backed out changeset b389e7654771 (bug 1772313)
Backed out changeset 59a33598ff51 (bug 1772313)
Backed out changeset ab60885a8a93 (bug 1772313)
Backed out changeset aad8efac9d05 (bug 1772313)
Backed out changeset 4378e519a8e7 (bug 1772313)
Backed out changeset 302ac54741f8 (bug 1772313)
Backed out changeset 74c59f9fd51c (bug 1772313)
Backed out changeset 575fb877c56c (bug 1772313)
Backed out changeset 2eaa68f10b19 (bug 1772313)
Backed out changeset 4a8b3ba193dc (bug 1772313)
 2022-06-06 07:04:25 +03:00
Tooru Fujisawa
81758ebac5 Bug 1772360 - Remove unnecessary call for XPCOMUtils.defineLazyGlobalGetters. r=florian,webdriver-reviewers,webcompat-reviewers,denschub,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148168
 2022-06-06 02:49:14 +00:00
Tooru Fujisawa
b580e51d8f Bug 1772351 - Part 3: Stop calling XPCOMUtils.defineLazyModuleGetters for AppConstants. r=florian,webdriver-reviewers,whimboo,robwu 
Differential Revision: https://phabricator.services.mozilla.com/D148166
 2022-06-06 02:49:13 +00:00
Tooru Fujisawa
c98ea942de Bug 1772313 - Part 7: Stop calling XPCOMUtils.defineLazyModuleGetters for Services. r=kmag,webdriver-reviewers,whimboo 
Differential Revision: https://phabricator.services.mozilla.com/D148160
 2022-06-06 02:49:10 +00:00
Tooru Fujisawa
bd81453bd5 Bug 1610653 - Part 14: Do not store lexical variable also to global this property in browser/modules. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D144121
 2022-05-30 15:19:40 +00:00
Tooru Fujisawa
bb3f11cf65 Bug 1765167 - Part 1: Stop using Cu.import in browser/. r=mossop 
Differential Revision: https://phabricator.services.mozilla.com/D144094
 2022-05-03 06:32:29 +00:00
Andreas Farre
658f0a9dbf Bug 1752143 - Wait for SSTabRestored before checking test result. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D137043
 2022-04-19 14:58:42 +00:00
Jari Jalkanen
eb54d47215 Bug 1760074 - Report when error causing retry changes. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D142322
 2022-04-06 06:02:19 +00:00
Jan Rio Krause
3fe00f5de7 Bug 1519200 - Remove NS_ERROR_FILE_TARGET_DOES_NOT_EXIST in favor of NS_ERROR_FILE_NOT_FOUND. r=xpcom-reviewers,nika,dom-storage-reviewers,jstutte 
Differential Revision: https://phabricator.services.mozilla.com/D77575
 2022-04-05 15:17:03 +00:00
Mark Banner
7ea3c792f2 Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-11 16:41:29 +00:00
smolnar
19781d16c7 Backed out changeset 5018856d8fee (bug 1758474) for causing node eslint failure. CLOSED TREE 2022-03-10 11:58:45 +02:00
Mark Banner
de1754318e Bug 1758474 - Implement an ESLint rule to disallow passing {} as the target parameter for ChromeUtils.import. r=Gijs,mossop,perftest-reviewers,preferences-reviewers,sparky 
Differential Revision: https://phabricator.services.mozilla.com/D140517
 2022-03-10 09:25:28 +00:00
Mark Banner
e2ac59ac05 Bug 1758090 - Stop using ChromeUtils.import(..., null) for importing modules in browser/. r=Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D140319
 2022-03-08 16:59:18 +00:00
Julian Descottes
95a8494b19 Bug 1371576 - [marionette] Avoid connections during marionette tests r=webdriver-reviewers,whimboo,Gijs 
Depends on D136914

Differential Revision: https://phabricator.services.mozilla.com/D136528
 2022-02-01 06:45:53 +00:00
Nick Alexander
381dd7c640 Bug 1749435 - Use Fluent to localize bookmarks.html at run-time rather than build-time. r=flod,mak,fluent-reviewers 
This modernizes an old part of the build system to not require
build-time localization at all.  That's generally preferable.

The most significant changes to the in-product functionality is to
make import localize HTML so that we can use Fluent's `data-l10n-id`.

The locale used is the user's current locale.  This is different than
the existing approach, which always uses the build-time (repack)
locale.  I believe this is a strictly superior user experience and it
may lead to future improvements where-in the default bookmarks become
truly dynamic and vary with the user's chosen locale rather than being
point-in-time decisions.

I tried to restrict these changes to only applen when we import the
default bookmarks, but I think the various layers of flags no longer
achieve this restriction in practice and the formatting and
localization will apply to all imported `bookmarks.html` files.  Since
we don't anticipate (nor ourselves write) these new things in
(respectively, to) `bookmarks.html`, and the file is already
user-controlled, I don't think this exposes any meaningful change in
functionality (or in security surface).

Some notes:

1) There's no migration of `.inc` -> `.ftl` because this is the lone
   `.inc` file.

2) I elected to prefix all strings with `default-bookmarks-`, since
   the existing names were very short and likely to collide (now or in
   the future).

3) I elected to change the HTML file name for easier searching.

4) Since the `default-bookmarks.html` file is product-specific and the
   existing tests are in `toolkit/`, I elected to not test the file
   directly in automation.

5) We removed the explicit locale (or equivalent `%LOCALE%`) since
   Mozilla properties will redirect to the appropriate language
   automatically.

Differential Revision: https://phabricator.services.mozilla.com/D135816
 2022-01-19 17:02:26 +00:00
Mike Hommey
48e9e01469 Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges 
While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737
 2021-12-30 20:56:43 +00:00
Iulian Moraru
c7b6c03d9d Backed out changeset 7f9b4b6191ad (bug 1747756) for causing multiple failures. CLOSED TREE 2021-12-30 01:59:26 +02:00
Mike Hommey
c20d6f43f8 Bug 1747756 - Move Windows system libraries from LIBS to moz.build. r=firefox-build-system-reviewers,mhentges 
While mingw builds don't require user32 and advapi32 explicitly, it doesn't
hurt for them to be there (and they're required for clang-cl build).
Likewise, while clang-builds don't require uuid and userenv explicitly
because they're pulled in via #pragmas in the source code, mingw doesn't
support those #pragmas and needs them explicitly, which doesn't hurt the
clang-cl builds.

Differential Revision: https://phabricator.services.mozilla.com/D134737
 2021-12-29 22:18:52 +00:00