Commit Graph

180 Commits

Author SHA1 Message Date
Sarah Chung
ccdd8c7af2 Bug 1947182 - update targeting for desktop to mobile adoption message r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D237616
2025-02-10 21:51:11 +00:00
Emily McMinn
8a96646dd7 Bug 1945564 - Update Create Tab Group callout && add new callout for users who have removed the all tabs button r=omc-reviewers,dao,fluent-reviewers,bolsson,mviar
Differential Revision: https://phabricator.services.mozilla.com/D236588
2025-02-06 17:28:08 +00:00
Emily McMinn
b6fec0fc15 Bug 1944344 - Anchor vertical callout to tab strip if active tab is pinned r=omc-reviewers,dao,mviar
Differential Revision: https://phabricator.services.mozilla.com/D236956
2025-02-06 15:38:50 +00:00
Sarah Chung
00af71e19a Bug 1944079 - land desktop to mobile adoption experiment in tree r=omc-reviewers,emcminn,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D236551
2025-02-06 15:14:36 +00:00
Emily McMinn
3a3f5adda0 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D222032
2025-02-05 21:01:41 +00:00
Rebecca King
ddcdf53352 Bug 1938421 - Implement callout 6 for RC in the sidebar, when a user closes RC - r=kpatenio,emcminn,shopping-reviewers,fluent-reviewers,omc-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D235003
2025-02-03 22:55:31 +00:00
Sandor Molnar
603aa1973c Backed out changeset d98b62477b98 (bug 1904441) for causing bc failures & assertion failures @ browser_messagepreview_receivemessage.js / nsContentSecurityUtils.cpp CLOSED TREE 2025-02-03 23:36:24 +02:00
Emily McMinn
b0ba7f9890 Bug 1904441 - Add test suite to about:messagepreview r=omc-reviewers,dmose
Differential Revision: https://phabricator.services.mozilla.com/D222032
2025-02-03 17:18:47 +00:00
Emily McMinn
c749a0b825 Bug 1944103 - Refine targeting for tab groups onboarding messages r=omc-reviewers,dao,jprickett
Differential Revision: https://phabricator.services.mozilla.com/D235698
2025-01-29 22:15:28 +00:00
Dão Gottwald
b377e92246 Bug 1944643 - Dispatch event when saving and closing a group. r=dwalker,tabbrowser-reviewers,omc-reviewers,emcminn
Note that in order to support the callout, we want to dispatch this only when picking "save and close" from the menu.

Differential Revision: https://phabricator.services.mozilla.com/D236020
2025-01-29 19:09:19 +00:00
Emily McMinn
da797a5490 Bug 1943442 - Land onboarding callouts for Tab Groups r=omc-reviewers,aminomancer,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D235376
2025-01-24 21:56:55 +00:00
Meg Viar
7dca8efc49 Bug 1941807 - Add ability to toggle AboutWelcome screen content by clicking a configurable header r=omc-reviewers,jprickett
Support a second variant of the preonboarding modal design by adding the ability to configure a header that toggles visiblity of content tiles.

- See design for [[ https://docs.google.com/presentation/d/1dDC9M9y-W3q90mkVRp4gq3p-x3u7F6qgy0jVeE4MwUw/edit#slide=id.g325219d6753_0_95 | modal Variant B ]]

Differential Revision: https://phabricator.services.mozilla.com/D235325
2025-01-24 13:30:07 +00:00
Punam Dahiya
0628dbd0a7 Bug 1937172 - Remove SectionManager and TopSitesFeed dependancy on ASRouterStorage r=home-newtab-reviewers,omc-reviewers,mconley,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D234447
2025-01-23 21:32:23 +00:00
Punam Dahiya
4f67dc494e Bug 1937170 - Transfer ownership of ActivityStreamStorage to ASRouter r=backup-reviewers,home-newtab-reviewers,omc-reviewers,mconley,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D234113
2025-01-22 05:59:40 +00:00
Punam Dahiya
59e4ab14a7 Bug 1937166 - Decouple ASRouter from NewTab TelemetryFeed r=home-newtab-reviewers,omc-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D233458
2025-01-21 18:56:18 +00:00
Meg Viar
645b9b4605 Bug 1942323 - Add carat icon to Content Tile headers and ensure proper border-radius on headers above non-toggleable tiles r=omc-reviewers,negin
Differential Revision: https://phabricator.services.mozilla.com/D234731
2025-01-21 18:43:09 +00:00
Emily McMinn
3748e6bed5 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer,negin
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-20 21:31:06 +00:00
Sandor Molnar
2d18e11253 Backed out changeset 232515e209c7 (bug 1940476) for causing bc failures @ browser_asrouter_trigger_docs.js 2025-01-18 07:46:06 +02:00
Emily McMinn
f4e1bff7e4 Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-18 00:02:55 +00:00
Norisz Fay
149fb6e550 Backed out changeset 6d26e856d73e (bug 1940476) for causing xpcshell failures on test_backgroundtask_targeting.js 2025-01-16 23:43:14 +02:00
Emily McMinn
418d1decfb Bug 1940476 - Add triggers for "Tab group created" and "Tab group closed" events; and targeting for counting tab groups r=dao,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D233953
2025-01-16 19:28:08 +00:00
Meg Viar
9e8ae04a1b Bug 1936656 - Add ability to show multiple content tiles on a single aboutwelcome screen with option to toggle visibility r=emcminn,omc-reviewers,jprickett
**Primary Updates**
- Add ability to show multiple content tiles on a single AboutWelcome screen by supporting an array of tile objects and/or sub-arrays of tile objects to be groups together as a value for "tiles" in screen content
- Keep compatibility with messages that use a single tile object as the value of "tiles" in screen content
- Add updates to `setMultiSelectActions` to ensure we can handle actions across multiple MultiSelect tiles.
- Add optional tile headers which can be displayed in place of the tile until clicked, closing any other tile with a header that's currently open
- Send click event telemetry when a user clicks a tile header to open the tile
- Update aboutwelcome source docs related to content tiles to include this new capability

**Additional Updates to Support UX Designs**
[[ https://www.figma.com/design/F63Ac1akw2q1fN5D59rgS5/Privacy?node-id=4110-16458&t=kSzPUp4XFLq0dKg8-4 |
See Figma designs ]]
- Add ability to configure `display`, `padding`, and `width` for aboutwelcome screens (this allows us to support the proposed Spotlight modal designs, which include anchoring the modal towards the top of the screen and expanding it downward when a tile is opened, rather than centering vertically)
- Add ability to configure action buttons to show above screen content

{F11717546}

Differential Revision: https://phabricator.services.mozilla.com/D231856
2025-01-15 16:29:23 +00:00
Emily McMinn
efeb1ce68d Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-13 18:48:32 +00:00
Cosmin Sabou
efae93e17d Backed out 2 changesets (bug 1938446, bug 1919598) for causing failures on browser_tabnotificationbox_switch_tabs and conflicts. CLOSED TREE
Backed out changeset be28df34cc76 (bug 1938446)
Backed out changeset ffa630d286bb (bug 1919598)
2025-01-11 01:58:14 +02:00
Emily McMinn
b2b5a8709e Bug 1938446 - Land illustrations & animations for Tab Groups callouts r=omc-reviewers,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D233445
2025-01-10 21:50:48 +00:00
negin
34caedb5e0 Bug 1919598 - Land Firefox View Discoverability treatment-b in mc- r=omc-reviewers,fluent-reviewers,emcminn,accessibility-frontend-reviewers,nstroud
Differential Revision: https://phabricator.services.mozilla.com/D229198
2025-01-10 21:31:18 +00:00
Punam Dahiya
cf58fbd5e3 Bug 1618001 - Move React vendored libraries to the toolkit to prevent multiple instances r=sylvestre,omc-reviewers,home-newtab-reviewers,frontend-codestyle-reviewers,firefox-ai-ml-reviewers,aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232431
2025-01-08 21:08:16 +00:00
Meg Viar
81a9ec1500 Bug 1937625 - Strengthen embedded browser element flags in Messaging System r=omc-reviewers,nalexander,nika,negin
Enhancements for the embedded browser component in AboutWelcome:

- Improve the speed at which the browser starts by predicting the `remoteType` the load is going to finish in
- Set `maychangeremoteness` attribute to true to allow changing remoteness if user navigates to a different URL that requires this (such as an `about:` page, though with the current set up `about:` pages won't load for security reasons).
- Set `nodefaultsrc` attribute to true to avoid loading a default URL if `src` is blank

Differential Revision: https://phabricator.services.mozilla.com/D232425
2025-01-08 00:14:40 +00:00
Meg Viar
d7704cbe37 Bug 1937599 - Address ASRouter console error on first startup due to this._storage being null r=omc-reviewers,pdahiya
- Wait for ASRouter to be initialized before recording screen impressions to ensure the impression for the first screen in `about:welcome` isn't lost because ASRouter's `_storage` variable is still null

- Local testing shows that this first screen impression is lost when an attempt is made to record it before ASRouter is initialized. It's unclear if this is an issue on production, or just when running locally. Locally the issue occurs consistently, but this can't be the case on production as telemetry includes impressions from the first screen of `about:welcome`. However, we should monitor telemetry for possible changes after this fix goes out to see if there is an increase in screen impressions for the first screen of about:welcome.

Differential Revision: https://phabricator.services.mozilla.com/D232736
2024-12-20 21:16:28 +00:00
Emily McMinn
c52497660c Bug 1923722 - Add fakespot opt-out survey strings for translation && move survey callout into code r=omc-reviewers,aminomancer,fluent-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D232540
2024-12-20 16:10:00 +00:00
Mike Conley
4647ce1c30 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-20 16:07:56 +00:00
Goloman Adrian
1683c8c8b5 Backed out 4 changesets (bug 1937234) for causing newtab failures @asrouter. CLOSED TREE
Backed out changeset 3fd6a002577a (bug 1937234)
Backed out changeset 6ab7c2107849 (bug 1937234)
Backed out changeset baa639909c0e (bug 1937234)
Backed out changeset 77e5bd035f08 (bug 1937234)
2024-12-19 19:46:38 +02:00
Mike Conley
f391c2f6b4 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-19 16:43:39 +00:00
Emilio Cobos Álvarez
becf088418 Bug 1929400 - Don't use :has() to hide BookmarksBarButton message. r=aminomancer,desktop-theme-reviewers,omc-reviewers,dao
This is faster, no point in making customize mode slower for something
that almost never shows up anyways.

Differential Revision: https://phabricator.services.mozilla.com/D228104
2024-12-19 14:32:52 +00:00
Stanca Serban
b21fd0feda Backed out 4 changesets (bug 1937234) for causing newtab failures.
Backed out changeset 9c4ec733448e (bug 1937234)
Backed out changeset 05d3d5a45230 (bug 1937234)
Backed out changeset 27877e1ab900 (bug 1937234)
Backed out changeset d56b2c3bfd0e (bug 1937234)
2024-12-19 03:55:28 +02:00
Mike Conley
2fad4563b7 Bug 1937234 - Add signed out avatar variants. r=skhamis,emilio,omc-reviewers,pdahiya
These variants are controlled via the avatarIconVariant variable of the
fxaButtonVisibility feature.

Differential Revision: https://phabricator.services.mozilla.com/D232128
2024-12-18 19:47:07 +00:00
Emily McMinn
1a5c041c25 Bug 1934661 - Top off FxMS placeholder buffer for 135 r=omc-reviewers,hanna_a,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D231622
2024-12-18 16:48:47 +00:00
Sammy Khamis
6a8f7f80ad Bug 1936922: Cache response from listAttachedOAuthClients to prevent unnecessary network calls r=markh,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D232006
2024-12-17 23:09:53 +00:00
Punam Dahiya
626a74d9fa Bug 1934668 - Move ASRouter image assets out of newtab r=desktop-theme-reviewers,home-newtab-reviewers,urlbar-reviewers,omc-reviewers,aminomancer,dao,mconley
Differential Revision: https://phabricator.services.mozilla.com/D232130
2024-12-17 01:36:16 +00:00
kpatenio
c8197f60d5 Bug 1920235 - add ability to access shadowDOM for callout selectors. r=omc-reviewers,aminomancer
The intent of this patch is to add support for feature callout anchors situated in the shadowDOM. For instance, for the Review Checker migration project, we want to add callout messages on the feature's sidebar icon. The actual parsing of the selector itself should be credited to @aminomancer; I'm authoring this patch to make sure we can get the change landed and tested.

I also verified the change with a few selectors via about:asrouter. For instance, if you wish to test with the actual Review Checker sidebar icon, you should have the prefs `sidebar.revamp` and `browser.shopping.experience2023.integratedSidebar` set to true. After enabling RC in the sidebar settings, add the following anchor to any callout: `"#sidebar-main > sidebar-main::%shadow% .tools-and-extensions::%shadow% moz-button[view='viewReviewCheckerSidebar']"`.

Lastly, I added a test in `browser/components/asrouter/tests/browser/browser_feature_callout_panel.js` to ensure `%shadow%` works as intended.

Differential Revision: https://phabricator.services.mozilla.com/D231337
2024-12-13 02:56:50 +00:00
Emily McMinn
b5d1cfafd6 Bug 1931659 - Add currentTabsOpen context to nthTabClosed trigger; as well as a similar nthTabOpened trigger r=omc-reviewers,pdahiya,dao
Differential Revision: https://phabricator.services.mozilla.com/D231144
2024-12-12 17:14:23 +00:00
Mike Conley
e06d4179af Bug 1932859 - Prevent auto-closing of the AppMenu / FxA panels when generically clicking the FxA menu message CTA. r=pdahiya,omc-reviewers
The change in CustomizableUI is required because the routine wasn't designed to handle
custom elements with shadow roots. The routine's job is to walk up the ancestry of
the click event and determine if any of the parents have certain characteristics
that would indicate that the event should not close the panel, and without this
change it would bail out as soon as it hit the shadow root if the event's original
target was inside the custom element.

In this case, the element enclosing the fxa-menu-message is the "appMenu-fxa-menu-message"
toolbaritem with `closemenu="none"`, which this modification now lets
CustomizableUI detect.

Differential Revision: https://phabricator.services.mozilla.com/D230560
2024-12-09 21:16:19 +00:00
Logan Rosen
d24c9d9ff4 Bug 1857834 - auto-formatting with Prettier v3 r=linter-reviewers,webdriver-reviewers,perftest-reviewers,search-reviewers,devtools-reviewers,sync-reviewers,reusable-components-reviewers,profiler-reviewers,dom-storage-reviewers,android-reviewers,firefox-ai-ml-reviewers,hjones,mcheang,mstange,sparky,janv,nchevobbe,tarek,Standard8,markh
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D230598
2024-11-29 15:18:25 +00:00
Meg Viar
48ab3860bf Bug 1923868 - Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya
This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Differential Revision: https://phabricator.services.mozilla.com/D225212
2024-11-25 18:14:28 +00:00
Jason Prickett
86f8c07bf1 Bug 1928467 - Add ability for bookmarks toolbar button to be removed after unenrollment r=mviar,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D229380
2024-11-22 20:32:07 +00:00
Alexandru Marc
f8117504e2 Backed out changeset a2435b289727 (bug 1923868) for causing bc failures @ browser_aboutwelcome_multistage_languageSwitcher.js. CLOSED TREE 2024-11-22 19:14:57 +02:00
Meg Viar
cf5467d380 Bug 1923868 - Support setting Firefox as default based on installer attribution campaign r=firefox-desktop-core-reviewers ,nalexander,omc-reviewers,pdahiya
This patch adds an startup idle task that sets the browser as default if an attribution campaign id of "set_default_browser" is present on first run. This works supports an upcoming experiment where users will have the option to "download as default" via [[ https://www.mozilla.org/en-US/firefox/new/ | the stub installer marketing page ]].

Differential Revision: https://phabricator.services.mozilla.com/D225212
2024-11-22 14:29:15 +00:00
Adi
9d9552bf95 Backed out changeset 893b697b0ad7 (bug 1923868) for causing bc failures @nsMacDockSupport.mm. CLOSED TREE 2024-11-22 05:40:59 +02:00
Adi
1553bea548 Backed out changeset 12efd90d2c57 (bug 1928467) for causing bc failures @browser_bookmarks_bar_button.js. 2024-11-22 05:38:11 +02:00
Jason Prickett
89c974a0bc Bug 1928467 - Add ability for bookmarks toolbar button to be removed after unenrollment r=mviar,omc-reviewers
This patch adds the functionality of the fxms_bmb_button surface to be removed when a user has been unenrolled from an experiment that used said feature.

Differential Revision: https://phabricator.services.mozilla.com/D229380
2024-11-22 02:40:22 +00:00