Commit Graph

212 Commits

Author SHA1 Message Date
Florian Quèze
1a1f0641c8 Bug 1918702 - Migrate telemetry events to use Glean APIs for aboutprivatebrowsing, r=chutten.
Differential Revision: https://phabricator.services.mozilla.com/D222419
2024-09-20 13:58:16 +00:00
Mark Banner
a1c6d4d388 Bug 1867620 - Avoid updating the in-content search bar placeholders / text from multiple locations when in handoff mode. r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D195167
2023-12-12 21:15:25 +00:00
Cieara Meador
30e2caed54 Bug 1862983 - Send up Felt Privacy exposure event on PBM new tab r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D193843
2023-11-20 16:14:55 +00:00
Cieara Meador
1784081468 Bug 1852607 - Felt Privacy v1 about:privatebrowsing strings r=mhowell,fluent-reviewers,desktop-theme-reviewers,dao,flod
Differential Revision: https://phabricator.services.mozilla.com/D188258
2023-09-18 14:50:40 +00:00
Cieara Meador
ba0f272343 Bug 1847102 - PBM styling updates r=mhowell,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D186185
2023-09-11 17:31:55 +00:00
Paul Zuehlcke
01d5b71c28 Bug 1851163 - Remove obsolete felt privacy (2022) prefs. r=timhuang
Differential Revision: https://phabricator.services.mozilla.com/D187275
2023-09-04 08:36:02 +00:00
Shane Hughes
402390df82 Bug 1833913 - Add default private newtab content. r=pdahiya,omc-reviewers,desktop-theme-reviewers,sfoster
Synchronously render default info content on about:privatebrowsing while
waiting for ASRouter to handle messages. Update the script and
stylesheet to account for rendering happening twice now. Add a browser
test to verify the content is rendered while ASRouter is hanging.

Differential Revision: https://phabricator.services.mozilla.com/D178987
2023-06-21 04:37:23 +00:00
Sandor Molnar
36ef388687 Backed out changeset 0ce9449255f9 (bug 1833913) for causing mochitest failures. CLOSED TREE 2023-06-15 22:53:08 +03:00
Shane Hughes
a90a3a4187 Bug 1833913 - Add default private newtab content. r=pdahiya,omc-reviewers,desktop-theme-reviewers,sfoster
Synchronously render default info content on about:privatebrowsing while
waiting for ASRouter to handle messages. Update the script and
stylesheet to account for rendering happening twice now. Add a browser
test to verify the content is rendered while ASRouter is hanging.

Differential Revision: https://phabricator.services.mozilla.com/D178987
2023-06-15 18:32:32 +00:00
Mark Banner
b61a6a6502 Bug 1826063 - Automatic fixes for enabling Prettier on production xhtml and html files. r=mossop,webdriver-reviewers,webcompat-reviewers,geckoview-reviewers,extension-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,fxview-reviewers,sgalich,nalexander,devtools-reviewers,sclements,denschub,robwu,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177938
2023-05-20 12:26:56 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Emily McMinn
765d181c6e Bug 1828765 - Restore awaits causing intermittents, clean up unused arg r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D176331
2023-05-02 15:40:59 +00:00
Emily McMinn
2a4a5ba992 Bug 1824807 - Remove unnecessary await from aboutPrivateBrowsing translateElements helper r=pdahiya,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D174810
2023-04-18 15:12:28 +00:00
Francesco Lodolo (:flod)
fa28bcb157 Bug 1822388 - Move brandings.ftl from browser to toolkit, r=eemeli,settings-reviewers,credential-management-reviewers,devtools-reviewers,fxview-reviewers,sgalich,Mardak
Differential Revision: https://phabricator.services.mozilla.com/D172643
2023-03-15 17:00:48 +00:00
Shane Hughes
bae182b52e Bug 1818345 - Fix private newtab CBH promo illustration vector. r=omc-reviewers,emcminn
Something went wrong when exporting the illustration for the Cookie
Banner about:privatebrowsing promo from Figma, causing the stop sign to
look a little funky. This is just a simple re-export.

Differential Revision: https://phabricator.services.mozilla.com/D170684
2023-02-23 18:17:31 +00:00
Shane Hughes
095143b123 Bug 1808441 - Add Cookie Banner Promo on PB new tab. r=omc-reviewers,flod,pdahiya,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D165924
2023-02-18 01:14:11 +00:00
Punam Dahiya
3187d5e5cb Bug 1753746 - PBM messaging devtool integration r=pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D145808
2022-10-31 15:21:56 +00:00
Paul Zuehlcke
b036de13fc Bug 1751481 - Enable felt privacy features by default and integrate with Nimbus. r=dao,preferences-reviewers,Gijs
Depends on D155013

Differential Revision: https://phabricator.services.mozilla.com/D155065
2022-08-25 11:17:39 +00:00
Paul Zuehlcke
827061f5ff Bug 1783235 - Update about:privatebrowsing logos. r=Gijs,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D153779
2022-08-10 11:44:08 +00:00
Tooru Fujisawa
15758870e7 Bug 1780543 - Part 4: Add mozilla/remote-page environment. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D152429
2022-07-26 02:46:30 +00:00
negin
dcfe503354 Bug 1774070 - Add asset needed for about:privatebrowsing pin promo r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D152107
2022-07-20 16:32:34 +00:00
Marian-Vasile Laza
dd8ace1062 Backed out changeset bdeb418ce16c (bug 1774070) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2022-07-19 00:56:45 +03:00
negin
5467869592 Bug 1774070 - Add asset needed for about:privatebrowsing pin promo r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D152107
2022-07-18 20:44:12 +00:00
Barret Rennie
b3e2605f2b Bug 1771073 - Correct FxMS features and keep them up to date with tests r=dmose,pdahiya
The Nimbus Features corresponding to FxMS messaging surfaces are actually
intended to map to FxMS message groups, which can accept *any* FxMS message.
The features have been updated with schemas that accept any FxMS message.

As part of this, all FxMS schemas have been updated with an `$id` so that they
can be bundled into feature schemas and have their internal `$ref`s work.
(Otherwise, a `$ref` would be relative to the top-level schema instead of the
sub-schema).

Schemas for individual message types are no longer exposed as resource:// URIs,
except in tests, as indivual schemas are no longer required at runtime.

Additionally, each FxMS schema has had its `template` field become required and
requires a constant value for that schema (e.g., Spotlight requires a template
value of "spotlight").

A test has been added to ensure that if any of the messaging surfaces schemas
change that the feature schemas are also updated. The feature schemas can be
regenerated via:

```
cd ./browser/components/newtab/content-src/asrouter/schemas
../../../../../../mach make-schemas.py
```

Differential Revision: https://phabricator.services.mozilla.com/D147332
2022-06-29 23:01:37 +00:00
Jason Prickett
22f6a50c28 Bug 1770067 - Adding link support to private browsing promo button r=pdahiya,emcminn
Differential Revision: https://phabricator.services.mozilla.com/D149571
2022-06-24 23:09:23 +00:00
Dan Mosedale
49b380eaef Bug 1748214 - Remove private browsing Nimbus feature, r=pdahiya,barret
Differential Revision: https://phabricator.services.mozilla.com/D146474
2022-06-15 16:03:17 +00:00
Punam Dahiya
06b2c92c46 Bug 1770061 - Enhance PBM Promo button to support all SpecialMessageActions r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D146751
2022-05-23 22:35:07 +00:00
Punam Dahiya
74fd8b3a3e Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-12 18:24:06 +00:00
Cristian Tuns
9a2ed99397 Backed out changeset eb12cdc5d1e8 (bug 1765907) for causing mochitest failures on browser_privatebrowsing_focus_promo.js CLOSED TREE 2022-05-10 14:38:02 -04:00
Punam Dahiya
daed30958c Bug 1765907 - PBM experiment message should override default promo message r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D144871
2022-05-10 17:12:05 +00:00
Itiel
27ee131af3 Bug 1767167 - Style improvements for PBM r=desktop-theme-reviewers,sfoster
This includes:
1. Fix "Download Firefox Focus" button :hover:active state
2. Make the fake caret visible in HCM
3. Fix the branding name to be visible in all HCM modes
4. Make the sections distinguishable from others in HCM
5. Fix the searchbox text to be visible when hovered, in HCM
6. Make the promo's X button look better and work in :hover:active state

Differential Revision: https://phabricator.services.mozilla.com/D145175
2022-05-05 23:02:37 +00:00
Meg Viar
083c4b4030 Bug 1766592 - [Experiment] The "Focus Promo" experiment message is wrongly displayed on the fist opened tab after it was dismissed r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D145015
2022-05-04 13:35:28 +00:00
Emily McMinn
404a100594 Bug 1759915 - Add aria-hidden to PBM search box to correct VoiceOver behaviour r=mviar
This should prevent VoiceOver from getting "stuck" between the address bar and the fake search bar in Private Browsing Mode. I'm not sure why PBM is different to the behaviour on the newtab page (the newtab page doesn't have the aria-hidden property and the HTML is essentially the same) but adding "aria-hidden" in this case doesn't seem to break anything.

Differential Revision: https://phabricator.services.mozilla.com/D143784
2022-04-18 19:49:04 +00:00
Meg Viar
5da74d3213 Bug 1764330 - The QR code from the "PB_FOCUS_PROMO" modal wrongly redirects to the "Firefox Klar" app even if the region is set to "US" and a Firefox en-US locale build is used r=pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D143724
2022-04-14 16:09:34 +00:00
Emily McMinn
64b83a68ec Bug 1762431 - Presentation fixes for a11y on PBM Fx100 r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D142893
2022-04-05 16:02:37 +00:00
Emily McMinn
812cfd4163 Bug 1761842 - Replace promo CTA link with a button for better a11y r=mviar
Differential Revision: https://phabricator.services.mozilla.com/D142589
2022-04-04 19:32:44 +00:00
Meg Viar
48fd34f067 Bug 1762242 - Conditionally show Private Browsing page Focus promo r=dmose
Differential Revision: https://phabricator.services.mozilla.com/D142551
2022-04-01 12:36:30 +00:00
Meg Viar
e6efb5e498 Bug 1760588 - The in-content "Search bar" placeholder is no longer displayed if the “about:privatebrowsing” page is refreshed after the “Get Firefox Focus” spotlight modal is triggered r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D141781
2022-03-23 19:56:59 +00:00
Meg Viar
9e6c3b20df Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140739
2022-03-23 14:03:18 +00:00
smolnar
a741da5d02 Backed out changeset f6577528fc15 (bug 1758028) for causing xpc failures in xpcshell/test_BrowserUtils.js CLOSED TREE 2022-03-22 21:54:22 +02:00
Meg Viar
e6c366cc05 Bug 1758028 - Implement PBM modal content as per finalized design r=pdahiya,preferences-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140739
2022-03-22 19:19:02 +00:00
Punam Dahiya
241b77481c Bug 1754832 - Update PBM to support opening spotlight tab modal r=Mardak,mviar,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D140565
2022-03-17 06:41:47 +00:00
Punam Dahiya
df78932187 Bug 1756860 - Add Firefox Focus promo image r=Mardak
Differential Revision: https://phabricator.services.mozilla.com/D140780
2022-03-12 11:15:33 +00:00
Dan Mosedale
1749a8cc63 Bug 1754115 - switch pvt browsing promo close string, r=pdahiya,fluent-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D140279
2022-03-04 20:09:46 +00:00
Punam Dahiya
bbc77f3f6c Bug 1756178 - Open link from the private browsing page in a new tab r=emcminn
Differential Revision: https://phabricator.services.mozilla.com/D139900
2022-03-01 18:38:23 +00:00
Dan Mosedale
5e02b224d2 Bug 1749775 - Add user telemetry for 98 VPN promo, r=andreio,pdahiya
Differential Revision: https://phabricator.services.mozilla.com/D135874
2022-02-11 16:31:06 +00:00
Andrei Oprea
799b962042 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-04 02:35:30 +00:00
Cosmin Sabou
443f0b25bb Backed out changeset edbc8f7e808f (bug 1748240) for bc failures on browser_privatebrowsing_about_nimbus.js. CLOSED TREE 2022-02-01 05:40:15 +02:00
Andrei Oprea
972606bfa5 Bug 1748240 - Add impressions counting and dismiss functionality to PB messaging r=desktop-theme-reviewers,barret,fluent-reviewers,Itiel
Depends on D134157

Differential Revision: https://phabricator.services.mozilla.com/D135058
2022-02-01 01:36:28 +00:00
Andrei Oprea
f64147a52f Bug 1746598 - Route MS messages to PB newtab r=dmose,extension-reviewers,rpl
Differential Revision: https://phabricator.services.mozilla.com/D134157
2022-01-25 13:02:30 +00:00