corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
519,973 Commits 1 Branch 0 Tags
b93a0ce668e5e46f7d4e5efcd8aae6f1bf06521e
Commit Graph

83 Commits

Author SHA1 Message Date
Masayuki Nakano
b93a0ce668 Bug 1407085 - nsAutoCompleteController shouldn't restore original value after somebody changes the input value even when Escape key is pressed r=mak 
When Escape key is pressed, nsAutoCompleteController needs to restore last
string which was default value of the input or typed by the user.  However,
somebody may change the value, e.g., an event listener which handles
Escape key.  In this case, nsAutoCompleteController shouldn't restore the
last string.

Unfortunately, when JS sets input value, DOM "input" event won't be fired.
Therefore, nsAutoCompleteController doesn't have a chance to modify
mSearchString in this case.  Therefore, nsAutoCompleteController needs to
store expected input string for checking if somebody modified the input value.
For solving this issue, this patch adds a new member, mSetValue which is
modified when the input value is modified by nsAutoCompleteController itself
or mSearchString is modified.

Even with this patch, if user temporarily selects an item of the popup and
JS sets same value as the selected item from JS, nsAutoCompleteController
restores the input value with mSearchString.  However, this must be rare
case and I don't have idea to fix this issue with simple patches.

MozReview-Commit-ID: lig8c7xvD7
 2017-12-19 16:46:20 +09:00
Drew Willcoxon
f0eb3eb041 Bug 1410240 - Search suggestions keep displacing awesomebar results as I'm about to click on them. r=mak 
MozReview-Commit-ID: 2NdV9qWzld1
 2017-11-22 16:22:32 -08:00
Marco Bonardo
c6b922c0b7 Bug 1415908 - Intermittent failure (nsIAutoCompleteController.getCommentAt) in browser_ext_omnibox.js. r=adw 
Fixes a timing bug where in certain moments matchCount may not be in sync with the current search status,
due to previous results not being cleared immediately. Still delays tree updates to avoid UI flickering.
Fixes a theorical timing issue in unifiedComplete where a stopped search could notify a result.
Removes the no more used OnUpdateSearchResult API.

MozReview-Commit-ID: COoIN4oQT4v
 2017-11-19 21:58:14 +01:00
Ray Lin
74e309f85d Bug 1410821 - Call startSearch again when the new search string could not hit the cached result. r=mak 
MozReview-Commit-ID: 1AJutt4IA0E
 2017-11-03 15:22:45 +08:00
Kris Maglione
60872d7b31 Bug 1404198: Part 2f - Switch to NS_NewTimer* in toolkit. r=njn 
MozReview-Commit-ID: 185rZ99R6zV
 2017-10-15 23:14:00 -07:00
Shane Caraveo
d540205171 Bug 1406229 fix autocomplete crash in panels when window is closed during event, r=mak 
MozReview-Commit-ID: 6TrLuwrk2nD
 2017-10-06 16:58:15 -07:00
Bevis Tseng
59627df038 Bug 1382172 - Name nsITimerCallback instances in native implementation. r=billm 2017-07-27 02:18:20 +08:00
Sylvestre Ledru
9d4a84d778 Bug 1378712 - Remove all trailing whitespaces r=Ehsan 
MozReview-Commit-ID: Kdz2xtTF9EG
 2017-07-06 14:00:35 +02:00
Marco Bonardo
999435c9e2 Bug 1370518 - Don't completely detach/attach the autocomplete controller on TabSelect. r=mconley 
Due to recent changes to tabbrowser focus behavior, now the "focus" event to the location bar
happens before the "TabSelect" event. On "focus" we would like to open the location bar popup,
but detaching the controller would immediately close it. Thus we don't want "TabSelect" to
detach the controller just to reset its internal state. Moreover, this should be cheaper.

MozReview-Commit-ID: 5NZ1TTI9NFW
 2017-06-06 18:47:19 +02:00
Marco Bonardo
817dd58fcc Bug 1368074 - Autocomplete popup is not re-opened when repeating the same search in a new tab. r=mconley 
MozReview-Commit-ID: GSZoWFgw0X8
 2017-05-30 17:28:34 +02:00
Marco Bonardo
12b2b6852f Bug 1304501 - Properly disable trimUrl on autofill. r=adw 
MozReview-Commit-ID: IxCOWkqFYV0
 2016-09-21 21:55:00 +02:00
Marco Bonardo
9f5dc75ac5 Bug 1306639 - Searching in locationbar by typing something and pressing enter is not accounted in telemetry. r=adw 
MozReview-Commit-ID: 9r8IyyyxruC
 2016-10-06 17:40:13 +02:00
Marco Bonardo
238ca13b58 Bug 1303624 - Remove typeAheadResult support from autocomplete. r=adw 
MozReview-Commit-ID: 7XLTON1Rj96
 2016-09-21 18:11:45 +02:00
Marco Bonardo
f838352255 Bug 1302472 - keyboard selected value in autocomplete popup cannot be confirmed with <enter> if completedefaultindex is true but completeselectedindex is false. r=adw 
MozReview-Commit-ID: FR4pKGZLAl2
 2016-09-17 14:03:37 +02:00
Marco Bonardo
785ad45550 Bug 1301093 - Part 3: fix delayed handleEnter regression. r=adw 
MozReview-Commit-ID: 1SZeMUtLjNg
 2016-09-13 09:35:00 +02:00
Marco Bonardo
4fc92051bb Bug 1301093 - Part 1: don't wait for a result when we won't get one. r=adw 
MozReview-Commit-ID: E6l9mW3ZoKp
 2016-09-07 17:44:46 +02:00
Marco Bonardo
b6f51668b8 Bug 1292310 - Enter may wrongly confirm a mouse selected entry in the urlbar. r=adw 
MozReview-Commit-ID: 6teMoPr1vb6
 2016-09-06 17:55:56 +02:00
Yoshi Huang
d1b4579af0 Bug 1244340 - Part 3: pass userContextId to search suggestions r=mak 2016-08-26 18:59:00 +08:00
Drew Willcoxon
a11453a5f4 Bug 1180944 - Implement one-off searches from Awesomebar. r=mak,florian 
MozReview-Commit-ID: A9YXB32L7MN
 2016-08-02 18:00:26 -07:00
Nicholas Nethercote
c74d1d066a Bug 1257128 (part 4) - Remove unused nsIAtomService references in toolkit/. r=froydnj. 2016-03-16 21:11:10 +11:00
Drew Willcoxon
826b4f753d Bug 1236364 - Don't reuse existing richlistitem in urlbar when handling a delete. r=mak 2016-01-25 10:13:26 -08:00
Marco Bonardo
299ef159d5 Bug 1234186 - Unified autocompletion Visit feature doesn't use https for https-only websites. r=adw 2016-01-19 00:39:57 +01:00
Drew Willcoxon
68436cd003 Bug 1182783 - Restore search string and selection when selecting an autofilled urlbar popup result. r=mak 2015-12-15 17:08:41 -08:00
Marco Bonardo
6c190ee363 Bug 720589 - mMatchCounts may be accessed with a nonexisting index. r=neil 2015-11-10 20:18:24 +01:00
Marco Bonardo
ed7123ee15 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Ryan VanderMeulen
d132c6c469 Backed out changeset 91b6fe481685 (bug 1172937) for test_autocomplete_with_composition_on_input.html failures. 2015-07-30 12:45:03 -04:00
Marco Bonardo
ef650b87a0 Bug 1172937 - Action row doesn't always update correctly with unified autocomplete. r=adw 
Original patch by Felipe Gomes <felipc@gmail.com>
 2015-07-30 16:54:27 +02:00
Matt Brubeck
f9b4e572a2 Bug 1185183 - Don't replace edited URL value with old completed value [r=mak] 2015-07-27 17:58:58 -07:00
Magnus Melin
6b6bed0e6d Bug 1130858 - Recipient autocomplete suggestion overrides ANY manual address input if quickly entered/pasted and confirmed with Enter/Tab before autocomplete suggestions disappear. r=mak 2015-07-15 16:21:52 +03:00
Matthew Noorenberghe
ce47a65476 Bug 998893 - Update the autocomplete search string when pressing DOM_VK_DOWN to initiate a search. r=mak 
Some script may have changed the value of the text field since our last keypress or after our focus handler and we don't want to search for a stale string.
 2015-05-06 11:23:51 -07:00
Tim Taubert
3637495d9f Bug 1042561 - Iterate a copy of mSearches in StartSearch() so that an observer can't modify the array we're iterating r=mak 2015-03-23 08:33:53 +01:00
Tim Taubert
61f65b8a83 Bug 1042561 - Correct autocomplete search result update handling in OnUpdateSearchResult() r=mak 2015-03-22 13:26:09 +01:00
Jorg K
f7ef87d5d1 Bug 1042561 - Autocomplete: Typed text in red despite results/matches found if suggestions change by last input r=mak 2015-03-22 13:25:42 +01:00
Carsten "Tomcat" Book
1d4c31c34e backed out changeset b798fd098e09 (bug 1042561) for assertion failure in mochitests 2015-03-20 13:32:28 +01:00
Carsten "Tomcat" Book
f504b1addb Backed out changeset ef86c7c53d21 (bug 1042561) 2015-03-20 13:32:01 +01:00
Tim Taubert
3ce2b76ce7 Bug 1042561 - Correct autocomplete search result update handling in OnUpdateSearchResult() r=mak 2015-03-20 11:15:40 +01:00
Jorg K
a99821113b Bug 1042561 - Autocomplete: Typed text in red despite results/matches found if suggestions change by last input r=mak 2015-03-20 11:18:07 +01:00
Neil Deakin
c0d331a396 Bug 1131685, don't have the selection in the list interfere with caret movement in the search field, r=mak 2015-02-26 09:14:19 -05:00
Neil Deakin
224e9e2862 Bug 1114707, don't close search suggestions when the caret is moved when norolluponanchor is set, r=mak 2015-02-02 15:53:55 -05:00
Magnus Melin
ec9febde8a Bug 1114011 - for autocomplete with for minresultsforpopup > 1: entering match doesn't work properly. r=mak 2015-01-10 13:48:24 +02:00
Magnus Melin
33ae72f811 Bug 1043310 - AutoCompletion doesn't take capitalization from address book entry, can leave angle brackets characters >> in field, when loosing focus by clicking outside (not enter/tab). r=mak 
The fix has two aspects:
 - for onblur we need to complete to the actual suggestion not to leave addresses uncapitalized or having " >> " as value
 - once we have a valid selection that should not be changed to default because EnterMatch is called again (which it is with blur if the value was confirmed by enter, or mouse selection already)
 2015-01-10 13:48:23 +02:00
Gijs Kruitbosch
b4e3c116f7 Bug 1043584 - fix mouseover vs. enter issue in the urlbar, r=mak 2014-12-02 15:52:26 -08:00
Julian Viereck
0047711bbf Bug 950797 - Use result from last completion in nsAutoCompleteController to reduce autoFill UI flickering until search results come back. r=mak 2014-09-30 04:14:49 -07:00
Marco Bonardo
ef6065ab6e Bug 1059846 - Search engine may autofill in-the-middle. r=ttaubert 2014-09-11 17:37:08 +02:00
Marco Bonardo
44a620fea4 Bug 433788 - Crash in [@ nsAutoCompleteController::ClosePopup] due to re-entrancy. r=Enn 2014-07-30 16:55:47 +02:00
Birunthan Mohanathas
eeb9aaaa94 Bug 900908 - Part 3: Change uses of numbered macros in nsIClassInfoImpl.h/nsISupportsImpl.h to the variadic variants. r=froydnj 2014-04-27 03:06:00 -04:00
Marco Bonardo
a50da3e1dc Bug 754265 - Add a dedicated API to provide a final complete value different from the matching one, r=Enn sr=gavin 2014-04-18 16:04:19 +02:00
Ehsan Akhgari
68bfe70f09 Bug 927728 - Part 1: Replace PRUnichar with char16_t; r=roc 
This patch was automatically generated by the following script:

#!/bin/bash
# Command to convert PRUnichar to char16_t

function convert() {
echo "Converting $1 to $2..."
find . ! -wholename "*nsprpub*" \
       ! -wholename "*security/nss*" \
       ! -wholename "*modules/libmar*" \
       ! -wholename "*/.hg*" \
       ! -wholename "obj-ff-dbg*" \
       ! -name prtypes.h \
       ! -name Char16.h \
         -type f \
      \( -iname "*.cpp" \
         -o -iname "*.h" \
         -o -iname "*.c" \
         -o -iname "*.cc" \
         -o -iname "*.idl" \
         -o -iname "*.ipdl" \
         -o -iname "*.ipdlh" \
         -o -iname "*.mm" \) | \
    xargs -n 1 sed -i -e "s/\b$1\b/$2/g"
}

convert PRUnichar char16_t
 2014-01-04 10:02:17 -05:00
Birunthan Mohanathas
37fac24a80 Bug 784739 - Switch from NULL to nullptr in toolkit/components/ (2/2); r=ehsan 2013-10-10 16:38:19 -04:00
Ehsan Akhgari
a2f70ae742 Bug 919326 - Minimize the #includes in layout/ IDL files; r=roc 2013-09-22 19:24:27 -04:00