Commit Graph

117 Commits

Author SHA1 Message Date
Jeff Gilbert
b8764fb04d Bug 1715690 - Generalize WebGL RENDERER into large buckets. r=lsalzman
+ Minor reduction in unused flexibility of limits.

Differential Revision: https://phabricator.services.mozilla.com/D117385
2021-06-14 21:27:08 +00:00
Butkovits Atila
45678d5d97 Backed out changeset 45887183c584 (bug 1715690) for causing failures at SanitizeRenderer. CLOSED TREE 2021-06-12 04:12:18 +03:00
Jeff Gilbert
65b37f7f09 Bug 1715690 - Generalize WebGL RENDERER into large buckets. r=lsalzman
+ Minor reduction in unused flexibility of limits.

Differential Revision: https://phabricator.services.mozilla.com/D117385
2021-06-11 23:54:39 +00:00
Iulian Moraru
e38919bd9b Backed out changeset 67b696ec70a9 (bug 1715690) for causing build bustages on SanitizeRenderer.cpp. CLOSED TREE 2021-06-11 02:46:23 +03:00
Jeff Gilbert
a4496cbc13 Bug 1715690 - Generalize WebGL RENDERER into large buckets. r=lsalzman
+ Minor reduction in unused flexibility of limits.

Differential Revision: https://phabricator.services.mozilla.com/D117385
2021-06-10 22:55:50 +00:00
Jeff Gilbert
7510580777 Bug 1655000 - Use same function for getting size as reading into buffer. r=lsalzman
Previously we called GetFrontBufferSize, alloc'd a buffer, and called
FrontBufferSnapshotInto to read into the buffer.
Now, call FrontBufferSnapshotInto({}) to get size, and then alloc and
pass pointer to newly alloc'd data into
FrontBufferSnapshotInto(Some(ptr)).
Using the same function for both means that logic can't diverge and
cause mismatch bugs.

Differential Revision: https://phabricator.services.mozilla.com/D113611
2021-05-06 00:22:42 +00:00
Alexandru Michis
e455810ac6 Backed out changeset 1331f134a250 (bug 1655000) for causing bustages in WebGLContext.cpp
CLOSED TREE
2021-04-29 00:44:19 +03:00
Jeff Gilbert
db38e2c290 Bug 1655000 - Use same function for getting size as reading into buffer. r=lsalzman
Previously we called GetFrontBufferSize, alloc'd a buffer, and called
FrontBufferSnapshotInto to read into the buffer.
Now, call FrontBufferSnapshotInto({}) to get size, and then alloc and
pass pointer to newly alloc'd data into
FrontBufferSnapshotInto(Some(ptr)).
Using the same function for both means that logic can't diverge and
cause mismatch bugs.

Differential Revision: https://phabricator.services.mozilla.com/D113611
2021-04-28 20:38:23 +00:00
Snehaa2296
bb57a16c0e Bug 1629420 - ClientWebGLContext.cpp: the 'empty' method should be used to check for emptiness instead of 'size'. r=andi
Differential Revision: https://phabricator.services.mozilla.com/D109271
2021-03-22 14:28:05 +00:00
Henri Sivonen
b6dc8371f9 Bug 1693534 - Avoid leaking the kernel version to the Web with amdgpu. r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D105636
2021-02-22 09:18:19 +00:00
Sylvestre Ledru
0a33533196 Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D105158
2021-02-15 08:49:20 +00:00
Jeff Gilbert
5cc460c364 Bug 1691606 - Clean up dead code following WebGL out-of-process stabilization. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D104495
2021-02-09 07:57:03 +00:00
Sylvestre Ledru
ddcb9eb4bc Bug 1519636 - Reformat recent changes to the Google coding style r=andi
Updated with clang-format version 11.0.1 (taskcluster-B6bdwSKDRF-luRQWXBuzpA)

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D102084
2021-01-18 16:50:16 +00:00
Jeff Gilbert
a315d0bc8f Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D101061
2021-01-14 01:23:06 +00:00
Mihai Alexandru Michis
66ca1a0d98 Backed out changeset 6149f5b15c5e (bug 1640607) for causing bustages in WebGLTextureUpload.cpp
CLOSED TREE
2021-01-14 00:43:40 +02:00
Steve Fink
a1d96801f9 Bug 1684122 - Demarcate region where GC would break stuff r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D100427
2021-01-13 22:24:36 +00:00
Jeff Gilbert
d26398df9f Bug 1640607 - Send SurfaceDescriptors for GPU blitting for video-to-webgl. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D101061
2021-01-13 21:49:40 +00:00
Jeff Gilbert
e95c696588 Bug 1680595 - Point users towards "webgl.disable-fail-if-major-performance-caveat" if failIfMajorPerformanceCaveat: true causes failure. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D98824
2020-12-07 05:35:57 +00:00
Jeff Gilbert
98ce99a9a7 Bug 1638568 - E.g. uniform1i(null, ...) should check avail len not total len. r=lsalzman
Also:
* Propagate null-location UniformDatas to host
* Move transpose validation to host-side

Differential Revision: https://phabricator.services.mozilla.com/D98243
2020-11-30 22:00:23 +00:00
Simon Giesecke
46908cfb51 Bug 1660470 - Add missing include directives/forward declarations. r=nika
Differential Revision: https://phabricator.services.mozilla.com/D87865
2020-11-23 16:21:38 +00:00
Sylvestre Ledru
206e89d677 Bug 1519636 - Reformat recent changes to the Google coding style r=andi,necko-reviewers,dragana
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D96608
2020-11-16 22:09:25 +00:00
Jeff Gilbert
4fd74ccc14 Bug 1674592 - Shrink uploads based on byte size estimates. r=lsalzman
For example uploads from WASM heaps would previously copy most of the
heap into shmem.

Differential Revision: https://phabricator.services.mozilla.com/D96287
2020-11-13 23:24:13 +00:00
Csoregi Natalia
72a239791b Backed out changeset 217b92a7892b (bug 1674592) for assertion failures on ClientWebGLContext.cpp. CLOSED TREE 2020-11-12 05:18:53 +02:00
Jeff Gilbert
f1c808b93e Bug 1674592 - Shrink uploads based on byte size estimates. r=lsalzman
For example uploads from WASM heaps would previously copy most of the
heap into shmem.

Differential Revision: https://phabricator.services.mozilla.com/D96287
2020-11-12 01:58:25 +00:00
Narcis Beleuzu
58b519d69f Backed out changeset 6701e0a37598 (bug 1674592) for multiple webgl failures. CLOSED TREE 2020-11-10 05:52:02 +02:00
Jeff Gilbert
8e449324c4 Bug 1674592 - Shrink uploads based on byte size estimates. r=lsalzman
For example uploads from WASM heaps would previously copy most of the
heap into shmem.

Differential Revision: https://phabricator.services.mozilla.com/D96287
2020-11-09 20:09:22 +00:00
Noemi Erli
e856762017 Backed out changeset 4a679b76e51b (bug 1674592) for causing failures in test_conformance__extensions__ext-texture-compression-rgtc.html CLOSED TREE 2020-11-09 13:16:26 +02:00
Jeff Gilbert
7b6507f56a Bug 1674592 - Shrink uploads based on byte size estimates. r=lsalzman
For example uploads from WASM heaps would previously copy most of the
heap into shmem.

Differential Revision: https://phabricator.services.mozilla.com/D96287
2020-11-09 07:28:34 +00:00
Jeff Gilbert
1ff736595c Bug 1656459 - Hold ref in DrawingBufferSize to prevent dangling reference use on context-loss. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D93398
2020-10-13 17:09:27 +00:00
Andi-Bogdan Postelnicu
298ee4f308 Bug 1671599 - Make dom/canvas buildable outside of unified-build environment. r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D93753
2020-10-20 13:14:51 +00:00
Jeff Gilbert
65e0264b2f Bug 1668144 - Add blocklisting for OOP WebGL. r=mattwoodrow
* Add FEATURE_THREADSAFE_GL and FEATURE_ALLOW_WEBGL_OUT_OF_PROCESS
* Add gfxVars::AllowWebglOop()
* Blocklist THREADSAFE_GL on mesa/nouveau

Differential Revision: https://phabricator.services.mozilla.com/D91879
2020-10-01 08:14:12 +00:00
Jeff Gilbert
ff7906d833 Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
GfxInfo generally wants to be main-thread, so WebGL (especially
out-of-process) runs into problems sometimes.

Also rename to UNUSED_FEATURE_WEBGL_MSAA, pending removal.

Differential Revision: https://phabricator.services.mozilla.com/D91208
2020-09-27 22:18:23 +00:00
Csoregi Natalia
f5c3e57716 Backed out changeset 3dcacf3ae5a1 (bug 1664905) for assertion failures on GfxInfoBase.cpp. CLOSED TREE 2020-09-25 09:33:40 +03:00
Jeff Gilbert
eeb2043f33 Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
GfxInfo generally wants to be main-thread, so WebGL (especially
out-of-process) runs into problems sometimes.

Also remove obsolete FEATURE_WEBGL_MSAA.

Differential Revision: https://phabricator.services.mozilla.com/D91208
2020-09-25 05:43:24 +00:00
Razvan Maries
207455bc4a Backed out changeset 3ea0c63fe8b8 (bug 1664905) for build bustages on ClientWebGLContext.cpp. CLOSED TREE 2020-09-25 03:26:17 +03:00
Jeff Gilbert
6b2c081c57 Bug 1664905 - Use gfxVars instead of GfxInfo in WebGL code. r=mattwoodrow
GfxInfo generally wants to be main-thread, so WebGL (especially
out-of-process) runs into problems sometimes.

Also remove obsolete FEATURE_WEBGL_MSAA.

Differential Revision: https://phabricator.services.mozilla.com/D91208
2020-09-24 23:46:12 +00:00
Jeff Gilbert
db736252b1 Bug 1662789 - Add IpcWebGL?/IpcWebGL+ feature annotation. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D89177
2020-09-02 19:14:53 +00:00
Mihai Alexandru Michis
31345d61d8 Backed out changeset cd08191c18c9 (bug 1662789) for causing bustages in ScopedGfxFeatureReporter
CLOSED TREE
2020-09-02 22:10:30 +03:00
Nathan Froyd
55437f2e0c Bug 1662251 - stop assigning from NS_Convert* values, mostly; r=sg
This patch was generated by running:

```
perl -p -i \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF8toUTF16\((.*)\);/\1CopyUTF8toUTF16(\3, \2);/;' \
     -e 's/^(\s+)([a-zA-Z0-9.]+) = NS_ConvertUTF16toUTF8\((.*)\);/\1CopyUTF16toUTF8(\3, \2);/;' \
     $FILE
```

against every .cpp and .h in mozilla-central, and then fixing up the
inevitable errors that happen as a result of matching C++ expressions with
regexes.  The errors fell into three categories:

1. Calling the convert functions with `std::string::c_str()`; these were
   changed to simply pass the string instead, relying on implicit conversion
   to `mozilla::Span`.
2. Calling the convert functions with raw pointers, which is not permitted
   with the copy functions; these were changed to invoke `MakeStringSpan` first.
3. Other miscellaneous errors resulting from over-eager regexes and/or the
   replacement not being type-aware.  These changes were reverted.

Differential Revision: https://phabricator.services.mozilla.com/D88903
2020-09-02 09:54:37 +00:00
Jeff Gilbert
6b5aa0513b Bug 1662789 - Add IpcWebGL?/IpcWebGL+ feature annotation. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D89177
2020-09-02 17:14:23 +00:00
Jeff Gilbert
7bd3d09c94 Bug 1661328 - Enable Mac webgl-ipc tests on Central. r=jmaher,lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D89038
2020-09-01 23:29:01 +00:00
Jeff Gilbert
f57e96ec1d Bug 1656991 - Handle surf alloc failure gracefully. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D89061
2020-09-01 23:29:44 +00:00
Jeff Gilbert
9762dd2876 Bug 1660886 - Release PWebGL when ClientWebGLContext is done with it. r=handyman,jld
Differential Revision: https://phabricator.services.mozilla.com/D88067
2020-08-27 00:50:32 +00:00
Jeff Gilbert
2b5ce9bf71 Bug 1656545 - Range cannot support nullptr with non-zero length. r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D87528
2020-08-20 00:33:52 +00:00
Emilio Cobos Álvarez
c388355156 Bug 1657402 - Turn webgl.enable-debug-renderer-info into a static pref. r=jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D86036
2020-08-05 17:43:20 +00:00
Jeff Gilbert
6671e9e3e0 Bug 1656034 - Add UnderlyingValue() to mfbt. - r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D85495
2020-07-31 23:04:44 +00:00
Jeff Walden
d6ec80e9ec Bug 1656411 - Move typed array, ArrayBuffer, and dataview-related functions out of jsfriendapi.h to two new headers. r=mgaudet,jgilbert
Differential Revision: https://phabricator.services.mozilla.com/D85524
2020-07-31 16:37:27 +00:00
Jeff Gilbert
6e48f9d1a9 Bug 1607940 - IPC TexImage. r=lsalzman,nika,handyman
Differential Revision: https://phabricator.services.mozilla.com/D83291
2020-07-21 22:57:01 +00:00
Jeff Gilbert
f60d94e923 Bug 1607940 - Stand up webgl.out-of-process:true path. r=handyman,nika,froydnj
* Use clearer pref names.
* Default (and only support) IPDL dispatching.
* Make DispatchCommands async-only.
* Sync ipdl command per sync webgl entrypoint.
  * Eat the boilerplate cost, since there's not too many.
* Run SerializedSize off same path as Serialize.
* All shmem uploads go through normal DispatchCommands.
* Defer pruning of dead code for now so we can iterate quickly.
* Use Read/Write(begin,end) instead of (begin,size).
  * This would have prevented a bug where we read/wrote N*sizeof(T)*sizeof(T).

Differential Revision: https://phabricator.services.mozilla.com/D81495
2020-07-21 22:56:52 +00:00
Jeff Gilbert
39d8a13e59 Bug 1654048 - Release NotLost in CC unlink for std::shared_ptr<webgl::NotLostData>&. r=lsalzman
Differential Revision: https://phabricator.services.mozilla.com/D84210
2020-07-20 18:52:12 +00:00