Commit Graph

104 Commits

Author SHA1 Message Date
Mike Conley
6ac3614ea7 Bug 1842605 - Handle errors in loading passwords from Safari CSV files. r=kpatenio,fluent-reviewers,bolsson
This also fixes some incorrect inline documentation I found in some of our tests,
and fixes a case where we were showing the warning state for importing bookmarks
in browser_safari_passwords.js.

Differential Revision: https://phabricator.services.mozilla.com/D183506
2023-07-13 20:55:05 +00:00
Mike Conley
f2f2869242 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 18:31:19 +00:00
Cristina Horotan
90490ed96b Backed out 2 changesets (bug 1823489) for causing bc failures at browser_multistage_spotlight.js
Backed out changeset 684648252672 (bug 1823489)
Backed out changeset 15437d29bacc (bug 1823489)
2023-07-10 17:47:20 +03:00
Mike Conley
55bee439b7 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-10 13:34:04 +00:00
Stanca Serban
ecb95f5427 Backed out 2 changesets (bug 1823489) for causing multiple bc failures.
Backed out changeset da128472125a (bug 1823489)
Backed out changeset dd5996a4e7d2 (bug 1823489)
2023-07-08 21:11:49 +03:00
Mike Conley
3bccb141ec Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-08 16:18:01 +00:00
Noemi Erli
043702d68b Backed out 2 changesets (bug 1823489) for causing failures in test_panel_list_min_width_from_anchor.html
Backed out changeset abe4ae7a4c01 (bug 1823489)
Backed out changeset ccb73c7c777a (bug 1823489)
2023-07-07 19:05:56 +03:00
Mike Conley
1d3fdc07d8 Bug 1823489 - Have the migration-wizard element create the panel-list in its shadow root. r=kpatenio,negin,desktop-theme-reviewers,dao
This involves opening the shadow root of the migration wizard, as the panel-list
really isn't designed to handle being embedded within a closed shadow root.

Differential Revision: https://phabricator.services.mozilla.com/D182484
2023-07-07 15:19:49 +00:00
Mike Conley
55ce4f172e Bug 1840489 - Rename success-text class to message-text to reflect that non-success states can use that class. r=tgiles
Differential Revision: https://phabricator.services.mozilla.com/D182391
2023-07-05 14:35:15 +00:00
Mike Conley
875b2b901a Bug 1840488 - Change from classes to a state attribute for the migration wizard progress icon. r=tgiles,desktop-theme-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D182274
2023-06-28 16:46:19 +00:00
negin
b882e48890 Bug 1837051 - Add Embedded Migration Wizard support for spotlight dialog r=omc-reviewers,pdahiya,mconley
Differential Revision: https://phabricator.services.mozilla.com/D180713
2023-06-23 19:23:51 +00:00
Mike Conley
669193a9a3 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
2023-06-22 13:48:51 +00:00
Norisz Fay
de0f4e32f7 Backed out 2 changesets (bug 1839462) as requested by dev CLOSED TREE
Backed out changeset a61155e9121f (bug 1839462)
Backed out changeset 99d02fe665aa (bug 1839462)
2023-06-21 23:42:10 +03:00
Mike Conley
b02bff5657 Bug 1839462 - Modify migration event telemetry for extensions migration. data-review=jhirsch, r=tgiles
Depends on D181298

Differential Revision: https://phabricator.services.mozilla.com/D181566
2023-06-21 20:24:57 +00:00
Tim Giles
6d7971b059 Bug 1836773 - Support the new MigrationResource in the migration wizard. r=mconley,willdurand,fluent-reviewers,desktop-theme-reviewers,flod
Enables support for migrating extensions from Chrome once we have the
API to match and install extensions from the add-ons store.

Adds a new ProgressState object to delineate between various progress
states. This new object has four properties: value, message, linkURL,
and linkText. See migration-wizard-constants for more information.

MigrationWizard.#onShowingProgress uses the new ProgressState object
to handle the new LOADING, SUCCESS, ERROR and INFO values for progress.
This has the added benefit of updating the UI on error cases for the
existing resource groups.

Adds a new details object parameter to MigratorBase.migrate which is
currently used in the Chrome extensions import case.
See ChromeProfileMigrator.GetExtensionsResource for an example of
creating this details object.
See MigrationWizardParent.#doBrowserMigration for example usage of this
details object.

Adds support-text links under each resource type group in the markup.
This is currently used only by extensions in the partial matching and
no matching extensions cases.

Refactor MigrationUtils.installExtensionsWrapper to return an array
with the progress state (LOADING, SUCCESS, ERROR, INFO) and any
imported extensions.

Depends on D180005

Differential Revision: https://phabricator.services.mozilla.com/D180876
2023-06-21 20:24:56 +00:00
Mike Conley
99e87d9a44 Bug 1837367 - Allow file migrators to show an error message if migration failed for some reason. r=kpatenio,desktop-theme-reviewers
The spec calls for a special-case in the event that file migration
ever fails - the wizard should be sent back to the selection page,
have the associated file migrator still set in the dropdown, and
show an error message.

A later patch in this series will add such an error message for
the bookmarks file migrator.

Depends on D180458

Differential Revision: https://phabricator.services.mozilla.com/D180490
2023-06-13 14:53:00 +00:00
Mike Conley
1ddda0a319 Bug 1837619 - Make sure to clear the file progress status message when going back to in-progress. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D180458
2023-06-12 19:45:51 +00:00
Mike Conley
e27d937911 Bug 1823537 - Add tests for the ported telemetry probes. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D180232
2023-06-09 17:39:51 +00:00
Mike Conley
bb66c4f000 Bug 1823537 - Port some older telemetry probes from the old migration wizard to the new one. r=Gijs
Those probes are:
* migration.uninstaller_profile_refresh (scalar)
* migration.discovered_migrators (keyed scalar)
* FX_MIGRATION_SOURCE_BROWSER (histogram)
* FX_MIGRATION_USAGE (histogram)
* FX_MIGRATION_ERRORS (histogram)

Not being ported are the following histograms:
* FX_STARTUP_MIGRATION_BROWSER_COUNT
* FX_STARTUP_MIGRATION_EXISTING_DEFAULT_BROWSER
* FX_STARTUP_MIGRATION_DATA_RECENCY
* FX_STARTUP_MIGRATION_USED_RECENT_BROWSER

as these are all expired.

Differential Revision: https://phabricator.services.mozilla.com/D180231
2023-06-09 17:39:51 +00:00
Mike Conley
9dcf68ac4d Bug 1823537 - Use new migration wizard for startup and profile reset migrations. r=kpatenio,Gijs,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D180230
2023-06-09 17:39:51 +00:00
Mike Conley
4972dd2d5f Bug 1833427 - Add bookmark import from HTML file in new migration wizard. r=fluent-reviewers,kpatenio,flod
Original patch by Tim Giles <tgiles@mozilla.com>, completed by Mike Conley <mconley@mozilla.com>.

Differential Revision: https://phabricator.services.mozilla.com/D179273
2023-05-30 13:37:54 +00:00
Mike Conley
e62aa51bdc Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
2023-05-29 16:12:41 +00:00
Butkovits Atila
9664e002bb Backed out changeset 863fae78db03 (bug 1825874) for causing failures at browser_disabled_migrator.js. CLOSED TREE 2023-05-29 18:34:53 +03:00
Mike Conley
e359cbe532 Bug 1825874 - Offer to import passwords from a CSV file for Safari. r=kpatenio
Safari doesn't let us import all passwords from Keychain at once. Instead,
the user needs to authorize each read from Keychain one by one. This is
not tenable for password import.

Instead, we show the user instructions on how they can export their passwords
from Safari into a CSV file that can then be imported. This patch adds support
for showing those instructions (which had landed earlier in bug 1818789) and
then importing from that CSV file upon selection.

The data-review for the safari_password_file Telemetry event being used here
was done earlier in bug 1824786.

Differential Revision: https://phabricator.services.mozilla.com/D175669
2023-05-29 14:39:59 +00:00
Mike Conley
dc1b375397 Bug 1826149 - Add payment method migration experience in new migration wizard. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D178364
2023-05-25 20:16:04 +00:00
Mike Conley
12aaa8d45f Bug 1830891 - Clear new migration wizard progress strings when going back to in-progress. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D178856
2023-05-23 23:13:26 +00:00
Mike Conley
ad6b556e37 Bug 1832227 - Use a button label that matches the instructions for migrating from Safari. r=flod,niklas
Differential Revision: https://phabricator.services.mozilla.com/D177806
2023-05-15 14:50:59 +00:00
negin
ba615fe519 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-10 13:08:59 +00:00
Narcis Beleuzu
6d06f48e1a Backed out changeset 86f74f61adc0 (bug 1829039) for newtab failure on aboutwelcome.scss 2023-05-10 00:43:26 +03:00
negin
4ca699875e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-09 20:22:09 +00:00
Cosmin Sabou
191135a322 Backed out changeset f1e19e0fa144 (bug 1829039) as requested by aminomancer. CLOSED TREE 2023-05-09 20:05:34 +03:00
negin
952dfbc88c Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-09 16:41:53 +00:00
Norisz Fay
32ae2d7897 Backed out changeset 67d785ab3cb3 (bug 1829039) for causing node-newtab failure on aboutwelcome.scss CLOSED TREE 2023-05-09 17:35:44 +03:00
negin
dd6b50d41e Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-09 13:46:13 +00:00
Cristian Tuns
05c7ba7f52 Backed out changeset 743c4f059b79 (bug 1829039) for causing bc failures in browser_aboutwelcome_multistage_mr.js CLOSED TREE 2023-05-05 19:50:02 -04:00
negin
087c181c62 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-05 19:30:31 +00:00
Stanca Serban
8fc4f98984 Backed out changeset 72f882230f63 (bug 1829039) for causing mochitests failures in browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-05 04:28:52 +03:00
negin
c514f3673d Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
This patch fixes the font size inconsistencies, extra whitespace above title, and lack of transition animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-04 23:32:12 +00:00
Cosmin Sabou
5eecdbf11c Backed out changeset cdaa6a0312f0 (bug 1829039) for causing increase in failures on browser_aboutwelcome_multistage_mr.js. CLOSED TREE 2023-05-03 19:40:03 +03:00
negin
717bd31e75 Bug 1829039 - Updates embedded migration wizard styles to match figma r=aminomancer,mconley
This patch fixes the font size inconsistencies, extra whitespace above title, and introduces simplified animations for [Embedded Migration Wizard](https://www.figma.com/file/c83OEio9DhCQKuabx2tIEl/NUO-Experiments-2023?node-id=976-31535) screen. Other feedback from the initial bug has been broken down into other bugs:

* [Position relative feedback bug](https://bugzilla.mozilla.org/show_bug.cgi?id=1829272)
* [Checkbox spacing](https://bugzilla.mozilla.org/show_bug.cgi?id=1829733)
* Logo feedback - syncing up with Gabrielle and will file a follow-up bug depending on what we want to do (figma does not include the logo)

Differential Revision: https://phabricator.services.mozilla.com/D176352
2023-05-03 13:46:47 +00:00
Mike Conley
76072f1bb0 Bug 1830726 - Only show the scrollbar in the migration wizard browser profile selector when there is something to scroll to. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D176810
2023-05-01 18:22:22 +00:00
Mike Conley
819a3c15f1 Bug 1829733 - Remove extraneous block margin around migration wizard checkboxes. r=niklas
This also updates the iterator that was - unchecking and hiding all of
the resource checkboxes during the start of the routine that runs
when the browser / profile selector changes. This original iterator
was accidentally including the "Select All" checkbox from Variant 2,
and setting the "hidden" attribute on it. That attribute has no effect,
but it _does_ cause the label:not([hidden]) selector in the migration
wizard to not select it, which cause the label to not have the right
vertical alignment.

This patch updates the iterator to just select and hide the checkboxes
that have resources associated with them.

Differential Revision: https://phabricator.services.mozilla.com/D176342
2023-04-26 20:27:13 +00:00
elephanteatsapple
9a04884ec9 Bug 1827903 - Browser list is cut off inside Import Browser data when having multiple browsers or profiles or reduced height.r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D175447
2023-04-21 13:18:42 +00:00
Mike Conley
efc612f60b Bug 1829196 - Use the term 'Continue' rather than 'Done' in the success state of the new migration wizard when embedding. r=niklas,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D176072
2023-04-21 03:18:13 +00:00
Mike Conley
ca528a2ed9 Bug 1820640 - Enforce left-alignment and expose the button containers for the new Migration Wizard. r=kpatenio
This is so that the contents of the Migration Wizard don't get automatically
centered if its embedding context is centering things.

This change also makes it so that embedders can customize some of the rules of how
buttons are laid out.

Differential Revision: https://phabricator.services.mozilla.com/D171771
2023-04-21 03:18:12 +00:00
Mike Conley
a98705b9fd Bug 1828758 - Make Password file migrator only available if importing logins from CSV is enabled. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D175804
2023-04-18 22:36:26 +00:00
Mike Conley
73c69aafb8 Bug 1828463 - Make file migrator icon the same size as browser icons in the browser-profile-selector dropdown. r=niklas,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D175677
2023-04-18 19:22:25 +00:00
Mike Conley
4922e2e5c2 Bug 1827204 - Set the right aria roles and attributes for the browser profile selector in the new migration wizard. r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D175052
2023-04-18 14:31:50 +00:00
Mike Conley
3b8c2d4517 Bug 1827274 - Allow users to use file importers after showing NO_BROWSERS_FOUND page in the new migration wizard. r=kpatenio,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D175069
2023-04-14 17:37:57 +00:00
Mike Conley
8cf40900bd Bug 1828003 - Remove aria-live attribute from new Migration Wizard deck to reduce chattiness. r=nlapre
Differential Revision: https://phabricator.services.mozilla.com/D175410
2023-04-13 21:31:39 +00:00