Commit Graph

58 Commits

Author SHA1 Message Date
Sarah Clements
80033d41ab Bug 1843587 - Change getClosedTabData param to default to non-private window object r=sfoster,fxview-reviewers,sessionstore-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D183739
2023-07-18 11:11:21 +00:00
Sam Foster
b23b17ffa1 Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Cosmin Sabou
a41e837bdf Backed out 2 changesets (bug 1819675) for causing a spike in wpt and browser-chrome failures.
Backed out changeset aa4368bfb81a (bug 1819675)
Backed out changeset e5be8edfd9cf (bug 1819675)
2023-07-08 13:44:40 +03:00
Sam Foster
5ddefef54e Bug 1819675 - Include tabs from all windows in all views of recently-closed tabs and re-open them into the current window. r=dao,sclements,fxview-reviewers,fluent-reviewers,flod,robwu,sessionstore-reviewers,tabbrowser-reviewers
* Menu Bar History menu recently-closed tab items includes closed tabs from all currently-open windows
* Toolbar/Appmenu history menu recently-closed tabs list includes closed tabs from all currently-open windows
* Firefox view recently-closed tab list includes closed tabs from all currently-open windows
* All recently-closed tab menu/items re-open in the current window
* Re-open all tabs menu item re-opens all tabs into the current window

* Ensure we filter out tabs without any useful state in firefox-view
* Add a target window argument to undoCloseTab and undoCloseById
* undoCloseTab will remove the tab data from the source window collection and re-open the tab into the target window
* Add an options argument to SessionStore.getWindows to get all private or non-private windows
* Add a getWindowForTabClosedId method on SessionStore, allowing look-up of the window associated with a closed tab
* Ensure recently-closed tab lists only include tabs from non-private windows when attached (i.e. opened from) a non-private window. And vice-versa.
* Update the sessionstore closed tab tests to assert on the new behavior

* Update the browser.sessions.restore implementation to always find and pass the source window when restoring a closed tab
* sessions.restore should always restore closed tabs to the source window as there's no implicit top or current window in the API context

Differential Revision: https://phabricator.services.mozilla.com/D174501
2023-07-06 22:49:52 +00:00
Sam Foster
ffc79712f2 Bug 1819675 - rename SessionStore.getClosedTabCount and getClosedTabData to getClosedTabCountForWindow and getClosedTabDataForWindow. r=dao,fxview-reviewers,kcochrane
- As closed tabs will change to mean closed tabs from all windows, rename these functions to make
  changes in later patches clearer when we mean closed tabs from this window specifically, or closed
  tabs for all private/non-private windows

Differential Revision: https://phabricator.services.mozilla.com/D177849
2023-05-30 18:54:12 +00:00
Mark Banner
91fde42f7b Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
Mike Kaply
1e64806384 Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-09 18:09:17 +00:00
Noemi Erli
ed26d7ff89 Backed out changeset 9e894095a614 (bug 1831601) for causing failures in browser_all_files_referenced.js CLOSED TREE 2023-05-08 18:15:12 +03:00
Mike Kaply
489564949e Bug 1831601 - Switch view chrome URLS to have a firefoxview specific path. r=kcochrane,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D177283
2023-05-08 14:11:12 +00:00
Jonathan Sudiaman
e5c848d3db Bug 1828736 - Change recently closed list items into links that support context clicking r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D175823
2023-04-20 12:51:58 +00:00
Kelly Cochrane
9f600e8dfc Bug 1824358 - Don't update textContent for elements in Recently Closed tabs in Fx View to prevent Lit errors r=mstriemer,fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D173547
2023-03-27 16:04:54 +00:00
Sam Foster
ce23bda9d6 Bug 1794435 - Make updateTime a noop when the updateTimeMs pref is 0. r=fxview-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D173225
2023-03-22 18:36:54 +00:00
Kelly Cochrane
ddc240c8c3 Bug 1822089 - [Fx View] Switch recently closed items back from role='link' to role='button' r=sclements,fxview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D172436
2023-03-13 18:06:16 +00:00
Kelly Cochrane
3d928092de Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D169010
2023-02-24 21:32:25 +00:00
Marian-Vasile Laza
7357f8910d Backed out changeset 2ca3d042a78d (bug 1801204) for causing multiple bc failures. 2023-02-14 00:19:16 +02:00
Kelly Cochrane
e79280b5e0 Bug 1801204 - Update recently-closed-tabs.mjs to be template-driven r=sfoster,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D169010
2023-02-13 20:56:56 +00:00
Kelly Cochrane
7fdda39974 Bug 1804244 - Remove existing tabs in Recently Closed tabs list in Fx View if not found in latest closed tabs data r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D166208
2023-01-12 20:20:55 +00:00
Norisz Fay
6a7b899764 Backed out changeset 2acf2ea39486 (bug 1804244) for causing failures on browser_recently_closed_tabs.js CLOSED TREE 2023-01-12 21:17:15 +02:00
Kelly Cochrane
89fd2e6fb8 Bug 1804244 - Remove existing tabs in Recently Closed tabs list in Fx View if not found in latest closed tabs data r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D166208
2023-01-12 18:35:15 +00:00
prathikshaprasadsuman
412010c031 Bug 1789533 - Improve title text (tooltips) experience in Firefox View. r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D164460
2022-12-14 21:39:00 +00:00
Kelly Cochrane
60c2e8256e Bug 1804099 - Add new telemetry event for recording tab dismissal from Recently Closed tabs in Fx View r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D163878
2022-12-07 15:05:13 +00:00
Gijs Kruitbosch
965c6e86fc Bug 1803158 - convert session restore consumers to reference the sys.mjs files instead, r=webdriver-reviewers,perftest-reviewers,extension-reviewers,credential-management-reviewers,Standard8,sgalich,whimboo,sparky,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D163350
2022-12-06 16:02:03 +00:00
Kelly Cochrane
d989c8bc35 Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D163719
2022-12-02 19:31:45 +00:00
Stanca Serban
fb83fffbb8 Backed out changeset 6c9b61f0bdaf (bug 1803763) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-12-02 19:34:20 +02:00
Kelly Cochrane
085abb39b4 Bug 1803763 - Add title attribute to recently closed tab dismiss button r=dao,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D163719
2022-12-02 16:06:53 +00:00
Kelly Cochrane
bacaafe92b Bug 1787945 - Add dismiss functionality to recently closed tabs list items in Fx View r=ayeddi,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D161848
2022-11-30 16:24:15 +00:00
Gijs Kruitbosch
3fd7180951 Bug 1789043 - use existing NOTIFY_BROWSER_SHUTDOWN_FLUSH on firefox view to be told about closing tabs, r=sclements
Differential Revision: https://phabricator.services.mozilla.com/D163216
2022-11-30 14:13:41 +00:00
Tim Giles
66cd4e5a23 Bug 1789875 - Allow restoring recently closed tabs with Space bar. r=sclements,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D160538
2022-10-31 13:54:33 +00:00
Tim Giles
3a7d010064 Bug 1789875 - Add list style keyboard navigation to the recently closed list. r=sclements,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D158151
2022-10-31 13:54:32 +00:00
Sarah Clements
87b1fd9667 Bug 1789042 - Prepend page-icon to url if image is null in Recently Closed Tabs list r=mak
Differential Revision: https://phabricator.services.mozilla.com/D160050
2022-10-28 13:38:07 +00:00
Sarah Clements
5fbcd1d91f Bug 1770471 - Use undoCloseById instead of undoCloseTab in Firefoxview r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D160388
2022-10-28 13:32:49 +00:00
Kelly Cochrane
1a02174385 Bug 1792099 - Allow for text selection in Recently Closed Tabs when holding Alt/Opt key r=Gijs,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D158708
2022-10-11 21:47:16 +00:00
Mark Banner
79b9557a71 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 21:47:50 +00:00
Marian-Vasile Laza
b7f6194b8d Backed out changeset 0679274d6ed5 (bug 1792398) for causing bc failures on browser_sendQuery.js. CLOSED TREE 2022-09-26 22:53:00 +03:00
Mark Banner
5dcae1ed44 Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 18:51:57 +00:00
Narcis Beleuzu
95ae6b7d0f Backed out changeset 849faf753208 (bug 1792398) for bc failures on browser_sendQuery.js . CLOSED TREE 2022-09-26 20:44:40 +03:00
Mark Banner
ff212fab8b Bug 1792398 - Enable ESLint rule 'strict' on mjs files as the directive is not necessary for modules. r=arai,pip-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D158115
2022-09-26 16:51:10 +00:00
Jared Hirsch
0ca0f19c16 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156754
2022-09-14 17:18:35 +00:00
Sandor Molnar
e5de5b30e6 Backed out changeset dd71b6e79551 (bug 1779384) for causing browser-chrome failures in browser/components/firefoxview/tests/browser/browser_recently_closed_tabs.js CLOSED TREE 2022-09-14 04:59:04 +03:00
Jared Hirsch
e2d8d3f927 Bug 1779384 - Persist collapsed state of Firefox View lists r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D156754
2022-09-13 23:18:34 +00:00
Gijs Kruitbosch
6e20818109 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
2022-09-04 08:04:09 +00:00
Iulian Moraru
5282da4259 Backed out changeset b63ab5a39b53 (bug 1787565) for causing bc failures on browser_recently_closed_tabs.js. CLOSED TREE 2022-09-03 14:09:15 +03:00
Gijs Kruitbosch
8f8fa020b4 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
2022-09-03 09:53:55 +00:00
Sam Foster
1bbdf0032f Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-02 18:53:21 +00:00
Butkovits Atila
dd9a633a7c Backed out changeset df6d4e6e452c (bug 1787565) for causing failures at browser_ext_browserAction_popup_resize_bottom.js. 2022-09-02 16:26:14 +03:00
Gijs Kruitbosch
2a1088e2f8 Bug 1787565 - update recently closed tab entries in Firefox View based on delayed tab navigation information from session history, r=sclements
I don't love this solution but it appears to work and I can't think of anything better.

Differential Revision: https://phabricator.services.mozilla.com/D155920
2022-09-02 12:32:45 +00:00
Noemi Erli
ec9494988d Backed out changeset 59536058a947 (bug 1784902) for causing failures in browser_setup_state.js 2022-09-02 04:42:49 +03:00
Sam Foster
fe2b36be03 Bug 1784902 - Implement the collapsible fx-view sections as details/summary elements. r=Gijs
* Both CEs now extend HTMLDetailsElement
* Keep the title string on the twisty/toggle element
* The whole summary element gets the focus highlight, and is clickable to collapse/expand the associated content
* Ensure the summary focus outline doesnt get clipped by the zap-card border below it
* Maintain the hover behavior on the twisty button to provide a visual cue for collapsibility
* The setup cards will be collapsible in all states, bug 1779384 will ensure we ignore a persisted closed state during sync setup so this content is always initially visible in a new session

Differential Revision: https://phabricator.services.mozilla.com/D155508
2022-09-01 22:30:42 +00:00
Bernard Igiri
3225b41e4c Bug 1770467 - Add arrow key nav to Recently Closed Tabs r=sfoster,sclements
Added arrow key navigation to recently closed tabs.

Differential Revision: https://phabricator.services.mozilla.com/D154402
2022-08-15 16:45:22 +00:00
Niklas Baumgardner
ba5d19f1f6 Bug 1779642 - Add telemetry for Firefox View. r=Gijs,sfoster
Differential Revision: https://phabricator.services.mozilla.com/D152437
2022-08-09 12:47:38 +00:00