Commit Graph

239 Commits

Author SHA1 Message Date
Emilio Cobos Álvarez
08a3c18595 Bug 1755315 - Add more convenient accessors for widget screen to chrome code. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D138662
2022-02-17 16:22:58 +00:00
Emilio Cobos Álvarez
2b4bcbce12 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-16 12:18:12 +00:00
smolnar
ac36389b37 Backed out 6 changesets (bug 1753836) for causing mochitest failures in test_event_screenXY_with_zoom. CLOSED TREE
Backed out changeset a572cbc0fac2 (bug 1753836)
Backed out changeset 371a495ff728 (bug 1753836)
Backed out changeset 774af76be463 (bug 1753836)
Backed out changeset faa8a8f2d40f (bug 1753836)
Backed out changeset 9209832ecffe (bug 1753836)
Backed out changeset db443ce0406d (bug 1753836)
2022-02-16 01:47:51 +02:00
Emilio Cobos Álvarez
1f6fc3a3d9 Bug 1753836 - Fix callers of screenForRect to pass desktop pixels. r=jfkthame,Gijs
Device pixels and desktop pixels are not the same on macOS and Win7.
Expose the desktop-to-device scale to JS and use it appropriately.

Depends on D138038

Differential Revision: https://phabricator.services.mozilla.com/D138039
2022-02-15 22:25:04 +00:00
Emilio Cobos Álvarez
09d941de74 Bug 1741830 - Fix front-end callers of screenForRect in HiDPI environments. r=Gijs
screenForRect takes screen coordinates (device pixels, for our purpose here).

However screenX / screenY are in CSS pixels, so we need to convert them to the
right coordinate space before looking up the screen.

Differential Revision: https://phabricator.services.mozilla.com/D137895
2022-02-05 15:44:43 +00:00
Gijs Kruitbosch
fb2c0a460f Bug 1752460 - drop references to unused 'navigable' class name from panel UI menu handling, r=sfoster
Differential Revision: https://phabricator.services.mozilla.com/D137449
2022-01-31 20:41:02 +00:00
Scott
9c09e77b2e Bug 1737868 - Pocket panel overflow menu not properly getting the remote attribute. r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D130770
2021-11-16 00:35:34 +00:00
Neil Deakin
0d6adaeabb Bug 1733786, replace uitour implementation of show how button with one that focuses the item on the app menu and submenu instead, r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D128428
2021-10-19 14:54:45 +00:00
Julien Wajsberg
78d61c1786 Bug 1681539 - Add a profiler marker for descriptionHeightWorkaround r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D126203
2021-10-05 09:13:12 +00:00
Michael Kohler
b40a4cb123 Bug 1702200 - Add toolbarseparator when header already exist when showing subview r=mconley
The toolbarseparator is added the first time a subview is opened. However for subsequent times the header already exists and we bailed out early without adding the separator.

Differential Revision: https://phabricator.services.mozilla.com/D122907
2021-08-30 07:11:24 +00:00
Alexandru Michis
358b440255 Backed out changeset 55776bb2f806 (bug 1702200) for causing failures in nsSocketTransport.
CLOSED TREE
2021-08-26 20:42:55 +03:00
Michael Kohler
8ad1631010 Bug 1702200 - Add toolbarseparator when header already exist when showing subview r=mconley
The toolbarseparator is added the first time a subview is opened. However for subsequent times the header already exists and we bailed out early without adding the separator.

Differential Revision: https://phabricator.services.mozilla.com/D122907
2021-08-26 16:48:01 +00:00
Michelle Goossens
80e0801348 Bug 1711515 - Remove gProtonDoorhangers, gProtonDoorhangersEnabled, and gProtonAppMenuEnabled from various jsms and other frontend (non-test) code r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D116246
2021-05-28 18:07:15 +00:00
Markus Stange
4b2c5e6c55 Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-20 17:44:16 +00:00
Narcis Beleuzu
2fd43d5a0b Backed out 7 changesets (bug 1704948, bug 1704879) for bc failures on browser_ext_menus_capture_secondary_click.js
Backed out changeset 02705918c4bf (bug 1704879)
Backed out changeset 79945b876a1d (bug 1704879)
Backed out changeset eb725de20b11 (bug 1704948)
Backed out changeset 454597ac2ba3 (bug 1704948)
Backed out changeset a43a8ef206ea (bug 1704948)
Backed out changeset 2369e321069e (bug 1704948)
Backed out changeset bdf396edd692 (bug 1704948)
2021-04-15 03:30:52 +03:00
Markus Stange
7f0c1757af Bug 1704948 - Give XULCommandEvent a button property. r=smaug,preferences-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D111955
2021-04-14 21:23:27 +00:00
Mike Conley
632adba6fc Bug 1695348 - Mass rename browser.proton.appmenu.enabled to browser.proton.enabled. r=emalysz,desktop-theme-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D106800
2021-03-01 17:27:52 +00:00
Emma Malysz
f11211967a Bug 1694648, ensure toolbarseparators are added correctly for menu headers when proton is enabled r=mconley
Differential Revision: https://phabricator.services.mozilla.com/D106310
2021-02-24 21:28:23 +00:00
Mike Conley
895d964a1d Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105081
2021-02-24 02:52:30 +00:00
Dorel Luca
3c18ad591d Backed out 2 changesets (bug 1688960, bug 1693177) for Browser-chrome failures in browser/base/content/test/sync/browser_sync.js. CLOSED TREE
Backed out changeset 13e08408add0 (bug 1693177)
Backed out changeset a34474998cd6 (bug 1688960)
2021-02-24 03:36:21 +02:00
Mike Conley
b822f4d379 Bug 1688960 - Use h1 and h2 elements for panel headers and subheaders. r=Standard8,yzen,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D105081
2021-02-23 23:16:12 +00:00
Mike Conley
b9c2415b31 Bug 1692630 - Apply more Proton styles for headers and subheaders in the AppMenu. r=mtigley
Differential Revision: https://phabricator.services.mozilla.com/D105786
2021-02-19 17:45:25 +00:00
Emma Malysz
f27d0ead3c Bug 1689366, simplify bookmark panel r=fluent-reviewers,mconley,flod
Differential Revision: https://phabricator.services.mozilla.com/D103402
2021-02-02 18:56:19 +00:00
Kartik Gautam
b2cd2a8893 Bug 1677247 - Replace :not(:is(X)) with :not(X) in the codebase. r=emilio
Differential Revision: https://phabricator.services.mozilla.com/D97943
2020-11-25 04:23:25 +00:00
emcminn
068da3c345 Bug 1669483 - Restore keyboard navigation to WhatsNewPanel footer r=Jamie,andreio
`oncommand` has been replaced with `onclick` for the checkbox in the WhatsNewPanel footer. `oncommand` was
causing the checkbox state to get out of sync with the pref when the keyboard was used. Since PanelMultiView treats
'enter' and 'space' presses as click events, using `onclick` gives us keyboard navigation while keeping the
pref in sync.

Differential Revision: https://phabricator.services.mozilla.com/D94454
2020-11-02 18:42:38 +00:00
Brad Werth
99fa1b63ae Bug 1634556 Part 1: Make web extension sidebars listen to zoom enlarge/reduce events. r=mixedpuppy
These events are fired for all parent process documents by the code that
handles native mousewheel events. This change adds listeners to those events
and handles them similarly to how they are handled for browsers.

Differential Revision: https://phabricator.services.mozilla.com/D84767
2020-10-26 16:20:59 +00:00
Emilio Cobos Álvarez
7a3751edb9 Bug 1666497 - Don't flush layout from popuppositioned events. r=mconley,Gijs,smaug
We don't need to flush before dispatching the event because we know that
if the values we cared about changed, then we'd get another event.

Differential Revision: https://phabricator.services.mozilla.com/D92444
2020-10-06 16:28:41 +00:00
Itiel
3a57098651 Bug 1631202 - Convert all uses of :-moz-any to :is in browser/ r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D90690
2020-09-21 19:35:35 +00:00
Emma Malysz
81a83433a7 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-10 17:09:55 +00:00
Butkovits Atila
9360ff6a6c Backed out changeset e71e10688704 (bug 1634030) for failure at browser_shim_disable_devtools.js CLOSED TREE 2020-08-08 03:46:14 +03:00
Emma Malysz
974077d255 Bug 1634030: lazify main app menu r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D84014
2020-08-07 22:02:32 +00:00
Emma Malysz
1f08b22e8b Bug 1648175, remove history and library panel views from the main panel and place in template r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D80306
2020-06-29 15:41:43 +00:00
Emilio Cobos Álvarez
e36413c4d7 Bug 1629096 - Always honor scroll-margin / scroll-padding from nsFocusManager. r=masayuki
We should always do this, otherwise stuff may not end up being visible which is
not acceptable for focus navigation.

Differential Revision: https://phabricator.services.mozilla.com/D70541
2020-04-13 11:34:48 +00:00
Kousuke Takaki
551a2aa73e Bug 1542975 - Radio buttons in Forget panel are not keyboard navigable r=Jamie
Differential Revision: https://phabricator.services.mozilla.com/D61820
2020-02-07 03:44:09 +00:00
gfmcknight
7733076174 Bug 1405031 - Add middle-click and click modifiers to browserAction r=robwu,Gijs
and pageActions.

Before this change, browserActions and pageActions did not trigger
onClick events when middle-clicked, and no information on the button or
any modifiers were passed in the onClick event. With this change, middle
clicking triggers an event, and a clickData object is passed in the
onClick event, with the button and a list of modifiers.

Differential Revision: https://phabricator.services.mozilla.com/D41492
2019-10-28 15:33:11 +00:00
Tim Nguyen
da27ed5d34 Bug 1513325 - Remove textbox binding. r=emilio,dao
Differential Revision: https://phabricator.services.mozilla.com/D38955
2019-10-09 09:27:28 +00:00
Gijs Kruitbosch
a9707e8401 Bug 1561581 - listen for key events in panels 'later' than the builtin menu handling code, r=jaws
Differential Revision: https://phabricator.services.mozilla.com/D44679
2019-09-18 22:48:15 +00:00
Gijs Kruitbosch
684845fd05 Bug 1580949 - avoid re-entry when showing extension subviews in the overflow panel, r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D46078
2019-09-17 14:57:52 +00:00
Nihanth Subramanya
830ee49ea8 Bug 1574196 - Properly wrap long subview header text in identity and protections panels. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D43335
2019-08-26 20:13:38 +00:00
Nihanth Subramanya
d87d51417e Bug 1572528 - [Protections Panel] Update category item subviews. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41271
2019-08-12 20:09:13 +00:00
Nihanth Subramanya
13a10607d3 Bug 1563093 - Set an attribute on PanelMultiView popups when the main view is showing, and use it to style the Protections Panel anchor arrow. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41204
2019-08-09 12:43:27 +00:00
Nihanth Subramanya
4dffe5766d Bug 1572416 - PanelMultiView: remove the min-height on the view container when navigating to the main view. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D41202
2019-08-09 12:43:15 +00:00
Jared Wein
a559a71435 Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745
2019-08-08 15:18:49 +00:00
Bogdan Tara
b60cea4f7a Backed out 10 changesets (bug 1571567) complementary backout after es lint failure on the patch CLOSED TREE
Backed out changeset ce83fa75ae32 (bug 1571567)
Backed out changeset 7aa97ba7cce9 (bug 1571567)
Backed out changeset 777d79076e99 (bug 1571567)
Backed out changeset fbdf6b75a484 (bug 1571567)
Backed out changeset e2ed4620f232 (bug 1571567)
Backed out changeset 2c67015f12c6 (bug 1571567)
Backed out changeset 7ec086bb5bd5 (bug 1571567)
Backed out changeset 42df735c8556 (bug 1571567)
Backed out changeset 7d5fc57b2809 (bug 1571567)
Backed out changeset 606bafb8211c (bug 1571567)
2019-08-08 18:13:54 +03:00
Jared Wein
8bcdbe62ed Bug 1571567 - Fix no-fallthrough errors in /browser. r=MattN,k88hudson
Differential Revision: https://phabricator.services.mozilla.com/D40745
2019-08-08 01:38:50 +00:00
James Teh
1f1c367bce Bug 1561517: PanelMultiView: Don't override the tab key when an open menulist has focus. r=johannh
Tab in an open menulist should close the menulist.
Previously, we were overriding the tab key in this case, which meant that the menulist remained open while focus moved elsewhere.

Differential Revision: https://phabricator.services.mozilla.com/D37835
2019-07-18 04:55:51 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
James Teh
6cf282f002 Bug 1557115: Fix PanelMultiView keyboard navigation for embedded iframes. r=Gijs
Bug 1545766 (D28442) tweaked PanelMultiView keyboard navigation to behave as expected for embedded browser elements.
This patch extends this to handle iframe elements such as used in the builtin Profiler panel.
In addition, it avoids setting tabindex="-1" on iframe and browser elements, since this breaks tabbing behavior in iframe elements (and possibly causes issues in browser elements as well).
iframe and browser elements are already focusable, so this isn't needed anyway.

Differential Revision: https://phabricator.services.mozilla.com/D34984
2019-06-14 09:44:55 +00:00
Andrew Swan
1ab513d145 Bug 1519577 Convert toolbarbutton to a custom element r=surkov
Differential Revision: https://phabricator.services.mozilla.com/D31941
2019-05-20 10:01:02 -07:00
James Teh
fc05c5a674 Bug 1547635: PanelMultiView: Don't override keyboard navigation in context menus. r=Gijs
Normally, context menu keyboard handling takes precedence.
However, because we have a capturing window keydown listener, our listener takes precedence.
Therefore, we need to check for an open context menu and suppress our keyboard handling in this case.

Differential Revision: https://phabricator.services.mozilla.com/D29791
2019-05-08 05:18:17 +00:00