Commit Graph

1187 Commits

Author SHA1 Message Date
Otto Länd
c333f002e7 Bug 1811281, 1812704: apply code formatting via Lando
# ignore-this-changeset
2023-01-31 16:24:28 +00:00
Mike Conley
58108e2c7e Bug 1812704 - Wire up the new MigrationWizard to MigrationUtils to let it perform migrations. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D167998
2023-01-31 15:30:58 +00:00
Mike Conley
9c17617fb0 Bug 1811281 - Open new MigrationWizard dialog as a SubDialog in about:preferences rather than a TabDialog. r=Gijs,settings-reviewers
This does a few things to support this new behaviour:

1. Adds the ability for about:preferences category modules to indicate that
   they want to specially handle subcategories. In this particular case, it
   causes the "migrate" subcategory of the "general" category to open up the
   migration dialog.
2. Updates MigrationUtils to open about:preferences#general-migrate if the opener
   is a tabbrowser window.
3. Adds some utility functions to make writing tests easier.
4. Updates existing tests to expect the wizard to be opened in the about:preferences
   subdialog.
5. Makes pressing "Escape" close the migration wizard when it's loaded in the
   migration-dialog.html document.

Differential Revision: https://phabricator.services.mozilla.com/D167873
2023-01-31 15:30:57 +00:00
Mike Conley
f5afc7a2e3 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-25 12:53:31 +00:00
Marian-Vasile Laza
9f616e2e60 Backed out changeset 97ee58e6c65d (bug 1811935) for causing bc failures on browser_dialog_cancel_close.js. CLOSED TREE 2023-01-25 04:06:11 +02:00
Mike Conley
2683edea63 Bug 1811935 - Adjust visibility of the resource types available for each migrator / profile pair in the new migration wizard. r=Gijs
This causes the MigrationWizardChild to request the full collection of available
migrators and user profiles, and then based on which resourceTypes those migrators
and user profiles have available, changes the visibility of the checkboxes in the
selection page of the new MigrationWizard component.

Differential Revision: https://phabricator.services.mozilla.com/D167617
2023-01-24 21:15:03 +00:00
Marco Bonardo
275a5e4803 Bug 1760074 - Frequent failure of test_MigrationUtils_timedRetry.js. r=Gijs
For how much it may sound strange, sometimes all the reads just happen before
the write, so they won't see the table.
Also fixes a wrong check on previousException.

Differential Revision: https://phabricator.services.mozilla.com/D167478
2023-01-23 15:44:10 +00:00
Mark Banner
2bd093b567 Bug 1811334 - Automatically replace Cu.reportError with console.error (most of browser/components). r=settings-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D167297
2023-01-20 17:49:21 +00:00
Otto Länd
2d62b90a6e Bug 1809498, 1810240: apply code formatting via Lando
# ignore-this-changeset
2023-01-17 20:33:50 +00:00
Mike Conley
d538cb869d Bug 1810240 - Make sure migration dialog container resizes when the wizard changes size. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D166839
2023-01-17 20:30:59 +00:00
Mike Conley
1bb03a6fc0 Bug 1809498 - Make browser.migrate.content-modal.enabled also control opening the new migration-dialog.html document. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166838
2023-01-17 20:30:58 +00:00
Mike Conley
10d5cbd8c2 Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-16 22:25:40 +00:00
Mike Conley
ce5bae69ff Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-16 22:25:40 +00:00
Csoregi Natalia
797db34488 Backed out 2 changesets (bug 1803447, bug 1809330) for failures on browser_dialog_cancel_close.js. CLOSED TREE
Backed out changeset 57167994f026 (bug 1809330)
Backed out changeset 4c1fd71421ab (bug 1803447)
2023-01-14 04:10:45 +02:00
Mike Conley
70e3458ae0 Bug 1809330 - Allow the MigrationWizard to close dialogs that it is embedded in. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D166392
2023-01-13 18:28:04 +00:00
Mike Conley
614f7fc403 Bug 1803447 - Implement progress page for the new migration wizard. r=hjones,kpatenio,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D165090
2023-01-13 18:28:03 +00:00
Ben Hearsum
01f485b050 Bug 1805919: disable tests that are currently failing against MSIX packages. r=jmaher,necko-reviewers,kershaw
Differential Revision: https://phabricator.services.mozilla.com/D165754
2023-01-11 14:45:03 +00:00
brian
ec76ee9539 Bug 1619090 - Clean up crypto modules that are used/referenced from various platforms. r=mconley,credential-management-reviewers,dimi.
Differential Revision: https://phabricator.services.mozilla.com/D164831
2023-01-05 15:38:11 +00:00
Mike Conley
4731915dc0 Bug 1808581 - Use moz-button-group for the new migration wizard. r=hjones
Differential Revision: https://phabricator.services.mozilla.com/D165978
2023-01-05 00:20:55 +00:00
Mike Conley
a7b26a4c0d Bug 1808608 - Move migration wizard constants into their own module for ease of use. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D165994
2023-01-05 00:20:54 +00:00
Marco Bonardo
c4325e1a9b Bug 1457131 - Remove no longer necessary PlacesUtils.toolbarFolderId. r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D165769
2023-01-04 13:16:10 +00:00
Sylvestre Ledru
173bbd66d5 Bug 1750450 - doc: fix some 'Title underline too short' warnings DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165654
2022-12-31 16:33:30 +00:00
Marco Castelluccio
ba39d286d5 Bug 1801836 - Remove no longer necessary 'from __future__' imports. r=linter-reviewers,glandium,webdriver-reviewers,perftest-reviewers,geckoview-reviewers,jld,ahal,owlish,afinder DONTBUILD
Differential Revision: https://phabricator.services.mozilla.com/D165395
2022-12-23 22:45:46 +00:00
Mike Conley
2a9002db47 Bug 1800733 - Fix macOS keychain values for Opera and Opera GX migrators. r=Gijs
It turns out we just had these two values wrong. Using the Keychain Access utility
on macOS, I was able to find the right values for both browsers and then do a
successfull password import from each.

Notably, both Opera and Opera GX share the same Keychain service and account
name despite being two separate products.

Differential Revision: https://phabricator.services.mozilla.com/D165180
2022-12-20 19:26:33 +00:00
Mike Conley
d619d82b5e Bug 1806128 - Fix path for migration wizard stylesheet when embedded in web-hosted Storybook. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D164909
2022-12-19 15:06:05 +00:00
Mike Conley
a3921de271 Bug 1800917 - Part 2: Disable Opera GX migrator for Linux, since it doesn't exist for that OS. r=niklas
Opera hasn't shipped Opera GX on Linux (yet), so it doesn't make sense to support it on that
platform since it can't be tested.

Depends on D164372

Differential Revision: https://phabricator.services.mozilla.com/D164373
2022-12-13 17:01:27 +00:00
Mike Conley
20577031be Bug 1800917 - Part 1: Fix paths for Opera and Vivaldi migrators on Linux. r=niklas
Depends on D164145

Differential Revision: https://phabricator.services.mozilla.com/D164372
2022-12-13 17:01:27 +00:00
Mike Conley
0c9b7ea199 Bug 718280 - Part 7: Update comment block on how to create a new migrator. r=NeilDeakin
Depends on D164144

Differential Revision: https://phabricator.services.mozilla.com/D164145
2022-12-13 17:01:26 +00:00
Mike Conley
0d769e3114 Bug 718280 - Part 6: Update MigratorBase documentation that mentions deCOM'ing. r=NeilDeakin
Now that deCOM'ing migration is done, these comments can be removed. At the time of writing
those comments, it might have been reasonable to move those methods out at the same time as
deCOM'ing, but I don't want to blow out the scope of this patch series, so we can leave those
cleanups to some other time.

Depends on D164143

Differential Revision: https://phabricator.services.mozilla.com/D164144
2022-12-13 17:01:26 +00:00
Mike Conley
1e25b753cb Bug 718280 - Part 5: Use named options rather than an array for showMigrationWizard. r=NeilDeakin,credential-management-reviewers,sgalich
Depends on D164142

Differential Revision: https://phabricator.services.mozilla.com/D164143
2022-12-13 17:01:25 +00:00
Mike Conley
613a702236 Bug 718280 - Part 4: Remove nsIBrowserProfileMigrator.idl and references. r=NeilDeakin
Depends on D164140

Differential Revision: https://phabricator.services.mozilla.com/D164142
2022-12-13 17:01:25 +00:00
Mike Conley
b194903466 Bug 718280 - Part 3: Get rid of some leftover wrappedJSObject usage now that the migrators aren't acquired through XPCOM. r=NeilDeakin
Depends on D164139

Differential Revision: https://phabricator.services.mozilla.com/D164140
2022-12-13 17:01:25 +00:00
Mike Conley
439288e699 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Depends on D164138

Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-13 17:01:24 +00:00
Mike Conley
8a65c0aa96 Bug 718280 - Part 1: Move resource type constants into MigrationUtils. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164138
2022-12-13 17:01:24 +00:00
Sandor Molnar
c46a05c875 Backed out 9 changesets (bug 1800917, bug 718280) for causing xpc failures in browser/components/migration/tests/unit/test_Edge_db_migration.js CLOSED TREE
Backed out changeset d55b95d9d14f (bug 1800917)
Backed out changeset 8427f1e65df4 (bug 1800917)
Backed out changeset 2d0f77d324f2 (bug 718280)
Backed out changeset eba58fd1ed1c (bug 718280)
Backed out changeset 33027a0f9ce9 (bug 718280)
Backed out changeset 237be1f62d01 (bug 718280)
Backed out changeset 007afe158ae5 (bug 718280)
Backed out changeset f1dea7abdfb7 (bug 718280)
Backed out changeset 47e2cccd33c7 (bug 718280)
2022-12-13 00:50:16 +02:00
Mike Conley
c588a030d3 Bug 1800917 - Part 2: Disable Opera GX migrator for Linux, since it doesn't exist for that OS. r=niklas
Opera hasn't shipped Opera GX on Linux (yet), so it doesn't make sense to support it on that
platform since it can't be tested.

Differential Revision: https://phabricator.services.mozilla.com/D164373
2022-12-12 16:04:06 +00:00
Mike Conley
cc48aa048b Bug 1800917 - Part 1: Fix paths for Opera and Vivaldi migrators on Linux. r=niklas
Differential Revision: https://phabricator.services.mozilla.com/D164372
2022-12-12 16:04:05 +00:00
Mike Conley
b82cf70da9 Bug 718280 - Part 7: Update comment block on how to create a new migrator. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164145
2022-12-12 16:04:05 +00:00
Mike Conley
d83dbc6d04 Bug 718280 - Part 6: Update MigratorBase documentation that mentions deCOM'ing. r=NeilDeakin
Now that deCOM'ing migration is done, these comments can be removed. At the time of writing
those comments, it might have been reasonable to move those methods out at the same time as
deCOM'ing, but I don't want to blow out the scope of this patch series, so we can leave those
cleanups to some other time.

Differential Revision: https://phabricator.services.mozilla.com/D164144
2022-12-12 16:04:05 +00:00
Mike Conley
27adceff4c Bug 718280 - Part 5: Use named options rather than an array for showMigrationWizard. r=NeilDeakin,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D164143
2022-12-12 16:04:04 +00:00
Mike Conley
521b3f4885 Bug 718280 - Part 4: Remove nsIBrowserProfileMigrator.idl and references. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164142
2022-12-12 16:04:04 +00:00
Mike Conley
8d7cf18a05 Bug 718280 - Part 3: Get rid of some leftover wrappedJSObject usage now that the migrators aren't acquired through XPCOM. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164140
2022-12-12 16:04:03 +00:00
Mike Conley
12b8c61465 Bug 718280 - Part 2: Move registration of migrators into MigrationUtils instead of components.conf. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164139
2022-12-12 16:04:03 +00:00
Mike Conley
414d26f70e Bug 718280 - Part 1: Move resource type constants into MigrationUtils. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D164138
2022-12-12 16:04:02 +00:00
Mike Conley
477129d77e Bug 1802961 - Add additional documentation for the new Migration Wizard component. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D163657
2022-12-06 17:50:40 +00:00
Mike Conley
7657f98f83 Bug 1802961 - Generate documentation for the new migration wizard reusable component. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D163390
2022-12-06 17:50:40 +00:00
Mike Conley
2e9c823cf7 Bug 1802961 - Generate documentation for the browser/components/migration component. r=kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D163258
2022-12-06 17:50:40 +00:00
Mike Conley
56e95c55b0 Bug 1802961 - Convert MigratorPrototype into an ES6 class and move into its own ESM as MigratorBase to be subclassed. r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D163257
2022-12-06 17:50:39 +00:00
Mike Conley
6d71851894 Bug 1802961 - Make MigrationUtils an ES6 class singleton. r=kpatenio,credential-management-reviewers,sgalich
Differential Revision: https://phabricator.services.mozilla.com/D163256
2022-12-06 17:50:39 +00:00
Mike Conley
b3072d6b33 Bug 1802358 - Enable require-jsdoc / valid-jsdoc for browser/components/migration. r=kpatenio
This doesn't do a thorough job of actually documenting things, it just makes sure that
the existing documentation abides by the JSDoc formatting rules. I did flesh out some
documentation here and there, but writing new / updating / clarifying documentation is
left as later work.

Differential Revision: https://phabricator.services.mozilla.com/D163133
2022-12-06 17:50:38 +00:00