Commit Graph

3897 Commits

Author SHA1 Message Date
Tomislav Jovanovic
c022e34731 Bug 1892667 - Don't open a sidebar for open_at_install=false after extension reloads r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D208352
2024-06-14 13:53:16 +00:00
Stanca Serban
5e7bbfb373 Backed out 2 changesets (bug 1835983, bug 1719271) for causing mochitests failures. CLOSED TREE
Backed out changeset 23d719860ea7 (bug 1719271)
Backed out changeset 10010b949e52 (bug 1835983)
2024-06-13 04:06:16 +03:00
Malte Juergens
073deaeb03 Bug 1835983 - Fix remaining tests failing with HTTPS-First r=freddyb,extension-reviewers,anti-tracking-reviewers,android-reviewers,geckoview-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D213017
2024-06-12 22:08:11 +00:00
Gregory Pappas
71145eb0d1 Bug 1880782 - Remove dom.animations-api.compositing.enabled and dom.animations-api.timelines.enabled prefs r=webidl,devtools-reviewers,firefox-animation-reviewers,nchevobbe,smaug,boris
Differential Revision: https://phabricator.services.mozilla.com/D211505
2024-06-05 19:13:23 +00:00
Moritz Beier
0dcee9a58f Bug 1610530 - Use classes instead of ids to access urlbar elements from UrlbarInput. r=dao,webdriver-reviewers,whimboo
Differential Revision: https://phabricator.services.mozilla.com/D212095
2024-06-04 12:58:52 +00:00
William Durand
c7419f6dcb Bug 1900443 - Prefs that link to AMO shouldn't use %APP%. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D212471
2024-06-04 08:22:03 +00:00
Gregory Pappas
43aeadda35 Bug 1898445 - Add new pref for presence of overflow/underflow events in extension documents r=extension-reviewers,emilio,willdurand
Differential Revision: https://phabricator.services.mozilla.com/D211324
2024-06-03 20:22:12 +00:00
Rob Wu
1373c52a41 Bug 1900033 - Stop running extension xpcshell tests with condprof r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D212259
2024-05-31 19:16:42 +00:00
Matthew Noorenberghe
ebfc58f503 Bug 1899939 - Fix typo in type of tab parameter to commands.onCommand. r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D212224
2024-05-31 16:42:32 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
2024-05-28 15:55:49 +00:00
Mark Banner
fa380ac5a9 Bug 1897508 - Separate out search engine icon updates into a separate notification subject. r=search-reviewers,settings-reviewers,mcheang
This also avoids sending an engine-update Glean event for the default engine by not handling the engine-icon-update
notification in the update tracking code.

Differential Revision: https://phabricator.services.mozilla.com/D210838
2024-05-24 09:10:05 +00:00
ujas.thakkar
7acd32b983 Bug 1874917 - Rename SearchTestUtils.promiseNewSearchEngine to SearchTestUtils.installOpenSearchEngine r=Standard8
Differential Revision: https://phabricator.services.mozilla.com/D211309
2024-05-23 16:17:00 +00:00
Luca Greco
dcc3c52b77 Bug 1771328 - Persist WebExtensions menus across sessions for extensions with a non-persistent background context. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D207311
2024-05-23 09:21:45 +00:00
Mark Banner
0bd2cccf87 Bug 1897770 - Improve .sjs file environment definitions in ESLint. r=frontend-codestyle-reviewers,extension-reviewers,Gijs
This stops sjs files from picking up the test environments/configurations which means they get just the sjs environment
which is what we want.

Differential Revision: https://phabricator.services.mozilla.com/D210928
2024-05-20 13:49:44 +00:00
Emilio Cobos Álvarez
1050f3eb24 Bug 1895870 - Fix browser_ext_browserAction_keyclick.js
focus() is sync so there's no need to await stuff.

The delayed one needs to remain focusable for the focus fix-up not to
kick in.

MANUAL PUSH: Trivial test change CLOSED TREE
2024-05-14 11:55:12 +02:00
Emilio Cobos Álvarez
0a1d2b49ff Bug 1895870 - Simplify refresh driver observer set-up. r=smaug
There's no call to AddRefreshObserver(FlushType::Layout), so we don't
need to track layout flushes. The only reason we need
mLayoutFlushObservers is so that reflows triggered from the style flush
get processed. But at that point, we can just flush layout directly.

There's no really good distinction between style flushes and layout
flushes with container queries anyways, so this makes the code simpler
to reason about.

Differential Revision: https://phabricator.services.mozilla.com/D209924
2024-05-14 08:12:03 +00:00
Mark Banner
bb7cb93cc2 Bug 1836804 - Remove support for {moz:locale} parameter replacements in search URLs. r=search-reviewers,daleharvey
Differential Revision: https://phabricator.services.mozilla.com/D209972
2024-05-13 22:10:30 +00:00
Tomislav Jovanovic
f2bc5d688a Bug 1889402 - Grant origin permissions during install for mv3 r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D208426
2024-05-03 16:05:15 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-03 15:20:15 +00:00
Christoph Kerschbaumer
cea9c08d23 Bug 1888117: Update tests within browser/components/ to work with https-first enabled, r=rpl,mak
Differential Revision: https://phabricator.services.mozilla.com/D205836
2024-05-03 11:20:52 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
5209eded5e Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-01 12:19:41 +00:00
Luca Greco
a603b213e3 Bug 1875480 - runtime.getContexts API method. r=robwu,extension-reviewers,geckoview-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207865
2024-04-30 17:26:18 +00:00
William Durand
39c0de3757 Bug 1893116 - Remove built-in abuse report UI. r=rpl,geckoview-reviewers,desktop-theme-reviewers,emilio,amejiamarmol
This patch removes both the backend and UI code related to the built-in
abuse reporting feature. I kept the ability to disable abuse reporting
with the `extensions.abuseReport.enabled` pref. Other prefs related to
the old abuse reporting feature have been removed.

Some tests have been deleted because they aren't relevant anymore.

On the web API side, both the property and method have been removed
since only AMO consumes these APIs and AMO already supports the absence
of these APIs. That is also why GeckoView has been slightly updated.

We do not collect Telemetry with the new AMO (abuse report) form so
all the Telemetry bits have been removed as well.

Differential Revision: https://phabricator.services.mozilla.com/D208457
2024-04-29 13:56:26 +00:00
Jonathan Sudiaman
e7a1b33bb3 Bug 1885883 - Create an extensions API in SidebarUI r=sclements,extension-reviewers,desktop-theme-reviewers,sidebar-reviewers,robwu,dao,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D206527
2024-04-26 09:36:29 +00:00
Hanna Jones
21849b1def Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
9413513b0d Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Hiroyuki Ikezoe
5ed1ecb283 Bug 1775568 - Await contentTransformsReceived() to ensure the iframe has been positioned. r=layout-reviewers,extension-reviewers,tnikkel,robwu
Differential Revision: https://phabricator.services.mozilla.com/D208085
2024-04-22 21:47:42 +00:00
Rob Wu
8127bd5824 Bug 1888866 - Improve dark theme support in options_ui r=willdurand,desktop-theme-reviewers,emilio
This patch changes the behavior for extensions with an embedded
options_ui page (open_in_tab not false), that have specified the
"dark" value in the "color-scheme" meta tag or CSS property, AND
with the user having indicated the preference for dark theme support.
There are no changes when any of these conditions have not been met.

The "color-scheme" CSS property is the standard way for extensions (web
pages in general) to opt in to automatic dark theme support, e.g. by
changing the foreground color to white. Prior this patch, the
background was unconditionally white, which resulted in unreadable text
when the dark theme is enabled. This patch changes the default
background color to "Canvas", which is a special keyword that is dark
theme-aware (almost black - `rgb(28, 27, 34)` by default).

When `browser_style:true` is used (which is the default in MV2),
extension.css is activated, which unconditionally specifies a black
foreground color. To avoid a poor contrast with the new theme-dependent
background color, the color is now white when the dark theme is enabled.

This patch includes comprehensive test coverage, but the only tests
whose behavior changed by this patch are:
- options_ui_dark (background changed)
- options_ui_browser_style_true_dark (color, background changed)

Differential Revision: https://phabricator.services.mozilla.com/D207540
2024-04-17 16:28:44 +00:00
Rob Wu
d3a8ef9d57 Bug 1847216 - Ensure that tab.isArticle is true before toggleReaderMode r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D207707
2024-04-17 16:24:33 +00:00
Rob Wu
a8ab849a6f Bug 1891954 - Fix intermittent failure in browser_ext_menus_targetElement.js r=willdurand
Differential Revision: https://phabricator.services.mozilla.com/D207703
2024-04-17 16:24:30 +00:00
William Durand
a3e269ecdd Bug 1797811 - Fallback to _execute_browser_action on MV3. r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D207454
2024-04-17 12:21:17 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount
Differential Revision: https://phabricator.services.mozilla.com/D207110
2024-04-15 10:22:46 +00:00
William Durand
82a3893343 Bug 1787379 - Add origin to runtime.MessageSender. r=robwu,zombie,geckoview-reviewers
Note that we intentionally return "null" for null principals *and* file
scheme, which is - at the time of writing - different than Chromium.

Differential Revision: https://phabricator.services.mozilla.com/D206989
2024-04-10 21:48:40 +00:00
William Durand
416ec07269 Bug 1784920 - Add activeTab as permission for tabs.captureVisibleTab API. r=robwu,geckoview-reviewers,amejiamarmol
Differential Revision: https://phabricator.services.mozilla.com/D206882
2024-04-10 14:15:23 +00:00
Gijs Kruitbosch
e6dd680afd Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206685
2024-04-09 18:28:44 +00:00
William Durand
596cecbf3d Bug 1843866 - Add tab parameter to commands.onCommand. r=robwu
Differential Revision: https://phabricator.services.mozilla.com/D206880
2024-04-08 13:45:06 +00:00
Tomislav Jovanovic
2c32b89754 Bug 1880162 - Decouple ExtensionChild namespace, rename BrowserExtensionContent, r=robwu
And export public classes from ExtensionChild.sys.mjs directly.

Differential Revision: https://phabricator.services.mozilla.com/D206235
2024-04-06 09:47:03 +00:00
Luca Greco
409c09490f Bug 1816960 - Add support for options_page as an alias for options_ui.page. r=robwu,amejiamarmol,geckoview-reviewers,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206429
2024-04-04 19:13:27 +00:00
Joel Maher
a1c9f109b8 Bug 1889412 - skip 25+ minute manifests on asan/tsan. r=aryx,extension-reviewers,settings-reviewers,robwu
Differential Revision: https://phabricator.services.mozilla.com/D206512
2024-04-03 17:46:29 +00:00
Yi Xiong Wong
3df27d805a Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D205529
2024-04-03 10:32:27 +00:00
Irene Ni
ea6c87d4f9 Bug 1876432 - Added support for custom themes as its own menu in Reader View. r=reader-mode-reviewers,fluent-reviewers,desktop-theme-reviewers,hjones,accessibility-frontend-reviewers,bolsson,devtools-reviewers,sfoster,cmkm,jules,ayeddi
Differential Revision: https://phabricator.services.mozilla.com/D204519
2024-04-02 00:08:46 +00:00
Yi Xiong Wong
9457049851 Bug 1880914 - Move BrowserHome. r=Gijs,extension-reviewers,sessionstore-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D205528
2024-03-28 17:05:02 +00:00
Luca Greco
d8453fa6cc Bug 1881820 - Tweak browser_ext_sidebarAction to cover the fix with a regression test. r=willdurand
Depends on D205440

Differential Revision: https://phabricator.services.mozilla.com/D205753
2024-03-27 13:18:34 +00:00
Anna Yeddi
a9b2a6e034 Bug 1886925 - Add an exception from a11y_checks for a click on a non-interactive content in Webextensions. r=rpl
We intentionally turn off this a11y check, because the following click is purposefully targeting a non-interactive content of the page to move cursor to the center of the entire browser UI to avoid issues with other focus/hover checks. We do this to avoid intermittent test failure.

Differential Revision: https://phabricator.services.mozilla.com/D205407
2024-03-22 21:02:51 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00