Commit Graph

163 Commits

Author SHA1 Message Date
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Tom Prince
4a92856c9d Bug 1638990: [taskgraph] Make test_try_option_syntax pass on python 3; r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D84073
2020-07-20 19:26:47 +00:00
Justin Wood
0d7dfc246d Bug 1640278 - Remove 'try' from checking run-on-projects for try-syntax. r=bhearsum
This could go further and test for m-c or the trunk/integration aliases, etc. but I opted for not letting this increase try-syntax jobs.

Differential Revision: https://phabricator.services.mozilla.com/D81756
2020-07-01 17:17:28 +00:00
James Graham
e6d8e7e5ad Bug 1644395 - Add wpt print reftests to TC config, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D79082
2020-06-23 10:00:28 +00:00
Narcis Beleuzu
c2b5b0d3c4 Backed out 4 changesets (bug 1644395) for bc failures on browser_all_files_referenced.js . CLOSED TREE
Backed out changeset 582c1dd945ca (bug 1644395)
Backed out changeset 9dbba532a700 (bug 1644395)
Backed out changeset 59e998eb5e59 (bug 1644395)
Backed out changeset 035ddba4a4d9 (bug 1644395)
2020-06-23 00:56:49 +03:00
James Graham
f33009837f Bug 1644395 - Add wpt print reftests to TC config, r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D79082
2020-06-22 13:44:13 +00:00
Ben Hearsum
c8e54ad842 Bug 1645265: -b o -p macosx64 chooses opt and shippable builds instead of one or the other r=ahal
Differential Revision: https://phabricator.services.mozilla.com/D79400
2020-06-13 13:17:29 +00:00
Kunchanapalli Shriram
584d1f83b6 Bug 1518313 - Removes --geckoProfile from talos-test mach command and replaces it with --gecko-profile; r=AlexandruIonescu,perftest-reviewers
Also removes import argparse as per https://bugzilla.mozilla.org/show_bug.cgi?id=1518313#c15
Addresses defect found in code analysis as per https://code-review.moz.tools/#/diff/242580
Changes parameters value as per https://phabricator.services.mozilla.com/D66380#2132590

Differential Revision: https://phabricator.services.mozilla.com/D66380
2020-06-09 13:22:15 +00:00
Justin Wood
6c62472264 Bug 1617481 - Remove most of nightly attribute from taskcluster/taskgraph. r=aki
We leave the nightly index in place for now in order to support Geckodriver until Bug 1577110 sticks.

Differential Revision: https://phabricator.services.mozilla.com/D74510
2020-05-21 16:31:04 +00:00
Narcis Beleuzu
9b7a9aa284 Backed out 13 changesets (bug 1636637, bug 1623355, bug 1636635, bug 1617481) buid signing failures. CLOSED TREE
Backed out changeset 1b340fa71d16 (bug 1617481)
Backed out changeset 607d65d6e48a (bug 1617481)
Backed out changeset d3b4ed0caa09 (bug 1636637)
Backed out changeset bff6ecc8bb12 (bug 1636637)
Backed out changeset 12774c2e7cfc (bug 1636635)
Backed out changeset f94e3f8179a5 (bug 1623355)
Backed out changeset 001eb6623a75 (bug 1623355)
Backed out changeset 87331010321a (bug 1623355)
Backed out changeset fd76f6bc0797 (bug 1623355)
Backed out changeset b4ffd5ccbfc7 (bug 1623355)
Backed out changeset 888df247ba6e (bug 1623355)
Backed out changeset dc3076515342 (bug 1623355)
Backed out changeset de5f01ae37fa (bug 1623355)
2020-05-18 21:37:31 +03:00
Justin Wood
945d8dbbd8 Bug 1617481 - Remove most of nightly attribute from taskcluster/taskgraph. r=aki
We leave the nightly index in place for now in order to support Geckodriver until Bug 1577110 sticks.

Differential Revision: https://phabricator.services.mozilla.com/D74510
2020-05-18 14:41:58 +00:00
Edwin Takahashi
e6fb8f6642 Bug 1630350 - apply mach try filter to try syntax selector r=jmaher,gbrown
Changes:

Applies the `filter_tasks_by_blacklist` method to try syntax pushes as well.

  - moved `TARGET_TASK_BLACKLIST`and `filter_tasks_by_blacklist` method to live in `taskcluster/taskgraph/target_tasks.py`.
  - removed existing filters against `ccov, windows10-aarch64` and `android-hw` filters against try syntax pushes.
  - update imports for `fuzzy` and `chooser` selectors to refer to the new location of `filter_tasks_by_blacklist` method.

The reason for moving the logic (again) from `tools/tryselect` to `taskcluster/` is due to the placement of `try_option_syntax` and `target_tasks` files and both of those files handle the processing of `mach try syntax` pushes.

Differential Revision: https://phabricator.services.mozilla.com/D71698
2020-04-21 19:51:25 +00:00
Edwin Takahashi
6dfbcf6046 Bug 1608837 - fix incorrect names of reftest/crashtest variants of web-platform-tests r=ahal
The definition for reftest/crashtest variants of web-platform-tests in web-platform.yml has a trailing `s` which is technically incorrect.

This causes problems when querying ActiveData for the runtimes for these subsuites since the suite name recorded in ActiveData has the trailing s.

Changes:

  - remove the trailing `s` from the definitions

Differential Revision: https://phabricator.services.mozilla.com/D68069
2020-03-31 20:41:17 +00:00
Tom Prince
dfb672bc5e Bug 1508504: [tryselect] Handle try syntax --setenv like --env; r=ahal
This converts `--setenv` into `env` in `try_task_config` at parameter
generation time.

Differential Revision: https://phabricator.services.mozilla.com/D66537
2020-03-14 01:18:44 +00:00
Tom Prince
48be49988a No bug: [taskgraph] Extract common setting from try_options to try_task_config in parameters; r=ahal
There are a number of settings that have equivalent expressions in
`try_options` (used for try syntax) and `try_task_config` (used for other try
selectors). Rather than requiring task generation code to understand both
formats, this converts the try syntax specification to `try_task_config` at
parameter generation time.

Differential Revision: https://phabricator.services.mozilla.com/D66536
2020-03-14 01:18:34 +00:00
Edwin Takahashi
f61facb3eb Bug 1611566 - support python3 syntax in taskcluster/taskgraph/try_option_syntax.py r=Callek
Changes:

Replaces all instances of `itervlaues` and `iteritems` with `six` variant in try_option_syntax.py.

Differential Revision: https://phabricator.services.mozilla.com/D61055
2020-03-06 21:58:55 +00:00
Csoregi Natalia
11efa40dd0 Backed out changeset 8685d073fea1 (bug 1611566) for breaking try option syntax. a=backout 2020-03-06 21:42:01 +02:00
Edwin Takahashi
4478225046 Bug 1611566 - support python3 in taskcluster/taskgraph/try_option_syntax.py and taskcluster/taskgraph/taskgraph.py r=Callek
Changes:

Replaces all instances of `itervlaues` and `iteritems` with `six` variant.

Differential Revision: https://phabricator.services.mozilla.com/D61055
2020-03-05 22:51:44 +00:00
Geoff Brown
37af87fb04 Bug 1612149 - Update linux64 try syntax aliases for 18.04; r=jmaher
Update existing unit test aliases for linux64 to include the new 18.04 platforms.

Differential Revision: https://phabricator.services.mozilla.com/D62137
2020-02-10 14:51:53 +00:00
Andreea Pavel
0997a274a0 Backed out changeset 0477a13c69c8 (bug 1612149) for failing test_try_option_syntax.py on a CLOSED TREE 2020-02-10 15:49:11 +02:00
Geoff Brown
19b53eb430 Bug 1612149 - Update linux64 try syntax aliases for 18.04; r=jmaher
Update existing unit test aliases for linux64 to include the new 18.04 platforms.

Differential Revision: https://phabricator.services.mozilla.com/D62137
2020-02-10 13:19:08 +00:00
Stephen Donner
3cae418a0d Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D59466
2020-01-14 22:36:47 +00:00
Mihai Alexandru Michis
5873ee8621 Backed out changeset fd1001cea260 (bug 1607344) for causing wpt failures regarding single_stylo_traversal.
CLOSED TREE
2020-01-11 09:55:56 +02:00
Stephen Donner
b3b6d8050e Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D59466
2020-01-11 07:20:50 +00:00
Daniel Varga
e8e2fe7f1a Backed out changeset 05f81cc8b39c (bug 1607344) for causing multiple failures at builds/worker/workspace/mozharness/mozharness/base/script.py
CLOSED TREE
2020-01-11 01:33:35 +02:00
Stephen Donner
4f99ad050d Fix Bug 1607344; remove legacy stylo-seq linux64 jobs. r=erahm,jmaher
Differential Revision: https://phabricator.services.mozilla.com/D59466
2020-01-10 21:39:19 +00:00
Henrik Skupin
b45d172325 Bug 1606335 - [marionette] Remove e10s support from build and mozharness. r=marionette-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D58812
2020-01-07 11:16:26 +00:00
James Graham
bdfb304a40 Bug 1605381 - Schedule wpt crashtests in CI, r=ahal
This is a new test type identified by --test-type=crashtest

Differential Revision: https://phabricator.services.mozilla.com/D57981
2020-01-02 17:13:54 +00:00
Csoregi Natalia
498697772c Backed out changeset 10024cf3aaca (bug 1562412) as per request. CLOSED TREE 2019-12-16 20:00:09 +02:00
Aki Sasaki
b1d0237589 Bug 1562412 - fix try.yml taskgraph-gen.py r=Callek
Differential Revision: https://phabricator.services.mozilla.com/D57189
2019-12-16 13:26:35 +00:00
Geoff Brown
b94d9899fc Bug 1577037 - Stop running all Fennec functional tests; r=bc
Stop running all Fennec functional (non-performance) tests:
 - stop running all Android 4.3 tests
 - switch android-em-7 cppunit and android-hw jittest from the Fennec apk to the
   geckoview apk (no difference in behavior expected)
 - stop running Android 7.0 marionette tests, since they also run against Fennec
 - remove android-em-4.* references from taskcluster configs
 - remove android instance: extra-large references from taskcluster configs,
   since they only affect aws, which is no longer used for Android

Android-hw raptor tests running against Fennec remain; I will prepare a separate
patch for those.

Differential Revision: https://phabricator.services.mozilla.com/D43684
2019-09-04 15:58:36 +00:00
Tom Ritter
967e26e5e2 Bug 1573239 - Run lower-tier tests if the build platform is of that tier r=dustin,catlee
Differential Revision: https://phabricator.services.mozilla.com/D41636
2019-08-28 12:26:59 +00:00
Edwin Gao
8978d533ef Bug 1570775 - remove references to macosx1010, OS X 10.10.x in configuration and test manifests r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D40309
2019-08-02 17:27:58 +00:00
Andrew Halberstadt
7097a4fc03 Bug 1554493 - [ci] Don't run 'fission' tests with try syntax, r=jmaher
Depends on D32700

Differential Revision: https://phabricator.services.mozilla.com/D32701
2019-05-28 13:36:09 +00:00
Andrew Halberstadt
57f82a59a4 Bug 1554493 - [ci] Improve some formatting in try_option_syntax.py, r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D32700
2019-05-28 13:34:56 +00:00
Joel Maher
03fc1be7d6 Bug 1550826 - add initial support for osx mojave 10.14 to our CI. r=ahal
add initial support for osx mojave 10.14 to our CI.

Differential Revision: https://phabricator.services.mozilla.com/D30795
2019-05-14 18:33:12 +00:00
Tom Ritter
639fbea36e Bug 1550866 - Support try syntax '-p foo,bar,bob -u all[all]' to run Tier 2 tests on all platforms specified r=catlee
Differential Revision: https://phabricator.services.mozilla.com/D30720
2019-05-14 19:53:44 +00:00
Joel Maher
41ecc30f4a Bug 1546459 - remove subsuite=clipboard from manifests. r=ahal
remove subsuite=clipboard from manifests

Differential Revision: https://phabricator.services.mozilla.com/D28521
2019-05-01 08:16:44 +00:00
Edwin Gao
9d2d0344c2 Bug 1544441 - prevent selecting windows10-aarch64 jobs using old try syntax and fuzzy unless --full is used r=jmaher
Changes:
- added windows10-aarch64 to the filter for fuzzy, to require `--full` in order to trigger jobs
- return False for any test tasks that contain windows10-aarch64 to prevent users using old try syntax from overwhelming the limited number of hardware

Differential Revision: https://phabricator.services.mozilla.com/D27590
2019-04-15 21:14:17 +00:00
Chris AtLee
57293a46c1 Bug 1531032: disable tier2 jobs from running with try syntax unless specifically enabled. r=tomprince
Enable WPT-reftests as tier1

Differential Revision: https://phabricator.services.mozilla.com/D21786
2019-04-05 13:38:13 +00:00
Justin Wood
257d0ad1df Bug 1541131 - 'try -b o -p macosx64 -u all' should trigger Mac opt tests to be run, on shippable. r=ahal
With the shift to shippable builds we no longer run tests on osx/opt though many still push to try with old try syntax using -p macosx64 and get surprised by no tests. This patch fixes it as a bandaid by appending macosx64-shippable as a platform when macosx64 is specified, making the tests run in the appropriate cases. The expectation with the methodology of this patch is that we'll be killing try syntax support in the near future, eliminating the need for these sorts of bandaids

Differential Revision: https://phabricator.services.mozilla.com/D26048
2019-04-04 15:06:22 +00:00
Mike Shal
bf3936c254 Bug 632954 - Enable tests on Android PGO; r=jmaher CLOSED TREE
Differential Revision: https://phabricator.services.mozilla.com/D22827
2019-03-18 23:53:38 +00:00
Noemi Erli
37aa5ac5f6 Backed out 12 changesets (bug 632954) for causing Android Bpgo(run) pending jobs CLOSED TREE
Backed out changeset 429c96e4de32 (bug 632954)
Backed out changeset de8beacc5eb4 (bug 632954)
Backed out changeset c151ebf303ca (bug 632954)
Backed out changeset b96dd954a456 (bug 632954)
Backed out changeset 26031d362333 (bug 632954)
Backed out changeset 097f141a499d (bug 632954)
Backed out changeset 6f5fc0d644dd (bug 632954)
Backed out changeset 53d3443e55d9 (bug 632954)
Backed out changeset 503bcac73583 (bug 632954)
Backed out changeset 142ae187478d (bug 632954)
Backed out changeset 0615c775a0cf (bug 632954)
Backed out changeset 3dfc0e4f8e7c (bug 632954)
2019-03-20 11:58:18 +02:00
Mike Shal
37ad791e2b Bug 632954 - Enable tests on Android PGO; r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D22827
2019-03-18 23:53:38 +00:00
Mike Hommey
62fd594d19 Bug 1530908 - Unify artifact builds setup between try config and try syntax. r=dustin
While try syntax is approaching its EOL, the fact that using it to do
artifact builds does some things subtly differently from using try
config is not helpful.

Depends on D22055

Differential Revision: https://phabricator.services.mozilla.com/D21312
2019-03-06 22:48:28 +00:00
Dustin J. Mitchell
7637730922 Bug 1525421 - parse out just the try syntax from the commit message r=tomprince
This mirrors what mozilla-taskcluster does in
cb3de4c31e/src/jobs/taskcluster_graph.js (L46-L58)

Differential Revision: https://phabricator.services.mozilla.com/D18748
2019-02-07 02:10:42 +00:00