Commit Graph

99 Commits

Author SHA1 Message Date
Ricky Stewart
31b8ca9716 Bug 1654103: Standardize on Black for Python code in mozilla-central.
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-26 18:34:53 +00:00
Bogdan Tara
612312a64c Backed out 10 changesets (bug 1654103, bug 1672023, bug 1518999) for PanZoomControllerTest.touchEventForResult gv-junit failures CLOSED TREE
Backed out changeset ff3fb0b4a512 (bug 1672023)
Backed out changeset e7834b600201 (bug 1654103)
Backed out changeset 807893ca8069 (bug 1518999)
Backed out changeset 13e6b92440e9 (bug 1518999)
Backed out changeset 8b2ac5a6c98a (bug 1518999)
Backed out changeset 575748295752 (bug 1518999)
Backed out changeset 65f07ce7b39b (bug 1518999)
Backed out changeset 4bb80556158d (bug 1518999)
Backed out changeset 8ac8461d7bd7 (bug 1518999)
Backed out changeset e8ba13ee17f5 (bug 1518999)
2020-10-24 03:36:18 +03:00
Ricky Stewart
065d2eb893 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Make some ad-hoc manual updates to `testing/marionette/client/setup.py`, `testing/marionette/harness/setup.py`, and `testing/firefox-ui/harness/setup.py`, which have hard-coded regexes that break after the reformat.

5. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-23 20:40:42 +00:00
Dorel Luca
95b44c982f Backed out changeset 7558c8821a07 (bug 1654103) for multiple failures. CLOSED TREE 2020-10-22 03:51:06 +03:00
Ricky Stewart
43baed3c18 Bug 1654103: Standardize on Black for Python code in mozilla-central. r=remote-protocol-reviewers,marionette-reviewers,webdriver-reviewers,perftest-reviewers,devtools-backward-compat-reviewers,jgilbert,preferences-reviewers,sylvestre,maja_zf,webcompat-reviewers,denschub,ntim,whimboo,sparky
Allow-list all Python code in tree for use with the black linter, and re-format all code in-tree accordingly.

To produce this patch I did all of the following:

1. Make changes to tools/lint/black.yml to remove include: stanza and update list of source extensions.

2. Run ./mach lint --linter black --fix

3. Make some ad-hoc manual updates to python/mozbuild/mozbuild/test/configure/test_configure.py -- it has some hard-coded line numbers that the reformat breaks.

4. Add a set of exclusions to black.yml. These will be deleted in a follow-up bug (1672023).

# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D94045
2020-10-21 21:27:27 +00:00
Andrew Halberstadt
1a5d28b93c Bug 1660506 - Move backstop determination to the decision task and store it in a parameter, r=marco,taskgraph-reviewers,jmaher
We want to be able to retroactively tell whether a push was a backstop or not.
This patch stores whether or not a push was a "backstop" directly in the
parameters. The optimization strategy now simply returns 'not
params["backstop"]'.

For simplicity, I'm not counting the 'optimized-backstop' as a backstop. It's
unclear if we'll want to be able to detect these types of the pushes in the
future or not, but we can cross that bridge when we get there.

Differential Revision: https://phabricator.services.mozilla.com/D88151
2020-08-26 21:56:05 +00:00
Nick Thomas
7e639781ec Bug 1630809 - add initial support for partner attribution in release promotion r=aki
Renames the release_enable_partners parameter to release_enable_partner_repack, and adds release_enable_partner_attribution for attribution. This it to provide support for disabling them independently in main releases, and in respins.
Adds docs for attribution, update docs for repacks.
Hardwire values for the enable params for the respin flavors, other wise read from the input (defaulting to on in promotion, off otherwise).
Fixes up the rebuild-kinds for partner repacks so that they reflect the current set, although the top level may be all that is needed.

Differential Revision: https://phabricator.services.mozilla.com/D87727
2020-08-27 22:19:41 +00:00
Butkovits Atila
797523cdf6 Backed out 9 changesets (bug 1630809, bug 1653476) for Gecko Decision failures. CLOSED TREE
Backed out changeset 02a27bfc76dd (bug 1653476)
Backed out changeset afb5df61943a (bug 1630809)
Backed out changeset 04628c1f98e9 (bug 1630809)
Backed out changeset 4b4d50e0b1bf (bug 1630809)
Backed out changeset 2fa2deb5c993 (bug 1630809)
Backed out changeset d6652114cac3 (bug 1630809)
Backed out changeset ad5e4caa3291 (bug 1630809)
Backed out changeset d3d841cd14f3 (bug 1630809)
Backed out changeset b3746502e227 (bug 1630809)
2020-08-28 01:15:03 +03:00
Nick Thomas
dccead459d Bug 1630809 - add initial support for partner attribution in release promotion r=aki
Renames the release_enable_partners parameter to release_enable_partner_repack, and adds release_enable_partner_attribution for attribution. This it to provide support for disabling them independently in main releases, and in respins.
Adds docs for attribution, update docs for repacks.
Hardwire values for the enable params for the respin flavors, other wise read from the input (defaulting to on in promotion, off otherwise).
Fixes up the rebuild-kinds for partner repacks so that they reflect the current set, although the top level may be all that is needed.

Differential Revision: https://phabricator.services.mozilla.com/D87727
2020-08-27 05:28:53 +00:00
Andrew Halberstadt
b462d16eef Bug 1636271 - [taskgraph] Move 'optimize-strategies' from try_task_config.json to a parameter, r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D79704
2020-07-28 13:21:05 +00:00
Narcis Beleuzu
f6c2e1b1c1 Backed out 3 changesets (bug 1636271) for breaking the Gecko Decision Task. CLOSED TREE
Backed out changeset 4b0f13fcf941 (bug 1636271)
Backed out changeset 4250f49877ba (bug 1636271)
Backed out changeset d3f93bd6b1f9 (bug 1636271)
2020-07-22 23:40:32 +03:00
Andrew Halberstadt
7d9e380699 Bug 1636271 - [taskgraph] Move 'optimize-strategies' from try_task_config.json to a parameter, r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D79704
2020-07-22 15:36:55 +00:00
Tom Prince
e7d8f225cb No bug: [taskgraph] Make verify_test_packaging handle --target-kind gracefully; r=Callek
If we are generating only a part of the graph, to given kind, don't fail if a
build is packaging tests and there is no corresponding test task, as the tests
may not have been generated.

Differential Revision: https://phabricator.services.mozilla.com/D82097
2020-07-14 07:17:26 +00:00
Chris AtLee
45d5347f22 Bug 1638990: Use requests for fetching parameters r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D76133
2020-05-28 19:01:42 +00:00
Andrew Halberstadt
297ec4fd75 Bug 1633866 - [taskgraph] Create a system to choose how test manifests are loaded via a parameter, r=tomprince
Currently test manifests are loaded by instantiating a TestResolver and
traversing moz.build files to find manifests.

With 'manifest-scheduling', we'll want to grab the manifests directly from the
bugbug service instead. Initially we'll want to enable manifest-scheduling with
|mach try auto|, but not on autoland yet.

This patch will allow |mach try auto| to set the parameter that causes bugbug
to be used (see future commits in this bug).

Differential Revision: https://phabricator.services.mozilla.com/D76522
2020-05-29 18:51:14 +00:00
Andrew Halberstadt
f733451b67 Bug 1633866 - [taskgraph] Log parameters url when using 'project=' or 'task-id=', r=tomprince
When performing diffs, identical parameters files need to be used. This makes
it possible to wget the exact same parameters used by a previous |mach
taskgraph| run.

Differential Revision: https://phabricator.services.mozilla.com/D76026
2020-05-19 20:00:32 +00:00
Rob Lemley
f386c19930 Bug 1609987 - Port bug 1568006: Allow projects to modify decision parameters. r=tomprince
More ports from external taskgraph project. Short term, this will be used to get partial updates
working for Thunderbird.

Differential Revision: https://phabricator.services.mozilla.com/D61636
2020-02-04 22:32:12 +00:00
Ricky Stewart
02945d3f8a Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-21 17:12:08 +00:00
Razvan Maries
1b1233c4a4 Backed out changeset a57aed49dc58 (bug 1524639) for beetmover bustages. a=backout 2020-01-16 14:04:31 +02:00
Ricky Stewart
16061a0a81 Bug 1524639: [taskgraph] Enforce unicode strings in schemas r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D18376
2020-01-15 20:33:20 +00:00
Tom Prince
bd7b7ae6f1 Bug 1562287: [taskgraph] try_task_config parameter is now always a dict; r=aki
Differential Revision: https://phabricator.services.mozilla.com/D38591
2019-07-22 17:30:49 +00:00
Tom Prince
ec3a02aee4 Bug 1565358: Use Parameters.file_url helper consitently; r=mhentges
Only one place should need to know how to generate VCS URLs. This
makes it easier to support other VCSs.

Differential Revision: https://phabricator.services.mozilla.com/D37772
2019-07-11 22:00:51 +00:00
Tom Prince
3d28fab749 Bug 1562287: Add an option to mach try to disable 3-tier PGO; r=mshal,ahal
Often times, PGO builds aren't required for testing things (in particular,
testing release automation). However, at least when testing release automation,
we do need to use the shippable build type.

Add an option to mach try that will disable using the 3-tier PGO jobs.

Differential Revision: https://phabricator.services.mozilla.com/D36365
2019-07-04 19:03:04 +00:00
Aki Sasaki
9e5d3ddf17 Bug 1471004 - add entitlements url for hardened runtime signing. r=tomprince
For mac hardened runtime signing, we use an entitlements file that's now
in-tree. This patch passes the url for that file in the task definition.

The original patch for this was written by sfraser.

Differential Revision: https://phabricator.services.mozilla.com/D33859
2019-06-05 15:03:36 -07:00
Mitchell Hentges
f4f64c3673 Bug 1535056 - Specifies schema for taskgraph parameters r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23756
2019-06-04 12:10:18 +00:00
Noemi Erli
ca054150dd Backed out changeset 50beca34e939 (bug 1535056) for causing cron tasks bustages a=backout 2019-05-29 14:15:04 +03:00
Mitchell Hentges
a6e625ae0a Bug 1535056 - Validate taskgraph parameters using a schema r=tomprince
Validate taskgraph parameters using an explicit schema

Differential Revision: https://phabricator.services.mozilla.com/D23756
2019-05-28 11:18:41 +00:00
Mihai Alexandru Michis
beeee7992b Backed out changeset 48687a76aec5 (bug 1535056) for causing nightly builds to fail. a=backout 2019-05-28 13:12:23 +03:00
Mitchell Hentges
465fe035c0 Bug 1535056 - Validate taskgraph parameters using a schema r=tomprince
Validate taskgraph parameters using a schema.

Previously, parameters were verified using handwritten comparison to a sample set of parameters.
Switch to using an explicit schema instead.

Differential Revision: https://phabricator.services.mozilla.com/D23756
2019-05-08 12:47:56 +00:00
shindli
b5c89e15cf Backed out 2 changesets (bug 1535056, bug 1513854) for linux build bustages and failed Gecko Decision Task CLOSED TREE
Backed out changeset f5eea3706636 (bug 1535056)
Backed out changeset 9b66e9b91074 (bug 1513854)
2019-05-02 12:25:40 +03:00
Mitchell Hentges
f1f585eb68 Bug 1535056 - Validate taskgraph parameters using a schema r=tomprince
Validate taskgraph parameters using a schema.

Previously, parameters were verified using handwritten comparison to a sample set of parameters.
Switch to using an explicit schema instead.

Differential Revision: https://phabricator.services.mozilla.com/D23756
2019-03-26 02:09:14 +00:00
Dustin J. Mitchell
1bd9d56a51 Bug 1534283 - use default parameters for mach try fuzzy r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23225
2019-03-14 19:32:05 +00:00
Dustin J. Mitchell
0587a2d14f Bug 1534283 - add a 'tasks_for' property; r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D23569
2019-03-14 20:01:32 +00:00
Bastien Abadie
4e74ebdb2c Bug 1527895 - Add code-review-issues task in CI, r=dustin,marco,tomprince
Differential Revision: https://phabricator.services.mozilla.com/D21348
2019-03-04 19:40:11 +00:00
Dorel Luca
22083fd99a Backed out changeset 7fdcccd878ad (bug 1527895) for Gecko Decision Task failure. CLOSED TREE 2019-03-04 19:40:12 +02:00
Bastien Abadie
2bed41b711 Bug 1527895 - Add code-review-issues task in CI, r=dustin,marco,tomprince
Differential Revision: https://phabricator.services.mozilla.com/D21348
2019-03-04 16:23:16 +00:00
Tom Prince
1c0a427ad9 Bug 1525736: [taskgraph] Allow looking up parameters by project for trust-domains other than gecko; r=dustin
Previously, this code looked parameters under `gecko.v2`, but that doesn't work
for projects using the out-of-tree taskgraph code, or Thunderbird. This moves
the parameter loading slightly later to vary the index used based on trust domain.

Differential Revision: https://phabricator.services.mozilla.com/D19028
2019-02-14 21:34:49 +00:00
Tom Prince
cae22e6a10 Bug 1524639: [taskgraph] Refine some docstrings that return unicode to indicate that; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D18379
2019-02-04 17:08:51 +00:00
Tom Prince
d2877004a8 Bug 1524639: [taskgraph] Force yaml to be loaded as unicode; r=dustin
Differential Revision: https://phabricator.services.mozilla.com/D18375
2019-02-04 22:18:57 +00:00
Nick Thomas
f08da23210 Bug 1492033 - Create partner repacks during esr60 releases r=tomprince
Supports partner builds on esr60 by re-arranging how we specify the manifest repositories, which are different for esr60 compared to beta+release. The defaults for enabling partners and EME-free now depend on the partner-urls definition in taskcluster/ci/config.yml.

This patch also adds support for partner & EMEfree repacks in try staging releases, for all the various release branches. It makes release_level available early in the decision task (for the release promotion action) where a Parameters object is not available. Signing worker type is no longer hard-coded, and we use level-1 secrets for querying Github (via bug 1513375).

Differential Revision: https://phabricator.services.mozilla.com/D15185
2018-12-27 09:30:52 +00:00
Aki Sasaki
5ed073b1a3 Bug 1501878 - required_signoffs and signoff_urls parameters r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D11733
2018-11-20 21:26:08 +00:00
Andreea Pavel
b6d1437ae8 Backed out 7 changesets (bug 1501878) for breaking win partial generation nightlies a=backout
Backed out changeset 00f109437e82 (bug 1501878)
Backed out changeset f1843fdd4c0f (bug 1501878)
Backed out changeset af0ea80f7b08 (bug 1501878)
Backed out changeset 01311f87d287 (bug 1501878)
Backed out changeset 4e2dc6c23463 (bug 1501878)
Backed out changeset 050c4bba5d71 (bug 1501878)
Backed out changeset 9198c5a03b59 (bug 1501878)
2018-11-17 18:37:39 +02:00
Aki Sasaki
aaa9659bc5 Bug 1501878 - required_signoffs and signoff_urls parameters r=tomprince
Differential Revision: https://phabricator.services.mozilla.com/D11733
2018-11-16 21:03:06 +00:00
Johan Lorenzo
11665b9d0a Bug 1500897 - geckoview: only spin beetmover tasks on GECKOVIEW_XX_RELBRANCH r=dustin,tomprince
geckoview: only spin beetmover tasks on GECKOVIEW_XX_RELBRANCH

Differential Revision: https://phabricator.services.mozilla.com/D9551
2018-10-29 11:11:46 +00:00
Narcis Beleuzu
86c5949e5a Backed out changeset deb0260b33c1 (bug 1500897) for taskgraph test failure 2018-10-29 12:18:13 +02:00
Johan Lorenzo
5e801b0e4b Bug 1500897 - geckoview: only spin beetmover tasks on GECKOVIEW_XX_RELBRANCH r=dustin,tomprince
geckoview: only spin beetmover tasks on GECKOVIEW_XX_RELBRANCH

Differential Revision: https://phabricator.services.mozilla.com/D9551
2018-10-26 16:36:49 +00:00
Tom Prince
46e18160fb No bug: [taskgraph] Remove check_servo filter; r=dustin
The service hasn't been running for over a year now.

Differential Revision: https://phabricator.services.mozilla.com/D9812
2018-10-25 18:32:09 +00:00
Tom Prince
c276089ced Bug 1501759: [taskgraph] Remove include_nightly parameter; r=aki
We only use `include_nigthly` where we are also using
`filter_beta_release_tasks`, so just change the later to include nightly.

Differential Revision: https://phabricator.services.mozilla.com/D9687
2018-10-24 20:44:03 +00:00
Rob Lemley
aa9835dcd1 Bug 1491907 - Get comm/ version from comm/mail/*version.txt r=dustin
The release-update-verify-config task requires that the versions passed
to it match up with what's been released. The version of Thunderbird
does not necessarily match the Gecko version it's based on.

Depends on D6509

Differential Revision: https://phabricator.services.mozilla.com/D6510
2018-09-29 20:53:10 +00:00
Tom Prince
a4d8a90466 Bug 1490094: [taskgraph] Change release_type to include more than just rc; r=bhearsum
Differential Revision: https://phabricator.services.mozilla.com/D5787
2018-09-17 18:09:16 +00:00