Commit Graph

3048 Commits

Author SHA1 Message Date
Dão Gottwald
f0cf92a1c5 Bug 1903996 - Make customizing and mousedown proper boolean attributes. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D214525
2024-06-21 15:38:54 +00:00
Tom Schuster
728dc2abf5 Bug 1904029 - Correctly init View > Toolbars in the menubar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D214543
2024-06-21 15:11:46 +00:00
Dão Gottwald
25644d743c Bug 1902314 - Consolidate toolbarpaletteitem rules. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D213590
2024-06-17 16:26:14 +00:00
Tom Schuster
a8c9401904 Bug 1893068 - Remove command inline event handlers from the menubar. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D212246
2024-06-14 21:08:03 +00:00
Masayuki Nakano
e1fd41420f Bug 1675847 - part 3: Make ePointerClick event dispatchers and handlers use WidgetPointerEvent r=smaug,search-reviewers,devtools-reviewers,nchevobbe,jteow
This patch makes the all `ePointerClick` event dispatcher in C++ code use
`WidgetPointerEvent` instead of `WidgetMouseEvent`.

Then, this patch also makes the all `click` event dispatcher in chrome code use
`PointerEvent` instead of `MouseEvent`.  For detecting wrong trusted event
dispatching of `click` event, this patch adds assertion into `MouseEvent`.
Therefore, all chrome test dispatchers also changed to use `PointerEvent`.

Finally, this patch includes a change of a WPT.  That checks the `pointerId`
caused by executing an access key.  In this case, the value should be `-1`
rather than the default value `0` because Pointer Event spec defines so for
synthetic pointer events caused by non-pointing devices [1].  Chrome also
sets it to `-1` and fails [2].  Therefore, the new assertion will pass on both
Firefox and Chrome.

1. https://w3c.github.io/pointerevents/#dom-pointerevent-pointerid
2. https://wpt.fyi/results/uievents/interface/keyboard-accesskey-click-event.html?run_id=5087897523060736&run_id=5136270464647168&run_id=5163620816388096&run_id=5201281304231936

Differential Revision: https://phabricator.services.mozilla.com/D213001
2024-06-14 00:18:47 +00:00
Irene Ni
63bca8a0d4 Bug 1900835 - Switch PanelMultiView keyboard focus handling to use Element.focus() rather than Services.focus.setFocus() r=mstriemer,Gijs
Differential Revision: https://phabricator.services.mozilla.com/D212962
2024-06-11 18:36:14 +00:00
Jonathan Sudiaman
6ccee8c69b Bug 1892429 - Create an expanded sidebar state r=sidebar-reviewers,fluent-reviewers,kcochrane,sclements,extension-reviewers,robwu
Adds an `expanded` property, which, if enabled, shows labels along with their respective icons within the sidebar menu. Currently, this property is not controllable from the UI. As I understand it, the follow-up bugs are responsible for addressing that.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f269729808eed19051bea5fe4eb41550ff94ce03

Differential Revision: https://phabricator.services.mozilla.com/D210187
2024-05-28 15:55:49 +00:00
Kelly Cochrane
67d49fd057 Bug 1892012 - Add toolbar entry point for the sidebar as a default setting r=sidebar-reviewers,Gijs,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D209978
2024-05-17 16:37:16 +00:00
Sarah Clements
fb5818e268 Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-03 15:20:15 +00:00
Norisz Fay
a2156ad63a Backed out changeset 75c44ff76360 (bug 1892965) for causing multiple failures 2024-05-01 22:58:27 +03:00
Sarah Clements
5209eded5e Bug 1892965 - Rename SidebarUI and SidebarLauncher r=sidebar-reviewers,places-reviewers,nsharpley
Differential Revision: https://phabricator.services.mozilla.com/D208901
2024-05-01 12:19:41 +00:00
Hanna Jones
21849b1def Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-24 19:16:46 +00:00
Stanca Serban
29d6ee2faf Backed out changeset 58e1e96263b7 (bug 1803678) mochitests failures in test_confirm_delete_dialog.html. CLOSED TREE 2024-04-24 03:14:45 +03:00
Hanna Jones
9413513b0d Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 19:28:47 +00:00
Gijs Kruitbosch
004090bf97 Bug 1890718 - move bookmark and library panelview event handling to not use inline event attributes, r=places-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D207881
2024-04-23 15:21:21 +00:00
Aron Cseh
08943f7f60 Backed out changeset 421fd8a0360c (bug 1803678) for causing mochitest failures on browser_translations_select_panel_init_failure.js CLOSED TREE 2024-04-23 18:16:55 +03:00
Hanna Jones
cf0399a238 Bug 1803678 - enable lazy loading of ESModule based moz- custom elements r=reusable-components-reviewers,pip-reviewers,credential-management-reviewers,translations-reviewers,kpatenio,issammani,mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D207445
2024-04-23 13:52:27 +00:00
Gijs Kruitbosch
dc38a85d9b Bug 1890718 - move mouseover sync panel handlers away from inline handlers, r=sync-reviewers,lina
Differential Revision: https://phabricator.services.mozilla.com/D207877
2024-04-22 13:07:23 +00:00
Sammy Khamis
9ad1c9d961 Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 20:13:16 +00:00
Cristian Tuns
8904d3681a Backed out changeset ab9a461da1ee (bug 1885064) for causing xpcshell failures in test_commands_closetab.js CLOSED TREE 2024-04-19 15:45:22 -04:00
Sammy Khamis
4e28b48a03 Bug 1885064 - Ability to send and receive close remote tab pushes r=lina,desktop-theme-reviewers,firefox-desktop-core-reviewers ,emilio,Gijs,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D204556
2024-04-19 18:44:43 +00:00
Gijs Kruitbosch
b60eb110cc Bug 1890718 - remove sync/fxa pane inline command listeners, r=sync-reviewers,lina
This also tidies up some variable naming (we were passing 'panel's that were not, in fact, panels)
and removes some methods that we no longer call.

Bug 1690131 removed the last call to 'showRemoteTabsFromFxaMenu', bug 1562006 removed the last
call to 'showSidebarFromFxaMenu', AFAICT.

Differential Revision: https://phabricator.services.mozilla.com/D207452
2024-04-15 23:23:52 +00:00
Gijs Kruitbosch
1be5de8ffe Bug 1890718 - remove history pane inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207121
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
efe284f711 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 23:23:51 +00:00
Gijs Kruitbosch
f63cdcf1d7 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop,desktop-theme-reviewers,Itiel
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 23:23:50 +00:00
Cosmin Sabou
d17bfe39f8 Backed out 3 changesets (bug 1890718) for failing sevaral UI related bc tests. CLOSED TREE
Backed out changeset 3d91014dfcef (bug 1890718)
Backed out changeset 8c09e2028ad9 (bug 1890718)
Backed out changeset ff91ebffa8ab (bug 1890718)
2024-04-15 21:11:48 +03:00
Gijs Kruitbosch
ff23c68395 Bug 1890718 - remove history pane inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207121
2024-04-15 14:45:52 +00:00
Gijs Kruitbosch
9d2dbb58f2 Bug 1890718 - remove hamburger menu mainview inline command listeners, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207120
2024-04-15 14:45:51 +00:00
Gijs Kruitbosch
bee5c98c47 Bug 1890718 - driveby: remove outdated mentions of proton, r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D207119
2024-04-15 14:45:51 +00:00
Yi Xiong Wong
03a2372d77 Bug 1880914 - Move BrowserOpenAddonsMgr. r=Gijs,extension-reviewers,settings-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers,robwu,thecount
Differential Revision: https://phabricator.services.mozilla.com/D207110
2024-04-15 10:22:46 +00:00
Yi Xiong Wong
86c228872e Bug 1880914 - Move BrowserForceEncodingDetection. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D207108
2024-04-15 10:22:45 +00:00
Gijs Kruitbosch
e6dd680afd Bug 1887717 - remove prompts.windowPromptSubDialog pref, r=mtigley,extension-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D206685
2024-04-09 18:28:44 +00:00
Emilio Cobos Álvarez
75ee484ddb Bug 1832748 - Hit the urlbar container margin to test the context menu. r=Gijs
Test passes verify locally without this change on my machine, but this
seems to work on automation and seems no more hacky than the existing
100px offset:

  https://treeherder.mozilla.org/jobs?repo=try&revision=309ff5bb95505c69250f3674131b7b5b2453795c

Differential Revision: https://phabricator.services.mozilla.com/D207032
2024-04-09 13:41:33 +00:00
Yi Xiong Wong
78b5d3f5fc Bug 1880914 - Move BrowserFullScreen. r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D206200
2024-04-08 17:21:02 +00:00
Emilio Cobos Álvarez
7bbe28bd37 Bug 1832748 - Make click consistently hit space between urlbar and nav bar. r=dao
It seems that 1px offset isn't consistently for our synthesized click to
hit where it's supposed to. There's a 4px gap between urlbar and navbar
so let's increase this a bit.

Differential Revision: https://phabricator.services.mozilla.com/D206881
2024-04-08 11:38:28 +00:00
Nika Layzell
690b246be7 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-05 16:42:51 +00:00
Yi Xiong Wong
3df27d805a Bug 1880914 - Move BrowserOpenTab. r=Gijs,webdriver-reviewers,perftest-reviewers,extension-reviewers,sessionstore-reviewers,tabbrowser-reviewers,home-newtab-reviewers,thecount,whimboo,dao,afinder,omc-reviewers,aminomancer
Differential Revision: https://phabricator.services.mozilla.com/D205529
2024-04-03 10:32:27 +00:00
Mike Conley
b65b8b6cce Bug 1888419 - Put appmenu-remote-tabs-showmore.label into sentence case. r=kcochrane,fluent-reviewers,kpatenio
Differential Revision: https://phabricator.services.mozilla.com/D206016
2024-04-02 14:03:46 +00:00
Butkovits Atila
8311343a9f Backed out 3 changesets (bug 1887029, bug 1886892) for causing failures at browser_all_files_referenced.js. CLOSED TREE
Backed out changeset 07f554ea4869 (bug 1887029)
Backed out changeset daa5f2355675 (bug 1886892)
Backed out changeset 389163cbd649 (bug 1886892)
2024-04-01 21:50:42 +03:00
Nika Layzell
c261303179 Bug 1887029 - Simplify TabAttributes to explicitly specify supported attributes, r=sessionstore-reviewers,sfoster,dao
The only tab attribute which is ever persisted by SessionStore is
"customizemode". This patch limits the logic to only allow persisting and
restoring this attribute.

The browser_attributes.js test is also updated to use the "customizemode"
attribute for testing, rather than a custom specified attribute.

Differential Revision: https://phabricator.services.mozilla.com/D205481
2024-04-01 17:11:23 +00:00
Emily McMinn
d4f51984fa Bug 1724300 - Remove What's New Panel, ToolbarPanelHub components & related tests & references r=desktop-theme-reviewers,omc-reviewers,aminomancer,pdahiya,emilio,devtools-reviewers,firefox-desktop-core-reviewers ,home-newtab-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201867
2024-03-21 22:05:28 +00:00
Mark Banner
ffb4b2b3fc Bug 1885723 - Fix more jsm references in browser/. r=Gijs,credential-management-reviewers,omc-reviewers,aminomancer,mtigley
Differential Revision: https://phabricator.services.mozilla.com/D204843
2024-03-19 22:08:29 +00:00
Dave Townsend
a0c83bc943 Bug 1864896: Autofix unused function arguments (browser). r=webcompat-reviewers,mconley,fxview-reviewers,desktop-theme-reviewers,omc-reviewers,migration-reviewers,twisniewski,aminomancer,dao,sclements,firefox-desktop-core-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D203005
2024-03-19 09:36:35 +00:00
Emilio Cobos Álvarez
1c20c25eda Bug 232598 - Return null for unset attributes in XUL. r=smaug,devtools-reviewers,omc-reviewers,zombie,nchevobbe,settings-reviewers,application-update-reviewers,credential-management-reviewers,mossop,aminomancer,bytesized,issammani,sessionstore-reviewers,dao
I just got bit by this in bug 1873833, let's just fix it. There isn't
all that much stuff depending on it anymore.

Differential Revision: https://phabricator.services.mozilla.com/D204496
2024-03-18 09:15:07 +00:00
Emilio Cobos Álvarez
508427619d Bug 1871515 - Let nsMenuPopupFrame constrain the panelview, and remove _calculateMaxHeight. r=dao,desktop-theme-reviewers
When I rewrote nsMenuPopupFrame, I made sure percentage sizes worked so
that we could do stuff like this.

This removes some complex code, and improves the behavior on platforms
where screen sizes might not be 100% reliable.

Differential Revision: https://phabricator.services.mozilla.com/D204754
2024-03-16 16:22:06 +00:00
Gregory Pappas
9d134e22f7 Bug 1878629 - part 1: Use EventTarget.addEventListener to add system group event listeners instead of nsIEventListenerService (browser/) r=tabbrowser-reviewers,Gijs,dao
Differential Revision: https://phabricator.services.mozilla.com/D201043
2024-03-06 19:27:10 +00:00
Kelly Cochrane
d5647a2076 Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D193593
2024-02-20 18:58:04 +00:00
Mike Conley
4c988cb8f1 Bug 1878731 - Convert ToolbarPanelHub to an ESM. r=emcminn,omc-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D201124
2024-02-12 18:49:34 +00:00
Noemi Erli
8534246c91 Backed out changeset f19610ecbade (bug 1850591) for causing failures in browser_opentabs_tab_indicators.js CLOSED TREE 2024-02-10 01:07:49 +02:00
Kelly Cochrane
6b7daf459f Bug 1850591 - Convert Firefox View's domain-specific navigation component to a global component r=desktop-theme-reviewers,fxview-reviewers,reusable-components-reviewers,sclements,jules,hjones,fluent-reviewers,flod
Differential Revision: https://phabricator.services.mozilla.com/D193593
2024-02-09 22:01:30 +00:00