Commit Graph

515 Commits

Author SHA1 Message Date
Dave Townsend
ec72562c2d Bug 1602195: Show site specific browsers as separate taskbar entries on windows. r=mhowell
Gives a site specific browser window a custom model ID and adds the same model
ID to its shortcut. This makes the window appear distinct from the rest of
Firefox's windows in the taskbar and allows for pinning the new entry to the
taskbar.

Differential Revision: https://phabricator.services.mozilla.com/D56780
2019-12-29 11:50:19 +00:00
Bogdan Tara
47166f5f0a Backed out 2 changesets (bug 1602195) for toolkit/components/alerts/test/test_alerts.html failures CLOSED TREE
Backed out changeset 399d66c91450 (bug 1602195)
Backed out changeset c007b95a362c (bug 1602195)
2019-12-19 03:50:16 +02:00
Dave Townsend
eb784a9ee1 Bug 1602195: Show site specific browsers as separate taskbar entries on windows. r=mhowell
Gives a site specific browser window a custom model ID and adds the same model
ID to its shortcut. This makes the window appear distinct from the rest of
Firefox's windows in the taskbar and allows for pinning the new entry to the
taskbar.

Differential Revision: https://phabricator.services.mozilla.com/D56780
2019-12-18 22:01:40 +00:00
Gurzau Raul
dae806f865 Backed out 2 changesets (bug 1602195) for assertion failures at ServoUtils.h on a CLOSED TREE.
Backed out changeset 1ed20a4511bf (bug 1602195)
Backed out changeset db0d6cb87c2a (bug 1602195)
2019-12-18 21:13:02 +02:00
Dave Townsend
fd6edd9b19 Bug 1602195: Show site specific browsers as separate taskbar entries on windows. r=mhowell
Gives a site specific browser window a custom model ID and adds the same model
ID to its shortcut. This makes the window appear distinct from the rest of
Firefox's windows in the taskbar and allows for pinning the new entry to the
taskbar.

Differential Revision: https://phabricator.services.mozilla.com/D56780
2019-12-18 16:38:46 +00:00
Dave Townsend
20677cc919 Bug 1602196: Generate an icon for the ssb shortcut on windows. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D56773
2019-12-18 16:38:23 +00:00
Dave Townsend
dcfa99738a Bug 1602191: Create a shortcut on the windows desktop to launch an installed ssb. r=mhowell,Gijs
Adds an XPCOM API for creating a windows shortcut and uses it to create one
when installing a SSB.

Differential Revision: https://phabricator.services.mozilla.com/D56292
2019-12-17 03:44:31 +00:00
Narcis Beleuzu
9f61abce8d Backed out 3 changesets (bug 1602191, bug 1602194, bug 1602196) for Windows MinGW bustages on WindowsUIUtils.cpp. CLOSED TREE
Backed out changeset 73c93dc0c790 (bug 1602196)
Backed out changeset ab3c0af1ec40 (bug 1602194)
Backed out changeset f1b308c595c8 (bug 1602191)
2019-12-17 05:41:41 +02:00
Dave Townsend
f3e09a9696 Bug 1602196: Generate an icon for the ssb shortcut on windows. r=mhowell
Differential Revision: https://phabricator.services.mozilla.com/D56773
2019-12-16 21:40:38 +00:00
Dave Townsend
009ee3a30f Bug 1602191: Create a shortcut on the windows desktop to launch an installed ssb. r=mhowell,Gijs
Adds an XPCOM API for creating a windows shortcut and uses it to create one
when installing a SSB.

Differential Revision: https://phabricator.services.mozilla.com/D56292
2019-12-16 20:11:04 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
Kirk Steuber
fae45264bb Bug 1585482 - Restructure all <xul:dialog> usages such that they are not the top level element r=bgrins
This patch also includes necessary JS changes to support this. Most commonly, the dialog was accessed with document.documentElement, which needed to be changed now that the dialog is not the top level element.

Differential Revision: https://phabricator.services.mozilla.com/D52411
2019-12-10 18:25:59 +00:00
Gabriele Svelto
eeb9bfc398 Bug 1600545 - Remove useless inclusions of header files generated from IDL files in accessible/, browser/, caps/, chrome/, devtools/, docshell/, editor/, extensions/, gfx/, hal/, image/, intl/, ipc/, js/, layout/, and media/ r=Ehsan
The inclusions were removed with the following very crude script and the
resulting breakage was fixed up by hand. The manual fixups did either
revert the changes done by the script, replace a generic header with a more
specific one or replace a header with a forward declaration.

find . -name "*.idl" | grep -v web-platform | grep -v third_party | while read path; do
    interfaces=$(grep "^\(class\|interface\).*:.*" "$path" | cut -d' ' -f2)
    if [ -n "$interfaces" ]; then
        if [[ "$interfaces" == *$'\n'* ]]; then
          regexp="\("
          for i in $interfaces; do regexp="$regexp$i\|"; done
          regexp="${regexp%%\\\|}\)"
        else
          regexp="$interfaces"
        fi
        interface=$(basename "$path")
        rg -l "#include.*${interface%%.idl}.h" . | while read path2; do
            hits=$(grep -v "#include.*${interface%%.idl}.h" "$path2" | grep -c "$regexp" )
            if [ $hits -eq 0 ]; then
                echo "Removing ${interface} from ${path2}"
                grep -v "#include.*${interface%%.idl}.h" "$path2" > "$path2".tmp
                mv -f "$path2".tmp "$path2"
            fi
        done
    fi
done

Differential Revision: https://phabricator.services.mozilla.com/D55443
2019-12-06 09:16:44 +00:00
Brian Grinstead
f7066e1806 Bug 1600281 - Rewrite horizontal boxes that were incorrectly translated from align=right to align=end to use pack=end r=Gijs
- align="left" maps to pack="start" for horizontal boxes and align="start" for vertical boxes.
- align="right" maps to pack="end" for horizontal boxes and align="end" for vertical boxes.

Differential Revision: https://phabricator.services.mozilla.com/D55528
2019-12-02 21:08:45 +00:00
Brian Grinstead
628c0a5dcc Bug 1596591 - Rename inc.xul files to inc.xhtml r=Gijs
Differential Revision: https://phabricator.services.mozilla.com/D53843
2019-11-21 09:46:01 +00:00
Brian Grinstead
92c7336a05 Bug 1592369 - Rewrite [align="left"] to [align="start"] and [align="right"] to [align="end"] in XUL elements r=NeilDeakin
Differential Revision: https://phabricator.services.mozilla.com/D51164
2019-11-19 20:30:34 +00:00
Mark Banner
ba7ecdeeaf Bug 324361 - Remove openApplication/openApplicationWithURI from the shell service as they aren't used. r=mossop
Keeps a function for opening the Mac desktop preferences.

Differential Revision: https://phabricator.services.mozilla.com/D43269
2019-08-27 08:03:12 +00:00
Mike Hommey
96b2f630c4 Bug 1575420 - Replace MOZ_WIDGET_TOOLKIT value of "gtk3" with "gtk". r=froydnj
Differential Revision: https://phabricator.services.mozilla.com/D42765
2019-08-21 12:25:42 +00:00
Cosmin Sabou
8ff81869f6 Bug 1429950 - Disable test_headless_screenshot.html on linux !e10s. r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D41474
2019-08-12 16:25:11 +00:00
Andrew Swan
1121e13482 Bug 1569135 Fix --screenshot r=kmag
This patch ressurects HiddenFrame.jsm and uses it when handling
the --screenshot command line argument to load the requested page
in a content process.  The actual logic for grabbing the image is
also ported to a JSWindowActor.  The test for this feature remains
suboptimal as described in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D40148
2019-08-07 21:33:49 +00:00
Brindusan Cristian
7109fcc39d Backed out changeset b4678e759a18 (bug 1569135) for mochitest failures at test_headless_screenshot.html. CLOSED TREE 2019-08-07 20:38:53 +03:00
Andrew Swan
0022ebe93c Bug 1569135 Fix --screenshot r=kmag
This patch ressurects HiddenFrame.jsm and uses it when handling
the --screenshot command line argument to load the requested page
in a content process.  The actual logic for grabbing the image is
also ported to a JSWindowActor.  The test for this feature remains
suboptimal as described in the bug.

Differential Revision: https://phabricator.services.mozilla.com/D40148
2019-08-07 16:07:08 +00:00
Edwin Gao
f78650f34c Bug 1555454 - disable permafailing tests on macosx1014, migrate mochitest-browser-chrome to macosx1014 r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38783
2019-07-23 18:30:26 +00:00
Bogdan Tara
7bb7cb8fa1 Backed out changeset ad5e0980c273 (bug 1555454) for central permafails on browser_devices_get_user_media.js a=backout 2019-07-22 07:45:40 +03:00
Edwin Gao
e92fed79bc Bug 1555454 - disable permafailing tests on macosx1014, migrate mochitest-browser-chrome to macosx1014 r=jmaher
Differential Revision: https://phabricator.services.mozilla.com/D38783
2019-07-21 09:27:47 +00:00
Thomas Nguyen
b29b902e64 Bug 1554947 - Update nsIWebBrowserPersist to use referrerInfo class instead of referrer and referrerr policy r=smaug
Differential Revision: https://phabricator.services.mozilla.com/D33938
2019-07-16 18:02:16 +00:00
Victor Porof
8eb72fd3fc Bug 1561435 - Format browser/components/, a=automatic-formatting
# ignore-this-changeset

Differential Revision: https://phabricator.services.mozilla.com/D36042
2019-07-05 09:53:32 +02:00
Sylvestre Ledru
c4c57387c3 Bug 1552795 - Remove all trailing whitespaces in idl files r=Ehsan
Differential Revision: https://phabricator.services.mozilla.com/D31769
2019-05-22 22:37:14 +00:00
Ian Moody
9da64d56c3 Bug 1549537 - Unconditionally offer 'Span' option for desktop background position on Linux. r=sfoster
Bug 1544105 added a default implementation of `GfxInfoBase::FindMonitors` so
`gfxInfo.getMonitors()` no longer throws on Linux, but it only ever returns the
primary monitor there.

Differential Revision: https://phabricator.services.mozilla.com/D30096
2019-05-07 18:36:19 +00:00
Ian Moody
f9cede0ea2 Bug 1547459 - Use explicit text for desktop span preview not being available. r=sfoster
When I implemented the no preview for span I did originally try using text in
the canvas, but discarded it when I realised trying to format it to display
nicely (across different languages and text lengths) was a losing proposition.
However just the prohibition symbol without context is confusing to users, and
on reflection the text can easily be included as an element stacked on top of
the canvas.

Also lighten the background of the no preview message, since the pure black was
indistinguishable from the frame sides on Windows and Linux.

Differential Revision: https://phabricator.services.mozilla.com/D29750
2019-05-06 18:55:57 +00:00
Sylvestre Ledru
ad31adba4c Bug 1547143 - Format the tree: Be prescriptive with the pointer style (left) r=Ehsan
# ignore-this-changeset

Depends on D28954

Differential Revision: https://phabricator.services.mozilla.com/D28956
2019-05-01 08:47:10 +00:00
Brian Grinstead
3dd68e7775 Bug 1546501 - Remove unnecessary type attributes (i.e. [type="application/javascript"]) on non-test script tags r=mossop
This is an autogenerated commit, generated with https://bug1546501.bmoattachments.org/attachment.cgi?id=9060222

Differential Revision: https://phabricator.services.mozilla.com/D28559
2019-04-24 19:43:57 +00:00
Brian Grinstead
36c26fa2b9 Bug 1544322 - Part 1 - Remove the [type] attribute for one-liner <script> tags loading files in chrome://mochikit/content/ r=bzbarsky
This is an autogenerated commit to handle scripts loading mochitest harness files, in
the simple case where the script src is on the same line as the tag.

This was generated with https://bug1544322.bmoattachments.org/attachment.cgi?id=9058170
using the `--part 1` argument.

Differential Revision: https://phabricator.services.mozilla.com/D26812
2019-04-15 20:56:58 +00:00
Makoto Kato
52c10c14b1 Bug 1539348 - Write old bitmap format for wallpaper support of Windows 7. r=jmathies
This is regression by bug 1502772. Windows 7 doesn't support bitmap v4 format
for wallpaper. So I revert to previous code to write wallpaper bitmap.

Differential Revision: https://phabricator.services.mozilla.com/D27465
2019-04-15 19:47:28 +00:00
Martin Stransky
aa2469363e Bug 1433685 - Remove nsGConfService, r=glandium
Differential Revision: https://phabricator.services.mozilla.com/D26484
2019-04-10 10:18:14 +00:00
Martin Stransky
cf3f8faabb Bug 1526243 - [Linux] Don't use nsGConfService in nsGNOMEShellService.cpp, r=glandium
Don't use gconf service to get/set default browser as it breaks recent Gnome environment.
Also use XDG_CURRENT_DESKTOP to check actual desktop.

Differential Revision: https://phabricator.services.mozilla.com/D25395
2019-04-04 05:58:32 +00:00
Brendan Dahl
33fcccff0e Bug 1526822 - Fix headless screenshot that has redirects. r=mossop
The changes in bug 1507352 caused onLocationChange events to be ignored
when there was an http redirect. This caused the screenshot command to hang
since it never attached an event listener on the page it was redirected to.

Differential Revision: https://phabricator.services.mozilla.com/D22220
2019-03-13 20:47:13 +00:00
Mark Banner
d5029e0dae Bug 1415265 - Remove now unnecessary .eslintrc.js files or entries. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D23850
2019-03-28 09:38:14 +00:00
Ian Moody
d441aa82ae Bug 612373 - Add "Span" option for Windows and Linux to "Set As Desktop Background". r=Gijs
Gnome introduced this in 2.30[0], Windows in 8[1].
Preview is just an "international prohibition symbol" to save the complicated
business of trying to calculate a semi-accurate one.

[0]
8eb0886312
https://bugzilla.gnome.org/show_bug.cgi?id=603551
[1]
https://superuser.com/questions/1061416/which-version-of-windows-introduced-the-span-wallpaper-style

Differential Revision: https://phabricator.services.mozilla.com/D23336
2019-03-27 18:26:19 +00:00
Ian Moody
6e78ce6115 Bug 612373 - Remove Win version<7 code from setDesktopBackground. r=Standard8
Minimum supported version of Windows is 7 now, this is dead code.

Differential Revision: https://phabricator.services.mozilla.com/D23335
2019-03-27 18:26:11 +00:00
Jonas Allmann
245381a9bb Bug 1529231, Remove all occurences of ondialogaccept and ondialogcancel, r=Gijs
Removed all occurences of ondialogaccept.
Removed all occurences of ondialogcancel.
Replaced all removed attributes with event handlers.

Differential Revision: https://phabricator.services.mozilla.com/D21227
2019-03-26 18:34:02 +00:00
Ian Moody
4843dbc900 Bug 1534475 - Use a responsive monitor frame in "Set As Desktop Background" preview. r=Gijs
Currently for any screen with a ratio 1.6 or above, the preview uses a 16:10
image.  However, the majority of Fx users have a screen that is 16:9[0], so for
most users the preview shows images distorted (compressed horizontally).

Originally I just added a new 16:9 version of the monitor image, but then I
realised I could save on filesize _and_ make it responsive to whatever the
user's screen actually is, rather than using arbitrary presets, by using
border-image.

The new image files are just sliced up versions of the original monitor.png
files, zopfli compressed to match (though with the power indicator dropped from
the Linux/Windows version to avoid distorting it).  The combined filesize
savings seem to be 8.5KiB on macOS and 6.5KiB on Linux/Windows.

With the removal of the use of margins on the canvas we no longer need the
platform-specific setDesktopBackground.css file.

[0] https://data.firefox.com/dashboard/hardware
As of 3rd March 2019 the top three resolutions, 1366x768, 1080p, & 1600x900,
are all 16:9 and make up 67% of the userbase.

Differential Revision: https://phabricator.services.mozilla.com/D23114
2019-03-19 07:12:26 +00:00
Gurzau Raul
1ea962054c Backed out changeset e5f1bcb6046e (bug 1534475) for failing at browser_setDesktopBackgroundPreview.js on a CLOSED TREE. 2019-03-14 02:00:20 +02:00
Ian Moody
ba5a4b004d Bug 1534475 - Use a responsive monitor frame in "Set As Desktop Background" preview. r=Gijs
Currently for any screen with a ratio 1.6 or above, the preview uses a 16:10
image.  However, the majority of Fx users have a screen that is 16:9[0], so for
most users the preview shows images distorted (compressed horizontally).

Originally I just added a new 16:9 version of the monitor image, but then I
realised I could save on filesize _and_ make it responsive to whatever the
user's screen actually is, rather than using arbitrary presets, by using
border-image.

The new image files are just sliced up versions of the original monitor.png
files, zopfli compressed to match (though with the power indicator dropped from
the Linux/Windows version to avoid distorting it).  The combined filesize
savings seem to be 8.5KiB on macOS and 6.5KiB on Linux/Windows.

With the removal of the use of margins on the canvas we no longer need the
platform-specific setDesktopBackground.css file.

[0] https://data.firefox.com/dashboard/hardware
As of 3rd March 2019 the top three resolutions, 1366x768, 1080p, & 1600x900,
are all 16:9 and make up 67% of the userbase.

Differential Revision: https://phabricator.services.mozilla.com/D23114
2019-03-13 16:24:40 +00:00
Ian Moody
c494af5c61 Bug 1533794 - encodeURI() expected path to account for possible spaces in filename. r=MattN
Usually the brandName is a single word like "Firefox" or "Nightly" but
DevEdition's is "Firefox Developer Edition", so on mozilla-beta the filename can
be written with spaces, which GSettings will return percent encoded in a file://
URL so we need to match that.

Differential Revision: https://phabricator.services.mozilla.com/D22746
2019-03-08 19:22:37 +00:00
Ian Moody
87d5d0ae4c Bug 1529363 - Fix SetDesktopBackground preview. r=paolo
Bug 1498274 removed the enclosing groupbox, which also removed the XBL box that
bounded the image size.  Add a vbox to do so.
Also add a test that checks the image's sizes match its natural sizes.

Differential Revision: https://phabricator.services.mozilla.com/D20547
2019-03-06 22:13:27 +00:00
Ian Moody
f8482574ac Bug 1529363 - Add GSettings testing to browser_420786.js. r=paolo
It seems like none of the Linux test runners lack GSettings, so effectively this
test hasn't actually been testing anything for a while.

Differential Revision: https://phabricator.services.mozilla.com/D20546
2019-03-06 22:03:56 +00:00
Ian Moody
8362d7808d Bug 1529363 - Rewrite browser_420786.js test to use add_task and BTU.withNewTab. r=paolo
Currently the test fails since it throws "TypeError: content is null".  This
hasn't been noticed since this test only runs when gsettings is absent and
presumably all the test machines have it.

Differential Revision: https://phabricator.services.mozilla.com/D20545
2019-03-06 22:03:48 +00:00
Mark Banner
6553bed7bc Bug 1528760 - Fix issues in the setDesktopBackground dialog following the ChromeUtils.import global changes. r=johannh
Differential Revision: https://phabricator.services.mozilla.com/D20180
2019-02-18 15:53:45 +00:00
Kris Maglione
fc47f72f82 Bug 1524687: Part 11 - Convert browser modules to static registration. r=mossop 2019-01-25 16:41:53 -08:00