Commit Graph

2382 Commits

Author SHA1 Message Date
Nicolas Chevobbe
0bb429a143 Bug 1599432 - Create ObjectFront for non-primitive expression result in inspector sidebar extension. r=rpl.
The WebExtensionInspectedWindow front is modified in order
to be able to parse the eval response.
We're doing it in a similar fashion to the other fronts methods
that can return ObjectFronts: everything is handled client side,
by the front, since an evaluation result can return primitive values,
long string or grips, and we can't define this through protocol.js in
a readable manner.
Some functions and a component are renamed to better represent
what they're doing.

Differential Revision: https://phabricator.services.mozilla.com/D58939
2020-01-14 15:55:54 +00:00
shindli
c78593bc8c Backed out changeset 1bdfd7c37b02 (bug 1511700) for causing newtab node test failure CLOSED TREE 2020-01-13 22:33:58 +02:00
Siddhant085
841c112b92 Bug 1511700 - Use the new notification system (PlacesObserver) for bookmark removed notifications. r=Standard8,mak
Phasing out the old notification system for OnItemRemoved events.

Differential Revision: https://phabricator.services.mozilla.com/D17753
2020-01-13 16:25:39 +00:00
Shane Caraveo
5569c64b15 Bug 1594921 fix intermittent browser.webNavigation failure r=rpl
Differential Revision: https://phabricator.services.mozilla.com/D58853
2020-01-08 18:07:42 +00:00
Luca Greco
cf0671e56f Bug 1605597 - DevTools API inspect binding called on a function should show it in the debugger panel. r=jdescottes,jlast,zombie
Differential Revision: https://phabricator.services.mozilla.com/D58086
2020-01-03 23:43:43 +00:00
Luca Greco
1947b63641 Bug 1606389 - Fix race in test_ext_urlbar test_engagementTelemetry. r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D58617
2020-01-03 17:46:53 +00:00
Shane Caraveo
5862df766b Bug 1603946 fix perma fail on 73 merge due to loading pageinfo before creating appinfo r=twisniewski
Differential Revision: https://phabricator.services.mozilla.com/D58470
2019-12-31 21:34:30 +00:00
Harry Twyford
d8ebb9fb16 Bug 1605958 - Disable openViewOnFocus WebExt API. r=mikedeboer
This API is no longer needed, seeing as the Top Sites experiment is over. Dao suggested in bug 1605958 comment 1 that it be removed.

Differential Revision: https://phabricator.services.mozilla.com/D58375
2019-12-30 16:30:35 +00:00
Harry Twyford
d15f072939 Bug 1604932 - Implement a Top Sites provider. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D57685
2019-12-24 16:10:15 +00:00
Dão Gottwald
eac6059eba Bug 1603778 - Enable openViewOnFocus in Nightly. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D57466
2019-12-24 16:10:41 +00:00
Coroiu Cristina
ee6f65527d Backed out 2 changesets (bug 1604932, bug 1603778) on request by dev
Backed out changeset 1b291d3f209e (bug 1604932)
Backed out changeset 4240d2fed367 (bug 1603778)
2019-12-24 17:34:34 +02:00
Harry Twyford
9099315397 Bug 1604932 - Implement a Top Sites provider. r=mikedeboer
Differential Revision: https://phabricator.services.mozilla.com/D57685
2019-12-24 13:43:11 +00:00
Tomislav Jovanovic
7d63b89c81 Bug 1604058 - Verify remote conduits coming from extension pages r=robwu,rpl
Differential Revision: https://phabricator.services.mozilla.com/D57252
2019-12-21 00:36:11 +00:00
Dão Gottwald
6c7dc01200 Bug 1605071 - Hide tab strip buttons using display:none instead of visibility:hidden. r=mak
Differential Revision: https://phabricator.services.mozilla.com/D57773
2019-12-19 13:27:00 +00:00
Rob Wu
d433bab132 Bug 1420296 - Add tests for file access from extensions r=rpl
Content scripts are allowed to run on file:-URLs, but other forms of
file access from extensions are not allowed. This has been the behavior
for a while, but there were no tests. This commit adds tests to ensure
that the functionality continues to work as intended.

Differential Revision: https://phabricator.services.mozilla.com/D54541
2019-12-17 16:17:13 +00:00
Nicolas Chevobbe
0977391079 Bug 1566850 - Remove target.activeConsole usage in devtools extension code. r=jdescottes,rpl.
Depends on D56692

Differential Revision: https://phabricator.services.mozilla.com/D57103
2019-12-16 13:11:12 +00:00
Harry Twyford
564273d239 Bug 1590450 - Remove the contextual tip API. r=adw
Differential Revision: https://phabricator.services.mozilla.com/D57133
2019-12-13 22:58:21 +00:00
Kris Maglione
ac36cf0bd5 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-13 20:36:48 +00:00
Kris Maglione
4302579aad Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-13 20:36:37 +00:00
Kris Maglione
99c0b418ed Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-13 20:36:36 +00:00
Kris Maglione
7b2657b231 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-13 20:36:24 +00:00
Kris Maglione
8c0d38f33d Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-13 20:36:16 +00:00
Shane Caraveo
b7031396e4 Bug 1586612 properly handle tab events that happen prior to firing tabs.onCreated r=rpl,Gijs
Ensure that our delay in firing the onCreated (TabOpen) event does not result
in other events happening prior to onCreated.

Differential Revision: https://phabricator.services.mozilla.com/D55865
2019-12-13 20:17:39 +00:00
Julian Descottes
fbd078a8ea Bug 1602371 - Rename LocalTabTargetFront tab getter to localTab r=ochameau
Depends on D56330

Renaming the "tab" getter to "localTab" will make it easier to refactor later.

Differential Revision: https://phabricator.services.mozilla.com/D56331
2019-12-13 10:38:07 +00:00
Mark Banner
90cfceb6be Bug 1601681 - Switch recently added files with Windows line endings to Unix. r=mossop
Differential Revision: https://phabricator.services.mozilla.com/D55990
2019-12-11 08:12:49 +00:00
Emma Malysz
ce4da4686b Bug 1601094, rename the remaining .xul files in browser/ to .xhtml r=marionette-reviewers,whimboo,mossop
Differential Revision: https://phabricator.services.mozilla.com/D55751
2019-12-11 00:27:19 +00:00
shindli
0aa47af90e Backed out 9 changesets (bug 1596918) for causing mochitest permafailures in toolkit/content/tests/chrome/test_findbar_events.xhtml CLOSED TREE
Backed out changeset 45a1c42118f2 (bug 1596918)
Backed out changeset db09910ffa56 (bug 1596918)
Backed out changeset 5c9d9f141c10 (bug 1596918)
Backed out changeset 6a135670d603 (bug 1596918)
Backed out changeset 3a0184e0df72 (bug 1596918)
Backed out changeset 2f0036486823 (bug 1596918)
Backed out changeset a770c6d08d52 (bug 1596918)
Backed out changeset ef062eb7a6ee (bug 1596918)
Backed out changeset a6ea596e98db (bug 1596918)
2019-12-11 03:09:26 +02:00
Jonathan Watt
39efd9f84e Bug 1602561. Make PrintUtils.printWindow() act on a BrowsingContext. r=Gijs
Factored out from patches to make printing work with Fission enabled.

Differential Revision: https://phabricator.services.mozilla.com/D56436
2019-12-10 21:59:02 +00:00
Kris Maglione
c87948a206 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-10 23:07:41 +00:00
Kris Maglione
40ceb887f2 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-10 23:07:34 +00:00
Kris Maglione
af77c00e7a Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-10 23:07:22 +00:00
Kris Maglione
eb68f8b548 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-10 23:07:21 +00:00
Kris Maglione
ad3537fc50 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-10 23:07:13 +00:00
Mélanie Chauvel (ariasuni)
76cfe57b43 Bug 1453355 - Add sidebarAction.toggle() to WebExtensions API r=mixedpuppy
Differential Revision: https://phabricator.services.mozilla.com/D54005
2019-12-09 14:52:45 +00:00
Emilio Cobos Álvarez
043ef46657 Bug 1601624 - Write an automated test for this. r=tnikkel
The existing tests changed both width and height, not triggering the bug.

Differential Revision: https://phabricator.services.mozilla.com/D56304
2019-12-08 21:26:08 +00:00
Noemi Erli
21eec8658f Backed out 9 changesets (bug 1596918) for causing multiple browser-chrome failures
Backed out changeset 415007efd8c9 (bug 1596918)
Backed out changeset 011eb5ce927b (bug 1596918)
Backed out changeset e5fd3ee22ea1 (bug 1596918)
Backed out changeset 0bca4de31d40 (bug 1596918)
Backed out changeset 11ec4393f23d (bug 1596918)
Backed out changeset c5404a7c286d (bug 1596918)
Backed out changeset 7e9304405a46 (bug 1596918)
Backed out changeset fa0f0aeabf99 (bug 1596918)
Backed out changeset de196b077000 (bug 1596918)
2019-12-07 22:26:43 +02:00
Kris Maglione
038e9efbd4 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-07 18:44:35 +00:00
Kris Maglione
f1231dcf6a Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-07 18:44:35 +00:00
Kris Maglione
b442dbf855 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-07 18:44:34 +00:00
Kris Maglione
6fb2c35351 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-07 18:44:34 +00:00
Kris Maglione
88fbf261f8 Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-07 19:11:58 +00:00
Daniel Varga
85f263a4c2 Backed out 17 changesets (bug 1596918) for multiple browser-chrome and dev-tools failures. On a CLOSED TREE
Backed out changeset ab87d2c1afae (bug 1596918)
Backed out changeset 775f3b06a687 (bug 1596918)
Backed out changeset 67cc63ef5d7f (bug 1596918)
Backed out changeset 7d290bcd2067 (bug 1596918)
Backed out changeset 048db9f4db7c (bug 1596918)
Backed out changeset 96a79d2ba614 (bug 1596918)
Backed out changeset be770d112dd8 (bug 1596918)
Backed out changeset 302c8ab8391c (bug 1596918)
Backed out changeset 44ef8f20732e (bug 1596918)
Backed out changeset 38c11ebfb8ff (bug 1596918)
Backed out changeset b586fc081374 (bug 1596918)
Backed out changeset 12283166716f (bug 1596918)
Backed out changeset 99b0421015d8 (bug 1596918)
Backed out changeset 97ec49dbbbf3 (bug 1596918)
Backed out changeset ec79478f58f1 (bug 1596918)
Backed out changeset c6d356833bb8 (bug 1596918)
Backed out changeset 5ef6026806c8 (bug 1596918)
2019-12-07 03:12:07 +02:00
Kris Maglione
d446581341 Bug 1596918: Part 4g - Misc cleanup/fixes. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53748
2019-12-06 22:14:43 +00:00
Kris Maglione
1353082784 Bug 1596918: Part 4d - Fix callers which try to return non-clonable values. r=mccr8
Differential Revision: https://phabricator.services.mozilla.com/D53745
2019-12-06 22:15:27 +00:00
Kris Maglione
3850c6a060 Bug 1596918: Part 4c - Fix callers which depend on document lifecycle changes. r=mccr8
ContentTask tasks have a different lifetime than SpecialPowers tasks, with the
former being tied to the lifetime of a message manager and the latter tied to
the lifetime of a window global. That means that existing ContentTask callers
which expect to be able to register load listeners before the creation of a
window global, or which expect to persist after a page has navigated, won't
work as SpecialPowers tasks.

Since those sorts of tasks are not really resilient in the face of Fission,
they should really be written to work differently, but this patch mostly just
reverts them to using ContentTask for the time being.

Differential Revision: https://phabricator.services.mozilla.com/D53744
2019-12-06 22:15:25 +00:00
Kris Maglione
487c4fe9c7 Bug 1596918: Part 3b - Run code formatters on files changed by previous patch. r=mccr8,remote-protocol-reviewers,ato
Differential Revision: https://phabricator.services.mozilla.com/D53741
2019-12-06 22:14:22 +00:00
Kris Maglione
e59706f08a Bug 1596918: Part 3a - Scripted rewrite of most ContentTask.spawn calls to SpecialPowers.spawn calls. r=mccr8,remote-protocol-reviewers,ato
This is generally pretty straightforward, and rewrites nearly all calls. It
skips the ones that it can detect using frame script globals like
`sendAsyncMessage`, though.

Differential Revision: https://phabricator.services.mozilla.com/D53740
2019-12-06 22:14:14 +00:00
Ehsan Akhgari
b2859185fc Bug 1595934 - Make nsICookieManager cookie enumerators return Array<nsICookie> instead of nsISimpleEnumerator; r=baku
Differential Revision: https://phabricator.services.mozilla.com/D52761
2019-12-03 17:08:25 +00:00
Luca Greco
15869025c6 Bug 1598079 - Turn abuseReport.openDialog on by default on all channels. r=mstriemer
Differential Revision: https://phabricator.services.mozilla.com/D54026
2019-11-25 17:35:48 +00:00
Marco Bonardo
9918983f83 Bug 1599839 - Merge sources and acceptableSources in UrlbarQueryContext. r=adw,mixedpuppy
Rename acceptableSources to just sources, merge it with the existing sources property.

Differential Revision: https://phabricator.services.mozilla.com/D55082
2019-12-02 17:20:39 +00:00