It is arguably more accurate to implement these boolean
getters in terms of whether we remember blocking anything
in the category being asked about. This will allow us to
correctly account for hiding the sheild icon when all
currently blocked trackers become unblocked, for example.
Differential Revision: https://phabricator.services.mozilla.com/D6600
It is arguably more accurate to implement these boolean
getters in terms of whether we remember blocking anything
in the category being asked about. This will allow us to
correctly account for hiding the sheild icon when all
currently blocked trackers become unblocked, for example.
Differential Revision: https://phabricator.services.mozilla.com/D6600
It is arguably more accurate to implement these boolean
getters in terms of whether we remember blocking anything
in the category being asked about. This will allow us to
correctly account for hiding the sheild icon when all
currently blocked trackers become unblocked, for example.
Differential Revision: https://phabricator.services.mozilla.com/D6600
Return the document element as the activeElement when there is no body
element, the document is chrome privileged, and the document element
is a XUL element.
MozReview-Commit-ID: JFDLAqOmLTS
Differential Revision: https://phabricator.services.mozilla.com/D6448
Various places in dom/ use the pattern:
already_AddRefed<NodeInfo> ni = ...;
which is supposed to be disallowed by our static analysis code, but
isn't, for whatever reason. To fix our static analysis code, we need to
eliminate instances of the above pattern.
Unfortunately, eliminating this pattern requires restructuring how Nodes
are created. Most Node subclasses take `already_AddRefed<NodeInfo>&` in
their constructors, and a few accept `already_AddRefed<NodeInfo>&&`. We
need to enforce the latter pattern consistently, which requires changing
dozens of source files.
Everything that goes in a PLDHashtable (and its derivatives, like
nsTHashtable) needs to inherit from PLDHashEntryHdr. But through a lack
of enforcement, copy constructors for these derived classes didn't
explicitly invoke the copy constructor for PLDHashEntryHdr (and the
compiler didn't invoke the copy constructor for us). Instead,
PLDHashTable explicitly copied around the bits that the copy constructor
would have.
The current setup has two problems:
1) Derived classes should be using move construction, not copy
construction, since anything that's shuffling hash table keys/entries
around will be using move construction.
2) Derived classes should take responsibility for transferring bits of
superclass state around, and not rely on something else to handle that.
The second point is not a huge problem for PLDHashTable (PLDHashTable
only has to copy PLDHashEntryHdr's bits in a single place), but future
hash table implementations that might move entries around more
aggressively would have to insert compensation code all over the
place. Additionally, if moving entries is implemented via memcpy (which
is quite common), PLDHashTable copying around bits *again* is
inefficient.
Let's fix all these problems in one go, by:
1) Explicitly declaring the set of constructors that PLDHashEntryHdr
implements (and does not implement). In particular, the copy
constructor is deleted, so any derived classes that attempt to make
themselves copyable will be detected at compile time: the compiler
will complain that the superclass type is not copyable.
This change on its own will result in many compiler errors, so...
2) Change any derived classes to implement move constructors instead of
copy constructors. Note that some of these move constructors are,
strictly speaking, unnecessary, since the relevant classes are moved
via memcpy in nsTHashtable and its derivatives.
nsIDocument::ResetToURI() resets and set the mDocumentLoadGroup property
even if it is given the same instance. This has caused BlockOnload() to
break on media documents, which calls into there while removing UA Widget.
This patch checks the weak ref before resets it.
Depends on D3841
Differential Revision: https://phabricator.services.mozilla.com/D4484
