This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.
Differential Revision: https://phabricator.services.mozilla.com/D21300
This patch addresses remaining test issues when pref'ing on. These are tests that
previously ran some tests in private contexts that now require the use of incognitoOverride.
This also fixes an xpcshell test wrapper to set the permission when overridden.
Differential Revision: https://phabricator.services.mozilla.com/D21300
Sometimes about:blank would match a non-private window, ensure we're looking
for a url specific to the private window.
Differential Revision: https://phabricator.services.mozilla.com/D21454
The timer cancelling in UnifiedComplete.js seems to make the tests more stable with QuantumBar for some reason. Without it, some of the sub-tests would tend to time out. This might be better once we can implement a proper waitForResult() that doesn't have to wait for the entire search to be complete.
Differential Revision: https://phabricator.services.mozilla.com/D21006
This patch rewrites the browser_ext_browserAction_popup.js test file to make it easier to follow the
sequence of its test cases (in the previous version of this test file, the logic that was executing
the sequence of test cases was fragmented in a bunch of listeners, in both the test extension and
the privileged test code) and to make the test able to wait for the popups to be fully loaded or
fully destroyed before moving to the next test case.
Differential Revision: https://phabricator.services.mozilla.com/D21427
The bug indicated that the setUninstallURL did not honor empty url during runtime.
Steps to reproduce:
1. Install an extension, uninstall URL is set
2. Update the extension, changing the uninstall URL string to null (empty)
3. Uninstall the extension
Differential Revision: https://phabricator.services.mozilla.com/D18499
This removes the need to go through the browser-to-tab mapping when discarding
a tab and simplifies the relevant code. Besides being renamed discardBrowser()
was also split so that one can check if a tab can be discarded prior to trying
it.
Differential Revision: https://phabricator.services.mozilla.com/D20475
This test was failing intermittently in opt and pgo builds because there was a slightly chance that
the test extension may be calling browser.extension.getViews while the popup context was unloading
but it wasn't still destroyed and so it wasn't yet removed from the set of the extension views.
This patch fixes this intermittency by changing the promiseBrowserContentUnloaded test helper to
ensure that the unloadPromise is resolved when the "inner-window-destroyed" message for the
extension window is being notified to the "observer service" listeners, as it is what
the ExtensionPageChild is listening to decide when the ExtensionPageContextChild should be
unloaded and removed from the set of the extension views.
Differential Revision: https://phabricator.services.mozilla.com/D20658
Summary: Before this change no style for invalid input fields was included in Firefox and thus invalid text fields where not highlighted as invalid as per the Firefox Photon design guide.
Test Plan:
Screenshot: https://hostux.pics/images/2019/01/25/image5123a27cc99ab189.png
# Installed my add-on: https://addons.mozilla.org/firefox/addon/mastodon-simplified-federation/
# Go to settings page and enter some invalid string in the input field.
# Open add-on debugger and inspect that element.
# (important!) Disable my workaround I added. (in options.css), see the screenshot at the top right, where I did this.
# And you can still see the invalid style…
Reviewers: rpl, bwinton
Reviewed By: bwinton
Subscribers: bwinton, caitmuenster
Bug #: 1514567
Differential Revision: https://phabricator.services.mozilla.com/D17558
This test was intermittently timing out, mostly on debug builds, because there
was a chance that from time to time the sidebar could have been loaded for the
first time while the background page of the test extension was still being loaded.
The test was sending an extension test message as soon as the sidebar was loaded
for the first time, and so if the background page didn't yet added its test message
listener, the test cases did never get started and the entire test was getting stuck.
The changes included in this patch prevents this intermittent failures by ensuring
that the test always waits for the background page and the sidebar to be both loaded
and ready before sending the test message that starts to run the test cases.
Differential Revision: https://phabricator.services.mozilla.com/D20657
This better reflects what the property is (i.e. a
WebConsoleUI instance), and avoid confusion with
the panel's hud (created in webconsole.js).
We take that as an opportunity to clean things up
a bit (e.g. don't access the webConsoleUI through
JsTerm).
Differential Revision: https://phabricator.services.mozilla.com/D19783
This patch changes ext-history.js and ext-browsingData.js to ensure that these API modules are importing PlacesUtils in the same way as ext-bookmarks.js, because mixing CU.defineModuleGetter and CU.import would raise an error and it would break those two WebExtensions APIs if the ext-bookmarks.js gets loaded first.
Differential Revision: https://phabricator.services.mozilla.com/D18683
