William Durand
7d98f15a74
Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod
...
Depends on D179780
Differential Revision: https://phabricator.services.mozilla.com/D180091
2023-06-09 14:58:03 +00:00
William Durand
fbd55117bc
Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D179780
2023-06-09 14:58:02 +00:00
William Durand
2799d3e5ca
Bug 1836771 - Add aria attributes to the message-bar notification used in the extensions panel. r=ayeddi
...
Differential Revision: https://phabricator.services.mozilla.com/D179957
2023-06-08 20:39:51 +00:00
Narcis Beleuzu
8f2b59f94b
Backed out 2 changesets (bug 1836448) for bc failure on browser_preferences_usage.js
...
Backed out changeset 1c53eee1c466 (bug 1836448)
Backed out changeset a86d5a3f177d (bug 1836448)
2023-06-08 21:22:20 +03:00
William Durand
8308622bca
Bug 1836448 - Part 2: show attention "dot" on the extensions button for quarantined domains. r=zombie,fluent-reviewers,flod
...
Depends on D179780
Differential Revision: https://phabricator.services.mozilla.com/D180091
2023-06-08 15:37:19 +00:00
William Durand
86def29cf9
Bug 1836448 - Part 1: show attention "dot" when an extension is quarantined from a domain. r=rpl,zombie,fluent-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D179780
2023-06-08 10:50:31 +00:00
William Durand
fd07ed0190
Bug 1836224 - A click on the "learn more" link in the panel should close it. r=zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D179649
2023-06-01 11:27:43 +00:00
William Durand
846ce75f99
Bug 1833438 - Implement user notification for quarantined domains. r=zombie,rpl,fluent-reviewers,flod
...
Depends on D179388
Differential Revision: https://phabricator.services.mozilla.com/D179386
2023-05-31 20:42:37 +00:00
Saira Abdulla
d8dc989e1b
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 15:27:03 +00:00
Iulian Moraru
05e26cad32
Backed out 2 changesets (bug 1824612) for causing dt failures on browser_dbg-features-source-tree.js. CLOSED TREE
...
Backed out changeset c3f38adc818e (bug 1824612)
Backed out changeset 58ba8bb3398a (bug 1824612)
2023-05-31 17:28:16 +03:00
Saira Abdulla
cac3d1f236
Bug 1824612 - Convert consumers of toolkit/components/extensions to ES modules. r=robwu,webcompat-reviewers,geckoview-reviewers,settings-reviewers,application-update-reviewers,credential-management-reviewers,devtools-reviewers,cookie-reviewers,twisniewski,sgalich,valentin,nalexander,mconley,m_kato
...
Depends on D175553
Differential Revision: https://phabricator.services.mozilla.com/D176005
2023-05-31 10:21:37 +00:00
William Durand
ffdc71c1cd
Bug 1833438 - Add support for notifications in the extensions panel. r=Itiel,rpl,desktop-theme-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D179345
2023-05-30 20:07:39 +00:00
Eemeli Aro
05300da5a3
Bug 1793557 - Migrate add-on notification strings to Fluent. r=extension-reviewers,flod,robwu
...
The l10n migration shows a diff for `addon-downloading-and-verifying`,
`addon-confirm-install-message`, and `addon-confirm-install-unsigned-message`
due to the en-US source having `1` rather than `one` variants.
For `addon-confirm-install-some-unsigned-message`,
the en-US source has a single-variant plural selector for localization to new languages.
In addition to moving strings from `browser.properties` to the new `addonNotifications.ftl`,
there's some shuffling of strings to & from `browser.ftl` as well.
The intent is to collect the more rarely used strings out of files loaded during startup,
especially as many of the notification strings need to be formatted in a sync context.
For the most part, string keys are left roughly the same as they were in .properties.
With some guidance, some rationalisation might make sense as a part of this for the
rather wide selection of prefixes in this set:
- `addon-`
- `site-permission-install-`
- `webext-`
- `xpinstall-`
The `addon-install-started` and `addon-install-failed` notifications appear to need sync l10n formatting,
as using async format calls before their `PopupNotifications.show()` leads to test failures in
`toolkit/mozapps/extensions/test/xpinstall/browser_doorhanger_installs.js`.
Differential Revision: https://phabricator.services.mozilla.com/D178235
2023-05-23 12:00:01 +00:00
Mark Banner
91fde42f7b
Bug 1826062 - Automatic fixes for Prettier 2.0.5 upgrade. r=mossop,perftest-reviewers,webcompat-reviewers,geckoview-reviewers,denschub,devtools-reviewers,sparky,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D177025
2023-05-20 12:26:49 +00:00
William Durand
df4f375b85
Bug 1805924 - Allow to re-order the list of extensions in the unified extensions panel. r=rpl,bolsson
...
Differential Revision: https://phabricator.services.mozilla.com/D175348
2023-05-04 06:11:44 +00:00
Itiel
332aa98bae
Bug 1818622 - More clean up to the unified extensions panel r=willdurand,mconley
...
Also, update also the menu button's class depending on its location. Update tests accordingly.
Differential Revision: https://phabricator.services.mozilla.com/D170828
2023-05-01 19:57:49 +00:00
William Durand
2ecb3826ff
Bug 1828966 - Ensure Pin to Toolbar context menu item shows the correct state when opening the context menu. r=mconley
...
I could only reproduce on macOS but it is indeed a valid bug. I noticed
that moving the `await` code at the bottom of the function fixed it but
that didn't sound too great.
I decided to propose this patch instead, and I made sure that we
wouldn't hit a similar problem with the "disabled" state of the remove
button. Apparently, that still works as expected (on macOS).
I am not quite sure how to cover that with a test, though, because we
have test coverage for the attributes and the HTML markup is correctly
updated. For example, I could see the correct `checked` attribute in the
HTML (in the devtools) with the wrong context menu item state rendered,
sigh. This likely means the race is at a lower level (cocoa?).
Differential Revision: https://phabricator.services.mozilla.com/D176416
2023-04-25 15:48:14 +00:00
William Durand
ee885114f8
Bug 1801266 - Handle the case where an extension widget is not visible and not in the extensions panel. r=mconley,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D168532
2023-04-19 07:42:16 +00:00
Bobby Holley
c934412517
Bug 1808431 — Reword first WebMIDI prompt. r=rpl,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D174813
2023-04-06 17:07:14 +00:00
Tim Giles
fb12c56560
Bug 1813077 - Make addon-install-blocked learn more link use Fluent. r=mstriemer,fluent-reviewers,extension-reviewers,Gijs,flod
...
The previous way of setting textContent via string from the
browser.properties file does not work with the moz-support-link widget
since it has a Fluent ID by default. Instead we migrate the existing
string from the browser.properties file to the browser.ftl file.
Differential Revision: https://phabricator.services.mozilla.com/D170255
2023-03-23 14:07:42 +00:00
Tim Giles
3bc1de1d4d
Bug 1813077 - Add import of moz-support-link for use in popup-notification via ensureCustomElements. r=mstriemer,extension-reviewers
...
Since we can't synchronously load ESModules yet, we use a new
abstraction of ensureCustomElements to ensure we have access to the
moz-support-link widget in popup-notifications.inc. The previous pattern
of loading the widget via module script does not work in this case due
to browser.xhtml, as we do not want to block on this path.
Differential Revision: https://phabricator.services.mozilla.com/D170254
2023-03-23 14:07:41 +00:00
William Durand
a4e3ec09cc
Bug 1820743 - Allow to move unified extensions button on the navbar. r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D171845
2023-03-21 16:55:11 +00:00
Cristina Horotan
3afab63217
Backed out changeset 56de7c6ac457 (bug 1820743) for causing bc failures at browser_toolbarKeyNav.js CLOSED TREE
2023-03-21 16:16:47 +02:00
William Durand
7b68de7353
Bug 1820743 - Allow to move unified extensions button on the navbar. r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D171845
2023-03-21 13:10:08 +00:00
William Durand
53fa5ffd91
Bug 1820124 - Remove addonManager.action/link/view Telemetry events. r=rpl,settings-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D171541
2023-03-20 20:11:15 +00:00
William Durand
3efdf5595f
Bug 1821288 - Remove "addon-install-complete" event. r=rpl
...
This is not used anymore.
Differential Revision: https://phabricator.services.mozilla.com/D172102
2023-03-15 17:37:42 +00:00
William Durand
9a9c666058
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Depends on D169810
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-16 12:03:07 +00:00
Cristian Tuns
011493bc1c
Backed out changeset e391918bb558 (bug 1800417) for causing mochitest failures in /browser_unified_extensions_overflowable_toolbar.js CLOSED TREE
2023-02-14 17:21:09 -05:00
William Durand
5993be7f69
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Depends on D169810
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-14 20:51:53 +00:00
Malte Jürgens
51c2bf31f4
Bug 1808459 - Take extensions.getAddons.showPane into consideration when clicking on empty unified extensions button r=extension-reviewers,robwu
...
In case the user does not have any active extensions listed, if `extensions.getAddons.showPane` is set to true (default), clicking on the unified extensions button will lead to the recommendations section in about:addons. If it is set to false, clicking the button will now lead to the extension list instead of the, disabled by the user, recommendations section.
Differential Revision: https://phabricator.services.mozilla.com/D169570
2023-02-14 13:07:22 +00:00
Marian-Vasile Laza
f298aadd15
Backed out changeset d26e7747cf69 (bug 1800417) for bc failures on browser_unified_extensions_overflowable_toolbar.js. CLOSED TREE
2023-02-13 22:14:44 +02:00
William Durand
e23737e755
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-13 16:52:18 +00:00
Sandor Molnar
d82f8e0057
Backed out changeset 549ce0549c2e (bug 1800417) for causing bc failures in browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js CLOSED TREE
2023-02-08 14:23:39 +02:00
William Durand
6f77c2b373
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Depends on D169088
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-08 10:25:02 +00:00
Sandor Molnar
a0241439d5
Backed out changeset 6dbcf3dd30c4 (bug 1800417) for causing bc failures in browser/components/extensions/test/browser/browser_unified_extensions_overflowable_toolbar.js CLOSED TREE
2023-02-08 13:54:33 +02:00
William Durand
4cf5bc48b2
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Depends on D169088
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-02-08 10:25:02 +00:00
Butkovits Atila
af64ca6493
Backed out changeset ab00cf793f29 (bug 1800417) for causing failures at browser_unified_extensions_overflowable_toolbar.js.
2023-01-30 17:34:14 +02:00
William Durand
fd0ded3d7b
Bug 1800417 - Fix the use of both toolbarbutton-1 and subviewbutton CSS classes in extension widgets. r=Itiel,mconley,dao,rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D162712
2023-01-30 13:36:07 +00:00
Tomislav Jovanovic
d378ab25a4
Bug 1805523 - Implement temporary access state and attention, r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D165490
2023-01-24 00:47:13 +00:00
William Durand
4b65e0a0cb
Bug 1799009 - Remove gUnifiedExtensions.isEnabled. r=rpl,mconley
...
Depends on D166923
Differential Revision: https://phabricator.services.mozilla.com/D166934
2023-01-23 10:39:29 +00:00
William Durand
7761eccedb
Bug 1799009 - Remove unified extensions pref and non-unified extensions variants from test suite. r=rpl,mconley,fluent-reviewers,desktop-theme-reviewers,Itiel
...
This patch removes the use of the "unified extensions" pref and adjust
the existing tests. More clean-ups will be done in follow-ups, e.g. the
removal of `gUnifiedExtensions.isEnabled` and some test-only changes to
no longer create a new window in each test file.
Differential Revision: https://phabricator.services.mozilla.com/D166908
2023-01-19 10:59:25 +00:00
Marian-Vasile Laza
3f9e8980c7
Backed out changeset 1c135e14142e (bug 1805523) for causing bc failures on browser_ext_windows_create_tabId.js.
2023-01-02 16:34:38 +02:00
Tomislav Jovanovic
6716f18a49
Bug 1805523 - Implement temporary access state and attention, r=rpl
...
Differential Revision: https://phabricator.services.mozilla.com/D165490
2023-01-01 21:46:00 +00:00
Bobby Holley
fd1ec254e0
Bug 1807852 - Don't omit the "extra" field for suspicious site telemetry. r=jmaher
...
Differential Revision: https://phabricator.services.mozilla.com/D165632
2022-12-28 20:07:25 +00:00
Bobby Holley
6bd00864a6
Bug 1806056 — Enable users to report suspicious site permission add-on prompts. r=rpl,flod
...
Differential Revision: https://phabricator.services.mozilla.com/D164876
2022-12-28 00:25:07 +00:00
Tomislav Jovanovic
02c5082e6b
Bug 1798695 - Use WebExtensionPolicy to get list of active extensions r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D162570
2022-12-14 17:56:29 +00:00
William Durand
ccab553cb5
Bug 1801456 - Lazy-load context menu strings when we lazy-load the panel. r=Gijs
...
Differential Revision: https://phabricator.services.mozilla.com/D163589
2022-12-05 16:43:12 +00:00
William Durand
d55bdd31af
Bug 1802925 - Update attention dot when (un)pinning extensions. r=zombie
...
Differential Revision: https://phabricator.services.mozilla.com/D163580
2022-12-05 14:55:51 +00:00
Mike Conley
dda8b11101
Bug 1801514 - Make sure addons panel hides when entering customize mode. r=willdurand
...
Differential Revision: https://phabricator.services.mozilla.com/D163013
2022-11-28 16:24:09 +00:00
William Durand
80f9f71d60
Bug 1799694 - Avoid flickering when messages have different lengths. r=rpl,mconley,desktop-theme-reviewers,Itiel
...
This is a completely redesign based on mconley's idea to use `deck`.
That removes a lot of code and makes things a lot better.
Depends on D163077
Differential Revision: https://phabricator.services.mozilla.com/D162390
2022-11-27 17:07:44 +00:00