Commit Graph

293 Commits

Author SHA1 Message Date
Stephen Thompson
b41097f455 Bug 1933309 - arrow keys should select tabs and tab group labels in the tab strip r=dao,tabbrowser-reviewers
Currently, when the tab strip is in focus, pressing the arrow keys currently switches the active tab only. With this change, pressing the arrow keys will continue to switch the active tab when the adjacent item in the tab strip is a tab, but tab group labels will also receive keyboard focus if they happen to the adjacent items in the tab strip. Now, pressing left/right allows the user to "select" each tab or tab group label in the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D233016
2025-01-06 17:08:03 +00:00
Mauro B
35bae9ed07 Bug 1921951 - Fixed linter errors. r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233208
2025-01-04 12:48:45 +00:00
Mauro B
dea2dbc861 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-04 12:48:45 +00:00
Narcis Beleuzu
884122ae28 Backed out changeset 5ddfa4c882b5 (bug 1921951) for lint failures on tabs.js . CLOSED TREE 2025-01-04 02:05:03 +02:00
Mauro B
1cae811100 Bug 1921951 - Added support for vertical tabbar scrolling r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D233205
2025-01-03 23:24:54 +00:00
Dão Gottwald
1a4c207141 Bug 1939677 - Correctly add toolbarbuttons to TAB key order. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233089
2025-01-03 17:34:14 +00:00
Dão Gottwald
e9e9d3a05a Bug 1926254 - Esc key should cancel rather than accept the tab group create panel. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D233185
2025-01-03 17:15:50 +00:00
Jeremy Swinarton
82d7acff7a Bug 1936015: Groups can be deleted after switching between horizontal and vertical tabs r=dao,sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232925
2025-01-03 13:37:41 +00:00
Stephen Thompson
4076f2c38a Bug 1936752 - unlock tab sizes in collapsed tab groups r=jswinarton,tabbrowser-reviewers
In certain cases when closing a tab(s), we temporarily lock the width of the tabs instead of letting them grow/shrink. If you close a tab and then quickly collapse a tab group right afterwards, you can end up with the tab group label going into the collapsed state correctly but the tabs in the tab group are still visible.

The issue is that we lock tab sizes on visible tabs using `max-width: ... !important` and we are hiding tabs in collapsed tab groups by using a CSS rule of `max-width: 0`. When we unlock the tab sizes, we only unlock visible tabs, but the tabs inside of the collapsed tab group are no longer considered visible.

This fix removes the tab lock size `max-width: ... !important` rule on all tabs regardless of tab visibility.

Differential Revision: https://phabricator.services.mozilla.com/D233022
2024-12-31 20:03:05 +00:00
Niklas Baumgardner
0f7ec7d1ef Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 20:46:00 +00:00
Dão Gottwald
3336bd457a Bug 1937203 - Tab group panel should close when expanding/collapsing a group. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232657
2024-12-19 20:30:41 +00:00
Goloman Adrian
8893c682ad Backed out changeset b732fa6b4026 (bug 1919600) for causing bc failures @browser_preferences_usage.js. CLOSED TREE 2024-12-19 19:47:31 +02:00
Niklas Baumgardner
99881abf10 Bug 1919600 - Update window title to include profile name. r=jhirsch,mossop,fluent-reviewers,tabbrowser-reviewers,bolsson,dao
Differential Revision: https://phabricator.services.mozilla.com/D230958
2024-12-19 16:07:05 +00:00
Dão Gottwald
8b91d8e6b9 Bug 1935956 - Include group labels in scrollable elements. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232517
2024-12-19 15:32:48 +00:00
DJ
a807e8e024 Bug 1908431 - add basic support for tab groups in overflow menu. r=dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D232389
2024-12-19 12:04:19 +00:00
Stephen Thompson
808fb505dc Bug 1921857 - "close tabs to the left/right" changes for tab groups r=dao,sessionstore-reviewers,tabbrowser-reviewers
1. should be available in the context menu even if there are collapsed tab groups to the left/right
2. should close collapsed tab groups when they are to the left/right
3. tab groups should be saved when they are going to be closed when using "close tabs to the left/right"

Differential Revision: https://phabricator.services.mozilla.com/D232432
2024-12-19 10:22:24 +00:00
Stephen Thompson
f8fd5db3b5 Bug 1933813 - "close other tabs" changes for tab groups r=dao,jswinarton,sessionstore-reviewers,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232430
2024-12-19 08:54:25 +00:00
Stanca Serban
4db9e4acb2 Backed out 2 changesets (bug 1938187, bug 1908431) for causing xpcshell failures in test_providerOmnibox.js. CLOSED TREE
Backed out changeset 0449f79cb3bd (bug 1938187)
Backed out changeset 26bd70f6e763 (bug 1908431)
2024-12-19 06:26:36 +02:00
DJ
13502b2c42 Bug 1908431 - add basic support for tab groups in overflow menu. r=dao,fluent-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,bolsson
Differential Revision: https://phabricator.services.mozilla.com/D232389
2024-12-19 03:08:11 +00:00
Stanca Serban
30c8718405 Backed out changeset a2a3d6bf518f (bug 1921060) as requested for causing multiple regressions. 2024-12-18 20:51:04 +02:00
Dão Gottwald
468d6c6d01 Bug 1938054 - Add a zero width space to tab group labels so we always create a text node and get consistent layout even if the group is unnamed. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D232453
2024-12-18 13:58:29 +00:00
Dão Gottwald
873d45642f Bug 1936341 - Convert textoverflow to boolean attribute. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D231711
2024-12-12 15:04:22 +00:00
Kelly Cochrane
93e44d9499 Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-12 12:57:41 +00:00
Dão Gottwald
8a2e7099f7 Bug 1934007 - Prevent empty group when attempting to group pinned tabs. r=jswinarton,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231788
2024-12-11 16:21:34 +00:00
Alexandru Marc
b15c866809 Backed out changeset 5b573c874645 (bug 1921060) for causing mda failures @ browser_mute_webAudio.js CLOSED TREE 2024-12-11 17:40:44 +02:00
Kelly Cochrane
bb2110744e Bug 1921060 - Implement full mute button spec r=desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
Differential Revision: https://phabricator.services.mozilla.com/D231182
2024-12-11 14:37:38 +00:00
Tom Schuster
66a5275deb Bug 1935688 - Remove inline event handlers from MozTabbrowserTab. r=tabbrowser-reviewers,mconley
Differential Revision: https://phabricator.services.mozilla.com/D231401
2024-12-10 08:51:09 +00:00
Emilio Cobos Álvarez
910845c8c5 Bug 1933769 - Remove no-op focus() calls. r=tabbrowser-reviewers,dao
Since bug 1823984, this focus() call has been a no-op on remote frames.

The previous patch also fixes the non-remote frame focus switch.

Differential Revision: https://phabricator.services.mozilla.com/D230098
2024-12-09 21:42:42 +00:00
Stephen Thompson
b437b0d758 Bug 1927994 - do not allow pinned tabs to move inside tab groups r=dao,tabbrowser-reviewers
There are a number of oddities that cropped up from pinned tabs moving into tab groups, e.g. when the first item in the tab strip is a tab group or when pinning a tab that's already in a tab group. This patch repairs those cases to ensure that pinned tabs stick to the beginning of the tab strip.

Differential Revision: https://phabricator.services.mozilla.com/D230344
2024-12-06 05:26:16 +00:00
Dão Gottwald
5536b67d3f Bug 1933775 - When you collapse all tab groups on tab strip, open a New tab. r=sthompson,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231295
2024-12-05 20:28:19 +00:00
Dão Gottwald
1a974c5351 Bug 1935029 - Add Nimbus recipe for tab groups. r=dwalker,tabbrowser-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D231030
2024-12-05 15:13:07 +00:00
Adam Vandolder
2ba689d99e Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-05 01:20:07 +00:00
Nikki Sharpley
6d6ad18210 Bug 1934957 - Remove unnecessary additional shift for expanded vertical pinned tabs drag over r=sidebar-reviewers,kcochrane
Differential Revision: https://phabricator.services.mozilla.com/D230987
2024-12-04 14:33:35 +00:00
Goloman Adrian
05b7d33317 Backed out changeset 4d19e4620e63 (bug 1924861) for causing bc failures @browser_stop_pending.js. CLOSED TREE 2024-12-04 09:11:45 +02:00
Adam Vandolder
87c9038ba7 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-04 04:17:36 +00:00
Stephen Thompson
2623aa98bb Bug 1933210 - maintain tab ordering on drop group creation r=dao,tabbrowser-reviewers
- when creating a group from the front edge of a target tab, the target tab should be the last tab in the group
- when creating a group from the back end of a target tab, the target tab should be the first tab in the group
- the tab group should be created at the position of the target tab

Differential Revision: https://phabricator.services.mozilla.com/D230283
2024-12-04 02:35:49 +00:00
Nikki Sharpley
9afc398378 Bug 1935026 - Ensure we are using the right scroll position for vertical pinned tabs r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D231017
2024-12-03 21:27:51 +00:00
Dão Gottwald
db518f5774 Bug 1934296 - Adding a tab to a collapsed group should expand the group. r=tabbrowser-reviewers,jswinarton
Differential Revision: https://phabricator.services.mozilla.com/D230982
2024-12-03 18:15:28 +00:00
Cosmin Sabou
82fbc8fbe4 Backed out changeset a8d030efc4ea (bug 1924861) for causing bc failures on browser_stop_pending. 2024-12-02 01:21:14 +02:00
Adam Vandolder
f6e7455adc Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-12-01 04:13:01 +00:00
Sandor Molnar
7e190c9386 Backed out changeset b94afd94ed9c (bug 1924861) for causing multiple bc failures. CLOSED TREE 2024-11-30 20:40:15 +02:00
Adam Vandolder
5f7b028386 Bug 1924861 - Only show the first history entry if it has user interaction. r=dom-core,omc-reviewers,sessionstore-reviewers,dao,peterv,tabbrowser-reviewers,mviar,sfoster,webdriver-reviewers
Differential Revision: https://phabricator.services.mozilla.com/D221390
2024-11-29 23:38:09 +00:00
Dão Gottwald
5cae56eb21 Bug 1933547 - Adjust group menu position for vertical tabs. r=tabbrowser-reviewers,jswinarton
Basically copied this from TabHoverPreviewPanel::#popupOptions.

Differential Revision: https://phabricator.services.mozilla.com/D230399
2024-11-28 15:15:43 +00:00
Nikki Sharpley
cb461afb42 Bug 1930929 - Fix vertical pinned tabs drag animation on scroll overflow r=tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D230425
2024-11-28 15:06:35 +00:00
Emilio Cobos Álvarez
768894a512 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 12:12:51 +00:00
Cristina Horotan
bb08cc9f1d Backed out 5 changesets (bug 1930292, bug 1932600) for causing chrome failures at test_maximized_persist.xhtml on a CLOSED TREE
Backed out changeset 2418bfee53f1 (bug 1932600)
Backed out changeset 3297e990715a (bug 1932600)
Backed out changeset 24a670dea977 (bug 1930292)
Backed out changeset 7dd9f48216dd (bug 1930292)
Backed out changeset 15a85ec739dd (bug 1930292)
2024-11-28 06:57:35 +02:00
Emilio Cobos Álvarez
26de824592 Bug 1932600 - Use customtitlebar rather than tabsintitlebar in front-end code. r=dao,desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley
This is probably also a better reflection of reality now that we can
have vertical tabs which would by definition not be in the titlebar.

Differential Revision: https://phabricator.services.mozilla.com/D229767
2024-11-28 03:26:50 +00:00
Nikki Sharpley
83c7885079 Bug 1908471 - Round content area top corner closest to sidebar r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,emilio,dao,sclements
Differential Revision: https://phabricator.services.mozilla.com/D229676
2024-11-27 19:50:02 +00:00
Simon Friedberger
997eea8abc Bug 1932640. Remove History:UndoCloseTab event handler. r=mossop,tabbrowser-reviewers,dao
Differential Revision: https://phabricator.services.mozilla.com/D229920
2024-11-27 11:07:19 +00:00
Dão Gottwald
fc9ca6d8a6 Bug 1933152 - Fix selected tab's group line color when the selected tab has a different color scheme than the tabs toolbar. r=tabbrowser-reviewers,sthompson
Differential Revision: https://phabricator.services.mozilla.com/D230083
2024-11-27 10:37:55 +00:00