Nikki Sharpley
65bf12da75
Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D221681
2024-09-11 22:43:59 +00:00
Nikki Sharpley
24fbe2a5b1
Bug 1913971 - Improve drag experience for pinned tabs in expanded vertical tabs r=sidebar-reviewers,sclements,mconley
...
Differential Revision: https://phabricator.services.mozilla.com/D221078
2024-09-11 18:18:36 +00:00
Norisz Fay
9a12f4f7a5
Backed out changeset 870b68c06bd7 (bug 1914438) for causing bc failures on browser_newtabButton.js CLOSED TREE
2024-09-11 19:05:37 +03:00
Nikki Sharpley
98f6dcfb4e
Bug 1914438 - Long press on New tab button does not offer to open a new Container tab r=sidebar-reviewers,tabbrowser-reviewers,dao,sclements
...
Differential Revision: https://phabricator.services.mozilla.com/D221681
2024-09-11 13:02:32 +00:00
Sarah Clements
00d0b28ceb
Bug 1913279 - Fix vertical tabs issue with selected tab not scrolling on overflow r=tabbrowser-reviewers,desktop-theme-reviewers,dao
...
* Remove condition in tabs.js that prohibited overflow attribute being added for vertical orientation
* Remove redundant overflow-y:auto for #tabbrowser-arrowscrollbox and set a min-height for vertical tabs
Differential Revision: https://phabricator.services.mozilla.com/D221133
2024-09-09 13:49:26 +00:00
DJ
c1bc3a2807
Bug 1912391 - position tab preview appropriately when in vertical mode. r=tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D219326
2024-09-09 05:06:29 +00:00
DJ
e3acb876f7
Bug 1908415 - fire DOM events on tab group create, delete, group, ungroup. r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220741
2024-09-06 17:31:13 +00:00
Dão Gottwald
06e952e673
Bug 1916941 - Vertical new tab button cleanup. r=desktop-theme-reviewers,sidebar-reviewers,kcochrane
...
Details in the bug.
Differential Revision: https://phabricator.services.mozilla.com/D221117
2024-09-06 14:04:43 +00:00
Dão Gottwald
47916b2da7
Bug 1916622 - Remove the browser.tabs.tabmanager.enabled pref. r=tabbrowser-reviewers,extension-reviewers,desktop-theme-reviewers,emilio,robwu,dwalker
...
Differential Revision: https://phabricator.services.mozilla.com/D221005
2024-09-05 13:37:09 +00:00
Dão Gottwald
ddb9309ce9
Bug 1915599 - Consolidate tabbrowser arrowscrollbox initialization and overflow/overflowing attribute checks. r=extension-reviewers,desktop-theme-reviewers,jswinarton,emilio,robwu
...
Differential Revision: https://phabricator.services.mozilla.com/D220594
2024-09-04 08:18:46 +00:00
Jeremy Swinarton
8a865f454f
Bug 1908408: API to move tab group to a new window r=dao,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220601
2024-09-03 14:06:07 +00:00
Stanca Serban
629a9a3617
Backed out changeset b20f0a3ffccf (bug 655445) for causing mochitests failures in browser_new_tab_insert_position.js. CLOSED TREE
2024-09-03 17:43:52 +03:00
codesuki
e60bdb02a5
Bug 655445 - Add setting to control position of tabs opened from pinned tabs. r=dao,tabbrowser-reviewers
...
This patch introduces `browser.tabs.insertAfterCurrentExceptPinned`.
Setting it to `true` open links from pinned tabs at the end of the tabbar.
Differential Revision: https://phabricator.services.mozilla.com/D69489
2024-09-03 13:12:27 +00:00
isaacylee
cfa004f3c1
Bug 1558149 - Use 'loadFlags' instead of 'flags' for flags eventually passed to 'loadURI' or 'fixupAndLoadURIString' r=Gijs,geckoview-reviewers,tabbrowser-reviewers,dao,owlish
...
Differential Revision: https://phabricator.services.mozilla.com/D216324
2024-08-31 22:00:59 +00:00
Dave Townsend
76fee57fc7
Bug 1915111: Double clicking in the vertical tab strip should open a new tab. r=desktop-theme-reviewers,tabbrowser-reviewers,sclements,dao
...
This solves two problems. First we must make the tabbrowser-tabs instance
fill the remaining space in the sidebar while at the moment it is constrained
to the height of the tabs. Then we allow the double click event to be
handled when vertical tabs and tabs in titlebar are enabled.
Differential Revision: https://phabricator.services.mozilla.com/D220269
2024-08-30 08:20:47 +00:00
Jeremy Swinarton
aaa87e6120
Bug 1908413: Delete tab group when closing the last tab r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220486
2024-08-29 15:29:03 +00:00
timw-dev
7275427d4a
Bug 1804166 - favicon not reseting when changing tab to about:newtab with newtab to Blank Page.r=tgiles,tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D216357
2024-08-28 15:33:38 +00:00
Jeremy Swinarton
6a9ffdb4fe
Bug 1908411: API to remove tab group r=dao,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220273
2024-08-28 11:29:44 +00:00
Dão Gottwald
fccdffe4bf
Bug 345399 - Update scroll buttons' disabled state when the scrollbox width changes. r=emilio,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220153
2024-08-27 20:19:18 +00:00
Jeremy Swinarton
b44f09e709
Bug 1914952: Grouping tabs doesn't fire TabMove event if position unchanged r=dao,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220140
2024-08-26 17:22:39 +00:00
Jeremy Swinarton
86a3077de9
Bug 1908407: Add tab groups API to ungroup tabs r=dao,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220001
2024-08-26 17:22:09 +00:00
DJ
6248ea2cf3
Bug 1908419 - add method to retrieve list of groups from tabContainer. r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220142
2024-08-26 16:59:51 +00:00
Dão Gottwald
b736efa05b
Bug 1914779 - Clean up getting the last tab in tabs.js. r=jswinarton,dwalker,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D220076
2024-08-26 14:39:43 +00:00
Dão Gottwald
399c2311b3
Bug 1914703 - Fix up scrolled to end check. r=emilio
...
I first tried to fix the disabled property, but this turned into a rabbit hole that seems a bit too risky at this stage. With some luck, this may be the only place accessing these buttons' disabled property. Medium-term we still need to fix the property, ideally by making the disabled attribute a standard boolean one.
Differential Revision: https://phabricator.services.mozilla.com/D220122
2024-08-26 13:06:21 +00:00
Dão Gottwald
21ba6a69e4
Bug 1914519 - Consolidate vertical mode and rtl checks in tab bar code. r=jswinarton,dwalker
...
Differential Revision: https://phabricator.services.mozilla.com/D219933
2024-08-23 20:17:39 +00:00
Emilio Cobos Álvarez
0cfa35c631
Bug 1914544 - Make sure we don't open a new tab for doubleclick on the overflow buttons.
...
MANUAL PUSH: Fixes browser_overflowScroll.js on Linux CLOSED TREE.
2024-08-23 18:47:10 +01:00
Emilio Cobos Álvarez
9cd0c34bd2
Bug 1914544 - Fix tab bar doubleclick check. r=dao,tabbrowser-reviewers
...
Make sure that we actually hit our arrowscrollbox (not any random
scrollbox).
Differential Revision: https://phabricator.services.mozilla.com/D219972
2024-08-23 14:55:27 +00:00
DJ
bfb53ac9de
Bug 1908405 - accept optional list of tabs in addTabGroup. r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D219941
2024-08-23 09:44:53 +00:00
Emilio Cobos Álvarez
b5cc0dcae9
Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
...
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.
Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.
Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-21 12:23:34 +00:00
Cristian Tuns
8914d54c72
Backed out changeset 6fb2cecebdd8 (bug 1913322) for causing multiple failures. CLOSED TREE
2024-08-20 21:01:50 -04:00
Emilio Cobos Álvarez
02bec8c38e
Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
...
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.
Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.
Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 22:31:22 +00:00
Iulian Moraru
cd76550840
Backed out changeset 1658290c1b95 (bug 1913322) for causing overflow related failures. CLOSED TREE
2024-08-20 17:54:54 +03:00
Emilio Cobos Álvarez
cb06f25a7a
Bug 1913322 - Make arrowscrollbox use resizeobserver rather than overflow/underflow events. r=Gijs,dao,desktop-theme-reviewers,tabbrowser-reviewers,frontend-codestyle-reviewers
...
For that, make the <slot> have a box. Keep firing the overflow /
underflow events, but only in cases relative to the arrowScrollbox.
Remove unneeded scrollbox-clip box, and replace it by
`overflow-clip-box-block: content-box` in the only place that we make
the scrollbox grow.
Differential Revision: https://phabricator.services.mozilla.com/D219249
2024-08-20 12:58:16 +00:00
Florian Quèze
65bf72cdca
Bug 1913624 - Remove expired telemetry histogram HOVER_UNTIL_UNSELECTED_TAB_OPENED, r=chutten,tabbrowser-reviewers,dao.
...
Depends on D219440
Differential Revision: https://phabricator.services.mozilla.com/D219441
2024-08-20 10:26:51 +00:00
Florian Quèze
171499434e
Bug 1913624 - Remove expired telemetry histogram TAB_AUDIO_INDICATOR_USED, r=chutten,tabbrowser-reviewers,dao.
...
Depends on D219439
Differential Revision: https://phabricator.services.mozilla.com/D219440
2024-08-20 10:26:51 +00:00
Jan-Niklas Jaeschke
de1c63ce2a
Bug 1911339 - Text Fragments: Preserve user activation when opening a link in a new tab or window. r=dom-core,tabbrowser-reviewers,dao,farre
...
Differential Revision: https://phabricator.services.mozilla.com/D218655
2024-08-20 08:47:49 +00:00
Jeremy Swinarton
1ca50f8860
Bug 1912275: Collapsing tab group changes selected tab r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218888
2024-08-14 13:56:29 +00:00
DJ
324236fba0
Bug 1911924 - don't show tab preview thumbnail placeholder when thumbnails are disabled. r=tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D219031
2024-08-14 07:58:20 +00:00
Jeremy Swinarton
0d521d1f2b
Bug 1908416: gBrowser.visibleTabs handles tab groups r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218796
2024-08-08 16:23:24 +00:00
Sam Foster
f64b68c78d
Bug 1899580 - Exclude collapsed vertical tabs from indicator-replaces-favicon behavior. r=sidebar-reviewers,desktop-theme-reviewers,tabbrowser-reviewers,dao,sessionstore-reviewers,sclements
...
- Ensure everything that sets .expanded on sidebar-main uses the toggleExpanded method
Differential Revision: https://phabricator.services.mozilla.com/D217507
2024-08-07 18:51:26 +00:00
Jeremy Swinarton
cd95d6d498
Bug 1908404: Click to expand/collapse tab group r=dao,desktop-theme-reviewers,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218434
2024-08-07 14:59:36 +00:00
Anna Yeddi
f351d96411
Bug 1884970 - Close current tab button is missing an accessible name and role. r=tabbrowser-reviewers,fluent-reviewers,dao,bolsson,flod
...
The [tab-close-button](https://searchfox.org/mozilla-central/rev/f9157a03835653cd3ece8d2dc713a782b7e4374e/browser/base/content/tabbrowser-tab.js#40 ) is not labeled and is missing an interactive role of button, while it is functioning as one.
Note: we do not want this control to be keyboard focusable, because keyboard-only user could close the tab via the context menu and we don't want to create an additional tab stop for the navigation as well, but making sure the control is marked up as a button with an accessible name would allow it to be actionable with speech-to-text software, with touch devices, with switch controls in scan mode, and for screen readers via their navigation shortcuts as well.
Differential Revision: https://phabricator.services.mozilla.com/D204413
2024-08-06 13:51:06 +00:00
Stefan Richter
551e400b7c
Bug 1409262 - Notify when openerTabId changed via tabs.update() r=robwu,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D164982
2024-08-05 17:49:06 +00:00
Dão Gottwald
5cc15d0779
Bug 1908412 - add API for adding tabs to a group. r=dao,tabbrowser-reviewers
...
Differential Revision: https://phabricator.services.mozilla.com/D218204
2024-08-05 09:25:19 +00:00
DJ
89ad94eb74
Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 18:47:41 +00:00
DJ
a96bf7ac85
Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 18:47:40 +00:00
Sandor Molnar
2e5df25263
Backed out 2 changesets (bug 1906123, bug 1902619) for causing bc failures @ @ browser_thumbnails_bg_basic.js CLOSED TREE
...
Backed out changeset d64bfab9a514 (bug 1902619)
Backed out changeset 5bbb9dd95c0e (bug 1906123)
2024-07-31 21:29:58 +03:00
DJ
7ae78e601d
Bug 1902619 - Hold space for pending screenshots and fade in when ready. r=jswinarton,desktop-theme-reviewers,tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D218101
2024-07-31 17:30:23 +00:00
DJ
db52857c68
Bug 1906123 - use a fixed AR for tab preview while preserving scroll position. r=tabbrowser-reviewers,dao
...
Differential Revision: https://phabricator.services.mozilla.com/D218085
2024-07-31 17:30:22 +00:00
Dão Gottwald
95d5536b2f
Bug 1910576 - tabbrowser.js needs to check tabContainer.verticalMode rather than tabContainer.inVerticalTabsMode. r=tabbrowser-reviewers,dwalker
...
Borrowed from https://phabricator.services.mozilla.com/D218052
Differential Revision: https://phabricator.services.mozilla.com/D218185
2024-07-31 15:18:09 +00:00