Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Adding additional UI elements and filling out state machine with actualy UI updates. Some functions are stubbed out while waiting on ML to have API up on central. These UI changes should have no change to current UI if pref is turned off.
Differential Revision: https://phabricator.services.mozilla.com/D237277
Landing in moz-central the utility SmartTabGrouping class that enables smart tab grouping of browser tabs.
This includes some cleanup in the toolkit/../ml /code, including adding more tests.
We are slimming test data tsv files by using 5 dimensional embeddings instead of 500 dim.
There is still some algorithm code in /tabbrowser/SmartTabGrouping because it is tied up with tabs. We could maybe move some to toolkit/../ml if required but it is a little tricky.
With this patch landed, some clustering access would be available in the console by typing: gBrowser.smartTabGrouping()
@ngrato will have a separate patch to enable the UI.
Differential Revision: https://phabricator.services.mozilla.com/D237112
Note that this is behind a pref that is turned off right now - I'm
landing this so UX and a11y folks can more easily take a look at it.
Differential Revision: https://phabricator.services.mozilla.com/D235864
Add a feature flag for turning on/off the UI for smart tab grouping. Updating formatting for the HTML. Due to the use of XUL the html has no syntax highlighting and is extremely difficult to read when not formatted vertically. More UI is comming and this helps pave the way for a more readable file.
Differential Revision: https://phabricator.services.mozilla.com/D236383
Let Gecko choose a suitable size. This seems to result in the desired
behavior (same as Ctrl+N). Tested GNOME and Kwin, X11 and Wayland.
The reason for the behavior change here is because `outerWidth` before
the regressing patch returned the inner, not the outer width. Combined
with the pre-existing behavior that decorations are added asynchronously
by the window manager, it just happened to conveniently cancel out that
bug, which is now fixed.
It's unclear we need this at all on macOS fwiw. IIRC Cmd+N does also the
same thing as Windows, so maybe we can remove this block altogether.
Separate patch tho, as I don't have a macOS build ready to test it this
very moment, but I think it should just work.
Differential Revision: https://phabricator.services.mozilla.com/D236867
To prep for the transition of code migrating from Larch to Central, for STG (Smart Tab Grouping), the best technique would be to implement peace by peace not to overwhelm a single patch.
This bug is the beginning of said work by setting the ground work for the state machine that manages the many additional states used by the STG feature.
Differential Revision: https://phabricator.services.mozilla.com/D235712
