corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
869,251 Commits 1 Branch 0 Tags
b207f35b42a6e79769646bc857a21fd5ea2e17f8
Commit Graph

195 Commits

Author SHA1 Message Date
Shane Hughes
080905839f Bug 1905119 - Fix feature callout RTL display. r=omc-reviewers,negin 
Differential Revision: https://phabricator.services.mozilla.com/D216597
 2024-07-16 02:11:32 +00:00
negin
88cc6d35cb Bug 1905175 - add fxa toolbar badge notification message r=omc-reviewers,aminomancer 
Adds [treatment-a of toolbar badge as default experience](https://experimenter.services.mozilla.com/nimbus/firefox-accounts-toolbar-button-default-visibility-existing-users-part-3/summary)
{F7380178}

Differential Revision: https://phabricator.services.mozilla.com/D215547
 2024-07-04 23:08:16 +00:00
Meg Viar
3a2722f608 Bug 1904345 - Ignore duplicate explicit target names r=omc-reviewers,negin 
Duplicate explicit targets in the previous patches resulted in warnings. This patch updated the two remaining duplicate explicit targets to cross-referencing syntax for glossary terms [[ https://docutils.sourceforge.io/docs/user/rst/quickref.html#hyperlink-targets | See documentation here ]].

Differential Revision: https://phabricator.services.mozilla.com/D214804
 2024-07-03 13:45:55 +00:00
Cristina Horotan
77f34279ed Backed out changeset 3cd5c74698b5 (bug 1899747) for causing bc failures at browser_feature_callout.js CLOSED TREE 2024-07-03 03:34:37 +03:00
hanna alemu
6e75b37b22 Bug 1899747 - Add option to extend feature callout page_event_listener to all windows r=omc-reviewers,mviar,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D213239
 2024-07-02 23:44:49 +00:00
negin
33463aa315 Bug 1903841 - Remove ghost shadow on feature callout r=omc-reviewers,aminomancer,mviar 
Removes additional 'ghost' shadow around the feature callout container when the feature callout repositions.

Before:
{F7346454}

After:
{F7346458}

Differential Revision: https://phabricator.services.mozilla.com/D215117
 2024-06-28 14:36:21 +00:00
Shane Hughes
dea4e0688d Bug 1903684 - Fix browser_spotlight_default_messages accessible failure. r=omc-reviewers,mviar 
Differential Revision: https://phabricator.services.mozilla.com/D214350
 2024-06-26 19:06:45 +00:00
Moritz Beier
9d7c26eff8 Bug 1903247 - Remove SearchEngine.searchForm. r=Standard8,omc-reviewers,home-newtab-reviewers,aminomancer,urlbar-reviewers,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D214240
 2024-06-26 16:03:23 +00:00
Meg Viar
3e1a99cbe9 Bug 1904345 - Remove duplicate link targets from messaging glossary and add to toctree r=omc-reviewers,aminomancer 
The multiple instances of links titled "Learn more" in the original patch caused issues. Also, this should be in a toctree under messaging system.

Differential Revision: https://phabricator.services.mozilla.com/D214724
 2024-06-25 00:27:53 +00:00
Shane Hughes
8ce2ea1d0f Bug 1903697 - Slightly improve ASRouter Admin styles. r=emcminn,omc-reviewers 
- Give all bordered tables 100% width.
- Show which view is active in the sidebar by highlighting the active
  tab in blue. Adjust the sidebar styles to match about:preferences.
- Increase the space between filter columns.

Differential Revision: https://phabricator.services.mozilla.com/D214353
 2024-06-24 19:52:53 +00:00
Meg Viar
beb32f7d8e Bug 1869215 - [Docs] Create Messaging System glossary r=omc-reviewers,negin 
Add a glossary of messaging system terms to Firefox source docs.

Differential Revision: https://phabricator.services.mozilla.com/D214106
 2024-06-24 13:24:47 +00:00
Shane Hughes
259507acf6 Bug 1861248 - Overhaul ASRouter admin and remove its dependency on newtab. r=omc-reviewers,emcminn 
For starters, replace all newtab styles and functions. Since we're
removing these styles, I conformed the asrouter admin to the reusable
components team's design tokens. So, it now uses global system page
styles. This is a pretty general overhaul since there are so many styles
to replace. In addition to the style changes, I've added a new Filters
UI and moved the groups table to the General tab. This allows us to
remove the Message Groups tab since that functionality is now rolled
into the Filters UI. The same with the Private Browsing tab: when you
hit Show on a pb_newtab message, it will open a PB window and override
the message. And you can filter by template now, so you can view only PB
messages on the General tab. I also fixed spellchecking. Instead of
spellchecking, which only works for natural languages, we just validate
that the text is valid JSON. If it's not valid, we show a red border on
the textarea. That way messages won't just mysteriously fail to show. I
also moved a few elements around to conserve space. Now, everything
should be able to fit on the screen of a default window size of 1500px.
Finally, I removed some old cruft that was left over from when the admin
interface was part of the newtab page.

Differential Revision: https://phabricator.services.mozilla.com/D213865
 2024-06-19 19:45:03 +00:00
Shane Hughes
17ca553f9d Bug 1899030 - Part 5: Remove miscellaneous unused asrouter code from newtab. r=mconley,omc-reviewers,frontend-codestyle-reviewers,pdahiya 
Also update nimbus rollout message provider.

Differential Revision: https://phabricator.services.mozilla.com/D211673
 2024-06-19 19:45:02 +00:00
Shane Hughes
ec1f215c37 Bug 1899030 - Part 2: Move remote-text component to asrouter. r=mconley,omc-reviewers,home-newtab-reviewers,negin,pdahiya,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211670
 2024-06-19 19:45:01 +00:00
Shane Hughes
e458f3a38a Bug 1899030 - Part 1: Remove ASRouterUserEvent from Actions.mjs. r=mconley,omc-reviewers,home-newtab-reviewers,negin,firefox-desktop-core-reviewers ,pdahiya,thecount 
Also remove unused action types and the unused ASRouter reducer.

Differential Revision: https://phabricator.services.mozilla.com/D211669
 2024-06-19 19:45:01 +00:00
Shane Hughes
47a7dce369 Bug 1900511 - Fix RC survey background, shadow, and transitions. r=omc-reviewers,pdahiya,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212499
 2024-06-18 16:58:32 +00:00
negin
ea70e6fdc9 Bug 1900984 - Fix Ghost shadow on feature callout arrow when flip=slide makes the arrow disappear r=omc-reviewers,mviar 
Before:
{F7308121}

After:
{F7308122}

Notice the lack of the arrow's shadow on mac OS.

Differential Revision: https://phabricator.services.mozilla.com/D213675
 2024-06-18 15:06:03 +00:00
Meg Viar
82932a56de Bug 1897804 - Fox Doodle Spotlight and Fox Doodle Set Default enrollment targeting should exclude First Run r=omc-reviewers,pdahiya 
This patch updates the targeting for two in-tree messages that include “source == ‘startup’” in their targeting and are triggered on default browser check. There are currently edge cases where these messages can collide with about:welcome. See [[ https://bugzilla.mozilla.org/show_bug.cgi?id=1897804#c4 | this comment ]] for steps to replicate an example.

By adding additional targeting that ensures this isn’t the user’s first session, we can avoid about:welcome collisions.

Differential Revision: https://phabricator.services.mozilla.com/D213456
 2024-06-18 11:32:42 +00:00
Shane Hughes
b7111cb1ca Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-18 10:42:27 +00:00
Stanca Serban
47ba18b7d7 Backed out changeset f6ca02568bef (bug 1899439) for causing xcpshell failures in xpcshell/test_PanelTestProvider.js. CLOSED TREE 2024-06-18 05:14:28 +03:00
Shane Hughes
91acd11433 Bug 1899439 - Flatten experiment-translated messages in local providers so they can be rendered. r=negin,omc-reviewers,emcminn,frontend-codestyle-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211946
 2024-06-17 17:52:59 +00:00
Emilio Cobos Álvarez
76dfae476f Bug 1902896 - Use system-ui font-family when appropriate. r=desktop-theme-reviewers,omc-reviewers,home-newtab-reviewers,dao,aminomancer,thecount 
This is shorter, and has the advantage that it behaves properly on Linux (not
just ubuntu). Also, it is more future-proof.

Differential Revision: https://phabricator.services.mozilla.com/D213880
 2024-06-17 14:53:04 +00:00
Shane Hughes
039ba4cf7a Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 23:05:10 +00:00
Aron Cseh
f28964fa3c Backed out changeset 98c3d77b4330 (bug 1899757) for causing multiple failures CLOSED TREE 2024-06-16 23:21:14 +03:00
Shane Hughes
6ef1ca7a31 Bug 1899757 - Allow targeting the trigger tab for feature callouts. r=hanna_a,omc-reviewers 
Also add a global `browserIsSelected` context property for all triggers,
so you can entirely avoid showing a message if the triggering browser
was in the background. You can use the selector and the context property
together or separately.

Context targeting:
`browserIsSelected`

Background tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%`

Current tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab%[visuallyselected]`

Child of tab selector:
`#tabbrowser-tabs:not([overflow]):not([haspinnedtabs]) %triggerTab% .tab-icon-image`

Differential Revision: https://phabricator.services.mozilla.com/D212494
 2024-06-16 19:11:41 +00:00
hanna alemu
d7c67f44bd Bug 1828508 - Clean up Firefox View Feature Tour + Notification r=omc-reviewers,fluent-reviewers,fxview-reviewers,nsharpley,bolsson,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209404
 2024-06-11 18:24:35 +00:00
Maxx Crawford
f79515b485 Bug 1900854 - Add telemetry events for dismiss and cta clicks for Wallpaper feature highlight r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D212952
 2024-06-07 20:44:50 +00:00
Amy Churchwell
528d14989b Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 23:02:05 +00:00
Butkovits Atila
4342985960 Backed out changeset fde0e6b10250 (bug 1897232) for causing bustages complaining about packager.mk. CLOSED TREE 2024-06-05 22:44:18 +03:00
Amy Churchwell
e77b770e58 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-05 17:21:22 +00:00
Sandor Molnar
093794820b Backed out changeset 711d1bed224b (bug 1897232) for causing xpc failures @ test_WallpaperFeed.js & bc failures @ browser_parsable_css.js CLOSED TREE 2024-06-04 23:34:06 +03:00
Amy Churchwell
cc94d1cbd3 Bug 1897232 - Add nested wallpaper categories. r=home-newtab-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D211895
 2024-06-04 19:31:03 +00:00
Maxx Crawford
370eb7ac1f Bug 1897233 - Add feature highlight for Wallpapers r=home-newtab-reviewers,fluent-reviewers,omc-reviewers,aminomancer,bolsson,thecount,nbarrett 
Differential Revision: https://phabricator.services.mozilla.com/D212157
 2024-06-04 00:54:00 +00:00
Nathan Barrett
c7d3cc489b Bug 1893007 - add location query to weather widget r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D212069
 2024-06-03 20:59:32 +00:00
scottdowne
0d285f9aec Bug 1900043 - Home and newtab fixing regression for light and dark mode caused by wallpaper contextual text colour changes. r=home-newtab-reviewers,maxx 
Differential Revision: https://phabricator.services.mozilla.com/D212301
 2024-05-31 18:36:19 +00:00
scottdowne
8954d01757 Bug 1898818 - Home and newtab fixes so newtab with a wallpaper looks good in both light and dark mode r=desktop-theme-reviewers,home-newtab-reviewers,omc-reviewers,sfoster,aminomancer,amy 
Differential Revision: https://phabricator.services.mozilla.com/D211623
 2024-05-30 18:47:21 +00:00
Shane Hughes
64ab25b51e Bug 1898346 - Fix feature callout incompatibility with transparent theme variables. r=negin,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D211275
 2024-05-28 17:59:47 +00:00
Maxx Crawford
ca1c9f6bb6 Bug 1898275 - Add impression and error telemetry events to Weather feature r=home-newtab-reviewers,thecount 
Differential Revision: https://phabricator.services.mozilla.com/D211402
 2024-05-24 01:46:48 +00:00
hanna alemu
5ad29cf4b1 Bug 1869212 - [Docs] Moments page is missing its example screenshot r=omc-reviewers,pdahiya 
Differential Revision: https://phabricator.services.mozilla.com/D210028
 2024-05-20 18:55:06 +00:00
Maxx Crawford
ef0230d8ef Bug 1895797 - Add telemetry to New Tab weather widget r=home-newtab-reviewers,omc-reviewers,nbarrett,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D209867
 2024-05-20 18:01:50 +00:00
Nathan Barrett
a46122da52 Bug 1896004 - Add wallpaper telemetry r=thecount,home-newtab-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D210101
 2024-05-17 14:51:43 +00:00
Nipun Shukla
a788d363d7 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 15:34:43 +00:00
Tamas Szentpeteri
833395877b Backed out 2 changesets (bug 1893341, bug 1895744) for causing bc failures in browser_windows_launch_on_login_msix.js. CLOSED TREE 
Backed out changeset ce5384469c24 (bug 1893341)
Backed out changeset 658645fa9303 (bug 1895744)
 2024-05-15 11:24:17 +03:00
Nipun Shukla
3e3ebab8c6 Bug 1893341 - Change Firefox launch on login to use Windows StartupTask functions on MSIX r=nalexander,nrishel,settings-reviewers,omc-reviewers,firefox-desktop-core-reviewers ,aminomancer 
Differential Revision: https://phabricator.services.mozilla.com/D208567
 2024-05-15 02:54:55 +00:00
Maxx Crawford
99b8fc05eb Bug 1890136 - Add weather widget component r=home-newtab-reviewers,omc-reviewers,aminomancer,thecount 
This commit adds the component - including markup, logic and styles for the weather widget on the New Tab page

Differential Revision: https://phabricator.services.mozilla.com/D208885
 2024-05-09 22:11:57 +00:00
Nathan Barrett
3ae97b6c59 Bug 1886833 - Home and newtab creating weather feed r=home-newtab-reviewers,maxx,nanj 
Differential Revision: https://phabricator.services.mozilla.com/D207763
 2024-05-06 16:02:21 +00:00
Sarah Chung
9a286a1dc8 Bug 1877512 - change feature-callout dismiss-button background color to transparent r=aminomancer,omc-reviewers 
Differential Revision: https://phabricator.services.mozilla.com/D209302
 2024-05-03 15:48:26 +00:00
Shane Hughes
8dd336f8c5 Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D208941
 2024-05-02 20:54:51 +00:00
Tamas Szentpeteri
c0574600bf Backed out changeset 1187f4d67bf7 (bug 1893671) for causing newtab failures in asrouter:CFRMessageProvider. CLOSED TREE 2024-05-02 21:34:33 +03:00
Shane Hughes
2625c54c7c Bug 1893671 - Add Fx113 facebook container experiment message in CFRMessageProvider. r=omc-reviewers,emcminn 
Differential Revision: https://phabricator.services.mozilla.com/D208941
 2024-05-02 17:44:25 +00:00