Commit Graph

103 Commits

Author SHA1 Message Date
Sean Lee
233ef57ca5 Bug 1282662 - Part 2: Implement the detail description in hover button case.; r=Paolo
MozReview-Commit-ID: G3L0sULmRLD
2016-12-21 22:50:07 +08:00
George Pîrlea
7262d5afe4 Bug 991965 - Inhibit item selection and update commands when the DownloadsBlockedSubview is open. r=paolo
MozReview-Commit-ID: Akly0NenY8Z
2017-01-21 17:42:36 +00:00
George Pîrlea
4c524107e8 Bug 991965 - Use event.target and inhibit item selection if the context menu is open. r=paolo
1) In the Downloads Panel, hovering over an item would sometimes not trigger an
actual selection, due to an error in how 'onDownloadMouseOver()' events were
processed - 'aEvent.orginalTarget' doesn't take retargets into account. Fixed
by using 'aEvent.target' instead of 'aEvent.originalTarget'.

2) In the Downloads Panel, right-clicking an item opens a context menu that
lets you act on the selected item. However, if you unintentionally hover over a
different item when the context menu is open, the selection changes. You may,
for example, 'Remove From History' a different, unintended item. Fixed by
inhibiting item selection when a context menu is open for a download item.

MozReview-Commit-ID: DLIAFNcs33N
2017-01-21 12:21:51 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Rex Lee
f09826a23b Bug 1269957 - Unify height of download items and allow maximum 5 items to show in downloads panel. r=Paolo
MozReview-Commit-ID: 1EoBfLXyDVN
2016-12-01 20:42:05 +08:00
Sean Lee
e6a4eae011 Bug 1282664 - Redesign the right-menu on a download item in Downloads Panel.; r=Paolo
MozReview-Commit-ID: DyTisE3dX1A
2016-10-14 14:07:00 +08:00
Paolo Amadini
52e44cd4c0 Bug 1300556 - Adjust the height of the Downloads Panel if downloads are removed while the panel is hidden. r=jaws
MozReview-Commit-ID: JpW9G6MAGwM
2016-09-07 15:00:46 +01:00
Sean Lee
0d30583c4a Bug 1298276 - Change the hover behavior in summary section with downloading files. r=paolo
MozReview-Commit-ID: 1hKBRXOBH6c
2016-08-18 14:45:57 +08:00
Drew Willcoxon
c4991eb672 Bug 1292345 - Downloads panel didn't shrink to the fit height after all items are downloaded. r=me
MozReview-Commit-ID: AV0S8GM0ztj
2016-08-26 16:36:56 -07:00
Drew Willcoxon
be9189f4dd Bug 1292573 - Broken keyboard interaction with the subview in the Downloads Panel. r=Paolo
MozReview-Commit-ID: 3jiqzlzLuWM
2016-08-26 09:59:11 -07:00
Drew Willcoxon
cd5d66ad17 Bug 1292566 - The "open" button in the subview for uncommon and potentially unwanted downloads should not ask for confirmation. r=Paolo
MozReview-Commit-ID: AVDyaQSbriX
2016-08-24 17:56:44 -07:00
Sean Lee
4a6aa72b89 Bug 1297039 - Implement the preference for showing dropmarker or not in Downloads Panel., r=Paolo
MozReview-Commit-ID: ArmPPgLABtA
2016-08-22 18:44:24 +08:00
Sean Lee
904b253968 Bug 1269962 - Implement a popup menu for showing a submenu in Downloads Panel Footer., r=Paolo
MozReview-Commit-ID: 7K1W15039W8
2016-07-13 13:39:00 +08:00
Drew Willcoxon
acaa33eb72 Bug 1287914 - Buttons in sliding panel overlay are not clickable. r=jaws
MozReview-Commit-ID: 91yoPxiMIy8
2016-07-28 11:51:53 -07:00
Drew Willcoxon
3b0116e6e0 Bug 1280709 - Downloads panel's "Show All Downloads" menu item is no longer clickable below its text label. r=gijs
MozReview-Commit-ID: HgTiDObq2JU
2016-07-25 12:25:52 -07:00
Drew Willcoxon
b3dd460b22 Bug 1252509 - Use a sliding panel overlay from the downloads panel to display the available actions. r=jaws
MozReview-Commit-ID: FhRlxcPeWu3
2016-06-10 22:08:59 -07:00
Paolo Amadini
c69ef4bd4a Bug 1265387 - The default action for uncommon downloads should open the file directly. r=past
MozReview-Commit-ID: GrZev8J5MRN
2016-04-20 15:44:38 +01:00
Paolo Amadini
1ca2e7074f Bug 1198181 - Part 5 - Change the unblock dialog actions based on the verdict. r=past
MozReview-Commit-ID: 3NkvpI9EqpB
2016-04-20 11:16:00 +01:00
Paolo Amadini
eaa8692867 Bug 1198181 - Part 2 - Unify the code that updates the state of download items. r=jaws
MozReview-Commit-ID: KptYcAGbMG2
2016-04-15 15:37:22 +01:00
Paolo Amadini
8a79832341 Bug 1254100 - Part 2 - Downloads blocked by Application Reputation should provide information about the verdict. r=mak
MozReview-Commit-ID: FYH5Tdtbzn
2016-03-16 14:29:23 +00:00
Paolo Amadini
be12a70c50 Bug 1117145 - Part 5 - Share the implementation of some of the download item commands. r=jaws
MozReview-Commit-ID: La6km3izidY
2016-02-14 17:28:12 +00:00
Paolo Amadini
1e4079adf2 Bug 1117145 - Part 4 - Unify how commands are handled in the Downloads Panel and the Library. r=jaws
MozReview-Commit-ID: 2Irgwu5YI72
2016-02-29 15:50:57 +00:00
Paolo Amadini
e309bff73c Bug 1117145 - Part 2 - Unify DownloadsViewItem and DownloadsViewItemController. r=jaws
MozReview-Commit-ID: 8qcV5Y7t1hM
2016-02-10 14:54:24 +00:00
Dave Townsend
6bc2e9ae43 Bug 1229224: Fix linting for some browser files that tests depend on. r=felipe 2015-12-17 15:19:00 -08:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Sebastian Hengst
190bccea7d Backed out changeset c6b267589d0d (bug 1202902) for Mulet Reftest, W3C Platform Test and other failures. r=backout a=backout on a CLOSED TREE 2015-10-07 13:36:26 +02:00
Shu-yu Guo
a021cebc10 Bug 1202902 - Fix the world. (r=ato for marionette, rs=Mossop for rest) 2015-10-06 14:00:30 -07:00
Tooru Fujisawa
7fc9d2c511 Bug 1207491 - Part 6: Remove use of expression closure from browser/components/downloads/. r=Gijs 2015-09-23 18:36:20 +09:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Nazim Can Altinova
c0751b8e87 Bug 1198235 - abuse of bind(this) with add/removeEventListener in downloads.js. r=mak 2015-08-31 14:04:00 +02:00
Birunthan Mohanathas
fe337d7c5e Bug 1166840 - Remove unused document argument in uses of nsIClipboardHelper.copyString. r=ehsan 2015-05-21 21:49:30 +01:00
Bill McCloskey
5a327da4cf Bug 1145394 - Remove exec bit on js files (r=fabrice,gavin) 2015-03-20 11:57:38 -07:00
Jared Wein
325a0016a0 Bug 1137909 - part 2: context menuitem to unblock downloads and an X button to confirm the blocked download. r=paolo 2015-03-05 12:25:45 -05:00
Paolo Amadini
39021a098d Bug 1137996 - Can't drag items from downloads panel. r=mak 2015-03-03 10:23:12 +00:00
Marco Bonardo
32485da9dc Bug 1135348 - Fix about:downloads by adding missing XPCOMUtils imports. r=paolo 2015-02-26 19:06:15 +01:00
Paolo Amadini
0333cf8e9e Bug 1129896 - Part 2 of 2 - Convert the shared front-end code to a JavaScript code module. r=mak 2015-02-16 18:49:56 +00:00
Paolo Amadini
7643037fa3 Bug 1127867 - Use the new back-end property to get the size of downloads asynchronously. r=mak 2015-02-16 18:49:52 +00:00
Paolo Amadini
31f72b0f7d Bug 1117141 - Part 2 of 2 - Refactor notifications and remove the DownloadsDataItem object. r=mak 2015-02-16 18:49:51 +00:00
Paolo Amadini
d98e8ef166 Bug 1117141 - Part 1 of 2 - Bypass all the DownloadsDataItem properties. r=mak 2015-02-16 18:49:49 +00:00
Paolo Amadini
790ecd81cd Bug 1117139 - Move code controlling the "download.xml" binding to a common place. r=mak 2015-02-16 18:49:47 +00:00
Paolo Amadini
5b719b29d4 Bug 1116176 - Create DownloadsHistoryDataItem and HistoryDownload objects. r=mak 2015-02-16 18:49:46 +00:00
Paolo Amadini
2eb368f4e5 Bug 1115983 - Keep only minimal state information in the DataItem. r=mak 2015-02-16 18:49:44 +00:00
Paolo Amadini
6ebe3e09a5 Bug 1115379 - Streamline DownloadsViewItemController construction and remove now unneeded identifiers. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
0da4c7d1ee Bug 1115369 - Use notifications instead of getViewItem for DownloadsView. r=mak 2015-01-14 17:30:27 +00:00
Paolo Amadini
a29cd43a55 Bug 1115364 - Downloads Panel code style refresh. r=jaws 2014-12-29 12:35:27 +00:00
Ed Morley
58709900bb Bug 577266 - Correct another handful of incorrect spellings 2014-08-13 09:04:36 +01:00
Jim Blandy
39dc0c6097 Bug 914753: Make Emacs file variable header lines correct, or at least consistent. DONTBUILD r=ehsan
The -*- file variable lines -*- establish per-file settings that Emacs will
pick up. This patch makes the following changes to those lines (and touches
nothing else):

 - Never set the buffer's mode.

   Years ago, Emacs did not have a good JavaScript mode, so it made sense
   to use Java or C++ mode in .js files. However, Emacs has had js-mode for
   years now; it's perfectly serviceable, and is available and enabled by
   default in all major Emacs packagings.

   Selecting a mode in the -*- file variable line -*- is almost always the
   wrong thing to do anyway. It overrides Emacs's default choice, which is
   (now) reasonable; and even worse, it overrides settings the user might
   have made in their '.emacs' file for that file extension. It's only
   useful when there's something specific about that particular file that
   makes a particular mode appropriate.

 - Correctly propagate settings that establish the correct indentation
   level for this file: c-basic-offset and js2-basic-offset should be
   js-indent-level. Whatever value they're given should be preserved;
   different parts of our tree use different indentation styles.

 - We don't use tabs in Mozilla JS code. Always set indent-tabs-mode: nil.
   Remove tab-width: settings, at least in files that don't contain tab
   characters.

 - Remove js2-mode settings that belong in the user's .emacs file, like
   js2-skip-preprocessor-directives.
2014-06-24 22:12:07 -07:00
Masayuki Nakano
a3ff9acf01 Bug 969247 part.1 Remove or replace DOM_VK_ENTER and NS_VK_ENTER users r=smaug 2014-02-15 09:57:39 +09:00
Marco Bonardo
fb598e0590 Bug 945707 - Pausing a download fails when done after a retry. r=paolo 2014-01-29 17:00:17 -05:00
Matthew Noorenberghe
28ba9edcf2 Merge mozilla-central to UX 2013-11-05 01:04:20 -08:00