Commit Graph

801 Commits

Author SHA1 Message Date
Narcis Beleuzu
53fd680209 Backed out changeset b73e82f1a589 (bug 1425323) to re-enable test on Windows pgo/opt (whimboo`s request). a=backout 2018-05-07 16:08:20 +03:00
Kris Maglione
fd7e9e6a69 Bug 1456035: Part 4 - Convert callers of XPCOMUtils.generateQI to ChromeUtils.generateQI. r=mccr8
This also removes any redundant Ci.nsISupports elements in the interface
lists.

This was done using the following script:

acecb401b7/processors/chromeutils-generateQI.jsm

MozReview-Commit-ID: AIx10P8GpZY
2018-04-22 20:55:06 -07:00
Kris Maglione
b3990a2d91 Bug 1456686: Part 1 - Fix unused and shadowed explicit imports. r=standard8
These issues were previously ignored due to the nature of our global import
rules. They need to be fixed before that rule can be updated.

MozReview-Commit-ID: DCChktTc5TW
2018-04-24 20:18:09 -07:00
Gijs Kruitbosch
6704872296 Bug 1448920 - add support for importing Edge typed URL history from its database instead, r=mak
MozReview-Commit-ID: 6AzEJluqn73
2018-04-18 17:50:36 +01:00
Jonathan Kingston
9b880fdc20 Bug 1374741 - Within browser/ make openUILinkIn() provide the correct triggeringPrincipal. r=gijs
MozReview-Commit-ID: 1NQrlWzIBja
2018-02-21 14:28:48 +00:00
Ganesh Chaitanya Kale
67bb868656 Bug 1282770 - Convert uses of PU.asyncHistory.updatePlaces in browser/components/migration to PU.history.insertMany. r=mak
Patch originally by Ganesh, updated by Standard8

MozReview-Commit-ID: AihTLo5OyK1
2018-03-20 12:36:31 +00:00
Tooru Fujisawa
675f5a9985 Bug 1442465 - followup: Wait for session store update in browser/components/migration/tests/browser/browser_undo_notification.js. r=me 2018-03-19 12:40:46 +09:00
Tooru Fujisawa
f415c74b57 Bug 1442465 - Part 4.2: Stop unnecessarily awaiting on BrowserTestUtils.removeTab (simple part). r=dao 2018-03-19 11:16:45 +09:00
Felipe Gomes
4351746c37 Bug 1439443 - Policies: Don't create the default and smart bookmarks on the profile. r=mak 2018-03-16 21:02:05 -03:00
Kit Cambridge
1e89ded632 Bug 1199077 - Split change sources for automatic and manual bookmark restores. r=mak
MozReview-Commit-ID: 1glcCPj2X90
2018-03-01 13:37:13 -08:00
Gijs Kruitbosch
7987f7b02f Bug 1438763 - fix intermittent orange in undo_notification_multiple_dismissal.js, r=ursula
When bug 1433324 made these tests run against activity stream, it made the notification
fire from the test's head.js file itself. Unfortunately, that races with the new tab / home
page actually loading, triggering an `onLocationChange` event in the tabbrowser, which
removes the notification again, meaning it is then no longer there when the test expects
it to be.

This wasn't an issue before, because the notification bar was opened via a message from
within the new tab page, which always arrived after the `onLocationChange` event.

Because the current state is temporary anyway, I'm just changing the test to open 2 tabs
first, and then opening the notification bars, which in practice guarantees this happens
after the `onLocationChange` event.

MozReview-Commit-ID: LOzgjrZBp0H
2018-03-07 16:07:41 +00:00
Daniel Marshall
7724f2e32c Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Mark Banner
29e56bce9b Bug 1434869 - Automatically mark EXPORTED_SYMBOLS as used, so that we don't need to ignore it in ESLint's no-unused-vars rule. r=florian.
MozReview-Commit-ID: IVMeZHGdVBk
2018-03-06 12:01:59 +00:00
Narcis Beleuzu
439cc34017 Backed out changeset a8130e46c530 (bug 1434483) for ESlint failures on browser_change_shipping.js. CLOSED TREE 2018-03-05 23:50:02 +02:00
Daniel Marshall
49ad18cee3 Bug 1434483 - Renamed profileStorage singleton to formAutofillStorage to make it more clear; r=MattN
MozReview-Commit-ID: CaPYBGLfs5I
2018-02-10 21:23:19 +00:00
Gijs Kruitbosch
e5c374b766 Bug 1437940 - fix where we look for a 'Local State' file for non-release Chrome data, r=dthayer
MozReview-Commit-ID: CXghkKKhHfx
2018-03-01 15:07:28 +00:00
Gijs Kruitbosch
ac044211af Bug 1437940 - include Chrome Beta and Chrome Dev in migration list on Linux, r=dthayer
MozReview-Commit-ID: HDTkdXdYos3
2018-03-01 14:03:06 +00:00
Florian Quèze
f6add2cafd Bug 1433175 - scripted patch to replace Components.classes[, Components.interfaces.nsI, Components.utils. and Components.results. with Cc, Ci, Cu and Cr, r=Mossop. 2018-02-28 18:51:33 +01:00
Mark Banner
910da570a0 Bug 1440379 - Tidy up ESlint no-unused-vars definitions wrt Ci/Cu/Cr/Cc usage for varsIgnorePattern. r=florian
MozReview-Commit-ID: HmliR8iNRDq
2018-02-22 16:55:36 +00:00
Sebastian Hengst
4e51639fe3 merge mozilla-central to autoland on a CLOSED TREE 2018-02-24 03:07:44 +02:00
Florian Quèze
f1a55f73f8 Bug 1440284 - change this.EXPORTED_SYMBOLS back to var EXPORTED_SYMBOLS in JS modules, r=mccr8. 2018-02-23 20:50:01 +01:00
Doug Thayer
396519498c Bug 1432529 - Exit spinEventLoopUntil when canceling migrator r=Gijs
Fairly trivial - discussed in bug 862127. Opt to cancel the spin wait
rather than disable canceling in the UI.

MozReview-Commit-ID: B55Fsw34uX7
2018-02-15 11:55:10 -08:00
Narcis Beleuzu
6946cfa455 Merge inbound to mozilla-central. a=merge 2018-02-16 11:49:59 +02:00
Margareta Eliza Balazs
7ec62aee45 Backed out changeset ebbcdc3e642d (bug 1433593) for X failing in toolkit/components/passwordmgr/test/unit/test_maybeImportLogin.js on a CLOSED TREE 2018-02-16 04:50:42 +02:00
Andrei Ciure
ae8967b6bf Bug 1425323 - disable test_refresh_firefox.py on Windows pgo and opt r=jmaher 2018-02-15 11:58:09 -05:00
Gijs Kruitbosch
38c9f9e2d5 Bug 1434167 - remove home page code from the migration wizard, r=MattN
This removes all the homepage-related code. All the cases where we advance the wizard straight to
the homepage wizardpage now go straight to the 'start migrating' page (the 'point' was skipping
earlier pages that allowed users to select items).
The brand bundle was only used by the homepage code so is also being removed.

MozReview-Commit-ID: I9nSU2IMkQz
2018-02-07 10:37:20 +00:00
Gijs Kruitbosch
4cd34f4756 Bug 1434167 - remove getSourceHomePageURL implementations and callsites, r=dthayer
MozReview-Commit-ID: 98p2Iy70EPv
2018-02-07 10:18:46 +00:00
Nathan Watson
5d40195377 Bug 1434262 - Remove PlacesTestUtils.clearHistory() r=mak
MozReview-Commit-ID: In2RaM0LBsc
2018-01-31 22:03:05 -08:00
Mark Banner
31b1fb7d6d Bug 1436389 - Update complexity rules to adapt for the algorithm in the new ESLint. r=mossop
MozReview-Commit-ID: 1LlfamNvBEM
2018-02-07 16:16:09 +00:00
Jeremy Lempereur
20165aaef4 Bug 1249596 - Part 2: Remove FHR client id migration code. r=Dexter
Removed a fallback import from a legacy FHR file when there is no valid ID in the DRS file.
This commit is related to bug 1431544
MozReview-Commit-ID: AACq7InWJpy
2018-01-18 23:51:24 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Florian Quèze
c5f15a4700 Bug 1339461 - script-generated patch to convert foo.indexOf(...) == -1 to foo.includes(), r=Mossop. 2018-02-01 20:45:22 +01:00
George Dan, Ryan Neilsen, Dylan Turner
61369dbaa9 Bug 1387632: Rename ProfileStorage module to FormAutofillStorage. r=MattN 2018-01-30 14:44:59 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Doug Thayer
73045e022b Bug 1433024 - Update MigrationUtils' sourceHomePageURL r=Gijs
Fairly trivial. This was breaking for the test_refresh_firefox
test in beta, since the code which calls this is only active if
certain branding strings are present.

MozReview-Commit-ID: 3CkosXHgoMm
2018-01-29 09:03:24 -08:00
Doug Thayer
c4a6e59688 Bug 1426721 - Encrypt Chrome logins in background thread r=keeler,MattN
A significant chunk of migration jank that I observe locally
happens due to login encryption. This patch reduces the locally
observed jank (measured importing 100 logins) from 180ms to 25ms.

Try is green, and as far as I can tell I don't see any thread
safety issues, but I'm not 100% sure on that. I don't see any
red flags inside the SecretDecoderRing::Encrypt implementation.

I only moved Chrome logins over since I wanted to frontload any
potential issues with the whole approach. It shouldn't be too
hard to move the MSMigrationUtils and IEProfileMigrator uses
over though.


MozReview-Commit-ID: 75edUqJlk8x
2018-01-04 15:10:54 -08:00
Marco Bonardo
70df2242e4 Bug 1416377 - Use new async Places APIs in test_refresh_firefox.py. r=standard8
MozReview-Commit-ID: HvN8oHgIbbq
2018-01-23 15:14:38 +01:00
Doug Thayer
153a7d805b Bug 862127 - Fix migrator tests to use async interfaces r=Gijs
MozReview-Commit-ID: 9qFA4y8viSW
2018-01-11 15:35:05 -08:00
Doug Thayer
358617edb4 Bug 862127 - Remove all sync IO from Chrome migration r=Gijs
Now that the interfaces are all async, we can simply replace all
the sync IO in the Chrome migrator with the equivalent async IO.
Other browsers will be addressed in separate patches.

MozReview-Commit-ID: FyGRRKY57Gm
2018-01-11 09:52:56 -08:00
Doug Thayer
73907ee665 Bug 862127 - Convert migration.js to use async migration interfaces r=Gijs
migration.js is a special case where we generally need blocking
calls in order for the wizard to work correctly. Accordingly we
block waiting for the new async interfaces. With automigration
and potential new UIs that are in the works for migration, the
asynchronicity of these interfaces will be more relevant, but
here it's not really important enough to make big changes to the
way the UI is implemented.

MozReview-Commit-ID: LkfwBVfpCJO
2018-01-12 09:11:38 -08:00
Doug Thayer
015377398b Bug 862127 - Make migration interfaces more async r=Gijs
In order to clean up sync IO within our profile migrators, we
need to have async interfaces for those parts which are currently
doing sync IO. This converts the sync interfaces and adjusts most
of the call sites (migration.js call site changes are addressed
in a separate patch to break it out a bit).


MozReview-Commit-ID: 2Kcrxco4iYr
2018-01-12 09:06:21 -08:00
Sam R-T, Joseph F, Robin H
0be01d2d28 Bug 1432062 - Require dangling commas via eslint for the migration component. r=MattN 2018-01-22 15:22:35 -08:00
Doug Thayer
2a70781cd0 Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
shindli
f1661b02af Backed out 2 changesets (bug 1433593) for xpcshell on /tests/unit/test_IE7_passwords.js on a CLOSED TREE
Backed out changeset c1b0ea577728 (bug 1433593)
Backed out changeset 96327b595b91 (bug 1433593)
2018-02-20 23:01:54 +02:00
Doug Thayer
afbdc3b32b Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Doug Thayer
38979fb27e Bug 1433593 - Clean up usages of LoginHelper.maybeImportLogin r=MattN
In bug 1426721 we added a bulk interface for importing logins, which
works in a background thread. This patch cleans up the single-login
interface and updates the remaining usages to consume the bulk
interface.

MozReview-Commit-ID: IziLXkO5dxQ
2018-02-15 10:26:44 -08:00
Ed Lee
ed7e46e0d9 Bug 1433324 - Part 2. Get auto migration tests running with activity stream enabled. r=Gijs
MozReview-Commit-ID: AOItGs3ca5v
2018-02-14 22:52:40 -08:00
Doug Thayer
c88b6d5bf1 Bug 1430318 - Fix getLastUsedDate bugs from using typedURLs r=mak
getLastUsedDate should be converting the microseconds of typedURLs
into milliseconds.

MozReview-Commit-ID: DjJKm5aPcGD
2018-01-17 11:15:27 -08:00
Doug Thayer
0c50874ac0 Bug 1430318 - Prevent zeroes Edge history timestamps from breaking import r=mak
Edge history visit times can be zero. Not sure of exactly what
conditions cause this, but the Edge start page has a visit time of
0 on a local machine.

MozReview-Commit-ID: KJ9iwbLIhj2
2018-01-16 11:08:21 -08:00
Doug Thayer
8223f4d38c Bug 1421703 - Fix tests to use onVisits r=mak
Fairly straightforward. Fixes the tests that were broken due to
the changes introduced in part 1.

MozReview-Commit-ID: GbZ9ZpmG9nE
2017-12-14 16:55:31 -06:00