Commit Graph

42 Commits

Author SHA1 Message Date
Dão Gottwald
dcc8113e58 Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs
MozReview-Commit-ID: 7oQrfiK0FRa
2018-03-27 23:34:23 +02:00
Margareta Eliza Balazs
0be5f458ea Backed out changeset 49867cc4dcc2 (bug 1448482) for ss failures in browser/tools/mozscreenshots/primaryUI/browser_primaryUI.js on a CLOSED TREE 2018-03-27 20:13:36 +03:00
Dão Gottwald
0196bd764d Bug 1448482 - Remove <title> element from about:privatebrowsing since tabbrowser already sets the title. r=Gijs
MozReview-Commit-ID: 3VcK126FfWX
2018-03-23 22:30:11 +01:00
Gijs Kruitbosch
2426a4d9cd Bug 1427186 - stop ever showing 'new tab' as a title for about:privatebrowsing in private windows, r=dao
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
  not set. This is fixed by setting it to the private title by default;
  there is very little (if any) UI that allows users to even open
  about:privatebrowsing in 'normal' windows so we care a lot less about
  flicker there. To be able to include this title in the markup, we switched
  to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
  created. This has been updated to check for private windows, and default to
  'Private Browsing' instead. This will obviously also affect other new tabs
  in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
  have a content title for (which can still happen while about:privatebrowsing
  is loading because e10s), and so that is updated, too.

MozReview-Commit-ID: nVfXD2M6UZ
2018-03-07 20:13:54 +00:00
Gurzau Raul
3d427471e3 Backed out changeset 4e5253710464 (bug 1427186) for failing ss tests on /mozscreenshots/primaryUI/browser_primaryUI.js and for failing bc tests on /privatebrowsing/test/browser/browser_privatebrowsing_windowtitle.js on a CLOSED TREE 2018-03-09 01:52:11 +02:00
Gijs Kruitbosch
97c3b183c4 Bug 1427186 - stop ever showing 'new tab' as a title for about:privatebrowsing in private windows, r=dao
There are 3 issues here:
- the runtime changing of the title causes issues where the content title is
  not set. This is fixed by setting it to the private title by default;
  there is very little (if any) UI that allows users to even open
  about:privatebrowsing in 'normal' windows so we care a lot less about
  flicker there. To be able to include this title in the markup, we switched
  to a dtd.
- the 'empty tab' title we set on the tab initially is set when the tab is
  created. This has been updated to check for private windows, and default to
  'Private Browsing' instead. This will obviously also affect other new tabs
  in private browsing, but that seems desirable/consistent.
- Likewise, we use this title when updating a tab's title that we don't yet
  have a content title for (which can still happen while about:privatebrowsing
  is loading because e10s), and so that is updated, too.

MozReview-Commit-ID: nVfXD2M6UZ
2018-03-07 20:13:54 +00:00
Christoph Kerschbaumer
3c66d0e8e0 Bug 1430751 - Apply unified behavior model for about: pages to about:privatebrowsing. r=gijs,mrbkap 2018-03-05 09:20:34 +01:00
Andrew McCreight
272cee1e65 Bug 1432992, part 1 - Remove definitions of Ci, Cr, Cc, and Cu. r=florian
This patch was autogenerated by my decomponents.py

It covers almost every file with the extension js, jsm, html, py,
xhtml, or xul.

It removes blank lines after removed lines, when the removed lines are
preceded by either blank lines or the start of a new block. The "start
of a new block" is defined fairly hackily: either the line starts with
//, ends with */, ends with {, <![CDATA[, """ or '''. The first two
cover comments, the third one covers JS, the fourth covers JS embedded
in XUL, and the final two cover JS embedded in Python. This also
applies if the removed line was the first line of the file.

It covers the pattern matching cases like "var {classes: Cc,
interfaces: Ci, utils: Cu, results: Cr} = Components;". It'll remove
the entire thing if they are all either Ci, Cr, Cc or Cu, or it will
remove the appropriate ones and leave the residue behind. If there's
only one behind, then it will turn it into a normal, non-pattern
matching variable definition. (For instance, "const { classes: Cc,
Constructor: CC, interfaces: Ci, utils: Cu } = Components" becomes
"const CC = Components.Constructor".)

MozReview-Commit-ID: DeSHcClQ7cG
2018-02-06 09:36:57 -08:00
Kris Maglione
0bb74efdf1 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Cosmin Sabou
f09d6d985d Backed out 3 changesets (bug 1431533) for Android mochitest failures on testEventDispatcher on a CLOSED TREE
Backed out changeset a1eca62826a1 (bug 1431533)
Backed out changeset 34c999fa006b (bug 1431533)
Backed out changeset e2674287e57f (bug 1431533)
2018-01-30 07:17:48 +02:00
Kris Maglione
fd67f090b2 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Brindusan Cristian
483ba301cb Backed out 2 changesets (bug 1431533) for ESlint failures on a CLOSED TREE
Backed out changeset 6e56f4c8843e (bug 1431533)
Backed out changeset 12fc4dee861c (bug 1431533)
2018-01-30 02:32:43 +02:00
Kris Maglione
683a97d172 Bug 1431533: Part 5a - Auto-rewrite code to use ChromeUtils import methods. r=florian
This was done using the following script:
37e3803c7a/processors/chromeutils-import.jsm

MozReview-Commit-ID: 1Nc3XDu0wGl
2018-01-29 15:20:18 -08:00
Johann Hofmann
25083ad50e Bug 1422903 - Prevent about:privatebrowsing favicon from flickering. r=florian
We apply a custom workaround to show about:home and about:newtab favicons
as early as possible for perceived performance, but didn't previously consider
the about:privatebrowsing page (which can act as both about:home and about:newtab).

MozReview-Commit-ID: gPiV08h0j0
2017-12-13 05:55:10 -06:00
Mark Banner
4de85b3d5b Bug 1230373 - Enable mozilla/use-services for browser/components/ r=mossop
MozReview-Commit-ID: 9m9iss3jUJJ
2017-10-11 15:43:51 +01:00
Jared Wein
5a181760cc Bug 1348068 - Enable the key-spacing rule for eslint and fix the related issues. r=standard8
Running eslint with --fix didn't fix many of the issues. The majority here had to be fixed by hand but a significant majority of the issues were related to a few files that I was able to use find-and-replace with. I regret not making this in to separate commits of the hand-fixes and the fixes from --fix but I don't recall --fix fixing any of the issues.

MozReview-Commit-ID: ANyg2qfo3Qx
2017-03-21 14:29:43 -04:00
Mark Banner
73c64015fb Bug 1311345 - Enable eslint of browser/components/privatebrowsing/ - Automatically fixed changes by eslint. r=jaws
MozReview-Commit-ID: 2rmHK5vkpt1
2017-02-28 12:44:14 +00:00
Florian Quèze
63de711857 Bug 1331081 - script generated patch to omit addEventListener/removeEventListener's third parameter when it's false, r=jaws. 2017-01-17 11:50:25 +01:00
Ricky Chien
dbb51e123b Bug 1269485 - Improve New Private Browsing start-page background styles r=Gijs
MozReview-Commit-ID: 6gju3cfipJ3
2016-05-04 17:05:50 +08:00
Gijs Kruitbosch
5f3574daae Bug 1270496 - tracking protection switch on about:privatebrowsing should also affect the actual setting when using <space> to toggle it, r=jaws
MozReview-Commit-ID: 51bf9AT9eh9
2016-05-05 16:28:28 +01:00
Ricky Chien
17b16e29ea Bug 1259340 - New Private Browsing Window Update. r=past,Gijs
MozReview-Commit-ID: 5NbLribECvC
2016-04-24 16:01:45 +03:00
Paolo Amadini
57c7f02714 Bug 1236231 - Make sure the Tracking Protection tour doorhanger is not shown when the tour starts from about:privatebrowsing. r=past 2016-01-11 14:40:31 +00:00
Carsten "Tomcat" Book
036e6d2fa3 Backed out 2 changesets (bug 1202902) to recking bug 1202902 to be able to reopen inbound on a CLOSED TREE
Backed out changeset 647025383676 (bug 1202902)
Backed out changeset d70c7fe532c6 (bug 1202902)
2015-10-07 14:03:21 +02:00
Carsten "Tomcat" Book
12369728f5 Backed out 1 changesets (bug 1202902) for causing merge conflicts to mozilla-central
Backed out changeset cfc1820361f5 (bug 1202902)
2015-10-07 12:13:45 +02:00
Shu-yu Guo
474f49adb7 Bug 1202902 - Scripted fix the world. 2015-10-06 14:00:31 -07:00
Shu-yu Guo
37989840cd Bug 1202902 - Mass replace toplevel 'let' with 'var' in preparation for global lexical scope. (rs=jorendorff) 2015-09-15 11:19:45 -07:00
Francois Marier
834504a1b7 Bug 1196017 - Deal with TP turned on globally in about:privatebrowsing. r=paolo 2015-08-24 16:10:14 -07:00
Panos Astithas
49089894d7 Bug 1175606 - Enable Tracking Protection by default in Private Browsing Mode;r=ttaubert 2015-08-08 00:33:05 +01:00
Phil Ringnalda
ecb77a2db7 Back out 023218047be5 (bug 1175606) for depending on the backed out bug 1192416 2015-08-07 22:06:51 -07:00
Panos Astithas
57bbc5e324 Bug 1175606 - Enable Tracking Protection by default in Private Browsing Mode;r=ttaubert 2015-08-08 00:33:05 +01:00
Paolo Amadini
4e4488d113 Bug 1190427 - Update the design of about:privatebrowsing. r=ttaubert 2015-08-06 15:51:41 +01:00
Paolo Amadini
51d678582f Bug 1177156 - Provide a button to re-enable Tracking Protection in about:privatebrowsing. r=ttaubert 2015-07-20 12:44:08 +01:00
Paolo Amadini
10be0d80bc Bug 1177152 - Add Tracking Protection tour entry point to about:privatebrowsing. r=ttaubert 2015-07-17 17:51:48 +01:00
Tim Taubert
752a90e4bb Backed out changeset 9798359363a0 (bug 1177152) 2015-07-17 14:06:50 +02:00
Paolo Amadini
c950687d13 Bug 1177152 - Add Tracking Protection tour entry point to about:privatebrowsing. r=ttaubert 2015-07-15 14:20:39 +01:00
Steven MacLeod
5f5b5ce08a Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop
browser_privatebrowsing_downloadLastDir.js and browser_bug963945.js are also updated to work properly when about:privatebrowsing is loaded remotely.
2015-04-15 13:58:21 +02:00
Wes Kocher
7b8b9fb1a3 Backed out changeset 1b23439451a8 (bug 1079245) 2015-03-19 15:43:21 -07:00
Steven MacLeod
268e4f080f Bug 1079245 - Set about:privatebrowsing to load in child. r=mossop
browser_privatebrowsing_downloadLastDir.js and browser_bug963945.js are
also updated to work properly when about:privatebrowsing is loaded
remotely.
2015-02-09 15:42:39 -05:00
Bill McCloskey
530eff93df Bug 1124129 - Fix warning about content window passed to PrivateBrowsingUtils.isWindowPrivate (r=ehsan) 2015-01-22 15:55:02 -08:00
Daniel
4d6dfbca6d Bug 956482 - Move inline script about:privatebrowsing out to an external file. r=jaws 2014-11-12 13:59:00 +01:00
Ryan VanderMeulen
a2a317618b Backed out changeset 4b5f794b80a8 (bug 956482) for mochitest-bc failures.
CLOSED TREE
2014-09-11 17:43:53 -04:00
Daniel
174310732d Bug 956482 - Rewrite inline script in /browser/components/privatebrowsing/content/aboutPrivateBrowsing.xhtml (about:privatebrowsing); r=jaws 2014-09-11 15:49:14 -04:00