corysanin/tubestation
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
906,980 Commits 1 Branch 0 Tags
b06c4c0583aa71ba6d7f41f4b536c9efb0f7997b
Commit Graph

284 Commits

Author SHA1 Message Date
Alexandru Marc
b06c4c0583 Revert "Bug 1941189 - Make vertical pinned tabs container adjustable r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley,sfoster" for causing bc failures @ browser_resize_sidebar.js 
This reverts commit 5c1d9210e4.
 2025-05-01 21:42:02 +00:00
Kelly Cochrane
5c1d9210e4 Bug 1941189 - Make vertical pinned tabs container adjustable r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D246484
 2025-05-01 20:52:57 +00:00
Iulian Moraru
6951b54b38 Backed out changeset 646fc6fe1859 (bug 1961955) for causing bc failures on browser_all_files_referenced.js. CLOSED TREE 2025-04-30 04:33:43 +03:00
Fred Chasen
b099c87ad0 Bug 1961955 - Clean up Review Checker sidebar panel. r=shopping-reviewers,fluent-reviewers,sidebar-reviewers,kpatenio,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D246993
 2025-04-29 23:59:01 +00:00
Sam Foster
2acb53bb57 Bug 1961190 - Only set initial sidebar launcher visibility to a default when its never been seen. r=sidebar-reviewers,kcochrane,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D246009
 2025-04-25 19:33:41 +00:00
Goloman Adrian
17befc4396 Backed out changeset 9838e2ffe509 (bug 1961190) for causing xpcshell failures @test_sidebar_state.js. CLOSED TREE 2025-04-25 21:31:22 +03:00
Sam Foster
5c9f87dc15 Bug 1961190 - Only set initial sidebar launcher visibility to a default when its never been seen. r=sidebar-reviewers,kcochrane,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D246009
 2025-04-25 16:59:53 +00:00
Emilio Cobos Álvarez
0c8b2bd7f8 Bug 1960926 - More explicitly wait for sidebar update. r=sidebar-reviewers,kcochrane 
This is the front-end side fix. We might want to change the rendering
code too, I'm still investigating if this is web observable.

Differential Revision: https://phabricator.services.mozilla.com/D246131
 2025-04-22 16:51:17 +00:00
smolnar
671d93ed3b Backed out changeset 5a2b98798636 (bug 1960926) for causing bc failures @ browser_customize_sidebar.js CLOSED TREE 2025-04-22 18:37:17 +03:00
Emilio Cobos Álvarez
02a342eb75 Bug 1960926 - More explicitly wait for sidebar update. r=sidebar-reviewers,kcochrane 
This is the front-end side fix. We might want to change the rendering
code too, I'm still investigating if this is web observable.

Differential Revision: https://phabricator.services.mozilla.com/D246131
 2025-04-22 13:52:06 +00:00
Micah Tigley
44634783bd Bug 1956952 - Add a probe for when CPM is enabled in sidebar customization panel. r=rsafaeian,sidebar-reviewers,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D243389
 2025-04-15 14:30:04 +00:00
Ed Lee
26865b29fa Bug 1943208 - Allow callout primary CTA to flip multiple prefs and open the chatbot panel r=sidebar-reviewers,sclements 
Reopen panel if one was open when toggling revamp and still available. This avoids race condition of trying to open chatbot and flip revamp at the same time.

Differential Revision: https://phabricator.services.mozilla.com/D245367
 2025-04-14 14:23:39 +00:00
Sam Foster
ced67263ef Bug 1959498 - Ensure sidebar launcher gets un-expanded when we switch back to horizontal tabs. r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D245005
 2025-04-10 20:43:18 +00:00
Sam Foster
5e57ba63ea Bug 1959121 - Don't forget previously open sidebar panels for legacy sidebar.revamp=false sidebars. r=sidebar-reviewers,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D245006
 2025-04-10 13:03:30 +00:00
Sam Foster
3977cd6c9f Bug 1956330 - Ensure extensions' sidebarAction get loaded into the panel when toggling the sidebar. r=sidebar-reviewers,jsudiaman,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D244269
 2025-04-09 10:12:02 +00:00
Cristian Tuns
041ebec961 Backed out changeset 9e0922e2fa4c (bug 1956330) for causing bc failures in /browser_toolbar_sidebar_button.js CLOSED TREE 2025-04-07 16:11:50 -04:00
Sam Foster
e6188a0b0b Bug 1956330 - Ensure extensions' sidebarAction get loaded into the panel when toggling the sidebar. r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D244269
 2025-04-07 18:10:53 +00:00
Sam Foster
37ad815c08 Bug 1949912 - Add a sidebar.revamp.defaultLauncherVisible pref for the initial launcher visibility with sidebar.revamp + horizontal tabs. r=sidebar-reviewers,sclements,kcochrane 
Differential Revision: https://phabricator.services.mozilla.com/D242609
 2025-04-03 19:20:51 +00:00
Kelly Cochrane
43f88580f8 Bug 1956909 - Prevent expand on hover jumping animation after browser restart r=tabbrowser-reviewers,sidebar-reviewers,jsudiaman,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D244203
 2025-04-03 10:09:14 +00:00
Gijs Kruitbosch
8d5a031563 Bug 1955030 - fix sidebar closing when button is moved, r=sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D242543
 2025-04-02 19:38:39 +00:00
Kelly Cochrane
a75d2e147f Bug 1956624 - Ensure sidebar collapses on mouse out when expand on hover is enabled and the window is inactive (macOS only) r=sidebar-reviewers,mstange,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D243512
 2025-04-02 14:44:08 +00:00
Kelly Cochrane
23e69eb981 Bug 1957393 - Fix inaccuracy of Expand on hover checkbox state in the customize panel r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D243686
 2025-03-31 19:09:30 +00:00
Rebecca King
8a1bcf5764 Bug 1955055 - Review Checker Callout 4B not triggered if the sidebar is closed with X button - r=shopping-reviewers,omc-reviewers,sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D242963
 2025-03-28 01:20:11 +00:00
Sam Foster
829925fc2c Bug 1954056 - Avoid closing the sidebar launcher when just closing the open panel. r=sidebar-reviewers,kcochrane 
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)
* Skip the browser_toolbarKeyNav.js test when sidebar.revamp=true, this should have been failing all along.

Differential Revision: https://phabricator.services.mozilla.com/D242240
 2025-03-28 00:27:49 +00:00
Kelly Cochrane
2818ae997f Bug 1956909 - Prevent expand on hover jumping animation after browser restart r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D243372
 2025-03-27 20:17:51 +00:00
Cosmin Sabou
a6f42c65a8 Backed out changeset a99655962ea6 (bug 1954056) for turning browser_toolbarKeyNav.js into permafail. CLOSED TREE 2025-03-27 06:41:26 +02:00
Fred Chasen
8fa2242721 Bug 1938392 - Add integratedSidebar pref to Nimbus. r=shopping-reviewers,firefox-desktop-core-reviewers ,sidebar-reviewers,mossop,Gijs,rking 
Adds the integratedSidebar pref to the `shopping2023` Nimbus feature and separates the enabling prefs for the migrated Review Checker in the main sidebar and the Shopping sidebar.

- Updates `browser.shopping.experience2023.integratedSidebar` to be the only enabling pref for the migrated Review Checker sidebar.
- Prevents `browser.shopping.experience2023.enabled` from disabling the migrate sidebar and uses it as the pref for the ShoppingSidebar actors.
- Removes the `browser.shopping.experience2023.shoppingSidebar` pref as it is no longer needed.
- Updates any tests the used these prefs to the new use.
- Init's the two sidebar differently in `ShoppingUtils` based on the Nimbus prefs.
- Unset the `SidebarController._state.command` when a sidebar tool pref sets it to `visible=false` otherwise it will try to re-open when the sidebar is opened again.

Differential Revision: https://phabricator.services.mozilla.com/D242053
 2025-03-27 00:05:15 +00:00
Sam Foster
b87c7b1846 Bug 1954056 - Avoid closing the sidebar launcher when just closing the open panel. r=sidebar-reviewers,kcochrane 
* Remove some of the overloading of SidebarState.updateVisibility
* Remove the no-longer-used #previousLauncherExpanded property
* SidebarController.hide() just hides the panel (same as legacy/original API)

Differential Revision: https://phabricator.services.mozilla.com/D242240
 2025-03-26 23:00:27 +00:00
Kelly Cochrane
6685a37131 Bug 1950419 - Prevent sidebar from collapsing when opening context menu if expand on hover is enabled r=tabbrowser-reviewers,sidebar-reviewers,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D242740
 2025-03-26 19:14:46 +00:00
Sarah Clements
3435c4b131 Bug 1947997 - Make sidebar.main.tools user customized r=sidebar-reviewers,firefox-desktop-core-reviewers ,mossop 
* Update sidebar.main.tools default values and include a migration
* Modify updateDefaultTools in SidebarManager
* Update tests

Differential Revision: https://phabricator.services.mozilla.com/D240903
 2025-03-24 18:32:29 +00:00
Nikki Sharpley
f944da9456 Bug 1949497 - Part 1: Replace use of waitForCondition with waitForMutationCondition in sidebar test suite r=sidebar-reviewers,sfoster 
Follow up patch for browser_syncedtabs_sidebar.js and browser_adopt_sidebar_from_opener.js in Part 2.

Differential Revision: https://phabricator.services.mozilla.com/D240637
 2025-03-21 15:16:16 +00:00
Kelly Cochrane
28a04d1c5f Bug 1954962 - Fix animations for expand on hover when expanding from the left r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D242386
 2025-03-21 01:23:34 +00:00
Kelly Cochrane
f419fc95e6 Bug 1954780 - Resolve attention dot positioning for expanded pinned tabs when expand on hover is enabled r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,nsharpley,emilio 
Differential Revision: https://phabricator.services.mozilla.com/D242030
 2025-03-19 16:03:45 +00:00
Kelly Cochrane
a9d254af97 Bug 1945959 - Add tests for sidebar expand on hover feature r=sidebar-reviewers,nsharpley 
Differential Revision: https://phabricator.services.mozilla.com/D237646
 2025-03-18 20:35:37 +00:00
Kelly Cochrane
a03f5ebbd6 Bug 1947254 - Debounce mouseover effects for expand on hover for the sidebar r=sidebar-reviewers,sfoster 
Differential Revision: https://phabricator.services.mozilla.com/D241505
 2025-03-18 19:04:17 +00:00
Eric Chen
19f81b780d Bug 1952045 - modify and refactor the "inPopup" logic of sidebarController to account for taskbar tabs r=sidebar-reviewers,Gijs 
Differential Revision: https://phabricator.services.mozilla.com/D240688
 2025-03-15 20:12:51 +00:00
Kelly Cochrane
d8275ce7d6 Bug 1951427 - Rework expand on hover to only overlay the sidebar launcher r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D240171
 2025-03-14 13:09:18 +00:00
Goloman Adrian
8cbc210af4 Backed out changeset e93b9b73aebd (bug 1951427) for causing bc failures @browser_sidebar_move.js. 2025-03-14 08:20:43 +02:00
Kelly Cochrane
8959c0fe82 Bug 1951427 - Rework expand on hover to only overlay the sidebar launcher r=desktop-theme-reviewers,tabbrowser-reviewers,sidebar-reviewers,dao,emilio,sclements 
Differential Revision: https://phabricator.services.mozilla.com/D240171
 2025-03-13 23:39:02 +00:00
Sam Foster
5e0d65a91e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-12 16:41:47 +00:00
Goloman Adrian
6847fa7ceb Backed out changeset 4754bc9e58f3 (bug 1921536) for causing bc failures @browser_toolbarKeyNav.js 2025-03-08 09:15:01 +02:00
Sam Foster
ace31bb084 Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-08 05:17:08 +00:00
Sandor Molnar
b51ff49434 Backed out changeset f56181344f2a (bug 1921536) for causing bc failures @ browser_bookmark_context_menu_contents.js & browser_reviewchecker_sidebar.js CLOSED TREE 2025-03-06 06:15:10 +02:00
Sam Foster
dc4f09430e Bug 1921536 - Make the SidebarState the source of truth for the current sidebar command/panel and re-open previous panel when toggling the sidebar open. r=sidebar-reviewers,jsudiaman 
* We retain the behavior from legacy sidebar which re-opens the previously open sidebar panel when the sidebar is toggled open
* Rename SidebarState's '#previousLauncherVisible' to '#previousLauncherExpanded' as it actually tracks expandedness
* Don't persist the panel/command id when the panel isn't open
* Ensure all the sidebar tests reset the sidebar state when they are done

Differential Revision: https://phabricator.services.mozilla.com/D234773
 2025-03-06 01:52:28 +00:00
kpatenio
de5da3721b Bug 1951175 - add icon_click Glean event for Review Checker sidebar icon. r=sidebar-reviewers,shopping-reviewers,rking,jsudiaman 
Differential Revision: https://phabricator.services.mozilla.com/D240087
 2025-03-03 23:02:40 +00:00
Kelly Cochrane
98adf13686 Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-28 09:24:26 +00:00
Stanca Serban
48f17a87bb Backed out changeset 75ec289e02ef (bug 1947818) for causing mochitests failures in browser_customize_sidebar.js. CLOSED TREE 2025-02-27 23:11:38 +02:00
Kelly Cochrane
6c12de724c Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-27 19:59:46 +00:00
Stanca Serban
de66cbe460 Backed out changeset 793f8bede918 (bug 1947818) for causing mochitests failures in browser_sidebar_move.js. CLOSED TREE 2025-02-27 21:36:43 +02:00
Kelly Cochrane
f1fe3cf1b3 Bug 1947818 - Fix for sidebar splitter issues r=desktop-theme-reviewers,sidebar-reviewers,jsudiaman,dao 
Differential Revision: https://phabricator.services.mozilla.com/D238878
 2025-02-27 17:01:13 +00:00